From nobody Thu Dec 18 22:26:08 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1592301810; cv=none; d=zohomail.com; s=zohoarc; b=YWYjtTceQQnllJLan0M8H68hardvji4AfUOuRtKh5rmSoRLcVkWYZrE10DdMJ1HP0pJ1V7TiahayvONwtN9dI8rha8He/H/XXWyHGBivjP8UI+qdXowhlNQnXdh4yuQG/Opi2RXhHZmk1AviWKlheUyVsGL2gRzLewBrGfQcHNI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1592301810; h=Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=I38XNUEOP0p0jWXS0d97X4fxUYTnsRlCa1N4i5/agBo=; b=FqrtYyR86a6eppn+JB5xeQ6ZVdAaW5jS+5f0nETtWcCqBX/0zSQvGGgsR91FJH8p+Qa9g2ii7F62THZqD8P9nNEUmxputJZNQI6LXWpKlSaH29k87xCN5I2ivgco3ssXYjU113cNiXDZSbtRimDkisebAnWAChjsY0jTxeu0/wg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1592301810465429.8763952265323; Tue, 16 Jun 2020 03:03:30 -0700 (PDT) Received: from localhost ([::1]:33170 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jl8RE-0007us-54 for importer@patchew.org; Tue, 16 Jun 2020 06:03:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50960) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jl8LP-0007Ug-4b for qemu-devel@nongnu.org; Tue, 16 Jun 2020 05:57:27 -0400 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]:56291) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jl8LN-00042v-8g for qemu-devel@nongnu.org; Tue, 16 Jun 2020 05:57:26 -0400 Received: by mail-wm1-x331.google.com with SMTP id c71so2248170wmd.5 for ; Tue, 16 Jun 2020 02:57:24 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [81.2.115.148]) by smtp.gmail.com with ESMTPSA id z12sm31090851wrg.9.2020.06.16.02.57.22 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jun 2020 02:57:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=I38XNUEOP0p0jWXS0d97X4fxUYTnsRlCa1N4i5/agBo=; b=UYnv4Nmz63jWid3IOw+5UMLIdFqMWFT5pooT5SGv0Qh4/TU9dJUqnDuPGgXtUlw0zs V+huTmihtdLNMyhvEMFRDoAFl3B/wRITNySmHr8rgxIlzAa+3T7dEoqz+9v+PhvqL98M /2zTofx0L6AvzGqVtOBYLYqx3DsjYbHrZ/F50HTLkmbyWPr7XTubWe20Wey+a2xFNBPT /tbpmf7VnQwK1SYdE1Sjl51t7Sy2Xe9zZDcWvCkNbPQd43Lr3WOBg4un3zubHTJmPjiw bQlGycTSgUDbgpAfc2pq8JNoZlaveP57x6krviJds9B8vt3w3bG5cnDe+6LwUnpNwUgj oVUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=I38XNUEOP0p0jWXS0d97X4fxUYTnsRlCa1N4i5/agBo=; b=Giot2L2cntX2ojxO3YViWyHSYEEMvUGqGSwrRWKkxT+yJPq/G0o7kCrd5RQ0ubzBME LX/CglV8LcO/pZ6dqnBj7FnbsHP0UqSgx7fZkEIBVSs30hJZr6Ugm7fNoVRzqvfSRnpC 4ee7hi3ch0m2KXcBO9jSJnUVKiHXdxAd6xVAqxOP2//x67ntzqsxBNhIDx2wIG3F/HXF JYEEXYpR99NjdM0hVzGAbTi40Zcj6eMkYl1++msDgZKClGXHS5eaj74I5GOzTOzyB3BR 2aZbqPT+bRTSRNBnQU8CeWbMqPTbUv9U4wXi3wD+s9vzDp5XiJk5DAfagPn6jWX19Xtu JsSQ== X-Gm-Message-State: AOAM530gEOoabn9/q80TkugJE7pdN0oBtjAeDsmBK26L4dlJzfxmI2RY zRXgYH8DWFe+m2+XgEy8sDZqWyxIqy8Q9g== X-Google-Smtp-Source: ABdhPJz2roNnBW/GOr4W6bcp/SpK7rWq6x6WTQKVp/Yl7InDnoBiOai9NVukkOro/muvtEGa0ual+A== X-Received: by 2002:a1c:6884:: with SMTP id d126mr2339532wmc.121.1592301443548; Tue, 16 Jun 2020 02:57:23 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PULL 15/23] target/arm: Convert Neon VEXT to decodetree Date: Tue, 16 Jun 2020 10:56:54 +0100 Message-Id: <20200616095702.25848-16-peter.maydell@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200616095702.25848-1-peter.maydell@linaro.org> References: <20200616095702.25848-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::331; envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x331.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) Content-Type: text/plain; charset="utf-8" Convert the Neon VEXT insn to decodetree. Rather than keeping the old implementation which used fixed temporaries cpu_V0 and cpu_V1 and did the extraction with by-hand shift and logic ops, we use the TCG extract2 insn. We don't need to special case 0 or 8 immediates any more as the optimizer is smart enough to throw away the dead code. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson --- target/arm/neon-dp.decode | 8 +++- target/arm/translate-neon.inc.c | 76 +++++++++++++++++++++++++++++++++ target/arm/translate.c | 58 +------------------------ 3 files changed, 85 insertions(+), 57 deletions(-) diff --git a/target/arm/neon-dp.decode b/target/arm/neon-dp.decode index 9ff182f56d7..26d60220168 100644 --- a/target/arm/neon-dp.decode +++ b/target/arm/neon-dp.decode @@ -413,7 +413,13 @@ Vimm_1r 1111 001 . 1 . 000 ... .... cmode:4 0= . op:1 1 .... @1reg_imm # return false for size=3D=3D3. ###################################################################### { - # 0b11 subgroup will go here + [ + ################################################################## + # Miscellaneous size=3D0b11 insns + ################################################################## + VEXT 1111 001 0 1 . 11 .... .... imm:4 . q:1 . 0 .... \ + vm=3D%vm_dp vn=3D%vn_dp vd=3D%vd_dp + ] =20 # Subgroup for size !=3D 0b11 [ diff --git a/target/arm/translate-neon.inc.c b/target/arm/translate-neon.in= c.c index 48a0dee1506..84bc2b239ca 100644 --- a/target/arm/translate-neon.inc.c +++ b/target/arm/translate-neon.inc.c @@ -2812,3 +2812,79 @@ static bool trans_VQDMLSL_2sc(DisasContext *s, arg_2= scalar *a) =20 return do_2scalar_long(s, a, opfn[a->size], accfn[a->size]); } + +static bool trans_VEXT(DisasContext *s, arg_VEXT *a) +{ + if (!arm_dc_feature(s, ARM_FEATURE_NEON)) { + return false; + } + + /* UNDEF accesses to D16-D31 if they don't exist. */ + if (!dc_isar_feature(aa32_simd_r32, s) && + ((a->vd | a->vn | a->vm) & 0x10)) { + return false; + } + + if ((a->vn | a->vm | a->vd) & a->q) { + return false; + } + + if (a->imm > 7 && !a->q) { + return false; + } + + if (!vfp_access_check(s)) { + return true; + } + + if (!a->q) { + /* Extract 64 bits from */ + TCGv_i64 left, right, dest; + + left =3D tcg_temp_new_i64(); + right =3D tcg_temp_new_i64(); + dest =3D tcg_temp_new_i64(); + + neon_load_reg64(right, a->vn); + neon_load_reg64(left, a->vm); + tcg_gen_extract2_i64(dest, right, left, a->imm * 8); + neon_store_reg64(dest, a->vd); + + tcg_temp_free_i64(left); + tcg_temp_free_i64(right); + tcg_temp_free_i64(dest); + } else { + /* Extract 128 bits from */ + TCGv_i64 left, middle, right, destleft, destright; + + left =3D tcg_temp_new_i64(); + middle =3D tcg_temp_new_i64(); + right =3D tcg_temp_new_i64(); + destleft =3D tcg_temp_new_i64(); + destright =3D tcg_temp_new_i64(); + + if (a->imm < 8) { + neon_load_reg64(right, a->vn); + neon_load_reg64(middle, a->vn + 1); + tcg_gen_extract2_i64(destright, right, middle, a->imm * 8); + neon_load_reg64(left, a->vm); + tcg_gen_extract2_i64(destleft, middle, left, a->imm * 8); + } else { + neon_load_reg64(right, a->vn + 1); + neon_load_reg64(middle, a->vm); + tcg_gen_extract2_i64(destright, right, middle, (a->imm - 8) * = 8); + neon_load_reg64(left, a->vm + 1); + tcg_gen_extract2_i64(destleft, middle, left, (a->imm - 8) * 8); + } + + neon_store_reg64(destright, a->vd); + neon_store_reg64(destleft, a->vd + 1); + + tcg_temp_free_i64(destright); + tcg_temp_free_i64(destleft); + tcg_temp_free_i64(right); + tcg_temp_free_i64(middle); + tcg_temp_free_i64(left); + } + return true; +} diff --git a/target/arm/translate.c b/target/arm/translate.c index 4d39bbf035b..a0822dba5e2 100644 --- a/target/arm/translate.c +++ b/target/arm/translate.c @@ -5030,10 +5030,8 @@ static int disas_neon_data_insn(DisasContext *s, uin= t32_t insn) int pass; int u; int vec_size; - uint32_t imm; TCGv_i32 tmp, tmp2, tmp3, tmp5; TCGv_ptr ptr1; - TCGv_i64 tmp64; =20 if (!arm_dc_feature(s, ARM_FEATURE_NEON)) { return 1; @@ -5076,60 +5074,8 @@ static int disas_neon_data_insn(DisasContext *s, uin= t32_t insn) return 1; } else { /* size =3D=3D 3 */ if (!u) { - /* Extract. */ - imm =3D (insn >> 8) & 0xf; - - if (imm > 7 && !q) - return 1; - - if (q && ((rd | rn | rm) & 1)) { - return 1; - } - - if (imm =3D=3D 0) { - neon_load_reg64(cpu_V0, rn); - if (q) { - neon_load_reg64(cpu_V1, rn + 1); - } - } else if (imm =3D=3D 8) { - neon_load_reg64(cpu_V0, rn + 1); - if (q) { - neon_load_reg64(cpu_V1, rm); - } - } else if (q) { - tmp64 =3D tcg_temp_new_i64(); - if (imm < 8) { - neon_load_reg64(cpu_V0, rn); - neon_load_reg64(tmp64, rn + 1); - } else { - neon_load_reg64(cpu_V0, rn + 1); - neon_load_reg64(tmp64, rm); - } - tcg_gen_shri_i64(cpu_V0, cpu_V0, (imm & 7) * 8); - tcg_gen_shli_i64(cpu_V1, tmp64, 64 - ((imm & 7) * 8)); - tcg_gen_or_i64(cpu_V0, cpu_V0, cpu_V1); - if (imm < 8) { - neon_load_reg64(cpu_V1, rm); - } else { - neon_load_reg64(cpu_V1, rm + 1); - imm -=3D 8; - } - tcg_gen_shli_i64(cpu_V1, cpu_V1, 64 - (imm * 8)); - tcg_gen_shri_i64(tmp64, tmp64, imm * 8); - tcg_gen_or_i64(cpu_V1, cpu_V1, tmp64); - tcg_temp_free_i64(tmp64); - } else { - /* BUGFIX */ - neon_load_reg64(cpu_V0, rn); - tcg_gen_shri_i64(cpu_V0, cpu_V0, imm * 8); - neon_load_reg64(cpu_V1, rm); - tcg_gen_shli_i64(cpu_V1, cpu_V1, 64 - (imm * 8)); - tcg_gen_or_i64(cpu_V0, cpu_V0, cpu_V1); - } - neon_store_reg64(cpu_V0, rd); - if (q) { - neon_store_reg64(cpu_V1, rd + 1); - } + /* Extract: handled by decodetree */ + return 1; } else if ((insn & (1 << 11)) =3D=3D 0) { /* Two register misc. */ op =3D ((insn >> 12) & 0x30) | ((insn >> 7) & 0xf); --=20 2.20.1