From nobody Mon Feb 9 12:16:47 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1592300939; cv=none; d=zohomail.com; s=zohoarc; b=VQSv6cti2/iZpb1r92CL1FKXD+kKPA+bF7eiMQaySofA2/Fy4SEiC52TvX3Cr2egEw4LMuchGEvpAACI2Htb2EREowTSB5U1wD7NlVW2QsC8KRXV9kaz2NQacJl2NVcGjLo4BeKa8QmsOkwfcAa/irhWIAmJkHUTPMkGL53oMr0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1592300939; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Bx4xNdWeU6C7TR4mll2UBf3V29qn2VJEgsPuF0yeqI4=; b=GMO2JS+32U1cp6wFbIFTsu8EtF3G/VVBEvph2PxE4WiC0FgCQU5DQzeIEQw02o4Xq0relNhVc7LFm35hFwPJ0trraUnDV2gUHwuoUSfV7e92XhRcLyPgZQF21SiiVk3nsOtea4tssHIHPn9JDi5acU+1dTCpxzyWHkh7wcZrbsM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1592300938990770.9986822563981; Tue, 16 Jun 2020 02:48:58 -0700 (PDT) Received: from localhost ([::1]:33860 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jl8DA-0003sf-OG for importer@patchew.org; Tue, 16 Jun 2020 05:48:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48686) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jl8A9-0000ov-TA; Tue, 16 Jun 2020 05:45:49 -0400 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]:36748) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jl8A8-00024v-Ed; Tue, 16 Jun 2020 05:45:49 -0400 Received: by mail-wm1-x343.google.com with SMTP id d128so2379389wmc.1; Tue, 16 Jun 2020 02:45:47 -0700 (PDT) Received: from localhost.localdomain (181.red-88-10-103.dynamicip.rima-tde.net. [88.10.103.181]) by smtp.gmail.com with ESMTPSA id o82sm3254017wmo.40.2020.06.16.02.45.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jun 2020 02:45:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Bx4xNdWeU6C7TR4mll2UBf3V29qn2VJEgsPuF0yeqI4=; b=CLL75c8uzvdrd26sq1LzFvBCsCuUU33kDB6iXE3xilPTMwirEr4kW8CNn/jDDjuxyZ PJwuJs/EQ0FeZjw1zBXFQ54qVBo6sAW4QeNvDsYELmVm8pdsypsFmQ8Xr/0cm+9uH14r a3h+Aela2G4l3o1pc7GsnN8eFSKvq1SUDttd9reUAHL79vhfYTz80BvBD/1t42yWk1AA jXPxk7g6LR9AQZtns2iTT2ppd4SoD3Nqv5FaleAAj3zQ4d2jPuJus+QFL0w1soNLNyEC VVEiUjDRtQu7bMuFObW8D4/0WuEXiJJQgPjIw4xvllval466C+DPc71iHNcb4m4dM7pE FmQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=Bx4xNdWeU6C7TR4mll2UBf3V29qn2VJEgsPuF0yeqI4=; b=A57BVKQ3yidfFd9YB6/89J8kp583CIVFE+vAhvNHvzf9mYs1kCtMVl72Gzfb8JSW0E w4/DtD1sz/V5fx9DoDzyid9j5RWcTj4FrvQsUYkVCYlCrmXH6cAT4NIikpuyLlmrFoaQ 5sGk8xxMnrNaItNenIEwtU+DlVI7E90yhthA3cEOe5OHmxSOdVME8BWUIP+vQUevqkLC +8q2uKEa9a4eUDZ6vfE3y5em3eqsMhuXS4jqgiNkF1hg4IQDCIReU2ZyRNeAXiGT8jL8 7nuddDCafT7tOi+4aCrxSbcAoTHIIMxo1ZooWRN5JtLAx2xPMEM0wcrMh9SlrmtGYof0 UEHA== X-Gm-Message-State: AOAM533yzvM3rPL5nYPC5F0rmWJf3YAw23lYjAfP7QEK5Uus7JotiylJ WD6kSbIsL79KSYxAAU/9rLnzPV07 X-Google-Smtp-Source: ABdhPJxbhSF8DGknQMoNW6WPUKmcJzJhHB1NirO5EATbNDXVlvXpYHE1rPnk604ZhzEzEiAhb+oSlA== X-Received: by 2002:a1c:3c1:: with SMTP id 184mr2243919wmd.40.1592300746586; Tue, 16 Jun 2020 02:45:46 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH 1/2] hw/misc/pca9552: Trace LED On/Off events Date: Tue, 16 Jun 2020 11:45:41 +0200 Message-Id: <20200616094542.25415-2-f4bug@amsat.org> X-Mailer: git-send-email 2.21.3 In-Reply-To: <20200616094542.25415-1-f4bug@amsat.org> References: <20200616094542.25415-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::343; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-x343.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: 0 X-Spam_score: 0.0 X-Spam_bar: / X-Spam_report: (0.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=1, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Andrew Jeffery , Joaquin de Andres , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Esteban Bosse , qemu-arm@nongnu.org, Joel Stanley , Guenter Roeck , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: C=C3=A9dric Le Goater Tested-by: C=C3=A9dric Le Goater --- hw/misc/pca9552.c | 7 +++++++ hw/misc/trace-events | 3 +++ 2 files changed, 10 insertions(+) diff --git a/hw/misc/pca9552.c b/hw/misc/pca9552.c index cac729e35a..a3d0decbff 100644 --- a/hw/misc/pca9552.c +++ b/hw/misc/pca9552.c @@ -17,6 +17,7 @@ #include "migration/vmstate.h" #include "qapi/error.h" #include "qapi/visitor.h" +#include "trace.h" =20 #define PCA9552_LED_ON 0x0 #define PCA9552_LED_OFF 0x1 @@ -45,9 +46,15 @@ static void pca9552_update_pin_input(PCA9552State *s) switch (config) { case PCA9552_LED_ON: s->regs[input_reg] |=3D 1 << input_shift; + if (input_shift < s->nr_leds) { + trace_pca9552_led_set(input_shift, true); + } break; case PCA9552_LED_OFF: s->regs[input_reg] &=3D ~(1 << input_shift); + if (input_shift < s->nr_leds) { + trace_pca9552_led_set(input_shift, false); + } break; case PCA9552_LED_PWM0: case PCA9552_LED_PWM1: diff --git a/hw/misc/trace-events b/hw/misc/trace-events index 5561746866..ed80d0d1be 100644 --- a/hw/misc/trace-events +++ b/hw/misc/trace-events @@ -206,3 +206,6 @@ via1_rtc_cmd_pram_sect_write(int sector, int offset, in= t addr, int value) "secto # grlib_ahb_apb_pnp.c grlib_ahb_pnp_read(uint64_t addr, uint32_t value) "AHB PnP read addr:0x%03= "PRIx64" data:0x%08x" grlib_apb_pnp_read(uint64_t addr, uint32_t value) "APB PnP read addr:0x%03= "PRIx64" data:0x%08x" + +# pca9552.c +pca9552_led_set(unsigned id, bool state) "LED#%d state:%u" --=20 2.21.3 From nobody Mon Feb 9 12:16:47 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1592300816; cv=none; d=zohomail.com; s=zohoarc; b=L/unwg0tVfNtspeitmge4oTIuKu1VWfSZqCXr9y4QXUETznt0r1jnCPlfmxNDaUidBc/ihkpYxOEbza/wAFPIk1AbzvzrUmEF8bBvyODNeV9WKJH0O7C3jrwzZttJrx8c/PCbSxmNmyU3A/KI6lTvlPBD9RADtVNsAiGti5fWcM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1592300816; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=pfO7RXZ9AYJ/DjgBHj2w4iXg2BcEpoZpY+MZ/Colj/Q=; b=nSStKRoy3cIj+vpnviLIhU0Hk/o90NPYKZZUfv6aXF35MkziiEQoKA5UZPxB8lHB/m31VRe5mTSFOAYIzcrcB6gmGmnqcB7SuNaXPOE5XOqE+/U0Zyua+xPWMhBdnnNeL3vU13SxVL8YZsTJKRVgkskSG67yxO/49pZWRUDuKBY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1592300816283986.2340763463787; Tue, 16 Jun 2020 02:46:56 -0700 (PDT) Received: from localhost ([::1]:57888 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jl8BB-0001y1-TW for importer@patchew.org; Tue, 16 Jun 2020 05:46:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48698) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jl8AB-0000rW-Nq; Tue, 16 Jun 2020 05:45:51 -0400 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]:34963) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jl8A9-000265-RG; Tue, 16 Jun 2020 05:45:51 -0400 Received: by mail-wm1-x332.google.com with SMTP id q25so2387420wmj.0; Tue, 16 Jun 2020 02:45:49 -0700 (PDT) Received: from localhost.localdomain (181.red-88-10-103.dynamicip.rima-tde.net. [88.10.103.181]) by smtp.gmail.com with ESMTPSA id o82sm3254017wmo.40.2020.06.16.02.45.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jun 2020 02:45:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=pfO7RXZ9AYJ/DjgBHj2w4iXg2BcEpoZpY+MZ/Colj/Q=; b=KxzkE+kN8d+/yMtCLY1rzEEnkce4mOs2MuyvzONtDwHw1al6D8OQMOW6ZAr0lKDYAl 6jivjgal0lK8KKlIWNfNyx/+eEnjViaDyH5nYwjfbntGqQDoXl2QurpPyTm+Ehl+TQtN 32x4W+MMV/eFcU1th8H9ebPPrJ9iPy2aWGIu0Z9pFdUvvfa+ZQ4jAQxStV9/dIN4zUBu GmFzdfR9c74wLiX9tz+8N1o65kv4b3E0GSb5/3n5Lu/P5GIzk4AgnFNH236C6ri5AI7t gdrZpRmvIzG9O2ygbuOZQCZ6qVywbB7qVLCndMrC60xPEJ7yFQ9XiR7mq/EqdMbNw74e tjIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=pfO7RXZ9AYJ/DjgBHj2w4iXg2BcEpoZpY+MZ/Colj/Q=; b=um1IGh5n2rh0lHCJlMcsuEUY/V2anqtjt/VvD4gmXhgUxf2H+UO3qEvcvOO9VSCAVH pNV0+aBM863VrwRnjDCm9Tmp3K+TmdKiAJ3120owH0EIzXjt+4ALhFtSmSgSoMG7+5ip qVYZ7+eGmuV9KZTtmZdHqXguxw7kyhxtUNrAeq7j84Ju08v03juinUYr3KDs1WNhJPs6 TAdwmB31Val6ycZAw/Lfv/n0s0XGdW9ewvfdaX367z+gRIDp2bQAK2LasT4subD6DNYg LtxZtr2bMs+X4HOUfR20WYmU9s4tIh5ram81JT6Q1DRBtrqtyyzdsUmXkO3wnkOeBbYW OWgA== X-Gm-Message-State: AOAM531i/UxpPHxyg6W2wnAqT6+AZoQE7rakKLQFrWr93vOeMPNnDUyi +xsWpHGqdPcNqsItYqGZNno77svA X-Google-Smtp-Source: ABdhPJxyn+eAAwG1pX3uM8LXYhyajmtwoVyA+glwGdnOODPzXDfMnmfDf833Wd2aOeXHmXstoE8IQA== X-Received: by 2002:a1c:7f4e:: with SMTP id a75mr2386452wmd.127.1592300747903; Tue, 16 Jun 2020 02:45:47 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH 2/2] hw/misc/pca9552: Make LEDs 13-15 also GPIOs Date: Tue, 16 Jun 2020 11:45:42 +0200 Message-Id: <20200616094542.25415-3-f4bug@amsat.org> X-Mailer: git-send-email 2.21.3 In-Reply-To: <20200616094542.25415-1-f4bug@amsat.org> References: <20200616094542.25415-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::332; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-x332.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: 0 X-Spam_score: 0.0 X-Spam_bar: / X-Spam_report: (0.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=1, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Andrew Jeffery , Joaquin de Andres , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Esteban Bosse , qemu-arm@nongnu.org, Joel Stanley , Guenter Roeck , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) The PCA9552 has 3 GPIOs, add them. See 'PCA9552 Product Datasheet Rev. 05 - 9 March 2006', chapter 6.4 'Pins used as GPIOs': LED pins not used to control LEDs can be used as general purpose I/Os (GPIOs). For use as input, set LEDn to high-impedance (01) and then read the pin state via the input register. For use as output, connect external pull-up resistor to the pin and size it according to the DC recommended operating characteristics. LED output pin is HIGH when the output is programmed as high-impedance, and LOW when the output is programmed LOW through the =E2=80=98LED selector=E2=80=99 register. The output can be pulse-width controlled when PWM0 or PWM1 are used. And chapter 8 'Application design-in information': LED0 to LED12 are used as LED drivers. LED13 to LED15 are used as regular GPIOs. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- include/hw/misc/pca9552.h | 2 ++ hw/misc/pca9552.c | 18 ++++++++++++++++++ 2 files changed, 20 insertions(+) diff --git a/include/hw/misc/pca9552.h b/include/hw/misc/pca9552.h index ebb43c63fe..7e47ea312d 100644 --- a/include/hw/misc/pca9552.h +++ b/include/hw/misc/pca9552.h @@ -15,6 +15,7 @@ #define PCA9552(obj) OBJECT_CHECK(PCA9552State, (obj), TYPE_PCA9552) =20 #define PCA9552_NR_REGS 10 +#define PCA9552_NR_GPIOS 3 =20 typedef struct PCA9552State { /*< private >*/ @@ -27,6 +28,7 @@ typedef struct PCA9552State { uint8_t regs[PCA9552_NR_REGS]; uint8_t max_reg; uint8_t nr_leds; + qemu_irq gpio[PCA9552_NR_GPIOS]; } PCA9552State; =20 #endif diff --git a/hw/misc/pca9552.c b/hw/misc/pca9552.c index a3d0decbff..6ca6c0dbc2 100644 --- a/hw/misc/pca9552.c +++ b/hw/misc/pca9552.c @@ -12,8 +12,10 @@ #include "qemu/osdep.h" #include "qemu/log.h" #include "qemu/module.h" +#include "qemu/bitops.h" #include "hw/misc/pca9552.h" #include "hw/misc/pca9552_regs.h" +#include "hw/irq.h" #include "migration/vmstate.h" #include "qapi/error.h" #include "qapi/visitor.h" @@ -48,12 +50,16 @@ static void pca9552_update_pin_input(PCA9552State *s) s->regs[input_reg] |=3D 1 << input_shift; if (input_shift < s->nr_leds) { trace_pca9552_led_set(input_shift, true); + } else { + qemu_set_irq(s->gpio[input_shift - s->nr_leds], 1); } break; case PCA9552_LED_OFF: s->regs[input_reg] &=3D ~(1 << input_shift); if (input_shift < s->nr_leds) { trace_pca9552_led_set(input_shift, false); + } else { + qemu_set_irq(s->gpio[input_shift - s->nr_leds], 0); } break; case PCA9552_LED_PWM0: @@ -65,6 +71,16 @@ static void pca9552_update_pin_input(PCA9552State *s) } } =20 +static void pca9552_gpio_set(void *opaque, int n, int enable) +{ + PCA9552State *s =3D opaque; + + /* LED13 to LED15 are used as regular GPIOs. */ + s->regs[PCA9552_LS3] =3D deposit32(s->regs[PCA9552_LS3], n + 1, 1, + enable ? PCA9552_LED_ON : PCA9552_LED= _OFF); + pca9552_update_pin_input(s); +} + static uint8_t pca9552_read(PCA9552State *s, uint8_t reg) { switch (reg) { @@ -308,6 +324,8 @@ static void pca9552_initfn(Object *obj) NULL, NULL); g_free(name); } + qdev_init_gpio_in(DEVICE(obj), pca9552_gpio_set, PCA9552_NR_GPIOS); + qdev_init_gpio_out(DEVICE(obj), s->gpio, PCA9552_NR_GPIOS); } =20 static void pca9552_class_init(ObjectClass *klass, void *data) --=20 2.21.3