From nobody Mon Feb 9 17:08:05 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1592289406; cv=none; d=zohomail.com; s=zohoarc; b=dgx1sis5OcxJ3gn52+3P6/0qZz4co5cTxHdvaGfQhDrHRMa73q8iuUZKKlMgpDdhEbNuSyIGsE4d5fwtb8cGsoyWu8acTr67YN1OUX+NUfcm2TZFT3b3fQQfg0utJTjR4GyIu1oMkbQCyZ8TmRkD+x0PjoI2ilGj7R94/5ezx7g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1592289406; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=fwp2bV7YJjkiLZTrttPTVnsH6xKa3HonthSU7rRzJJA=; b=UAKOvV+qsBX3h9tHV/KOlR38ggyYkY4ILuHniP49fwXPuPPIrz9FYXSZ0LV4yjYOdctzse58RNH800HiY6HhDuEkax/b1twVWCQCiWCxzJG5PSKZkbicqkaI1aVv8GShiukVIw3TgpoDGK0XFMSqFuMHyyjDvFeFvKC7z4ObfEQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1592289406680917.2784765428088; Mon, 15 Jun 2020 23:36:46 -0700 (PDT) Received: from localhost ([::1]:56950 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jl5DB-000558-Fj for importer@patchew.org; Tue, 16 Jun 2020 02:36:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39298) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jl58e-0007u7-2y; Tue, 16 Jun 2020 02:32:04 -0400 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]:55597) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jl58c-0003LG-N1; Tue, 16 Jun 2020 02:32:03 -0400 Received: by mail-wm1-x343.google.com with SMTP id c71so1700267wmd.5; Mon, 15 Jun 2020 23:32:01 -0700 (PDT) Received: from localhost.localdomain (181.red-88-10-103.dynamicip.rima-tde.net. [88.10.103.181]) by smtp.gmail.com with ESMTPSA id t188sm2483250wmt.27.2020.06.15.23.31.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jun 2020 23:32:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=fwp2bV7YJjkiLZTrttPTVnsH6xKa3HonthSU7rRzJJA=; b=MmNw4K8/gon6mgxA9LK3rVLZq+tpX8RgeZx33g6F8PL2+ox2TeCYAIdN+aKQoxMEHA X4MYXVYC6qgJ41XhPfRzB+VVTksKfMtjpOLrhHcNYZ/zpjd7qW9rC10Nmh5HuwWL54Ou QnWdq6q776ucKZ2WGHFuiKAiURLEhoGejsj5N8BtD8Vzu5hRjT+/I2SVpdDbxB5DcF7j 8ZiHXRHJ4YI2W1AEAPlPzg5mpl1vj13rzEv0CofGxkbcWPnf1R38mY34BN0aYnfsqz3v eSJ2y1OnqTYGRyUOHc9fDzwD7lZm3WAN6+iOZ3ycwUnmSEnCySP+or7sq60Cfdly8vci 0vjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=fwp2bV7YJjkiLZTrttPTVnsH6xKa3HonthSU7rRzJJA=; b=N5GK4OZrGloQHTZqdC/b1zi21eazo27bU+8IDfePCfljSR7N/bgU3rdJiolumlcuVv MAOlDsVGJrrXiCbIx0MGNFrUlY6pCGMakhBOLaso1J3ViAgH8nN6QKAZVA1lXH45sKth m3aRJ+vr/IV/G5W9Vd+184jcX0J+fJ16PP2VdqNFo7CbeqNG1RaoJ2zOwJWtoWInav6v Y8m9k7SUMry7zXjmnPOTD3pyf8EdVTOIcFoBVqP4K2JS/ryCdvcortXJZHwQ3ljnfx5n VVhHj7gFWhZ25+afCQjmxuI0PEEvEOLZG8EjLyAyUNVYmX2iIBTAkq0bgPwybAfQMT4w BfjQ== X-Gm-Message-State: AOAM531a0a1U3VsBLeP1u+PlcYViVoDqk0nKVftaoe6w60pZMPXR4PXr ojM2UbBlQCo7Ma5HDlrfKtPRNkan X-Google-Smtp-Source: ABdhPJx10W4CD/+D2U162LBnW0cMnx/cbfyPobFSBmDgmfSepliwqzYA30FyjDPW629GJTT6dr2lvw== X-Received: by 2002:a7b:cf31:: with SMTP id m17mr1446887wmg.47.1592289120628; Mon, 15 Jun 2020 23:32:00 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH 1/7] hw/arm/mps2: Rename CMSDK AHB peripheral region Date: Tue, 16 Jun 2020 08:31:51 +0200 Message-Id: <20200616063157.16389-2-f4bug@amsat.org> X-Mailer: git-send-email 2.21.3 In-Reply-To: <20200616063157.16389-1-f4bug@amsat.org> References: <20200616063157.16389-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::343; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-x343.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: 0 X-Spam_score: 0.0 X-Spam_bar: / X-Spam_report: (0.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=1, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Joaquin de Andres , qemu-arm@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Esteban Bosse Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) To differenciate with the CMSDK APB peripheral region, rename this region 'CMSDK AHB peripheral region'. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Peter Maydell --- hw/arm/mps2.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/arm/mps2.c b/hw/arm/mps2.c index f246213206..3cc02c9018 100644 --- a/hw/arm/mps2.c +++ b/hw/arm/mps2.c @@ -212,10 +212,11 @@ static void mps2_common_init(MachineState *machine) */ create_unimplemented_device("CMSDK APB peripheral region @0x40000000", 0x40000000, 0x00010000); - create_unimplemented_device("CMSDK peripheral region @0x40010000", + create_unimplemented_device("CMSDK AHB peripheral region @0x40010000", 0x40010000, 0x00010000); create_unimplemented_device("Extra peripheral region @0x40020000", 0x40020000, 0x00010000); + create_unimplemented_device("RESERVED 4", 0x40030000, 0x001D0000); create_unimplemented_device("VGA", 0x41000000, 0x0200000); =20 --=20 2.21.3 From nobody Mon Feb 9 17:08:05 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1592289245; cv=none; d=zohomail.com; s=zohoarc; b=S3naIwUJp/EA3a3+cVyiAl2xcANjziUYaH+rDu7ot6M1gxb7cX9tjetO/5uGjN3hYKjiRKz1ZpaZmT36LHOrbcS+XXeN+HTdf2FeTqCJcCAtDTJTSoHlFC8sFM/DVkOPdt3Zp15/Y4rWY82ps4zNWI34DinoA31oE9w9ZZxFqL0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1592289245; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=zqA2FU9tJ7z1sN241pmUGO/apZ+JdoG+SHFS+QpWuEA=; b=K8dHkT/wzRuIW0DrhApH+CMvd85l+3V63DoXGP7CPFtg+INdP4QQJqH3r53Z83TNlxw80SM65J80YoCQogDrCWr3dahAGXPG+a+42HXzYiwai9KT6jNsU8Ko/cWSeIFbo0tkyP2vhxSc9Fx+qUrdQ0SqkxXpE/umhY+4E2jqtFM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1592289245224911.6262818562108; Mon, 15 Jun 2020 23:34:05 -0700 (PDT) Received: from localhost ([::1]:47692 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jl5AZ-0001DS-L9 for importer@patchew.org; Tue, 16 Jun 2020 02:34:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39312) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jl58f-0007uT-8j; Tue, 16 Jun 2020 02:32:05 -0400 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]:50887) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jl58d-0003LR-HS; Tue, 16 Jun 2020 02:32:04 -0400 Received: by mail-wm1-x341.google.com with SMTP id l17so1723880wmj.0; Mon, 15 Jun 2020 23:32:02 -0700 (PDT) Received: from localhost.localdomain (181.red-88-10-103.dynamicip.rima-tde.net. [88.10.103.181]) by smtp.gmail.com with ESMTPSA id t188sm2483250wmt.27.2020.06.15.23.32.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jun 2020 23:32:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=zqA2FU9tJ7z1sN241pmUGO/apZ+JdoG+SHFS+QpWuEA=; b=OYqjEsjIf9mT85xUHLTdSJOVKFvKCGpcGerrL8lLXivaNhEXa5qarLa0CunVVUj7Ku EzsaVGpKrQCasNtZ2EUVHty794yeTatEgiPODQwLGf39DDxj+skOlqz/2+0fPjHqMAhF DpCIeQZAa/U0fDaszqyonqqRZnPoalmYNfTVasSEaNJTLqIXG+ZiOYmO7upojA4Ocgug ZQg74yFBHbgukaQh9b227/sijPh0q8RKUhu+lDLLQy9dRpRTP09q4L/iCpnPokwNz+Ii ZcLT+3w8Z29rvr07AVshDlcYRxvsMWF+s1BUD6l+sGmIHJ95lIBXM3xCJ7FgLFZ2Bccg VREw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=zqA2FU9tJ7z1sN241pmUGO/apZ+JdoG+SHFS+QpWuEA=; b=i7Ih2HeskeJgmKFEWMOZFrWyPMZpcRymB178EKmOURdLTNJCpm9gRqoAeinF7uGcB+ todagm3r0pnO5dsxJKtjlWtgiDFtI5J51fo+csRE/fBuYEImEazT8ywGuhmSQUO4x5AV k0A3KO90Vtv1l1WZPY2z4AvOdVIkKn5QnHetW/5yKSqg689zXpuvQFuuKSCbh1wfhnDh V9RV67/1D8FF394ZiKfVV+x/qwn0fTm8WihvYxlA/A0pbYOGY6JTydv0dJR8EwtxO3th q0h7n7GDS6g4A0DahDc7rWCsJUi/Q+Rh0/LA2u/hVsLn5gJFcd4dgPNxssY9Ia5CgNRY 62og== X-Gm-Message-State: AOAM530F6IlDW9YlOTdnpzQPpuxPpEqF6EMpwTGky4Nrc3QVD7H5yhLM zgM77xOaQ+1RF3E6XW/mgOuCPG4K X-Google-Smtp-Source: ABdhPJyq9Bc5RyVkOKPFUh1u5sg2eUWFaCIhaW1/M0z2NJk0Nt7KDb7SewsszkTaAxM7VqQjUH9hpw== X-Received: by 2002:a1c:b182:: with SMTP id a124mr1470329wmf.114.1592289121705; Mon, 15 Jun 2020 23:32:01 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH 2/7] hw/arm/mps2: Rename dualtimer as apb-dualtimer Date: Tue, 16 Jun 2020 08:31:52 +0200 Message-Id: <20200616063157.16389-3-f4bug@amsat.org> X-Mailer: git-send-email 2.21.3 In-Reply-To: <20200616063157.16389-1-f4bug@amsat.org> References: <20200616063157.16389-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::341; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-x341.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: 0 X-Spam_score: 0.0 X-Spam_bar: / X-Spam_report: (0.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=1, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Joaquin de Andres , qemu-arm@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Esteban Bosse Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) The dualtimer is connected to AMBA APB. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/arm/mps2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/arm/mps2.c b/hw/arm/mps2.c index 3cc02c9018..1e8d5f21f9 100644 --- a/hw/arm/mps2.c +++ b/hw/arm/mps2.c @@ -306,7 +306,7 @@ static void mps2_common_init(MachineState *machine) cmsdk_apb_timer_create(0x40000000, qdev_get_gpio_in(armv7m, 8), SYSCLK= _FRQ); cmsdk_apb_timer_create(0x40001000, qdev_get_gpio_in(armv7m, 9), SYSCLK= _FRQ); =20 - sysbus_init_child_obj(OBJECT(mms), "dualtimer", &mms->dualtimer, + sysbus_init_child_obj(OBJECT(mms), "apb-dualtimer", &mms->dualtimer, sizeof(mms->dualtimer), TYPE_CMSDK_APB_DUALTIMER= ); qdev_prop_set_uint32(DEVICE(&mms->dualtimer), "pclk-frq", SYSCLK_FRQ); object_property_set_bool(OBJECT(&mms->dualtimer), true, "realized", --=20 2.21.3 From nobody Mon Feb 9 17:08:05 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=amsat.org ARC-Seal: i=1; a=rsa-sha256; t=1592289275; cv=none; d=zohomail.com; s=zohoarc; b=bdY1h1eTzw7gK7nZVtzgAjNVy0BmKnPPVE/jk6lNOCf4PiI7dN8yxAKfAuZsge341HI8EiQDLfI1uWLRmTP2RDZCA9NMuixNVH2bhjqvLCDJydwL0gJEd62UO8/I0LND5rPA/RJB+Dg6un23nyMId1EsMWVStprzKoiI14l6xt4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1592289275; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=MjgVP8rwX0nk7ybJEZVD26qOTyCHQ8rjBa6s5OZUNzs=; b=gtd9fM97jCclv0JYcCscN53JVjrBNKuy5xfw2sc7i4fqg+s6CefmL8fEhCbSg4L/etOGFplDSmPxOSblDXLgElQg2pe11tnOMf7/EHJVj8sx5JZpR/JUqYjrHRzVFXM6vsWNyeMB1MyIZtGLNUiQl3xmT+o/IeHIF9z6+uyBung= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1592289275540978.2563865601201; Mon, 15 Jun 2020 23:34:35 -0700 (PDT) Received: from localhost ([::1]:48510 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jl5B4-0001Xd-8b for importer@patchew.org; Tue, 16 Jun 2020 02:34:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39332) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jl58g-0007wR-KV; Tue, 16 Jun 2020 02:32:06 -0400 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]:37448) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jl58e-0003Lk-Ta; Tue, 16 Jun 2020 02:32:06 -0400 Received: by mail-wr1-x444.google.com with SMTP id x13so19439573wrv.4; Mon, 15 Jun 2020 23:32:04 -0700 (PDT) Received: from localhost.localdomain (181.red-88-10-103.dynamicip.rima-tde.net. [88.10.103.181]) by smtp.gmail.com with ESMTPSA id t188sm2483250wmt.27.2020.06.15.23.32.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jun 2020 23:32:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=MjgVP8rwX0nk7ybJEZVD26qOTyCHQ8rjBa6s5OZUNzs=; b=sBV0tcVoyjFqt1tVIHJE+6IUOMYpnGXt9S+RgQDfZjA9NOv5tjC1sg9ErQTj7r7USx IQRta6mwBfv7PmQZM8/NDJ3s4JS7VvEcznMWyiRRMgolaf0b9yQeYytC9MUtcf/2SqVI MPepvu8uqkipGJJPz/7H5+H6TOI0xsx+H6GfyYlscitRJs3S/nCDlhNxymHPAf4w4wb0 D33za4FDs4BxrJbsju3v+FgSHMY+lgsvVfrvdc0ULAehQSYRbgjgJYIRWMbeiOzciMte Ng2/l0P9rmV4a3nDB9AHZzFgh0avziaKClgHYv8jKFP8WxpXH5pmcE0D+vBezardStt2 kwiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=MjgVP8rwX0nk7ybJEZVD26qOTyCHQ8rjBa6s5OZUNzs=; b=j+mpgQ8WbfnfIpIADZxgIF9TjlZJB77e3f+Vqyq5nyKSUVdLiyQQlh93u8hQAgfwZ0 DqWULdFmqq5tN71vwh9KE6sKa1fWXvMCFdQmW9XSqW7mqJa2sBcJk67TKWsllM3oH7fh h1wvZSI/ESjesbxucIucrDkwbTVP3gwErfLY94E4XU4qaCnkwLoVNHgCjuoP1tWOxetd dw/XlOSxRWOraRi8I6GdLJVokaqfzF/J95kQWVTcMlO9kadFRw4tbd77WcXBo66uCB7s AxzLVlpN5aI8LH/Uf9ZeMQo4nZPaTYZdKmLrcv+ktrEbzB1Lc6ubVTfJdCeYMxLbzmt+ IscA== X-Gm-Message-State: AOAM530LGAx93xNHsHqhqWhZl9Rj2+Hu0rw41ZLrB9Uh82joCjRXYgbY djTB+D/K31xDEQLYZNn390P7A26T X-Google-Smtp-Source: ABdhPJzrJxrt0nbB08y0ysvfGXIsFhjZG84V14gT6T/WIrBhemXlay9mir0pJFKTC5XfvIWsXhLesw== X-Received: by 2002:adf:a350:: with SMTP id d16mr1345314wrb.237.1592289122994; Mon, 15 Jun 2020 23:32:02 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH 3/7] hw/arm/mps2: Add CMSDK APB watchdog as unimplemented device Date: Tue, 16 Jun 2020 08:31:53 +0200 Message-Id: <20200616063157.16389-4-f4bug@amsat.org> X-Mailer: git-send-email 2.21.3 In-Reply-To: <20200616063157.16389-1-f4bug@amsat.org> References: <20200616063157.16389-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::444; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-x444.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: 0 X-Spam_score: 0.0 X-Spam_bar: / X-Spam_report: (0.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=1, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Joaquin de Andres , qemu-arm@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Esteban Bosse Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Register the watchdog peripheral as unimplemented to better follow its accesses, for example booting Zephyr: ---------------- IN: wdog_cmsdk_apb_init 0x00000900: b508 push {r3, lr} 0x00000902: 4b07 ldr r3, [pc, #0x1c] 0x00000904: 4a07 ldr r2, [pc, #0x1c] 0x00000906: 6018 str r0, [r3] 0x00000908: 4b07 ldr r3, [pc, #0x1c] 0x0000090a: 4808 ldr r0, [pc, #0x20] 0x0000090c: f8c3 2c00 str.w r2, [r3, #0xc00] 0x00000910: 4a07 ldr r2, [pc, #0x1c] 0x00000912: 6812 ldr r2, [r2] 0x00000914: 601a str r2, [r3] 0x00000916: f000 f9f9 bl #0xd0c cmsdk-apb-watchdog: unimplemented device write (size 4, value 0x1acce551,= offset 0xc00) cmsdk-apb-watchdog: unimplemented device write (size 4, value 0xe4e1c00, = offset 0x0) Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/arm/mps2.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/arm/mps2.c b/hw/arm/mps2.c index 1e8d5f21f9..570ec50aa8 100644 --- a/hw/arm/mps2.c +++ b/hw/arm/mps2.c @@ -314,6 +314,7 @@ static void mps2_common_init(MachineState *machine) sysbus_connect_irq(SYS_BUS_DEVICE(&mms->dualtimer), 0, qdev_get_gpio_in(armv7m, 10)); sysbus_mmio_map(SYS_BUS_DEVICE(&mms->dualtimer), 0, 0x40002000); + create_unimplemented_device("cmsdk-apb-watchdog", 0x40008000, 0x1000); =20 sysbus_init_child_obj(OBJECT(mms), "scc", &mms->scc, sizeof(mms->scc), TYPE_MPS2_SCC); --=20 2.21.3 From nobody Mon Feb 9 17:08:05 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1592289249; cv=none; d=zohomail.com; s=zohoarc; b=L5dbkNkI8GeuulmENo8WVE3n1SRXS/wb/nl6puZjm6S8CzYB3Ttf6fC/uL+npyAQ2YaO0QCfHb5v7t9WbfMcIrhZlaujhOTdba1BX6KMfBl5ztD79d5X1fK/IKtNEy+jZnxC+SLa0cHgCZikXqyLramyyVbH8MEHRGD9HGQiPgE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1592289249; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=cOk8KAmRqbditcK3tUyn2RQFRwEFLc0t20rHeY/wkGk=; b=HevCr+5/THz6W6RD+/jNM/x3EsIiKwsFykJA7CHA7NmSR7oqsWTzaFzV65svsZU4CU8lxg6Sf33LcyayEHdA4RXh92d71FvJocgILhJBZ9MYKT7vMXBWtbQXnRPwvfNJNzaShrRm/f/bubj7Hr/7wxaOZaa3KZzlK9GaKr6GpXY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1592289249861879.3884738730559; Mon, 15 Jun 2020 23:34:09 -0700 (PDT) Received: from localhost ([::1]:47762 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jl5Ae-0001FC-ES for importer@patchew.org; Tue, 16 Jun 2020 02:34:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39348) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jl58h-0007ye-LB; Tue, 16 Jun 2020 02:32:07 -0400 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]:35033) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jl58f-0003Lu-Tm; Tue, 16 Jun 2020 02:32:07 -0400 Received: by mail-wr1-x444.google.com with SMTP id x14so19470695wrp.2; Mon, 15 Jun 2020 23:32:05 -0700 (PDT) Received: from localhost.localdomain (181.red-88-10-103.dynamicip.rima-tde.net. [88.10.103.181]) by smtp.gmail.com with ESMTPSA id t188sm2483250wmt.27.2020.06.15.23.32.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jun 2020 23:32:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=cOk8KAmRqbditcK3tUyn2RQFRwEFLc0t20rHeY/wkGk=; b=FfM1zO0D84sphPl8TX3M4U3jzZNT3EBhVaG810iD2iWv3LxtvkqKp9kB866cUqYucK ow7Bps+LGDYz6NCzbCVZBh7cRwAf2Pcn1FqU/tpg+Hoxr6YRCzu2xpSGozG8M49d3+GY RYEa8g59UHCUkih8KP47NfSMEpFwR4f5YQNgNDmgay20xqo2efZ59eTREGPGMZDJoiwh a7cT9u9jlgIc1NPixKmsJE0+wFqznKhJyNOFo33U9aG6UqbBQ3PzSydO9cEAteowPC0N u5ueFcqEUK91ofkGKCBO813BeMN4sZUhve26FO0ObIzd98TeuqQNJ+zn85sLIO+GMJ6h re8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=cOk8KAmRqbditcK3tUyn2RQFRwEFLc0t20rHeY/wkGk=; b=nTLaIN+cgt8uQUizHZxzxf5NzVQ0q5yG9kvVOIdj9Zcro4IjBNm1ZYBW5BYET6LDyW 34u7803stVPLYIyczDgWzYcAmC9yRdyMS9bCFbPF2F9GPNrfQd6XkNopjXVNXlag6UIH ohCtIPySPVIwbkzc7Wc3HA1cO1NXDMhTz/V9fbRa+wnYBEyp/IYpxjnqaL/1kqlBNSFz AmGR23vBgzgLHVtviIWDzpu2J4CJvIlw0HxfREuG/a45UTvAkl0SU70TU4Ty1VAAzKqg j3Tw2mJwMSY2Ckt9ABLFPZiTsNDbEW3JFSuU1/eihfp+2IkrIANWl4Rd0wbAOY/tEAPI IYzw== X-Gm-Message-State: AOAM530BFPLHhcce4eE/ZizzR0hUVVY3UAXJ99eBTry7vJ8YlOX6QkFm jb1MzgTsD0nOTS8PMI3RN5znej7n X-Google-Smtp-Source: ABdhPJwg2B8YQ+0WR7EXbmnTpSl73e2pMw/Uiv2fkojq6WF5Qzgy8X7Y08Sj9ax5773/MTG8PR8C8g== X-Received: by 2002:adf:ecce:: with SMTP id s14mr1352042wro.154.1592289124048; Mon, 15 Jun 2020 23:32:04 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH 4/7] hw/arm/mps2: Add CMSDK AHB GPIO peripherals as unimplemented devices Date: Tue, 16 Jun 2020 08:31:54 +0200 Message-Id: <20200616063157.16389-5-f4bug@amsat.org> X-Mailer: git-send-email 2.21.3 In-Reply-To: <20200616063157.16389-1-f4bug@amsat.org> References: <20200616063157.16389-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::444; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-x444.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: 0 X-Spam_score: 0.0 X-Spam_bar: / X-Spam_report: (0.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=1, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Joaquin de Andres , qemu-arm@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Esteban Bosse Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Register the GPIO peripherals as unimplemented to better follow their accesses, for example booting Zephyr: ---------------- IN: arm_mps2_pinmux_init 0x00001160: f64f 0231 movw r2, #0xf831 0x00001164: 4b06 ldr r3, [pc, #0x18] 0x00001166: 2000 movs r0, #0 0x00001168: 619a str r2, [r3, #0x18] 0x0000116a: f24c 426f movw r2, #0xc46f 0x0000116e: f503 5380 add.w r3, r3, #0x1000 0x00001172: 619a str r2, [r3, #0x18] 0x00001174: f44f 529e mov.w r2, #0x13c0 0x00001178: f503 5380 add.w r3, r3, #0x1000 0x0000117c: 619a str r2, [r3, #0x18] 0x0000117e: 4770 bx lr cmsdk-ahb-gpio: unimplemented device write (size 4, value 0xf831, offset = 0x18) cmsdk-ahb-gpio: unimplemented device write (size 4, value 0xc46f, offset = 0x18) cmsdk-ahb-gpio: unimplemented device write (size 4, value 0x13c0, offset = 0x18) Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Peter Maydell --- hw/arm/mps2.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/hw/arm/mps2.c b/hw/arm/mps2.c index 570ec50aa8..4a49bfa9b9 100644 --- a/hw/arm/mps2.c +++ b/hw/arm/mps2.c @@ -111,6 +111,7 @@ static void mps2_common_init(MachineState *machine) MemoryRegion *system_memory =3D get_system_memory(); MachineClass *mc =3D MACHINE_GET_CLASS(machine); DeviceState *armv7m, *sccdev; + int i; =20 if (strcmp(machine->cpu_type, mc->default_cpu_type) !=3D 0) { error_report("This board can only be used with CPU %s", @@ -228,7 +229,6 @@ static void mps2_common_init(MachineState *machine) */ Object *orgate; DeviceState *orgate_dev; - int i; =20 orgate =3D object_new(TYPE_OR_IRQ); object_property_set_int(orgate, 6, "num-lines", &error_fatal); @@ -265,7 +265,6 @@ static void mps2_common_init(MachineState *machine) */ Object *orgate; DeviceState *orgate_dev; - int i; =20 orgate =3D object_new(TYPE_OR_IRQ); object_property_set_int(orgate, 10, "num-lines", &error_fatal); @@ -315,6 +314,12 @@ static void mps2_common_init(MachineState *machine) qdev_get_gpio_in(armv7m, 10)); sysbus_mmio_map(SYS_BUS_DEVICE(&mms->dualtimer), 0, 0x40002000); create_unimplemented_device("cmsdk-apb-watchdog", 0x40008000, 0x1000); + for (i =3D 0; i < 4; i++) { + static const hwaddr gpiobase[] =3D {0x40010000, 0x40011000, + 0x40012000, 0x40013000}; + + create_unimplemented_device("cmsdk-ahb-gpio", gpiobase[i], 0x1000); + } =20 sysbus_init_child_obj(OBJECT(mms), "scc", &mms->scc, sizeof(mms->scc), TYPE_MPS2_SCC); --=20 2.21.3 From nobody Mon Feb 9 17:08:05 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1592289408; cv=none; d=zohomail.com; s=zohoarc; b=VS4M3QEisOmRx7Q0k3XHJ1xoyff150/elCz6Uc+ngtCCjCqkpHo+5KzQ1yQdDRG3kAPOw7kWNqXDb1C/2cViKrf30LD2xN77bSY+t3V70lk5zLMnhjpQHideUJLMn7HCbRzdOWYTB/9o/zIeuyztFRW8JNKuEHn3EH/ZANUpv+M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1592289408; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=0C754Z2styJVcWZeah0XfpUldg+E2WED/NhKiLJuUwM=; b=iRnUaTL5ulugIvrYIHbnpYDOA2LzQMu6CsM0coPMY2Dn4+L47OdJ7UpsWdYynAPRT1n5XJDb6l9KIdbR6JqBPa21bYIm3H/4hvbDbSc0SIjjMQri9LVMV4yGnK1owuxQQ3ndsqlvk12R9/LiffpsfstKBeHIMfNEt0huEcjajaQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1592289408332432.2490878637776; Mon, 15 Jun 2020 23:36:48 -0700 (PDT) Received: from localhost ([::1]:57088 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jl5DD-00058q-2l for importer@patchew.org; Tue, 16 Jun 2020 02:36:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39356) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jl58i-00080U-Hn; Tue, 16 Jun 2020 02:32:08 -0400 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]:33660) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jl58h-0003MH-1t; Tue, 16 Jun 2020 02:32:08 -0400 Received: by mail-wm1-x341.google.com with SMTP id j198so1519972wmj.0; Mon, 15 Jun 2020 23:32:06 -0700 (PDT) Received: from localhost.localdomain (181.red-88-10-103.dynamicip.rima-tde.net. [88.10.103.181]) by smtp.gmail.com with ESMTPSA id t188sm2483250wmt.27.2020.06.15.23.32.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jun 2020 23:32:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=0C754Z2styJVcWZeah0XfpUldg+E2WED/NhKiLJuUwM=; b=mX7AeBCmISmFvf1ccvUqkR0mMy1JR8NNO98AQPSOzV4WYlL6sf5STJzzK7oDXR+E03 R0CXPdpfts55K3YTMA2Acz9YHFrtm/JbUCXC+3GrbEQGIEV1Vv4dPshC4U5TpXB8oqPy oJpCC6kKvHaCiqyvgHuz5u3ollxjm8f/Jgk0ECRbo8FBjoZz62TatXlRU/fHuSbO2QI6 PipW+aLCNLmcKyW7o8XqXdjwn2Xyz6WmGPrqvR7fc8H3eSJAjOomBcqzj1S01mOSBEV9 /ssPOyLMADJqFH1u/eU5Ty0rFPtcFs6hJLaJAVXrVFUcFR9o85QUYv/vC+GiMRdCmwiy 9IHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=0C754Z2styJVcWZeah0XfpUldg+E2WED/NhKiLJuUwM=; b=rrlve4pCZNqXzK7IBdoapoOHiEEzED0oVzapBEVBA891QmUMlQGJnC7f57+KXJZWEy md6j1u4qB6jemmXYFLWiE/8q8r/EVSjKSrO/OhEoI1kwi4aGahUQmodcE0gxOOg2wB50 gkHRcpPansWfSUPs0JAx12XVg563FFH2mB9bZtbzSg5fhV9TQBklMNeAyNvnvm68EDBj JkI0aStD3BnvJwg15k5yYShh3gCk+SQw2UbFvWhJuhbkptRKTTAUWBl1FSLXXsYUg3MP ybSqMheLcczXqcLhM4ToyndrPfLlZs3XLV+K9PK82e3/4MdT106/HJhqw8MQnT7SdqWS hBaA== X-Gm-Message-State: AOAM533npcPKP98VB5eNdL7Be2l9Uu8L525Mc7Iu81kOi19xU2cG3hAX sHiRmbR3CE7hRwCO/St/jCyUKBo2 X-Google-Smtp-Source: ABdhPJzlPadS5VEC26TKnCCdNA0iXGEZ7JZ2XekaKsP6DbW7l6mwdkDDgV5T99IwPunfRpmXd+Qt1Q== X-Received: by 2002:a1c:9613:: with SMTP id y19mr1475307wmd.135.1592289125102; Mon, 15 Jun 2020 23:32:05 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH 5/7] hw/arm/mps2: Add I2C busses on FPGA APB Date: Tue, 16 Jun 2020 08:31:55 +0200 Message-Id: <20200616063157.16389-6-f4bug@amsat.org> X-Mailer: git-send-email 2.21.3 In-Reply-To: <20200616063157.16389-1-f4bug@amsat.org> References: <20200616063157.16389-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::341; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-x341.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: 0 X-Spam_score: 0.0 X-Spam_bar: / X-Spam_report: (0.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=1, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Joaquin de Andres , qemu-arm@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Esteban Bosse Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) There are 4 different I2C peripherals on the FPGA APB. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/arm/mps2.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/hw/arm/mps2.c b/hw/arm/mps2.c index 4a49bfa9b9..6224d7a63c 100644 --- a/hw/arm/mps2.c +++ b/hw/arm/mps2.c @@ -321,6 +321,7 @@ static void mps2_common_init(MachineState *machine) create_unimplemented_device("cmsdk-ahb-gpio", gpiobase[i], 0x1000); } =20 + /* FPGA APB */ sysbus_init_child_obj(OBJECT(mms), "scc", &mms->scc, sizeof(mms->scc), TYPE_MPS2_SCC); sccdev =3D DEVICE(&mms->scc); @@ -330,6 +331,12 @@ static void mps2_common_init(MachineState *machine) object_property_set_bool(OBJECT(&mms->scc), true, "realized", &error_fatal); sysbus_mmio_map(SYS_BUS_DEVICE(sccdev), 0, 0x4002f000); + for (i =3D 0; i < 4; i++) { + static const hwaddr i2cbase[] =3D {0x40022000, 0x40023000, + 0x40029000, 0x4002a000}; + + sysbus_create_simple("versatile_i2c", i2cbase[i], NULL); + } =20 /* In hardware this is a LAN9220; the LAN9118 is software compatible * except that it doesn't support the checksum-offload feature. --=20 2.21.3 From nobody Mon Feb 9 17:08:05 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=amsat.org ARC-Seal: i=1; a=rsa-sha256; t=1592289399; cv=none; d=zohomail.com; s=zohoarc; b=NSh9GYElxCua4hMCWEr6BE6x0p527e7CZyhwNIrvfG7tsmc1XMvHAG/ns79SiJ3WgmHvPSdWkqh9phux6qn7dgz53MVuHIhgOiRaci3hbInyccT8sT3UpeWbHzmPT/pBe1s3lpa56WMNCH0fj+i10FlEZYquJ926q8Rl/iGeMNg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1592289399; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=2FjgOSd/PcaKbg94PaHicHO0rGFHpV0TnPuxXVdcN10=; b=hv+M70LSadCLR7AZYL0QnQ+78MjzMdsqWyFYWSC3ZL4k4DPZB38WCtdb3Dukrx0unhvp+MuFfUQN5+83ryMsBoytYyp16B9PqRf6V3UkwO0vjZ3jJs93jOZlBQE/BXkEa9YGeOIKhg41kqGMZde7MWN+tu17SLOR5v1T0P7+lhk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1592289399786822.6742811273765; Mon, 15 Jun 2020 23:36:39 -0700 (PDT) Received: from localhost ([::1]:56446 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jl5D4-0004sb-EU for importer@patchew.org; Tue, 16 Jun 2020 02:36:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39372) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jl58j-00082C-QT; Tue, 16 Jun 2020 02:32:09 -0400 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]:33754) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jl58i-0003Mc-2W; Tue, 16 Jun 2020 02:32:09 -0400 Received: by mail-wr1-x442.google.com with SMTP id l11so19465026wru.0; Mon, 15 Jun 2020 23:32:07 -0700 (PDT) Received: from localhost.localdomain (181.red-88-10-103.dynamicip.rima-tde.net. [88.10.103.181]) by smtp.gmail.com with ESMTPSA id t188sm2483250wmt.27.2020.06.15.23.32.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jun 2020 23:32:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=2FjgOSd/PcaKbg94PaHicHO0rGFHpV0TnPuxXVdcN10=; b=T5PsuaTM5zThSTjUXQD/0QYhszyEdhoZHQp8fhpUlPl7mAtK235dFj/CuvulyuNC45 D4WcjwAEZex9pSb326jKayEUew1vxgnA2ap1jDLxL7ISjeZhelQg+HIVkybgzswZmb3E /NyqDeijTjljMlgKldEwu3NuUnLnDIBgzDNBekopeNCh2qEvAW/N4p99rdvP3lXt/Fuv RTA9Rnm2AbHqk8J5Zm/itD9hAf0R/40XKYoyMEBStSqyxrlH6IzPlTODrB0dc+zcPwb8 y65VcVCr4wfvGB1KTo3vUlLKfaAy68bpGqjoYyGToXpV1tqQKFHQ7GPJAFYUY8Z164Bj L9RA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=2FjgOSd/PcaKbg94PaHicHO0rGFHpV0TnPuxXVdcN10=; b=jOLSWNHAdegBT3VPJDSjc+9jJC7nyQ9Djm7J6hK1GfDRt69eGNLKMGPSrme67nxfRY hcIu8LMaif8AndPq9J5YZemaOoxLtXrggYY761Nf/HckgYdZ1isWhYnKUJLH8Eq6V5U4 jrqOwtEPJta5BzTubM7AbS1DW7auYP8wNgn8UVXwgiy2fN30DLEzbsj3vEvS1d0CP+rX hTVKtuMVe0hmsAlaWmYGiAV0y8SqpkWYQoCyCHLS5KQmolFJ/Bz52xibTtdstU8feELI /cOdcYR1h3YhkDkBYra2Jm6KyfGqhi6DW1C1zqIs+VhVnljSOQmLGUqWKFw6GToHBeuE SP8A== X-Gm-Message-State: AOAM532sdqHXssNiIM0gcHC6Fiy4i2gnxV2P1n49QMQkp8ZmyVWM6CS/ DqeRlnlzXnE1ykKj3WEHXUBxykM5 X-Google-Smtp-Source: ABdhPJwtY74K9OAMAZYUnH7lhCuobvYIiZAvY7IcA6o2SgRxRE6nPWfsKMxIN/N4CnR/sG7C0Y0G1w== X-Received: by 2002:a5d:5744:: with SMTP id q4mr1264543wrw.137.1592289126139; Mon, 15 Jun 2020 23:32:06 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH 6/7] hw/arm/mps2: Map the FPGA I/O block Date: Tue, 16 Jun 2020 08:31:56 +0200 Message-Id: <20200616063157.16389-7-f4bug@amsat.org> X-Mailer: git-send-email 2.21.3 In-Reply-To: <20200616063157.16389-1-f4bug@amsat.org> References: <20200616063157.16389-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::442; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-x442.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: 0 X-Spam_score: 0.0 X-Spam_bar: / X-Spam_report: (0.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=1, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Joaquin de Andres , qemu-arm@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Esteban Bosse Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/arm/mps2.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/hw/arm/mps2.c b/hw/arm/mps2.c index 6224d7a63c..345ba551ab 100644 --- a/hw/arm/mps2.c +++ b/hw/arm/mps2.c @@ -38,6 +38,7 @@ #include "hw/timer/cmsdk-apb-timer.h" #include "hw/timer/cmsdk-apb-dualtimer.h" #include "hw/misc/mps2-scc.h" +#include "hw/misc/mps2-fpgaio.h" #include "hw/net/lan9118.h" #include "net/net.h" =20 @@ -66,6 +67,7 @@ typedef struct { MemoryRegion blockram_m3; MemoryRegion sram; MPS2SCC scc; + MPS2FPGAIO fpgaio; CMSDKAPBDualTimer dualtimer; } MPS2MachineState; =20 @@ -337,6 +339,11 @@ static void mps2_common_init(MachineState *machine) =20 sysbus_create_simple("versatile_i2c", i2cbase[i], NULL); } + sysbus_init_child_obj(OBJECT(mms), "fpgaio", &mms->fpgaio, + sizeof(mms->fpgaio), TYPE_MPS2_FPGAIO); + object_property_set_bool(OBJECT(&mms->fpgaio), true, "realized", + &error_fatal); + sysbus_mmio_map(SYS_BUS_DEVICE(&mms->fpgaio), 0, 0x40028000); =20 /* In hardware this is a LAN9220; the LAN9118 is software compatible * except that it doesn't support the checksum-offload feature. --=20 2.21.3 From nobody Mon Feb 9 17:08:05 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=amsat.org ARC-Seal: i=1; a=rsa-sha256; t=1592289547; cv=none; d=zohomail.com; s=zohoarc; b=jZZMoQiW0PBBwpueRKylxjprW4j6W+S+dcWxjh6mX1lrxF/V/AXhP6dhHEaiSrdpB4k/SLj1iKmtjtqyNRJi7SfjBHE6Q5SJaTXmsj00Li0u0e/YY/pp72p139hs6u90I9MbZGL7UJWfRDvh99XPzVQZM4k6S6FEGoGqaUFod78= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1592289547; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=YSemiN4fbL6V0zVgew+3sXrasP2DCRMVckmXdCuQt0Q=; b=Yk0urN++Y2Z3lFFskTyut4xizLIM4F+S0xBcyRQUKleoG/bou54fH6O3E+BpHqGTLRFGngxTW/+o4HeHixWC5hXj4F0BcF8tZpYnBup7bdcM9qgDMzaF5K4y7wSrd8PD3V1fG//uRprpfI1ueq6bng9LPZj0LWkmSy7y0JCf1gU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1592289547221305.4739293339495; Mon, 15 Jun 2020 23:39:07 -0700 (PDT) Received: from localhost ([::1]:35098 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jl5FR-0007kF-St for importer@patchew.org; Tue, 16 Jun 2020 02:39:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39382) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jl58k-00084a-ME; Tue, 16 Jun 2020 02:32:10 -0400 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]:50889) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jl58j-0003Mp-38; Tue, 16 Jun 2020 02:32:10 -0400 Received: by mail-wm1-x342.google.com with SMTP id l17so1724103wmj.0; Mon, 15 Jun 2020 23:32:08 -0700 (PDT) Received: from localhost.localdomain (181.red-88-10-103.dynamicip.rima-tde.net. [88.10.103.181]) by smtp.gmail.com with ESMTPSA id t188sm2483250wmt.27.2020.06.15.23.32.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jun 2020 23:32:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=YSemiN4fbL6V0zVgew+3sXrasP2DCRMVckmXdCuQt0Q=; b=rIDFg/ilVdF18P/muCtqY2rGWKrLtSdARF1XIyJZhfyKw68ALtIaXRBbefq5eIS/pN KcMAyFKiME8ibiIV8rmURcD6ha5u3Y9PXL2bLuA/D82rY4fwExp2LJt49gPkKB1eDgcf hj8pKJ1e5Nn0YA88iS0kW5g3IXdTLq48fdUD0NA+effKSzyTG5byKKCTQXTbniL3JpS2 1TBsVf+KpP1RQhYnsO1TtzCkueO0Y1rnLhFYqr2FzmoF+4FPYwmzNk3pei+qhLxEC5gc NkbNVu1T8i4+Eqt/KaGkM6jUSBvF/db3YfqgfiU+VXpI8C9xrrwIcNhuRLhmyL3zmPlj bXaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=YSemiN4fbL6V0zVgew+3sXrasP2DCRMVckmXdCuQt0Q=; b=riwRADmysHHvZlbdi+wtjrdEoqY2IcjnaDd7plL+cxigGMHb7lnGpGwFGlfO5LdfIb FDwepOUCJ6A7zY+xkxzDQPUxad6nPrxR1W814eJk9WZpZptNArD80DrlTsZ6EgTBNWsJ r4EozAo3r6I+UF4SLhTlOtxeGVYC5hDWKmSth6PVz9g0M4NHsGR1AyCTEnhmihqCtgjb TaGdCoGBFhyvjdJxLM88IL5mkM/GsBxZHE2UeLDjT0VgVoIuKiSHY54/eGGkBtqlkQlZ VMlhd4eT9q5jt0+e4PIyHeMyYsnU1UszroBcjun0pHzA591conXJPp9zjNSpENIwt+r2 wMAw== X-Gm-Message-State: AOAM5319pZ21+nRXWJ5NA7dW0L8yheAAz2RLygawVqgv0PmSXTBNe7+r CMFwnf/iyokJJdNOMyotKB2LfvTd X-Google-Smtp-Source: ABdhPJxxgHEQNQ2LBe0zTFb7hlj7T+WX7pCJkCYySyoCnuCUOAq/D0Zw3YqPydNNq8hScoShj9CDTg== X-Received: by 2002:a1c:59c7:: with SMTP id n190mr1453521wmb.61.1592289127191; Mon, 15 Jun 2020 23:32:07 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH 7/7] hw/misc/mps2-fpgaio: Implement push-buttons Date: Tue, 16 Jun 2020 08:31:57 +0200 Message-Id: <20200616063157.16389-8-f4bug@amsat.org> X-Mailer: git-send-email 2.21.3 In-Reply-To: <20200616063157.16389-1-f4bug@amsat.org> References: <20200616063157.16389-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::342; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-x342.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: 0 X-Spam_score: 0.0 X-Spam_bar: / X-Spam_report: (0.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=1, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Joaquin de Andres , qemu-arm@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Esteban Bosse Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) The FPGA system control block has 2 push-buttons labelled PB0/PB1. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- include/hw/misc/mps2-fpgaio.h | 1 + hw/misc/mps2-fpgaio.c | 13 ++++++++++++- 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/include/hw/misc/mps2-fpgaio.h b/include/hw/misc/mps2-fpgaio.h index 69e265cd4b..521900ae81 100644 --- a/include/hw/misc/mps2-fpgaio.h +++ b/include/hw/misc/mps2-fpgaio.h @@ -34,6 +34,7 @@ typedef struct { MemoryRegion iomem; =20 uint32_t led0; + uint32_t button; uint32_t prescale; uint32_t misc; =20 diff --git a/hw/misc/mps2-fpgaio.c b/hw/misc/mps2-fpgaio.c index 2f3fbeef34..655e7a14fc 100644 --- a/hw/misc/mps2-fpgaio.c +++ b/hw/misc/mps2-fpgaio.c @@ -18,6 +18,7 @@ #include "qemu/osdep.h" #include "qemu/log.h" #include "qemu/module.h" +#include "qemu/bitops.h" #include "qapi/error.h" #include "trace.h" #include "hw/sysbus.h" @@ -36,6 +37,13 @@ REG32(PRESCALE, 0x1c) REG32(PSCNTR, 0x20) REG32(MISC, 0x4c) =20 +static void mps2_fpgaio_push_button(void *opaque, int irq, int level) +{ + MPS2FPGAIO *s =3D MPS2_FPGAIO(opaque); + + s->button =3D deposit32(s->button, irq, 1, level); +} + static uint32_t counter_from_tickoff(int64_t now, int64_t tick_offset, int= frq) { return muldiv64(now - tick_offset, frq, NANOSECONDS_PER_SECOND); @@ -131,7 +139,7 @@ static uint64_t mps2_fpgaio_read(void *opaque, hwaddr o= ffset, unsigned size) /* User-pressable board buttons. We don't model that, so just retu= rn * zeroes. */ - r =3D 0; + r =3D s->button; break; case A_PRESCALE: r =3D s->prescale; @@ -232,6 +240,7 @@ static void mps2_fpgaio_reset(DeviceState *dev) =20 trace_mps2_fpgaio_reset(); s->led0 =3D 0; + s->button =3D 0; s->prescale =3D 0; s->misc =3D 0; s->clk1hz_tick_offset =3D tickoff_from_counter(now, 0, 1); @@ -249,6 +258,8 @@ static void mps2_fpgaio_init(Object *obj) memory_region_init_io(&s->iomem, obj, &mps2_fpgaio_ops, s, "mps2-fpgaio", 0x1000); sysbus_init_mmio(sbd, &s->iomem); + + qdev_init_gpio_in_named(DEVICE(s), mps2_fpgaio_push_button, "PB", 2); } =20 static bool mps2_fpgaio_counters_needed(void *opaque) --=20 2.21.3