From nobody Sat Nov 15 01:00:39 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1592256346; cv=none; d=zohomail.com; s=zohoarc; b=JsqSI3IW5RBO+cdvWq/Q+pSvbA7PHDK76XFFLS57r9oZwSLL+wSCGsyhoevncsns2WH/Ws6z6g9O8fW5zDYHLDBceCN0xLV223pReS4T1s64DiJ+Qrcn/dVFia7ONccNplo8o2Ld4YFWs4ZzCyYIwA1Qpcf8ZDuBBtLsF1Hjbhw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1592256346; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=1bdwthpX063KI53Ka4xIVr1SHMvVphbvYC/t6A7aLHI=; b=KdIVA/VogfTzvNDPrUPJEp8pQb7n8cr/rmrFeEJNLNQF6snBDBkQa7Pm8a++voSCl+acwhkf1dxmnIR5NagfVh3/AB1iidYqAkiw0i26YyjLYfks9G9xdIu8kkAkbIHLJe8CxJwg3VTo9nnOdcF2cOYoBikIs4ekxV2zRe9tKEw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1592256346664435.529120716262; Mon, 15 Jun 2020 14:25:46 -0700 (PDT) Received: from localhost ([::1]:50680 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jkwbw-0002CM-QG for importer@patchew.org; Mon, 15 Jun 2020 17:25:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33980) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jkvug-0003aB-Pm for qemu-devel@nongnu.org; Mon, 15 Jun 2020 16:41:02 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:53374 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jkvua-0000hy-23 for qemu-devel@nongnu.org; Mon, 15 Jun 2020 16:41:02 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-148-PKPDzHgyPx6j2eybAA1Wxw-1; Mon, 15 Jun 2020 16:40:51 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AE096873415 for ; Mon, 15 Jun 2020 20:40:50 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-112-121.ams2.redhat.com [10.36.112.121]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7E40B19C79; Mon, 15 Jun 2020 20:40:50 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 68FAE1130342; Mon, 15 Jun 2020 22:40:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1592253653; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1bdwthpX063KI53Ka4xIVr1SHMvVphbvYC/t6A7aLHI=; b=XXbNFsLrl1Tq/SwdfO61xXLkgOpm/A58LC5jVeqaBRCM3UpJq9PXZQdJidNUPEmqC1hhnR FjbN/94gFoNtPbUSRTC7T2rG8fXJkr0mFqlGqvKu9JeUx+U5J22/pzMp2Rs3EkgbThuna9 PbJMyC6k1d8YJBfqT2z91YVQMWNC60U= X-MC-Unique: PKPDzHgyPx6j2eybAA1Wxw-1 From: Markus Armbruster To: qemu-devel@nongnu.org Subject: [PULL 81/84] qdev: Use qdev_realize() in qdev_device_add() Date: Mon, 15 Jun 2020 22:40:05 +0200 Message-Id: <20200615204008.3069956-82-armbru@redhat.com> In-Reply-To: <20200615204008.3069956-1-armbru@redhat.com> References: <20200615204008.3069956-1-armbru@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.139.110.120; envelope-from=armbru@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/15 16:38:57 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Signed-off-by: Markus Armbruster Reviewed-by: Paolo Bonzini Message-Id: <20200610053247.1583243-56-armbru@redhat.com> --- qdev-monitor.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/qdev-monitor.c b/qdev-monitor.c index 20cfa7615b..22da107484 100644 --- a/qdev-monitor.c +++ b/qdev-monitor.c @@ -661,9 +661,7 @@ DeviceState *qdev_device_add(QemuOpts *opts, Error **er= rp) goto err_del_dev; } =20 - if (bus) { - qdev_set_parent_bus(dev, bus); - } else if (qdev_hotplug && !qdev_get_machine_hotplug_handler(dev)) { + if (!bus && qdev_hotplug && !qdev_get_machine_hotplug_handler(dev)) { /* No bus, no machine hotplug handler --> device is not hotpluggab= le */ error_setg(&err, "Device '%s' can not be hotplugged on this machin= e", driver); @@ -678,7 +676,7 @@ DeviceState *qdev_device_add(QemuOpts *opts, Error **er= rp) } =20 dev->opts =3D opts; - object_property_set_bool(OBJECT(dev), true, "realized", &err); + qdev_realize(DEVICE(dev), bus, &err); if (err !=3D NULL) { dev->opts =3D NULL; goto err_del_dev; --=20 2.26.2