From nobody Sat Nov 15 01:03:25 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1592254748; cv=none; d=zohomail.com; s=zohoarc; b=iOrk/Qs/SKIXR6UmVJmNL1Gx3qhVYUUUFHpzJOO4auPpS9YVm+YC+zBpC2G7nuc5DCrehu4ad2Silj95jXnw9Zy38H1Edc0D3T0v+4HZHJuET66QPSFuxyS1ntmHruteIb7pbhiv5DnZkVy7pj8CMgJpuGVUBflnuwuqZMDt3z0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1592254748; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=8FKNvrPvDLsRitdAPoJ6/9c1yZMKCGCK96yfARlEUJw=; b=S3CQ16cAdTLlCWC13pbQaGudwoi7PHh1oNLKItLVqAoOPOXExHfw7bMYbgu7kiWXjRoF8ldacRKs3zsDfC1MBbQNvvCIY6kbVUSf5bW8Zg/6HmQbNR2o4xAzE3oWFEkO5wcaS1WFjLtBOAGK2/lUaPo1knVLykbiA3Y/bHRYBBE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1592254748446940.0685474908131; Mon, 15 Jun 2020 13:59:08 -0700 (PDT) Received: from localhost ([::1]:48794 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jkwCB-0007OX-71 for importer@patchew.org; Mon, 15 Jun 2020 16:59:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33464) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jkvuH-0002wb-V7 for qemu-devel@nongnu.org; Mon, 15 Jun 2020 16:40:39 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:23498 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jkvuD-0000Xt-TT for qemu-devel@nongnu.org; Mon, 15 Jun 2020 16:40:37 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-108-Tu0ostVrMeGeoK2Xb4UqjA-1; Mon, 15 Jun 2020 16:40:31 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8F6AA100CCC6 for ; Mon, 15 Jun 2020 20:40:30 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-112-121.ams2.redhat.com [10.36.112.121]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3ADFC5C1D2; Mon, 15 Jun 2020 20:40:27 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 88CC91135237; Mon, 15 Jun 2020 22:40:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1592253633; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8FKNvrPvDLsRitdAPoJ6/9c1yZMKCGCK96yfARlEUJw=; b=OP9i9ACg8/gxIO8XrOxZOeo3UeMxuz5mtGahV+jdh9qmhdBsH1fYzMPUywhpItBfHhskjM mWq0XFqly6G4c5tQomEj4oHz4kYwU3x7oQhxGI/xHf9YudkMupStbd6IAagfb9FvsqDWEa Iuv6S8qnS5EjecQAmyy+Eib5yC9HcgM= X-MC-Unique: Tu0ostVrMeGeoK2Xb4UqjA-1 From: Markus Armbruster To: qemu-devel@nongnu.org Subject: [PULL 31/84] qdev: Put qdev_new() to use with Coccinelle Date: Mon, 15 Jun 2020 22:39:15 +0200 Message-Id: <20200615204008.3069956-32-armbru@redhat.com> In-Reply-To: <20200615204008.3069956-1-armbru@redhat.com> References: <20200615204008.3069956-1-armbru@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.139.110.61; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/15 15:33:00 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Let's start simple and put qdev_new() to use. Coccinelle script: @ depends on !(file in "hw/core/qdev.c")@ expression type_name; @@ - DEVICE(object_new(type_name)) + qdev_new(type_name) Signed-off-by: Markus Armbruster Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Paolo Bonzini Message-Id: <20200610053247.1583243-6-armbru@redhat.com> --- hw/block/nand.c | 2 +- hw/misc/auxbus.c | 2 +- qdev-monitor.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/block/nand.c b/hw/block/nand.c index bba89688ba..cdf3429ce6 100644 --- a/hw/block/nand.c +++ b/hw/block/nand.c @@ -644,7 +644,7 @@ DeviceState *nand_init(BlockBackend *blk, int manf_id, = int chip_id) if (nand_flash_ids[chip_id].size =3D=3D 0) { hw_error("%s: Unsupported NAND chip ID.\n", __func__); } - dev =3D DEVICE(object_new(TYPE_NAND)); + dev =3D qdev_new(TYPE_NAND); qdev_prop_set_uint8(dev, "manufacturer_id", manf_id); qdev_prop_set_uint8(dev, "chip_id", chip_id); if (blk) { diff --git a/hw/misc/auxbus.c b/hw/misc/auxbus.c index 80bc3a0777..c37d235b0e 100644 --- a/hw/misc/auxbus.c +++ b/hw/misc/auxbus.c @@ -273,7 +273,7 @@ DeviceState *aux_create_slave(AUXBus *bus, const char *= type) { DeviceState *dev; =20 - dev =3D DEVICE(object_new(type)); + dev =3D qdev_new(type); assert(dev); qdev_set_parent_bus(dev, &bus->qbus); return dev; diff --git a/qdev-monitor.c b/qdev-monitor.c index a4735d3bb1..20cfa7615b 100644 --- a/qdev-monitor.c +++ b/qdev-monitor.c @@ -652,7 +652,7 @@ DeviceState *qdev_device_add(QemuOpts *opts, Error **er= rp) } =20 /* create device */ - dev =3D DEVICE(object_new(driver)); + dev =3D qdev_new(driver); =20 /* Check whether the hotplug is allowed by the machine */ if (qdev_hotplug && !qdev_hotplug_allowed(dev, &err)) { --=20 2.26.2