From nobody Mon Feb 9 14:05:32 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1592254469; cv=none; d=zohomail.com; s=zohoarc; b=cKQuiUQXMYuUUeCF+qb9+ID5z2MfUo8RCT8srpss8usWy/u2C7BT+ur0PKCJA4+78p5IgmfFDuz+CrLZlyHGo4tgqKmHFRELAvj7x2IEFRLDm/gqLxFbaJ7e9fwCwPH/X8kv+tKkGTGCIWLSBILPHx1o6wYjfheclcLHOe7f258= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1592254469; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=oR1WaFlgSz7otVXYZILJaYZbow/8lwVGgDarldA7V4w=; b=CYh6wNjzpyRCdnZnQZPpRgINsOra6acfYVGqfaUtGK91+JfRgQVjY3Jst/ZvKvMNNizHU98j7eTnFV5FVCDDaoT3q55YIdTJPy9ywRwvWAEX/Cq21ymdAynYOFxT6GbLVypu1Q0RaQnYea/3ARe4ppAdSZkruS6YQ2l9IaIA3y0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1592254469354491.4024003200393; Mon, 15 Jun 2020 13:54:29 -0700 (PDT) Received: from localhost ([::1]:57800 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jkw7f-0007cm-Ss for importer@patchew.org; Mon, 15 Jun 2020 16:54:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33652) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jkvuQ-0003Bh-Aj for qemu-devel@nongnu.org; Mon, 15 Jun 2020 16:40:46 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:21876 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jkvuL-0000a4-7l for qemu-devel@nongnu.org; Mon, 15 Jun 2020 16:40:45 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-391-vacT-XU0OJO-86u47qeY3w-1; Mon, 15 Jun 2020 16:40:37 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1F69E100CCC2; Mon, 15 Jun 2020 20:40:36 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-112-121.ams2.redhat.com [10.36.112.121]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2D1AD707C6; Mon, 15 Jun 2020 20:40:28 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 82DAD1135232; Mon, 15 Jun 2020 22:40:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1592253640; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oR1WaFlgSz7otVXYZILJaYZbow/8lwVGgDarldA7V4w=; b=FLBNk2O24JTDnXqVN0DmXZDQLn8A+E2HCiXMobM5eTKiWzyjOkacBwbbO42CYjm9VUsIeu yYJ3Ig8KygmlOlhQ1uKAJkiuXgh8Qm+kujZyNQNWHwW8YHEncoJZwNBOHEazBCg50p/cRS +rA9MXBuSRfWrQYBioDjIiTHGo0ELM0= X-MC-Unique: vacT-XU0OJO-86u47qeY3w-1 From: Markus Armbruster To: qemu-devel@nongnu.org Subject: [PULL 29/84] Revert "hw/versatile: realize the PCI root bus as part of the versatile init" Date: Mon, 15 Jun 2020 22:39:13 +0200 Message-Id: <20200615204008.3069956-30-armbru@redhat.com> In-Reply-To: <20200615204008.3069956-1-armbru@redhat.com> References: <20200615204008.3069956-1-armbru@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=207.211.31.81; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/15 15:33:04 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , "Michael S . Tsirkin" Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" This reverts commit b1af7959a66610669e1a019b9a84f6ed3a7936c6. Realizing a device automatically realizes its buses, in device_set_realized(). Realizing them in realize methods is redundant, unless the methods themselves require them to be realized early. pci_vpb_realize() doesn't. Drop the redundant bus realization. Cc: Marcel Apfelbaum Cc: Michael S. Tsirkin Signed-off-by: Markus Armbruster Reviewed-by: Paolo Bonzini Message-Id: <20200610053247.1583243-4-armbru@redhat.com> --- hw/pci-host/versatile.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/pci-host/versatile.c b/hw/pci-host/versatile.c index 8ddfb8772a..ea7390c6fa 100644 --- a/hw/pci-host/versatile.c +++ b/hw/pci-host/versatile.c @@ -459,7 +459,6 @@ static void pci_vpb_realize(DeviceState *dev, Error **e= rrp) } =20 /* TODO Remove once realize propagates to child devices. */ - object_property_set_bool(OBJECT(&s->pci_bus), true, "realized", errp); object_property_set_bool(OBJECT(&s->pci_dev), true, "realized", errp); } =20 --=20 2.26.2