From nobody Sat Nov 15 01:05:30 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1592256572; cv=none; d=zohomail.com; s=zohoarc; b=UX3dELw1XY0011e/jTPmBOAS6sfeSFdfHrUWPlnFuDFhPrWxjtxqhtwiuyr5jyyQWJTWXBHVP1YGuJtW10kGSpzQDhjDlnPl3wo+ielqzUklkMQ5TXKWPPMHJoe+Lpap/eKModc22XuGNqEF7GqiDWQ9dRo9HRVWfqRJJi/4Xyg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1592256572; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=h5uRniHQ8kVN8cknHVESOdPXvEtUPv/dvKLxaCQjQJA=; b=NagwY9ndD8mZ2cb6rgewrylLhJ3VoWIQl42wkPqrC3npTkU4TOzI2Y/VBrl9I2JcpcwImXNqgU157IookTcvci9D/24qa3JK2G81eohuztXrYFJXyW/JBn1D5JsQOyUy11N7VtBBX4ppOgBPug1aPcpPSF5nGAJP5bqIzvdB0Co= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1592256572849342.1723768343917; Mon, 15 Jun 2020 14:29:32 -0700 (PDT) Received: from localhost ([::1]:37896 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jkwfb-0000Lp-I6 for importer@patchew.org; Mon, 15 Jun 2020 17:29:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34056) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jkvuk-0003fn-FI for qemu-devel@nongnu.org; Mon, 15 Jun 2020 16:41:06 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:56803 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jkvua-0000jF-IZ for qemu-devel@nongnu.org; Mon, 15 Jun 2020 16:41:06 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-181-krna4oP6Mpacyfy44Z4i3A-1; Mon, 15 Jun 2020 16:40:43 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D5FC75AEC8; Mon, 15 Jun 2020 20:40:42 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-112-121.ams2.redhat.com [10.36.112.121]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A370919C79; Mon, 15 Jun 2020 20:40:39 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 7E078113522D; Mon, 15 Jun 2020 22:40:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1592253655; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=h5uRniHQ8kVN8cknHVESOdPXvEtUPv/dvKLxaCQjQJA=; b=UvwfbOYAMlQH5iy1jNySjQNFVEi+Tp2sQVI8gcuFayL9u8zHIZD3cNTj6C8gpnieO8CcIq G3q+lqcsPIXG2Bvl5sQGkDgpyGUdsDR28DphRAq+x0K1D/GaliO7WxECMhajeFInhoWISl d1imnuv174MAsVxptvUo5t07tv9jvCY= X-MC-Unique: krna4oP6Mpacyfy44Z4i3A-1 From: Markus Armbruster To: qemu-devel@nongnu.org Subject: [PULL 28/84] Revert "hw/prep: realize the PCI root bus as part of the prep init" Date: Mon, 15 Jun 2020 22:39:12 +0200 Message-Id: <20200615204008.3069956-29-armbru@redhat.com> In-Reply-To: <20200615204008.3069956-1-armbru@redhat.com> References: <20200615204008.3069956-1-armbru@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=207.211.31.81; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/15 15:33:04 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , "Michael S . Tsirkin" Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" This reverts commit 685f9a3428f625f580af0123aa95f4838d86cac3. Realizing a device automatically realizes its buses, in device_set_realized(). Realizing them in realize methods is redundant, unless the methods themselves require them to be realized early. raven_pcihost_realizefn() doesn't. Drop the redundant bus realization. Cc: Marcel Apfelbaum Cc: Michael S. Tsirkin Signed-off-by: Markus Armbruster Reviewed-by: Paolo Bonzini Message-Id: <20200610053247.1583243-3-armbru@redhat.com> --- hw/pci-host/prep.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/pci-host/prep.c b/hw/pci-host/prep.c index 88e2fc66a9..fc01a294a4 100644 --- a/hw/pci-host/prep.c +++ b/hw/pci-host/prep.c @@ -268,7 +268,6 @@ static void raven_pcihost_realizefn(DeviceState *d, Err= or **errp) memory_region_add_subregion(address_space_mem, 0xbffffff0, &s->pci_int= ack); =20 /* TODO Remove once realize propagates to child devices. */ - object_property_set_bool(OBJECT(&s->pci_bus), true, "realized", errp); object_property_set_bool(OBJECT(&s->pci_dev), true, "realized", errp); } =20 --=20 2.26.2