From nobody Sat Nov 15 01:03:25 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1592255524; cv=none; d=zohomail.com; s=zohoarc; b=mjiSqDe3cZqWuR0CO7/Ce9tRqmcR/Gi15Y2zXHC5elQi6Y6lD/u3zy7H9158cJQAYY+ds959yINrYrxcUw/K7FYqhxbXOmtmb47x6GYvmgeY2j9BCKbyX3zOQkZmeqBGVsbySmJ5cjiStl4naJ2uageNgWQeemniohxN10KsJlE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1592255524; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=RE1dT4X0pXhJk5SKjj1PZfZX3Cv7LEcbkluEwgKx3ak=; b=AYTOKlO0v1TpXkw+lcAL0+Wis7MKTOI1mHnqVQx8vvHoJSNXd7LaDs7LREHbLj+hKU6YhTinSNMCk2xhc1QkFQSRaj+j2IH3KZL/FKqhutBrs7qJVQUDHxAx5dvy8vzolFfpfwHmEK63GAp72pZQeIhemKbZpAZ8C4ITy3H0F/E= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1592255524292755.3554479878728; Mon, 15 Jun 2020 14:12:04 -0700 (PDT) Received: from localhost ([::1]:59132 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jkwOg-00076W-RF for importer@patchew.org; Mon, 15 Jun 2020 17:12:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33672) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jkvuR-0003F4-OR for qemu-devel@nongnu.org; Mon, 15 Jun 2020 16:40:47 -0400 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:23248 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jkvuK-0000Zo-Ow for qemu-devel@nongnu.org; Mon, 15 Jun 2020 16:40:47 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-46-yZXiH1U5PlevJ_9e9_nyBQ-1; Mon, 15 Jun 2020 16:40:38 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4ECA2803308 for ; Mon, 15 Jun 2020 20:40:37 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-112-121.ams2.redhat.com [10.36.112.121]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 21C127CAB1; Mon, 15 Jun 2020 20:40:30 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 7716E1135227; Mon, 15 Jun 2020 22:40:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1592253639; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RE1dT4X0pXhJk5SKjj1PZfZX3Cv7LEcbkluEwgKx3ak=; b=i2y1rV9YLDua6hMwcZKP3GTmol5e+FzzcE4sXQtcObq0COfGlScLYQa0ULULNZnfHIhFhE e5lijJ2ijIiLC3RZYKi77BtffienJszTqS0DQtQ50KvrX+Lo1hSySX0jggKVInmfyrIbji 3LjBqWNejomAVNTGojVWJHQNjuvtCO0= X-MC-Unique: yZXiH1U5PlevJ_9e9_nyBQ-1 From: Markus Armbruster To: qemu-devel@nongnu.org Subject: [PULL 26/84] qdev: Assert onboard devices all get realized properly Date: Mon, 15 Jun 2020 22:39:10 +0200 Message-Id: <20200615204008.3069956-27-armbru@redhat.com> In-Reply-To: <20200615204008.3069956-1-armbru@redhat.com> References: <20200615204008.3069956-1-armbru@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.139.110.61; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/15 15:33:00 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) This would have caught some of the bugs I just fixed. Signed-off-by: Markus Armbruster Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20200609122339.937862-25-armbru@redhat.com> --- hw/core/qdev.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/hw/core/qdev.c b/hw/core/qdev.c index b5b42b2616..a68ba674db 100644 --- a/hw/core/qdev.c +++ b/hw/core/qdev.c @@ -427,6 +427,19 @@ void qdev_init_nofail(DeviceState *dev) object_unref(OBJECT(dev)); } =20 +static int qdev_assert_realized_properly(Object *obj, void *opaque) +{ + DeviceState *dev =3D DEVICE(object_dynamic_cast(obj, TYPE_DEVICE)); + DeviceClass *dc; + + if (dev) { + dc =3D DEVICE_GET_CLASS(dev); + assert(dev->realized); + assert(dev->parent_bus || !dc->bus_type); + } + return 0; +} + void qdev_machine_creation_done(void) { /* @@ -434,6 +447,9 @@ void qdev_machine_creation_done(void) * only create hotpluggable devices */ qdev_hotplug =3D true; + + object_child_foreach_recursive(object_get_root(), + qdev_assert_realized_properly, NULL); } =20 bool qdev_machine_modified(void) --=20 2.26.2