From nobody Sun Nov 16 06:32:47 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1592234370; cv=none; d=zohomail.com; s=zohoarc; b=mBuAmu0drBCiLIqK1HuxdzQRGR9ARLHXdb8HDWYZVw/DBb1TNB9f9qF3dW+TMIrhH2kR0yc/xo8Q7Q6RMu9rPOYNIpHWhWdF0VVeNEqRqkoblXIFFTMTgHPxDFrWFBm528atkso3SNIwwTy/Xyn2qqkSyjO4mFOB8Xl0cqlyxtI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1592234370; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=LecwvyP45EHIo/5ojaRVp+ZNZSpf0qxlB4yWhHxuzMQ=; b=XyoYcC5XX7ayyf55re6xnw4EnhMJglDAxkMLGHUB7H3wzoTZuo8nz6gDBjZkolZtmwSUwQBhn5435Ma1Xo0A17aGT6G+AiBA+DzToHv8on4u0nHitkqsakAl2C9ID6c2EVcKbNcUASoMadG3cDoSC+ldVVXhJfpmX6rpsmjD6wU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1592234370025970.0830297359969; Mon, 15 Jun 2020 08:19:30 -0700 (PDT) Received: from localhost ([::1]:52612 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jkqtU-0002lH-PL for importer@patchew.org; Mon, 15 Jun 2020 11:19:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38662) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jkqpA-0005bV-MD for qemu-devel@nongnu.org; Mon, 15 Jun 2020 11:15:00 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:20472 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jkqp8-0008Hw-73 for qemu-devel@nongnu.org; Mon, 15 Jun 2020 11:15:00 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-320-fyhKSViFM2WLan5fPaXiaw-1; Mon, 15 Jun 2020 11:14:55 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 541B918A2666; Mon, 15 Jun 2020 15:14:54 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-112-67.ams2.redhat.com [10.36.112.67]) by smtp.corp.redhat.com (Postfix) with ESMTP id D0A1119C79; Mon, 15 Jun 2020 15:14:50 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 90CF91753D; Mon, 15 Jun 2020 17:14:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1592234097; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:content-type:content-type:in-reply-to:in-reply-to: references:references; bh=LecwvyP45EHIo/5ojaRVp+ZNZSpf0qxlB4yWhHxuzMQ=; b=bQOocitK/C/AM3XHTitguFUaLG9KP2PutLJa6l6L87sJ3xxEtvsB8CvslFYoTWlYo1UwTb tw50qFMNmcJf287gOv4jFqBBRExypSzUf3OaO4Zy2ixdR1wEWwu3StpOJW13gbzr0PpBTG 9MZge+6xyNVhlvDrXjGwTq4uLOL05ak= X-MC-Unique: fyhKSViFM2WLan5fPaXiaw-1 From: Gerd Hoffmann To: qemu-devel@nongnu.org Subject: [PULL 3/4] sm501: Ignore no-op blits Date: Mon, 15 Jun 2020 17:14:48 +0200 Message-Id: <20200615151449.19818-4-kraxel@redhat.com> In-Reply-To: <20200615151449.19818-1-kraxel@redhat.com> References: <20200615151449.19818-1-kraxel@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.139.110.61; envelope-from=kraxel@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/15 01:12:36 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-ppc@nongnu.org, Gerd Hoffmann Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: BALATON Zoltan Some guests seem to try source copy blits with same source and dest which are no-op so avoid calling pixman for these. Signed-off-by: BALATON Zoltan Message-id: b62681e58108651b2ca0d2fdbde8281e87185dbb.1591471056.git.balaton= @eik.bme.hu Signed-off-by: Gerd Hoffmann --- hw/display/sm501.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/hw/display/sm501.c b/hw/display/sm501.c index 85d54b598f80..3397ca9fbf4c 100644 --- a/hw/display/sm501.c +++ b/hw/display/sm501.c @@ -788,6 +788,11 @@ static void sm501_2d_operation(SM501State *s) (rop2_source_is_pattern ? " with pattern source" : "")); } + /* Ignore no-op blits, some guests seem to do this */ + if (src_base =3D=3D dst_base && src_pitch =3D=3D dst_pitch && + src_x =3D=3D dst_x && src_y =3D=3D dst_y) { + break; + } /* Check for overlaps, this could be made more exact */ uint32_t sb, se, db, de; sb =3D src_base + src_x + src_y * (width + src_pitch); --=20 2.18.4