From nobody Mon Feb 9 12:26:38 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=hostfission.com ARC-Seal: i=1; a=rsa-sha256; t=1592109823; cv=none; d=zohomail.com; s=zohoarc; b=jih5ys7WCU7/vGtY6v4F4PQFDhVKD8xBdd6+i4ub6GJbH0xZHuOwANWsMpCZv82/0MtWuSNBKth9019baPGQMFBln67+xqEcAha9+THmBJ3XfvVd3nk1Qa2UX/yqyCmIvd9dGtex8iyGWNoATv0jYz22TStr7EjmlolQv2TDiwY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1592109823; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=kOUUj6+wMUMPTrkoBypdrikcBCbUsuzxkmZ2BPOhY8s=; b=HhtuazJqMJqR0XO7J62MXQXd6QgCnMxLDd8sLdXtLXIWycqfwq3Plesvchdk03Q8oz9fCHHuoWt8bYBs7o+NsLiWWORxYAE51VqC8TE3IUJR/zqFAhtdYu3kZI0rIGEA6XfmEnsyVEkoD4NG2G8qQcfgBhw9Yjv0kVe837xHA9I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1592109823178207.39350259668709; Sat, 13 Jun 2020 21:43:43 -0700 (PDT) Received: from localhost ([::1]:41636 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jkKUf-0006Nx-KH for importer@patchew.org; Sun, 14 Jun 2020 00:43:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35842) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jkKTd-0004jC-B0 for qemu-devel@nongnu.org; Sun, 14 Jun 2020 00:42:37 -0400 Received: from mail1.hostfission.com ([139.99.139.48]:57380) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jkKTa-0005Av-OZ for qemu-devel@nongnu.org; Sun, 14 Jun 2020 00:42:37 -0400 Received: from moya.office.hostfission.com (office.hostfission.com [220.233.29.71]) by mail1.hostfission.com (Postfix) with ESMTP id 46503445D3; Sat, 13 Jun 2020 14:06:01 +1000 (AEST) Received: by moya.office.hostfission.com (Postfix, from userid 0) id 2EA0F3A0506; Sat, 13 Jun 2020 14:06:00 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=hostfission.com; s=mail; t=1592021161; bh=4UNyzqKwA72Hv2rXe7+67R0tuH+ZT6vZbiRtOXthWWA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ES+GokTHDTwJo8TsehcaBH4pYPjLkE0pnv2y4ByexEJa6bSLzqVcEFVDNv+s9GyJS OTuF9/h5/CYbAJvkbTJww1e2W+biI6DQW0ZZn8wizZkN5JpptibPNyF1GCXEm6DYXc 3wNravGdQjJtaXtD0h8Ocn6B8XEcuBOFdk0rHyBQ= From: Geoffrey McRae To: qemu-devel@nongnu.org Cc: kraxel@redhat.com, geoff@hostfission.com Subject: [PATCH 1/6] audio/jack: fix invalid minimum buffer size check Date: Sat, 13 Jun 2020 14:05:13 +1000 Message-Id: <20200613040518.38172-2-geoff@hostfission.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200613040518.38172-1-geoff@hostfission.com> References: <20200613040518.38172-1-geoff@hostfission.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=139.99.139.48; envelope-from=root@moya.office.hostfission.com; helo=mail1.hostfission.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/13 00:05:57 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @hostfission.com) Content-Type: text/plain; charset="utf-8" JACK does not provide us with the configured buffer size until after activiation which was overriding this minimum value. JACK itself doesn't have this minimum limitation, but the QEMU virtual hardware and as such it must be enforced, failure to do so results in audio discontinuities. Signed-off-by: Geoffrey McRae --- audio/jackaudio.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/audio/jackaudio.c b/audio/jackaudio.c index 722ddb1dfe..d0b6f748f2 100644 --- a/audio/jackaudio.c +++ b/audio/jackaudio.c @@ -434,17 +434,6 @@ static int qjack_client_init(QJackClient *c) jack_set_xrun_callback(c->client, qjack_xrun, c); jack_on_shutdown(c->client, qjack_shutdown, c); =20 - /* - * ensure the buffersize is no smaller then 512 samples, some (all?) q= emu - * virtual devices do not work correctly otherwise - */ - if (c->buffersize < 512) { - c->buffersize =3D 512; - } - - /* create a 2 period buffer */ - qjack_buffer_create(&c->fifo, c->nchannels, c->buffersize * 2); - /* allocate and register the ports */ c->port =3D g_malloc(sizeof(jack_port_t *) * c->nchannels); for (int i =3D 0; i < c->nchannels; ++i) { @@ -468,6 +457,17 @@ static int qjack_client_init(QJackClient *c) jack_activate(c->client); c->buffersize =3D jack_get_buffer_size(c->client); =20 + /* + * ensure the buffersize is no smaller then 512 samples, some (all?) q= emu + * virtual devices do not work correctly otherwise + */ + if (c->buffersize < 512) { + c->buffersize =3D 512; + } + + /* create a 2 period buffer */ + qjack_buffer_create(&c->fifo, c->nchannels, c->buffersize * 2); + qjack_client_connect_ports(c); c->state =3D QJACK_STATE_RUNNING; return 0; --=20 2.20.1