From nobody Mon Feb 9 18:46:14 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1591907139; cv=none; d=zohomail.com; s=zohoarc; b=jmJ5a5Rz9YAYvt1KP+5kkK+IK5o3elsutyKDIXKnJI7WfK9x/4V/VlM/AZaN1TFWV82sDF6SGOrBbLvLSMTBD31JIDe7mRXzO5tAKzCPbD6LaJnQ8I4/kPyw5EksqQh6fK7YEFXpdRRxODZwTKjKYntPOQEeglOttAZ/A/WbA50= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1591907139; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=xsno5tlvM6Jk1Psxj6i69cWNRmy6+Mz9lMv8WAnRyrc=; b=Ya5denVM3hYpSJ+kJ5U+514szb/sRrjqIITsPNTdvjad5cP4qx1Ygu/QEoWWbc8064freui8OK3DWzTK4LyFuxhLQSbMxkF/TilJcFAqycWM7/U/+8uB0RaIeksxW5Jp/aMKM07cOnyrRR5IY/acBFaQL/1qSzzezV4uPeSijjU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1591907139918368.06129401793055; Thu, 11 Jun 2020 13:25:39 -0700 (PDT) Received: from localhost ([::1]:39946 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jjTla-0005gm-FU for importer@patchew.org; Thu, 11 Jun 2020 16:25:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55164) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jjT98-00086t-9B for qemu-devel@nongnu.org; Thu, 11 Jun 2020 15:45:55 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:27187 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jjT90-00018y-Cf for qemu-devel@nongnu.org; Thu, 11 Jun 2020 15:45:53 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-471-uav9ZJblO_681N0rq2gBvA-1; Thu, 11 Jun 2020 15:45:43 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 703768015CE; Thu, 11 Jun 2020 19:45:42 +0000 (UTC) Received: from virtlab701.virt.lab.eng.bos.redhat.com (virtlab701.virt.lab.eng.bos.redhat.com [10.19.152.228]) by smtp.corp.redhat.com (Postfix) with ESMTP id 02ED562509; Thu, 11 Jun 2020 19:45:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591904745; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xsno5tlvM6Jk1Psxj6i69cWNRmy6+Mz9lMv8WAnRyrc=; b=YHppnoVaNuMD51WyKZ+hwnAQSvKXBbXDYLAcWFVVQlk/hqA6P0SZNaQScB/ugafX01MyDT LLHM1NBl/0BgvZs9U47ngwdPVTLZSGdVlh5FfP3DR0eDA1D+568RyasLvNWsLpzUReJyTT k2Psetwv1qHZfjHPXHztK+Q1hbdIhNU= X-MC-Unique: uav9ZJblO_681N0rq2gBvA-1 From: Paolo Bonzini To: qemu-devel@nongnu.org Subject: [PULL 065/115] hw/i386/vmport: Allow QTest use without crashing Date: Thu, 11 Jun 2020 15:43:59 -0400 Message-Id: <20200611194449.31468-66-pbonzini@redhat.com> In-Reply-To: <20200611194449.31468-1-pbonzini@redhat.com> References: <20200611194449.31468-1-pbonzini@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=207.211.31.120; envelope-from=pbonzini@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/11 08:37:10 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) From: Philippe Mathieu-Daud=C3=A9 Trying libFuzzer on the vmport device, we get: AddressSanitizer:DEADLYSIGNAL =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =3D=3D29476=3D=3DERROR: AddressSanitizer: SEGV on unknown address 0x00000= 0008840 (pc 0x56448bec4d79 bp 0x7ffeec9741b0 sp 0x7ffeec9740e0 T0) =3D=3D29476=3D=3DThe signal is caused by a READ memory access. #0 0x56448bec4d78 in vmport_ioport_read (qemu-fuzz-i386+0x1260d78) #1 0x56448bb5f175 in memory_region_read_accessor (qemu-fuzz-i386+0xefb1= 75) #2 0x56448bb30c13 in access_with_adjusted_size (qemu-fuzz-i386+0xeccc13) #3 0x56448bb2ea27 in memory_region_dispatch_read1 (qemu-fuzz-i386+0xeca= a27) #4 0x56448bb2e443 in memory_region_dispatch_read (qemu-fuzz-i386+0xeca4= 43) #5 0x56448b961ab1 in flatview_read_continue (qemu-fuzz-i386+0xcfdab1) #6 0x56448b96336d in flatview_read (qemu-fuzz-i386+0xcff36d) #7 0x56448b962ec4 in address_space_read_full (qemu-fuzz-i386+0xcfeec4) This is easily reproducible using: $ echo inb 0x5658 | qemu-system-i386 -M isapc,accel=3Dqtest -qtest stdio [I 1589796572.009763] OPENED [R +0.008069] inb 0x5658 Segmentation fault (core dumped) $ coredumpctl gdb -q Program terminated with signal SIGSEGV, Segmentation fault. #0 0x00005605b54d0f21 in vmport_ioport_read (opaque=3D0x5605b7531ce0, ad= dr=3D0, size=3D4) at hw/i386/vmport.c:77 77 eax =3D env->regs[R_EAX]; (gdb) p cpu $1 =3D (X86CPU *) 0x0 (gdb) bt #0 0x00005605b54d0f21 in vmport_ioport_read (opaque=3D0x5605b7531ce0, ad= dr=3D0, size=3D4) at hw/i386/vmport.c:77 #1 0x00005605b53db114 in memory_region_read_accessor (mr=3D0x5605b7531d8= 0, addr=3D0, value=3D0x7ffc9d261a30, size=3D4, shift=3D0, mask=3D4294967295= , attrs=3D...) at memory.c:434 #2 0x00005605b53db5d4 in access_with_adjusted_size (addr=3D0, value=3D0x= 7ffc9d261a30, size=3D1, access_size_min=3D4, access_size_max=3D4, access_fn= =3D 0x5605b53db0d2 , mr=3D0x5605b7531d80, at= trs=3D...) at memory.c:544 #3 0x00005605b53de156 in memory_region_dispatch_read1 (mr=3D0x5605b7531d= 80, addr=3D0, pval=3D0x7ffc9d261a30, size=3D1, attrs=3D...) at memory.c:1396 #4 0x00005605b53de228 in memory_region_dispatch_read (mr=3D0x5605b7531d8= 0, addr=3D0, pval=3D0x7ffc9d261a30, op=3DMO_8, attrs=3D...) at memory.c:1424 #5 0x00005605b537c80a in flatview_read_continue (fv=3D0x5605b7650290, ad= dr=3D22104, attrs=3D..., ptr=3D0x7ffc9d261b4b, len=3D1, addr1=3D0, l=3D1, m= r=3D0x5605b7531d80) at exec.c:3200 #6 0x00005605b537c95d in flatview_read (fv=3D0x5605b7650290, addr=3D2210= 4, attrs=3D..., buf=3D0x7ffc9d261b4b, len=3D1) at exec.c:3239 #7 0x00005605b537c9e6 in address_space_read_full (as=3D0x5605b5f74ac0 , addr=3D22104, attrs=3D..., buf=3D0x7ffc9d261b4b, len=3D1)= at exec.c:3252 #8 0x00005605b53d5a5d in address_space_read (len=3D1, buf=3D0x7ffc9d261b= 4b, attrs=3D..., addr=3D22104, as=3D0x5605b5f74ac0 ) at i= nclude/exec/memory.h:2401 #9 0x00005605b53d5a5d in cpu_inb (addr=3D22104) at ioport.c:88 X86CPU is NULL because QTest accelerator does not use CPU. Fix by returning default values when QTest accelerator is used. Reported-by: Clang AddressSanitizer Signed-off-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Paolo Bonzini --- hw/i386/vmport.c | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/hw/i386/vmport.c b/hw/i386/vmport.c index 79ef25d223..89bda9108e 100644 --- a/hw/i386/vmport.c +++ b/hw/i386/vmport.c @@ -34,6 +34,7 @@ #include "hw/qdev-properties.h" #include "sysemu/sysemu.h" #include "sysemu/hw_accel.h" +#include "sysemu/qtest.h" #include "qemu/log.h" #include "cpu.h" #include "trace.h" @@ -94,10 +95,14 @@ static uint64_t vmport_ioport_read(void *opaque, hwaddr= addr, VMPortState *s =3D opaque; CPUState *cs =3D current_cpu; X86CPU *cpu =3D X86_CPU(cs); - CPUX86State *env =3D &cpu->env; + CPUX86State *env; unsigned char command; uint32_t eax; =20 + if (qtest_enabled()) { + return -1; + } + env =3D &cpu->env; cpu_synchronize_state(cs); =20 eax =3D env->regs[R_EAX]; @@ -142,6 +147,9 @@ static void vmport_ioport_write(void *opaque, hwaddr ad= dr, { X86CPU *cpu =3D X86_CPU(current_cpu); =20 + if (qtest_enabled()) { + return; + } cpu->env.regs[R_EAX] =3D vmport_ioport_read(opaque, addr, 4); } =20 @@ -149,6 +157,9 @@ static uint32_t vmport_cmd_get_version(void *opaque, ui= nt32_t addr) { X86CPU *cpu =3D X86_CPU(current_cpu); =20 + if (qtest_enabled()) { + return -1; + } cpu->env.regs[R_EBX] =3D VMPORT_MAGIC; if (port_state->compat_flags & VMPORT_COMPAT_REPORT_VMX_TYPE) { cpu->env.regs[R_ECX] =3D port_state->vmware_vmx_type; @@ -172,6 +183,9 @@ static uint32_t vmport_cmd_ram_size(void *opaque, uint3= 2_t addr) { X86CPU *cpu =3D X86_CPU(current_cpu); =20 + if (qtest_enabled()) { + return -1; + } cpu->env.regs[R_EBX] =3D 0x1177; return ram_size; } --=20 2.26.2