From nobody Tue Feb 10 04:14:52 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1591908315; cv=none; d=zohomail.com; s=zohoarc; b=Vv6s9OnPr9x2qpTSNCXE5Si8/EfJZ1ZvCwjH+QeyiWwpow8KFlLgq9aliSS6VISuPh7iUgJcR562FoPxWHE078zniZ2R89rxpAbv6//rgfGcbPzUI/Oaq+2Eo6T6scVkemF9aaq6BS1RYoyqqfjFTDDK3KuSJFDQvMDUSgRwoJQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1591908315; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=tDOSBX+I1rycg2KqbZ9V3sM7gy5Up2HI9ibUsGnKUzQ=; b=YdRQ0U6EJzg6/w3zyPK68ImEL/81ZNBpot+cRTmNOOv7g5GgKIl9qIyiqbPq4VjHltRzYcZ5YS/5CdojF+5Oq1xTsAOqZbdoFETpCCoDpqnmGl/3Xh5LwtnFcFYJ6tdls6sefAwwYSCo4lTHyu/2gmLs5308BiyV6rQfk+OTDSM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 15919083152591013.8427622080497; Thu, 11 Jun 2020 13:45:15 -0700 (PDT) Received: from localhost ([::1]:49666 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jjU4X-0004Ai-MV for importer@patchew.org; Thu, 11 Jun 2020 16:45:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56148) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jjTAS-00020h-SG for qemu-devel@nongnu.org; Thu, 11 Jun 2020 15:47:16 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:24869 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jjTAN-0001QE-4u for qemu-devel@nongnu.org; Thu, 11 Jun 2020 15:47:16 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-421-tD5-rnoaMDK9bfPik4eNJQ-1; Thu, 11 Jun 2020 15:45:38 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2D0C88015CE; Thu, 11 Jun 2020 19:45:37 +0000 (UTC) Received: from virtlab701.virt.lab.eng.bos.redhat.com (virtlab701.virt.lab.eng.bos.redhat.com [10.19.152.228]) by smtp.corp.redhat.com (Postfix) with ESMTP id C7BD58FF91; Thu, 11 Jun 2020 19:45:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591904830; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tDOSBX+I1rycg2KqbZ9V3sM7gy5Up2HI9ibUsGnKUzQ=; b=DBxdT668AeNtG5BKARUN0T6hEgzpYILtN1MLVpF3QSJ9M3rOsdm2WEqJLtutVpA9kNqJ95 Q8wmdcnoMXxeDhNlbLxH50BORuQmcdp9KTFwQ2ywE7E657lDGxsucWZJWw/LBBzqlloF7X SWmrHPPA+Pr6IzLtsOfKLTmOPCju+uw= X-MC-Unique: tD5-rnoaMDK9bfPik4eNJQ-1 From: Paolo Bonzini To: qemu-devel@nongnu.org Subject: [PULL 058/115] disas: Let disas::read_memory() handler return EIO on error Date: Thu, 11 Jun 2020 15:43:52 -0400 Message-Id: <20200611194449.31468-59-pbonzini@redhat.com> In-Reply-To: <20200611194449.31468-1-pbonzini@redhat.com> References: <20200611194449.31468-1-pbonzini@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=207.211.31.81; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/11 03:29:33 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) From: Philippe Mathieu-Daud=C3=A9 Both cpu_memory_rw_debug() and address_space_read() return an error on failed transaction. Check the returned value, and return EIO in case of error. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Paolo Bonzini --- disas.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/disas.c b/disas.c index 45285d3f63..c1397d3933 100644 --- a/disas.c +++ b/disas.c @@ -39,9 +39,11 @@ target_read_memory (bfd_vma memaddr, struct disassemble_info *info) { CPUDebug *s =3D container_of(info, CPUDebug, info); + int r; =20 - cpu_memory_rw_debug(s->cpu, memaddr, myaddr, length, 0); - return 0; + r =3D cpu_memory_rw_debug(s->cpu, memaddr, myaddr, length, 0); + + return r ? EIO : 0; } =20 /* Print an error message. We can assume that this is in response to @@ -718,10 +720,11 @@ physical_read_memory(bfd_vma memaddr, bfd_byte *myadd= r, int length, struct disassemble_info *info) { CPUDebug *s =3D container_of(info, CPUDebug, info); + MemTxResult res; =20 - address_space_read(s->cpu->as, memaddr, MEMTXATTRS_UNSPECIFIED, - myaddr, length); - return 0; + res =3D address_space_read(s->cpu->as, memaddr, MEMTXATTRS_UNSPECIFIED, + myaddr, length); + return res =3D=3D MEMTX_OK ? 0 : EIO; } =20 /* Disassembler for the monitor. */ --=20 2.26.2