From nobody Mon May 13 04:47:45 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1591795099; cv=none; d=zohomail.com; s=zohoarc; b=HGbYn0PxR5eBbGmIpJz7yfdIpAI20865TYgzCtaO/f7rhSVqVvrC1TpiZO54aJtjl15ll/aYd+jw/VABiP9yu5dP24pYg/paJd/2R6BoiA4WgWwmjzu5h2cQa0zbhszSIyb5FKIAyNngyXmLZUdlu9dXiMJXgGe4v4AAZsQpcM4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1591795099; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=OzXOROevY10r6Nwp+JcMDg2KIy8BQ6fiJ42Fm8lk9v8=; b=WyGo4jpIBFn1S76j+8Wo/v5W2PzCf2Trsmwhvhu0vsTh1BiRGH8eaRe+l3zSHH/xiOnjni2uGDlyp983Uw0I4EezTxtIuDJ7O4TeQjMJPatmq1EKfvLVpH2wcoVA8GNyBcGY4Scmx3KaWZCeV+AUVaKWsetd8cjAyMYtzCoiOGE= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1591795099116749.8137671123361; Wed, 10 Jun 2020 06:18:19 -0700 (PDT) Received: from localhost ([::1]:54194 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jj0cT-0001Jd-Fe for importer@patchew.org; Wed, 10 Jun 2020 09:18:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45154) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jj0Ur-0007l7-0Y; Wed, 10 Jun 2020 09:10:25 -0400 Received: from mout.kundenserver.de ([212.227.126.133]:46185) by eggs.gnu.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jj0Up-0003cY-4z; Wed, 10 Jun 2020 09:10:24 -0400 Received: from localhost.localdomain ([82.252.135.106]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1M6lxe-1jrEUa0Fag-008JRU; Wed, 10 Jun 2020 15:10:14 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL v2 01/16] Fix parameter type in vhost migration log path Date: Wed, 10 Jun 2020 15:09:56 +0200 Message-Id: <20200610131011.1941209-2-laurent@vivier.eu> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200610131011.1941209-1-laurent@vivier.eu> References: <20200610131011.1941209-1-laurent@vivier.eu> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:GC4QxVhoyRWPc2opmiANzOPcwFOhSvLfhoXfjQFiQAGmI5kg1fh ip2rXH5dOtjWESF9Z8A+xvyBu6sGdUETpHpTFL/RLAjZxhKnNnV1rHEBPkjLW9FarwC0Ze0 osAGfGPjkmHPW9a1oYsUlqincWHaoSL/qs08z8FTFDdagrN/C2fa6cV0isCPITize/5JRNo eZDIIeoUSt35+5MvL+X9A== X-UI-Out-Filterresults: notjunk:1;V03:K0:/2BlOD/8RX0=:fiowDzPcbOKbIEeEYSVbNC eh66wg1Kpbpw92XQUGaHM3ByigAp7IPE3QCbPvLikJNZvrhbS6wbHcV/4MCVJYMix3/sHhgRl g/3KMh+gsf+c5H00Mv+VDuY07cE8eOxHIFR4p/Um3RyHZdvcdNy0aYsIuBhUthDuHNES3K/C2 CXCfD3SO2Ogy6OOyYAb8nMUGltp3BBeCZwBNASeIfC4EQwoN6beb6FBOxpqGC4Vvk2TDV6Q4d XoSEA6AG1sPASRGw7K1dBmJsL7rNfy/UdaU2GBqullNepBA1rDkvZHqcz4w1HToD09HIha9Qe WtPrz3uRVZx1SHX8wA8ty69qM3nnSyX5Mo/uOGBRRcqkCM2x1Jw59g8BnolZvkLeKo/u9++92 mFhiK6PPc7viYnAvx7pE/LsFtkZuqUCdsLFwpNt9zJfkwvv4UAZHcN2wG0DcaSivUxX+xRuXo WFSDtf7o6nnO5TqgZ51zxGRUqvuAqvUvc3ZHarJoCmO5j0FIJoIaklUQC2JhWFxjwKDQYGui7 QruQXVbgeFoGitL76NimV0q2DQ1Knza+8jnvRQEhF2V3FxZq0AwPAzbnhv3QDKQs+0uD88ZsA k8Y3v0l/KZyRufkvYuW4IEvAvrjHPxI40v2uFuTwrrDY8G4Xa2H6aG/h+kInt6u69co1bympg AkUTvsMbW9EVyX+7yOKDBXYUYs6UFQe6prIx/TM6NPNvBAHsKDlgj1acopL2dT2dkIbGEy3QA E4j6TFcESqoJ/629RkhsLa7ZzLlEE/7Am2hfv64/AdI/u04WXzkSxLz2AdCNHD2QGO1MI6ip5 k4d63rreD73W2SececyC6/MWysHgbRsdyV/SOmibp4hlif4qZdIBIzI0kq7bIyWzCwovQ7m Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=212.227.126.133; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/10 09:10:17 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Raphael Norwitz , qemu-trivial@nongnu.org, Michael Tokarev , Laurent Vivier , Raphael Norwitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" From: Raphael Norwitz The =E2=80=98enable=E2=80=99 parameter to the vhost_migration_log() functio= n is given as an int, but "true"/"false" values are passed in wherever it is invoked. Inside the function itself it is only ever compared with bool values. Therefore the parameter value itself should be changed to bool. Signed-off-by: Raphael Norwitz Reviewed-by: Eric Blake Message-Id: Signed-off-by: Laurent Vivier --- hw/virtio/vhost.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c index aff98a0ede56..aa06a3691919 100644 --- a/hw/virtio/vhost.c +++ b/hw/virtio/vhost.c @@ -809,12 +809,12 @@ err_features: return r; } =20 -static int vhost_migration_log(MemoryListener *listener, int enable) +static int vhost_migration_log(MemoryListener *listener, bool enable) { struct vhost_dev *dev =3D container_of(listener, struct vhost_dev, memory_listener); int r; - if (!!enable =3D=3D dev->log_enabled) { + if (enable =3D=3D dev->log_enabled) { return 0; } if (!dev->started) { --=20 2.26.2 From nobody Mon May 13 04:47:45 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1591794768; cv=none; d=zohomail.com; s=zohoarc; b=R0NQCUlXEmqS9IXgPBKWOF0F/hadLLyIRPCBYH9kWsV0hScy3w9d1qj1HwGVRAeHct9nJaHupOeVb+OEbONchsFfZaB422RtYasKXDgGKl1lkC615pIL5dfWcYzC0laCN8stOejYbYpNGl6NWOEgdsFlbaWcxsfiWzWxxfO/QMc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1591794768; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=pNizcwpz0/G1r/GNiT81/gVsnjzaF5a+lbJyejsuY8M=; b=aTlGa/doVuRaRuk3f9+6JOayHOt2S9zgkmrW4q4DQ+ggaCCiBZ21cONHTu4bm5hdac8cPvtrHFIEnLysqZQEzV0ClzHe2RYB8//a2Z/yLZ9xSH8Dtx+lCy9y/ywaBRzA3g+9W4VVanidkTaOZCdy9RfijX0EqSuL7gyJVU6gWtY= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1591794768375439.707972919127; Wed, 10 Jun 2020 06:12:48 -0700 (PDT) Received: from localhost ([::1]:37770 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jj0X9-0002Fw-0S for importer@patchew.org; Wed, 10 Jun 2020 09:12:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45126) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jj0Up-0007iM-8b; Wed, 10 Jun 2020 09:10:23 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:33379) by eggs.gnu.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jj0Un-0003a7-V6; Wed, 10 Jun 2020 09:10:22 -0400 Received: from localhost.localdomain ([82.252.135.106]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1N8GIa-1incZS2u0W-014Dwg; Wed, 10 Jun 2020 15:10:14 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL v2 02/16] net: Do not include a newline in the id of -nic devices Date: Wed, 10 Jun 2020 15:09:57 +0200 Message-Id: <20200610131011.1941209-3-laurent@vivier.eu> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200610131011.1941209-1-laurent@vivier.eu> References: <20200610131011.1941209-1-laurent@vivier.eu> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:zW5agQm9+hnRkugX9dRv6OmtIMNVTi/qL7EpK+RoYDoTmod2A5g lV3oXzwahxJw72SWY7LHB/N2bOdU23umLr+LEvpi11y/3ONei4iWPMrl3z5CERtEQWU+CDt HXJBHVX1OKt3aXCWkDqGTUrP0MnnwkkhW+Oy6GvCTmC3hWStuH1nqFJZQqQCsbQhATAewh/ fKibQv8rovx2XdwjtMGCQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:5J5hcVjLmQQ=:zmL8+vTkzeBwOhQPCqsUl2 U2yAmhYHA3+LS5TeyXRziGo8+dAigCZtBLBwkOmUVAoRTZVl/edkJPn3GGPKFlBpIsICDvS4C 1RMi3aRmomf8nZ1sh4wI1ybW8aM+ovj23SENpt1uFIj6lwmOhlc7DHm3Y6ogjQuDWY78kO74/ QqUzYGQpKc+fljJxU4023vA8F6om9bcPB9drenatls5sa2p+O8yNEpaT5VqdBAx1ORR6cdtUh a5pkdbhDzpY19GuviVOFw6rni1dxUAbvXduivOKQVfBBqRPArxSqNTR8yNJ0qzAEVwgvh2t1/ u7Jr2U1HNak4DO0SDUePMcR2NX8ktKiqEHRt6jo0KUpWZwUEITme4tV8ixWYQtu6n71gp93RC Cnb6PO32SZu6+bm5MAFvh6eQUEIK+gxsOgpQg0yTBzWkpBufdTZ9LufKMtrsz1/a26tsHhcgP t4k2ZEmgpHIg0iDIJflypnL+wZpYiBs3jeJ3YNywgsuGd1D7X7k4VPFiTVodPTkjqhzDKEtDx 1KIvXPqyrbQCAb9zxJbqN1uB0wMdulfhal2gGjqswQjTsZR8KrKpU8kkEpqwqv+V+5/dC2TSH V7JR7skh+gKr4z9FLH/GdGSu+bXmWlaeRQxePacp9omTauw99xurwrjUtOMLycii4vZ1uYQFy PyloLiwAqLb0rcChZLniuEfNqgWgYhtOb+QKzvrO7IIfHx/jD6Bs46OCvRJ4Y+9Pd5WO28w8d MZtMe2nXDxPuoIm9e+U994JEtQdKYa/qXp+U4M6c9h7XmsJBSTzV3pdspCFrBQLrJHsZR83lN 6wtARNCmuPe21+MRzTraG0Oy9nlEsjwmcHS/7F77YgJhCLy6Hk= Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=212.227.126.130; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/10 09:10:20 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Thomas Huth , Michael Tokarev , Laurent Vivier Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" From: Thomas Huth The '\n' sneaked in by accident here, an "id" string should really not contain a newline character at the end. Fixes: 78cd6f7bf6b ('net: Add a new convenience option "--nic" ...') Signed-off-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20200518074352.23125-1-thuth@redhat.com> Signed-off-by: Laurent Vivier --- net/net.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/net.c b/net/net.c index 38778e831da2..cbeeeadff8f8 100644 --- a/net/net.c +++ b/net/net.c @@ -1506,7 +1506,7 @@ static int net_param_nic(void *dummy, QemuOpts *opts,= Error **errp) /* Create an ID if the user did not specify one */ nd_id =3D g_strdup(qemu_opts_id(opts)); if (!nd_id) { - nd_id =3D g_strdup_printf("__org.qemu.nic%i\n", idx); + nd_id =3D g_strdup_printf("__org.qemu.nic%i", idx); qemu_opts_set_id(opts, nd_id); } =20 --=20 2.26.2 From nobody Mon May 13 04:47:45 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1591794853; cv=none; d=zohomail.com; s=zohoarc; b=VUVuLeU6GH5cScS1DTivvypPzEY9bqnLr1Z4IEoHdPGiKwKB4jwtnKjh00pYNMvdn7qQj/r3afuYQf2PQgT8vPnIah51w7C5nvxB2x2abqy24TTkewzj5+ZiN8LiiMSVFW9DY/EdtBM2LOl9OYotTyKskuPFLl2drbipmWoCTv8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1591794853; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=b2/g1BDQ1lwU+6kaPeGVK8UfbM5TkK2sjCGdXXk85u8=; b=W/KGD57RsBGTDNefvyVpteHUQFzol9Xku4SGJvhimCpGRaWWg3wqXkWFP2D9/VLzrA2AuP0TpO04cnWlHWilnA7FeQ3CBvUH7ia7zAcHCINiuAeGTAAc9ZKlHdP3JycF3BHbnVopXCd0OiCZbQqmksRgYRWq9GrrAAugr7GWpVc= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1591794853172499.6577006043889; Wed, 10 Jun 2020 06:14:13 -0700 (PDT) Received: from localhost ([::1]:43590 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jj0YV-0004mW-PG for importer@patchew.org; Wed, 10 Jun 2020 09:14:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45114) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jj0Um-0007fp-HN; Wed, 10 Jun 2020 09:10:20 -0400 Received: from mout.kundenserver.de ([212.227.126.133]:41555) by eggs.gnu.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jj0Ul-0003YD-F5; Wed, 10 Jun 2020 09:10:20 -0400 Received: from localhost.localdomain ([82.252.135.106]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MhDEo-1jEbLx1VsA-00eLLE; Wed, 10 Jun 2020 15:10:15 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL v2 03/16] .mailmap: Update Fred Konrad email address Date: Wed, 10 Jun 2020 15:09:58 +0200 Message-Id: <20200610131011.1941209-4-laurent@vivier.eu> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200610131011.1941209-1-laurent@vivier.eu> References: <20200610131011.1941209-1-laurent@vivier.eu> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:aTIGPe841mZtN90PlWEZkR07pjm50oT/zey3EVHP5vYBhRPOEsU B5Jb7F6qliljDSDhaaCXMBUcZMiMDjdmqHa2seQrEe5eBJ6y2yAmz51c8cmx/+61ENbptGb t7AIgQRU97Fc8bWiJhqMcyufBWMFDgznqLNMweB76I2z3ONTynrNNu+TyWDsfKkmL9mGQ0Y bLEg1pJDUbvuDyFSptfng== X-UI-Out-Filterresults: notjunk:1;V03:K0:GqaU1epEMdM=:W4SbNrzNS8DoGB5kvXPcy1 M/Kx5eQNcOaGLj4AlaLj+xJtxTOB1H2OIfhuzMrf6dakWPjNvhpjs9p1D7Y6/FyRV2Ju/B570 PAqjpY56TyL/ksscj9E2Ynfig4K2zUx/fVqB+Rj6HPM2rAlyJztMlZWOtH8jUgJPk0uXoUliW JoXG72+aeh1vjUz8Gln//gQr1piZx3dM5uQAJ0Io9SNN5Geax9+5JlHt6NFMUd73HjhmsYtAd KwAbrUnUKLLmqfiqgh2frlXYCmhZpNDAPFuf0xl5xGApZOB2Hfl41cfK+Cchl9oG3icmrQ2dU oUBe0cJpdcjeOoUi6DAyJOLYLzeG4blKYTxh1Nav9sspN96Kb8pGzzDeaJ3y77qH8rlSmBMA3 BL5MPVAJSq8fCvBI6HBZd2hrYXuFPJxh+gft7xSUzJl534890pLsUuCAnmMLAuFiDXNPEkx7/ TJG0M0sql4qCdtD27xEFudtAVn66SlXeQ0U/sNu9CMMYNN+uqcufJr/bfO79daoKEqHSz+Mf9 dqApPYdwRklI4ZeE0pKBlbZvXNrDmDmAhqERiDSTAKSwgXiBgDcuGCaXShvp8ghiR3xtnMj7v j6QYLkRgZs60hZBisrlVQ2F99MdBa2WqZdHXt1ZPvevJwL9qjzUGlVs7pCDfK20g615yycnY4 +c96n4Cua451/DfgRutEdvKZg1BkTUnPpxyDdpTE+MVLEF7AqAwKxd06ncpIhbjurnBQvD3xM RXdIyhsi/n3ugI0kKZNu7NCeGK6VK2sTJ19URvDFAU5jaiLAYJqcva/mxB1xyZA9RHqrUG7fZ //Fx0dQWRFyaPAuD1E4T6c7XKsPxDzWUkxhfeJVu0LqVdbb9l9TS0W0pP+3hvhxnBTGFcSn Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=212.227.126.133; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/10 09:10:17 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, KONRAD Frederic , Michael Tokarev , Laurent Vivier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" From: Philippe Mathieu-Daud=C3=A9 Update Fred Konrad email address to avoid emails bouncing. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: KONRAD Frederic Message-Id: <20200518103920.10699-1-f4bug@amsat.org> Signed-off-by: Laurent Vivier --- .mailmap | 1 + 1 file changed, 1 insertion(+) diff --git a/.mailmap b/.mailmap index e3628c7a6613..d6bd1b2fec02 100644 --- a/.mailmap +++ b/.mailmap @@ -45,6 +45,7 @@ Aleksandar Markovic Aleksandar Rikalo Aleksandar Rikalo Anthony Liguori Anthony Liguori +Frederic Konrad James Hogan Leif Lindholm Paul Burton --=20 2.26.2 From nobody Mon May 13 04:47:45 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1591795097; cv=none; d=zohomail.com; s=zohoarc; b=FtVSBcsiKq8yRM0abOIjhbHmYGn2Gj4ESDjpzmOqTcGxmKZ0GYyfoOfaLXkcLsfiaC9sUu9A++SY291COjI8am7U9OueDf67PCNeMl3uUV8skwiwQHXnZaho8Enn1Pu3gBrpLrrCBjYfKCGxlI/as9VPYH3j0pH/0NxTcNzCu2A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1591795097; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ecqzgZ8Zzz0CSNp/jJgnavOlhg2l+VFVZF1nn0LmQmQ=; b=FF0Y3wSjMLqs5PmyJgaq74635YzmYKF3bn59no2JiSPqvJWk7BTY55ewG0BnaWFXJZMD2VEZwNg5nvrLl9QXZpTR1rl8k3+QIpEsebQEXt+2O6ylgBh93OOQyx50pIic8HmKQj9R+49tjz5OQ78qoxqIl0s/wAcqbEF/rPyFv6g= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1591795097812104.25316222674633; Wed, 10 Jun 2020 06:18:17 -0700 (PDT) Received: from localhost ([::1]:54006 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jj0cS-0001Dh-1N for importer@patchew.org; Wed, 10 Jun 2020 09:18:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45174) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jj0Us-0007ny-KO; Wed, 10 Jun 2020 09:10:26 -0400 Received: from mout.kundenserver.de ([212.227.126.135]:60589) by eggs.gnu.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jj0Uo-0003aw-CQ; Wed, 10 Jun 2020 09:10:26 -0400 Received: from localhost.localdomain ([82.252.135.106]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1M1HmE-1jlkJp45fe-002ney; Wed, 10 Jun 2020 15:10:16 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL v2 04/16] hw/unicore32/puv3: Use qemu_log_mask(ERROR) instead of debug printf() Date: Wed, 10 Jun 2020 15:09:59 +0200 Message-Id: <20200610131011.1941209-5-laurent@vivier.eu> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200610131011.1941209-1-laurent@vivier.eu> References: <20200610131011.1941209-1-laurent@vivier.eu> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:udKSw+ayb4qkPch96FQ6c6Qp0+yPcNEDmVG1mO6qGqHvNr+A+0a gGlGEAMM0eKPx//uH1NfBlWtO7eoGnErH/jf1ha2tjBSdQ6zcAUfh/Ju69dQoc5ABHMw2vb XZVsWR5KqPG5mp3FdiufXuOBWs4pi77/qsiLCuah8ZgjtkfFKBvoHPxjTXltXvCLcCGcBHs taYTiUmndP0+EO4wfFPGQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:kyXEb8IGuek=:sz3n+Bf06uKaEJai1sf5au RcjCICKWQ6TTgp84BNJwPwg5KJTL/SJeArgYelBoz7M9kgdfrGnKw0/t97jhc4XyUsvWJxHc8 Zi8wbCXfx4tw2R/F51uJ7RM6jtxTDJFi7G1Sm+MBdlMNH6Ccd3gfTpWYciTnM5L9JvezBf/Xr G3dqZWsRplRC9QQIuVbAzOvE06kuD89NZrLI2To6sw/hrTEbJqzd3ohdXTtORfUJFuE+5oNcr 9RobuRrgO89Ubp6If426XJ4TZc2qW1aSV2WyWtgWQAO5Aox8990cbPnbfwfxLNotN6uqB0bca NOPn4dNSRkYIhzXXNNaRHbiwEHv0fd/oUpVsi/cWEum09euglCMN2Ndo09wSvgrwMBPdBZXv+ W/7Vb//Y6h8GEnkYDpEbrx6+XGDGh0MRLTfUOjiE3bE0oFI4dYrDxkg39mSRsi1TcYmffsOdA POyU3vadnyLXHr42BgJ/zfC8VuXWnNv2aiGDmKAUMRa0Lg3Q66JHqzlCuVhLs9H8vW1sVf8US kccjdhOR/982pQ024M9JB8iRVZqRBajSqYpPTLwtJcnU9AEleCTCXx6992u5fY4xX2bDsN4zi 9qXm4/8PqqOQs/dNz7W5s0hFKbCxQBVtrbsxSvssHEixG1SM3O/1MXkRXJgq3neEajUluUF3j ddwMgHLytGD0XBHTX3Szs0JwdUD/TK+Ry/+eQqGRapPEmxbZVgqSA04BAPlNpYREYuCVgYuu7 Kw9RgvtiUT7M9qzQnaTNJ/85hRflRmPc8nDAJYQIZplz6WN1vhEcq+43nSbKueMPABcs6q6AR FD0cfYjHpG3BdLcCxSLVmAYY+u1bGzbV1eXvhOyRCC/uBm7R6w0Ra2Z3U6Lr3tnFslgdHmj Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=212.227.126.135; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/10 08:14:00 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Thomas Huth , Michael Tokarev , Laurent Vivier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" From: Philippe Mathieu-Daud=C3=A9 Replace some debug printf() calls by qemu_log_mask(LOG_GUEST_ERROR). Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Thomas Huth Message-Id: <20200524164503.11944-1-f4bug@amsat.org> Signed-off-by: Laurent Vivier --- hw/dma/puv3_dma.c | 9 +++++++-- hw/gpio/puv3_gpio.c | 15 +++++++++++---- hw/intc/puv3_intc.c | 9 +++++++-- hw/misc/puv3_pm.c | 9 +++++++-- hw/timer/puv3_ost.c | 9 +++++++-- hw/unicore32/puv3.c | 2 -- 6 files changed, 39 insertions(+), 14 deletions(-) diff --git a/hw/dma/puv3_dma.c b/hw/dma/puv3_dma.c index 5488d388a962..7fa979180f3a 100644 --- a/hw/dma/puv3_dma.c +++ b/hw/dma/puv3_dma.c @@ -15,6 +15,7 @@ #undef DEBUG_PUV3 #include "hw/unicore32/puv3.h" #include "qemu/module.h" +#include "qemu/log.h" =20 #define PUV3_DMA_CH_NR (6) #define PUV3_DMA_CH_MASK (0xff) @@ -43,7 +44,9 @@ static uint64_t puv3_dma_read(void *opaque, hwaddr offset, ret =3D s->reg_CFG[PUV3_DMA_CH(offset)]; break; default: - DPRINTF("Bad offset 0x%x\n", offset); + qemu_log_mask(LOG_GUEST_ERROR, + "%s: Bad read offset 0x%"HWADDR_PRIx"\n", + __func__, offset); } DPRINTF("offset 0x%x, value 0x%x\n", offset, ret); =20 @@ -62,7 +65,9 @@ static void puv3_dma_write(void *opaque, hwaddr offset, s->reg_CFG[PUV3_DMA_CH(offset)] =3D value; break; default: - DPRINTF("Bad offset 0x%x\n", offset); + qemu_log_mask(LOG_GUEST_ERROR, + "%s: Bad write offset 0x%"HWADDR_PRIx"\n", + __func__, offset); } DPRINTF("offset 0x%x, value 0x%x\n", offset, value); } diff --git a/hw/gpio/puv3_gpio.c b/hw/gpio/puv3_gpio.c index d19e3425140e..7362b6715f20 100644 --- a/hw/gpio/puv3_gpio.c +++ b/hw/gpio/puv3_gpio.c @@ -15,6 +15,7 @@ #undef DEBUG_PUV3 #include "hw/unicore32/puv3.h" #include "qemu/module.h" +#include "qemu/log.h" =20 #define TYPE_PUV3_GPIO "puv3_gpio" #define PUV3_GPIO(obj) OBJECT_CHECK(PUV3GPIOState, (obj), TYPE_PUV3_GPIO) @@ -47,7 +48,9 @@ static uint64_t puv3_gpio_read(void *opaque, hwaddr offse= t, ret =3D s->reg_GPIR; break; default: - DPRINTF("Bad offset 0x%x\n", offset); + qemu_log_mask(LOG_GUEST_ERROR, + "%s: Bad read offset 0x%"HWADDR_PRIx"\n", + __func__, offset); } DPRINTF("offset 0x%x, value 0x%x\n", offset, ret); =20 @@ -68,14 +71,16 @@ static void puv3_gpio_write(void *opaque, hwaddr offset, if (s->reg_GPDR & value) { s->reg_GPLR |=3D value; } else { - DPRINTF("Write gpio input port error!"); + qemu_log_mask(LOG_GUEST_ERROR, "%s: Write gpio input port\n", + __func__); } break; case 0x0c: if (s->reg_GPDR & value) { s->reg_GPLR &=3D ~value; } else { - DPRINTF("Write gpio input port error!"); + qemu_log_mask(LOG_GUEST_ERROR, "%s: Write gpio input port\n", + __func__); } break; case 0x10: /* GRER */ @@ -86,7 +91,9 @@ static void puv3_gpio_write(void *opaque, hwaddr offset, s->reg_GPIR =3D value; break; default: - DPRINTF("Bad offset 0x%x\n", offset); + qemu_log_mask(LOG_GUEST_ERROR, + "%s: Bad write offset 0x%"HWADDR_PRIx"\n", + __func__, offset); } } =20 diff --git a/hw/intc/puv3_intc.c b/hw/intc/puv3_intc.c index e018955ce8cb..090d4839d103 100644 --- a/hw/intc/puv3_intc.c +++ b/hw/intc/puv3_intc.c @@ -16,6 +16,7 @@ #undef DEBUG_PUV3 #include "hw/unicore32/puv3.h" #include "qemu/module.h" +#include "qemu/log.h" =20 #define TYPE_PUV3_INTC "puv3_intc" #define PUV3_INTC(obj) OBJECT_CHECK(PUV3INTCState, (obj), TYPE_PUV3_INTC) @@ -68,7 +69,9 @@ static uint64_t puv3_intc_read(void *opaque, hwaddr offse= t, ret =3D s->reg_ICPR; /* the same value with ICPR */ break; default: - DPRINTF("Bad offset %x\n", (int)offset); + qemu_log_mask(LOG_GUEST_ERROR, + "%s: Bad read offset 0x%"HWADDR_PRIx"\n", + __func__, offset); } DPRINTF("offset 0x%x, value 0x%x\n", offset, ret); return ret; @@ -88,7 +91,9 @@ static void puv3_intc_write(void *opaque, hwaddr offset, s->reg_ICMR =3D value; break; default: - DPRINTF("Bad offset 0x%x\n", (int)offset); + qemu_log_mask(LOG_GUEST_ERROR, + "%s: Bad write offset 0x%"HWADDR_PRIx"\n", + __func__, offset); return; } puv3_intc_update(s); diff --git a/hw/misc/puv3_pm.c b/hw/misc/puv3_pm.c index c213500d9c3c..8989d363cd0a 100644 --- a/hw/misc/puv3_pm.c +++ b/hw/misc/puv3_pm.c @@ -15,6 +15,7 @@ #undef DEBUG_PUV3 #include "hw/unicore32/puv3.h" #include "qemu/module.h" +#include "qemu/log.h" =20 #define TYPE_PUV3_PM "puv3_pm" #define PUV3_PM(obj) OBJECT_CHECK(PUV3PMState, (obj), TYPE_PUV3_PM) @@ -73,7 +74,9 @@ static uint64_t puv3_pm_read(void *opaque, hwaddr offset, ret =3D 0x7; break; default: - DPRINTF("Bad offset 0x%x\n", offset); + qemu_log_mask(LOG_GUEST_ERROR, + "%s: Bad read offset 0x%"HWADDR_PRIx"\n", + __func__, offset); } DPRINTF("offset 0x%x, value 0x%x\n", offset, ret); =20 @@ -105,7 +108,9 @@ static void puv3_pm_write(void *opaque, hwaddr offset, case 0x38: break; default: - DPRINTF("Bad offset 0x%x\n", offset); + qemu_log_mask(LOG_GUEST_ERROR, + "%s: Bad write offset 0x%"HWADDR_PRIx"\n", + __func__, offset); } DPRINTF("offset 0x%x, value 0x%x\n", offset, value); } diff --git a/hw/timer/puv3_ost.c b/hw/timer/puv3_ost.c index 697519593bb5..f76b0bb1cac7 100644 --- a/hw/timer/puv3_ost.c +++ b/hw/timer/puv3_ost.c @@ -14,6 +14,7 @@ #include "hw/irq.h" #include "hw/ptimer.h" #include "qemu/module.h" +#include "qemu/log.h" =20 #undef DEBUG_PUV3 #include "hw/unicore32/puv3.h" @@ -52,7 +53,9 @@ static uint64_t puv3_ost_read(void *opaque, hwaddr offset, ret =3D s->reg_OIER; break; default: - DPRINTF("Bad offset %x\n", (int)offset); + qemu_log_mask(LOG_GUEST_ERROR, + "%s: Bad read offset 0x%"HWADDR_PRIx"\n", + __func__, offset); } DPRINTF("offset 0x%x, value 0x%x\n", offset, ret); return ret; @@ -88,7 +91,9 @@ static void puv3_ost_write(void *opaque, hwaddr offset, s->reg_OIER =3D value; break; default: - DPRINTF("Bad offset %x\n", (int)offset); + qemu_log_mask(LOG_GUEST_ERROR, + "%s: Bad write offset 0x%"HWADDR_PRIx"\n", + __func__, offset); } } =20 diff --git a/hw/unicore32/puv3.c b/hw/unicore32/puv3.c index 7f9c0238fe0f..eacacb4249bd 100644 --- a/hw/unicore32/puv3.c +++ b/hw/unicore32/puv3.c @@ -16,8 +16,6 @@ #include "hw/boards.h" #include "hw/loader.h" #include "sysemu/qtest.h" - -#undef DEBUG_PUV3 #include "hw/unicore32/puv3.h" #include "hw/input/i8042.h" #include "hw/irq.h" --=20 2.26.2 From nobody Mon May 13 04:47:45 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1591794741; cv=none; d=zohomail.com; s=zohoarc; b=VXhWfIASa1oYR9A7viSvmGbhvB2gkE5qc7xuRsn/Hj1Qs7jSnCcH8SS8cKlEapDdDTMs6LTf52jjAS7sqkJjLgv0TFf0uqQMeQd6jtn9mFL6Qoofyr9r2yuRXIrHPPKMG4S59MqpBaetF7U886EGqaAsmKcJlZzTyCN7Cnh4ZiY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1591794741; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ZY+aq6rg6jUppSkTpslERCNL5eG2AhaTfkT9y3bsMRI=; b=MYDP8J5FeFzZP8cIxHzokPudsD/JXLrdvN5n79oD2Fv77cbZOIhyv9z/wj3+93rmx4PwAPDtVanI7Y+1Moq0OuYdx3obyJ43pQfj+UsTnW23p6BltCcyVVViN1NOtYXcuhMudDtNJJZSF6M/jwFkL92awfaRz9ml491JdHpweCw= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1591794741792119.14236206165742; Wed, 10 Jun 2020 06:12:21 -0700 (PDT) Received: from localhost ([::1]:35698 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jj0Wi-0001E3-DP for importer@patchew.org; Wed, 10 Jun 2020 09:12:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45118) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jj0Un-0007gB-9w; Wed, 10 Jun 2020 09:10:21 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:57733) by eggs.gnu.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jj0Um-0003Z9-5j; Wed, 10 Jun 2020 09:10:20 -0400 Received: from localhost.localdomain ([82.252.135.106]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MStKw-1jMPxe2iS6-00UKQO; Wed, 10 Jun 2020 15:10:16 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL v2 05/16] hw/isa/apm: Convert debug printf()s to trace events Date: Wed, 10 Jun 2020 15:10:00 +0200 Message-Id: <20200610131011.1941209-6-laurent@vivier.eu> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200610131011.1941209-1-laurent@vivier.eu> References: <20200610131011.1941209-1-laurent@vivier.eu> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:BSGPFsbMSrJJdCEnLODi1H19zLMsYGbOkyF+y1Wm295AfJR35Be 8kS5Sux21+dUpwv6a1tCd5NHcMC3p3feZa/Z+4MMy63sLS/GQ5upeM/gRn9DI2pndz2J3vk 3A9iPIFjjG7dlTHAwlJEQ60DyczrD5XE+MKziiZ7drp0uDEN5RLf9OleO6R2NhlLzzpHs+D W6fgnlV4yELsSgaRG8Ghg== X-UI-Out-Filterresults: notjunk:1;V03:K0:lIGKMcqLdaw=:FlYsc7R6ktKHedypKWSwJQ ApYGKp9QN++nfazBcZ3D3wwwAc9hw5piRUdrJbSirnMq1GF7fY3o8z9MBRUBn7mcY1yXHNdmb VMaTZ9uZF4O7mgGL7fmM9eVFfjxrwb2eUJmJNyYW0y/0PwBWE9XPKOhRDPCEqU1dGQ/8psg7n g+BId/kN02a7lIhfS6wBmsyIiiBeeXmUAfv8QQhZPi87g3kNK9eofIUou26JnN9SyAFAH1FVS uReg/DBP45yqnZidSNl1NyusAJhV6YYUHV888TJ00IH13XF5TGS2sRHlldo/PGNZo365rXMd6 uDLJ3ooi2aoFc/F9glZqClCH8cCL/Te1snP6aBPTwj9EJVv/5sHFaAt0T36OM+Y+lCZj8i9li D0ij1YV9IUqTP7glE1YrkG5XyVib0o/LmlqeVqsJxRHl6L4gH69J90RVSssC/JLnKuXXblXJa a/i4pvY3EmMdI+JDLHb0o1dGZZHP3ocVYH0oK63tmshMWHSGlakgbBeMgFeHhy7i4AokVh+NT 8Km/aVh14X2fEVz4IeeRveTEWRvZn88YWvcqP4grMYy8O72kFn+GGSCHmTNNvGwLhcWo5FCvp dvSjRbmMIaXBof2f5EPVMI/hzfPRMSmWOZNG6aE9kG0rzlkg7m/R91dYo4516XvAyt9wDdcKI ZMHiePHw5R3nKQ1cnCtQo385feDdtXqs6bF6AKaOpbyJOjQDTxFu9bPx/UN3hjqVP+nHZm8Fb OWZ4GBAfqidfq4a/JRYLys64SpxzU+PVtdl5bk23UPLovkfmgKfI/+KvbEUj4UMtqxYsU08cE r07JlIpXdefQkRomKK9KzyX1QRoyZ5th0c92EbtUjWhgVu3CkisUGA2597FsMhetQsgXmHW Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=212.227.126.187; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/10 09:10:15 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Richard Henderson , Michael Tokarev , Laurent Vivier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" From: Philippe Mathieu-Daud=C3=A9 Convert APM_DPRINTF() to trace events and remove ifdef'ry. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Message-Id: <20200524164806.12658-1-f4bug@amsat.org> Signed-off-by: Laurent Vivier --- hw/isa/apm.c | 15 +++++---------- hw/isa/trace-events | 4 ++++ 2 files changed, 9 insertions(+), 10 deletions(-) diff --git a/hw/isa/apm.c b/hw/isa/apm.c index 6300b1ba7ace..bce266b9574c 100644 --- a/hw/isa/apm.c +++ b/hw/isa/apm.c @@ -24,14 +24,8 @@ #include "hw/isa/apm.h" #include "hw/pci/pci.h" #include "migration/vmstate.h" +#include "trace.h" =20 -//#define DEBUG - -#ifdef DEBUG -# define APM_DPRINTF(format, ...) printf(format, ## __VA_ARGS__) -#else -# define APM_DPRINTF(format, ...) do { } while (0) -#endif =20 /* fixed I/O location */ #define APM_STS_IOPORT 0xb3 @@ -41,8 +35,8 @@ static void apm_ioport_writeb(void *opaque, hwaddr addr, = uint64_t val, { APMState *apm =3D opaque; addr &=3D 1; - APM_DPRINTF("apm_ioport_writeb addr=3D0x%" HWADDR_PRIx - " val=3D0x%02" PRIx64 "\n", addr, val); + + trace_apm_io_write(addr, val); if (addr =3D=3D 0) { apm->apmc =3D val; =20 @@ -65,7 +59,8 @@ static uint64_t apm_ioport_readb(void *opaque, hwaddr add= r, unsigned size) } else { val =3D apm->apms; } - APM_DPRINTF("apm_ioport_readb addr=3D0x%" HWADDR_PRIx " val=3D0x%02x\n= ", addr, val); + trace_apm_io_read(addr, val); + return val; } =20 diff --git a/hw/isa/trace-events b/hw/isa/trace-events index 202f8938e7b8..3544c6213c39 100644 --- a/hw/isa/trace-events +++ b/hw/isa/trace-events @@ -9,3 +9,7 @@ superio_create_ide(int id, uint16_t base, unsigned int irq)= "id=3D%d, base 0x%03x, # pc87312.c pc87312_io_read(uint32_t addr, uint32_t val) "read addr=3D0x%x val=3D0x%x" pc87312_io_write(uint32_t addr, uint32_t val) "write addr=3D0x%x val=3D0x%= x" + +# apm.c +apm_io_read(uint8_t addr, uint8_t val) "read addr=3D0x%x val=3D0x%02x" +apm_io_write(uint8_t addr, uint8_t val) "write addr=3D0x%x val=3D0x%02x" --=20 2.26.2 From nobody Mon May 13 04:47:45 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1591795099; cv=none; d=zohomail.com; s=zohoarc; b=PvPnQgPxLIQK6+LawaM/kaqRmR73yoaWJLzUvbfiHKyv4NAHkUrUYlCTc6jaxn+P8VaIunEp1D5+fE/n6kBz8QEUul/1UyvATrr8wbLFmtjF505cLvsIuL+/iaBKPwY+VZK88iS9RdZc06A3km+sKUA4CpOBzHnS4fD98Ti+iAo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1591795099; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=VblrgGK/0RAmwKN4SDTFBh4A0Qcv6Vmz40ef9iuk7aw=; b=kxwRuCYvMBic5iULBFw3ff75x/pIgdmnhknEIhYiCGaA+Kc4fM5vWmQzA5Do4JpKXZAXxJa1QCj3FsB1/vODyxvPDq6RH6x5O0LUh99bxZBhH0eKSfMEHnvZkkAGKrq0aFR1zSyutuVwMl2H06EO3u0FAbbmKIh917z1BaN8Y4Q= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1591795099075892.8536932340546; Wed, 10 Jun 2020 06:18:19 -0700 (PDT) Received: from localhost ([::1]:54166 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jj0cT-0001Io-Om for importer@patchew.org; Wed, 10 Jun 2020 09:18:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45166) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jj0Us-0007mr-1f; Wed, 10 Jun 2020 09:10:26 -0400 Received: from mout.kundenserver.de ([212.227.126.134]:55147) by eggs.gnu.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jj0Uq-0003f8-Sq; Wed, 10 Jun 2020 09:10:25 -0400 Received: from localhost.localdomain ([82.252.135.106]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MCsLo-1jaF3J1PaC-008nvu; Wed, 10 Jun 2020 15:10:17 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL v2 06/16] hw/misc/auxbus: Use qemu_log_mask(UNIMP) instead of debug printf Date: Wed, 10 Jun 2020 15:10:01 +0200 Message-Id: <20200610131011.1941209-7-laurent@vivier.eu> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200610131011.1941209-1-laurent@vivier.eu> References: <20200610131011.1941209-1-laurent@vivier.eu> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:f6tXZMwZDUbgrvEjnrqNSAxGAjaPzbZV3Tk/jRVBuao3Axji1JW iMcdgfLsBJQn0KoAx/EV2dKJIUc2GRqsaO4VDvLDJInZYsMkXlN4ZEfPiNeSSEavMfRP+io BTHcMLFyZjwApHoxVHGBrGX6vsjL8KPLT8uo9FmRPNil6K43vnmtfNVSmxq/E2gtyF0131s 3pZtqv2KCoqAqEeAciDuA== X-UI-Out-Filterresults: notjunk:1;V03:K0:95eZisdeyBY=:83FmCVHX5OnDe1rohRwect 2FTdWFWRbPFFZ9zEdLuVdCTBCNJpsQxZrbK+oiCx/pRjQbQK+YcnqCdiOM62+nXBuQOVzcL8t NZ9B/keYw8nmaqoeI3e/MyBxFoF1x8qsbw2milId6RmT09qasAAZ5B1znMUE1y9vRGmdBgEBA AmwgtqEAvj4pOmIatd6a/Q1B0n2U9BWTqEwOFvb3Y0dDT4Q0aXlVgMJKq0n9P7Op6SycayPtl fNbecJec7WMbrrQoIW7BXrj/EXguHdLF1fZ4HTjZdVyQjJqsdlLKXduJNGWrnAGKQwPuhaj/7 6Q3lVGlZupYS5uKIHFrIM8WeUm6PCK7Ec5AZR5R+u8TEB8do52S1RHk5pqNjwf8agfxErT9P/ KU2uzPj4/vQXjSJDvqzEsRIZwiHt+q4xEHA+DZrmPd3aUGnefgmSS6YfOi5kPo2QU1bTDkytr 1Di95RjFa0Tp5BqIGbInIEdEPiYrrCOOQkb0V+xsZOzBAx4rfBh7FEJTsjz7PjplL7EuwP9yB g6kbfcw3yurhnuQh9M7Z5xeakAxCLB4ThPKu0GLthrwR88jE51Gj0ra3T1RVLkDSARm8DIcxa w9nO9UAwYkY/m3mG5OTZVsJoZjXnLCv3va3KpSywGky0vqLLACwQFAIqfJgrIK1U8GSEEh2De 30oZZTaPdB6zlNzY8dMr8HBZ8WndugaImUtkpQ82QwOCDqs61bbqI5UHXJ/+vQNQVl/Da5Zi2 oznqZX3CicSGA6UaW3GZwmdUYHBNmoEux0Ingq5+d0Zj5+JaHzhUe6YKbfcXmoDTrh/xPuDON FZTKMJfNDff29JOcrmzqy7+brJFXSMTEfapg9tHoLDCYPw8wl24LqIYhpA6xOhoqxZjc7dY Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=212.227.126.134; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/10 09:10:23 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , qemu-trivial@nongnu.org, Michael Tokarev , Richard Henderson , Laurent Vivier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" From: Philippe Mathieu-Daud=C3=A9 Replace a deprecated DPRINTF() call by qemu_log_mask(LOG_UNIMP). Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Reviewed-by: Thomas Huth Message-Id: <20200606070216.30952-1-f4bug@amsat.org> Signed-off-by: Laurent Vivier --- hw/misc/auxbus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/misc/auxbus.c b/hw/misc/auxbus.c index f8e7b9797125..06aabf20c59c 100644 --- a/hw/misc/auxbus.c +++ b/hw/misc/auxbus.c @@ -196,7 +196,7 @@ AUXReply aux_request(AUXBus *bus, AUXCommand cmd, uint3= 2_t address, } break; default: - DPRINTF("Not implemented!\n"); + qemu_log_mask(LOG_UNIMP, "AUX cmd=3D%u not implemented\n", cmd); return AUX_NACK; } =20 --=20 2.26.2 From nobody Mon May 13 04:47:46 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1591795285; cv=none; d=zohomail.com; s=zohoarc; b=U3Z+FFcI/di5AicMoHkrzF3e0am9bvMaQ/1D+eNQkZsU9B5G+0FRoQNDI4+BJGczn00nwkoc9jTD0jyY7Enuo7ufa3qwdq+oce2KdFNnMGNzbZGL2lrjLDtBJRkhC/MyaR7DmrwJKePm+/kilduhaN9S6AaWjSgFRP6CPb3p0Lg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1591795285; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=9AyxJsi/aoo8xJcOt6AAT4nlFYzS1egnzyh+K92OEtI=; b=V5ADoDHCVHnLTGy6xy5Q1reOhDD2RW/3WgMxmBofJtbBTZlfcIhJKME3rwlIoEX53atco/YsYUquxX3CIlKwUkVkJUWHI9Y7NSgyMwfTM+7u8E4HmtZpiAH4FGd9vzseAEiOGMvb7TbW8StMSpkctjXs58tVmo4w4jLfMnmnZ7M= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1591795285264358.5105420292788; Wed, 10 Jun 2020 06:21:25 -0700 (PDT) Received: from localhost ([::1]:36902 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jj0fT-00062V-T0 for importer@patchew.org; Wed, 10 Jun 2020 09:21:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45164) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jj0Ur-0007m9-Mq; Wed, 10 Jun 2020 09:10:25 -0400 Received: from mout.kundenserver.de ([212.227.126.133]:37667) by eggs.gnu.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jj0Up-0003d4-9a; Wed, 10 Jun 2020 09:10:25 -0400 Received: from localhost.localdomain ([82.252.135.106]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1N6KML-1iq5PX05ST-016hql; Wed, 10 Jun 2020 15:10:18 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL v2 07/16] qemu-img: Fix doc typo for 'bitmap' subcommand Date: Wed, 10 Jun 2020 15:10:02 +0200 Message-Id: <20200610131011.1941209-8-laurent@vivier.eu> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200610131011.1941209-1-laurent@vivier.eu> References: <20200610131011.1941209-1-laurent@vivier.eu> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:fK8iv6C1HwdqQhd/VkgelztgmZ7yxCQwoDAv43kmXHdv0sWRPjY RA9JL+I2c0a7jdxDQbdasICULdQk1X8tMYW2Z5oX35UEEqwWRXrkCP9mVE2fR1khinotDux ps0FXEvEvCGoGixiHt9vUJk3E3qRnfjhIHzc3OKHvhBihPP5dPhujaE/4QHlEhNqEAoNmml sYBnb+gHwOci0/goFiP3w== X-UI-Out-Filterresults: notjunk:1;V03:K0:YbtXtnlVb9Q=:zP3khABMS+VslhTTURfDky atM1nzYWYeKVpKdsZpV1tKWIuj31z8an7nfJWQuUOjm3F4iVA8Wi3YH6D9olXG2KsASRKkR5p 2Ql6kVXa/MoQy2M/Q8uo6yw8UpmFz/IVAjKfxA7XxTUd3vIvsamXg1jzncU1+Z1SmGcD6hof3 tFf76ViH1PlFOlCKrV0DuC+Mn++eIuhEfa8LaARRE5PrbB252gQv2oCbYe3zAtgbeGpg/wtAy EJlprAJ8ViCJJ2h8NPRwmw+SiwT6LQ4h4xOGU8/neaG4AfdF+HxjGfd/6H6FmT94+8CaIh63L sih1GKIuO5vp6XDqccI2fFimsCHR8HXK9PB7ChzBB7xed5pLkHVKuaMqxsCxHGI5/DX1ryvmo hRreQB5knWlOIu/fjfmz0kRpmDr/iyjsyks55B88eUbFt87tw4GGEkucKBN5vcYwphc7Q9uRv HYUWzIJ8ajxjkV7zm43HxqAbWDIm3bL4uw2R0XQaFTrUDC2beXeapUzBEOm/69cHKq+5i8Fj0 WcUFamYzoDaelnXawFDMfXNujhsA9lVDyWeITkepseqNMV+F5xqEKSKaqaZpYv9lfni+X7cea 8ZfFYIFV9GCoAWqcaAYaeD7+fHyqaEU8ooGaZ2zpTxM3zX9NctwVoabgX8GLe/kP2kVqySGp1 2FY17rq1amQCkw5ZAwWEy9xhy4F8ic7mfDL+QGMRk3qEKIRmySVoIfDsv4Qzz+aGpQB5qmkfK qbw73A7WU4uRShNvHUarNP29xPqzR3wFtapLWzN1EhgdbXPc1/eek5GMXxNxwNulu8rqRwbV8 Wfwh9iqZeCKCr93loMqvegER/O7ZQfdVZy7OrI+WIbcZFXzPceNh8YwhvDZ6HfNByQRD5+T Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=212.227.126.133; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/10 09:10:17 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Vladimir Sementsov-Ogievskiy , Michael Tokarev , Laurent Vivier Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" From: Eric Blake Prefer a consistent naming for the --merge argument. Fixes: 3b51ab4bf Signed-off-by: Eric Blake Reviewed-by: Vladimir Sementsov-Ogievskiy Message-Id: <20200529144527.1943527-1-eblake@redhat.com> Signed-off-by: Laurent Vivier --- docs/tools/qemu-img.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/tools/qemu-img.rst b/docs/tools/qemu-img.rst index 69cd9a30373a..7f0737488ade 100644 --- a/docs/tools/qemu-img.rst +++ b/docs/tools/qemu-img.rst @@ -300,7 +300,7 @@ Command description: =20 ``--disable`` to change *BITMAP* to stop recording future edits. =20 - ``--merge`` to merge the contents of *SOURCE_BITMAP* into *BITMAP*. + ``--merge`` to merge the contents of the *SOURCE* bitmap into *BITMAP*. =20 Additional options include ``-g`` which sets a non-default *GRANULARITY* for ``--add``, and ``-b`` and ``-F`` which select an --=20 2.26.2 From nobody Mon May 13 04:47:46 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1591794883; cv=none; d=zohomail.com; s=zohoarc; b=RrtGp5RUFRKFa6dAz+1Ii9zscjEGZ1pGIAHYfuAlBsujE9t0QaJYjLVXJeDbLRyTKMBg1TZyjC1Ji4GPSSxTFhsiPUTJGhrttiviDyJbiIdlAmuL2dQoo1/DCfD3HD2pcxqe8PY1AkBTsQ4s6hWofV+As8ewQPvghYrUZVDmQyY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1591794883; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=7/5FOHJrcOEtUFUqAzxGJmO0KXZPHnY9SCFP7gteuCk=; b=L2pqYt4v7tjFndWwJ+ggwvCyaAL95gAukAaFEPZyG7h1jKkiyIt6FavBhzBeuHOPgew77r9EelclSHZ/gBHHAx+ivR0xr3LlJ/jCowGQ8dMHHNNjnN4seDGuIKsJTkDtn9MWNOflVl5DRaOUfS3ryk8wZyXaUWH4YtvZQDpxggM= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1591794882996293.18276750995153; Wed, 10 Jun 2020 06:14:42 -0700 (PDT) Received: from localhost ([::1]:45970 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jj0Yz-0005tG-MC for importer@patchew.org; Wed, 10 Jun 2020 09:14:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45146) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jj0Uq-0007kG-Dh; Wed, 10 Jun 2020 09:10:24 -0400 Received: from mout.kundenserver.de ([212.227.126.133]:56225) by eggs.gnu.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jj0Up-0003cP-3r; Wed, 10 Jun 2020 09:10:23 -0400 Received: from localhost.localdomain ([82.252.135.106]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MEmAV-1jhdZJ3B8t-00GFv7; Wed, 10 Jun 2020 15:10:18 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL v2 08/16] hw/arm/aspeed: Correct DRAM container region size Date: Wed, 10 Jun 2020 15:10:03 +0200 Message-Id: <20200610131011.1941209-9-laurent@vivier.eu> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200610131011.1941209-1-laurent@vivier.eu> References: <20200610131011.1941209-1-laurent@vivier.eu> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:aoyblYvsxNs/VaIf9aNl95oG04olgSvD6l6khwnqzdMTlTYHqgl UEjXCX7l3XJ8HnTryfuiHK4bEvKYLzVnym1o4R3pnSYwxikSQ1ZcsLub42RkWfNCbPVzjw5 WuzMReXW+1b3qZVeCQAIemzMZDJsrNWVfV6TznKkdYh41E+3Fw92dFf/AtewYlXtDqBriCr 3Iha14j7AFGtkpaePrgnQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:ga1Vdo8ob8c=:yfGYd7nSifPd9m5FG0rh8R ZvbTK/rLHlBMX6QP+IvJ6BInveyYoGgz2IFmBjkghgXu6sL0dUa5jpSLpVT1c4Nedf74goC6C u6WSnY9ia2KDStyJrGX8N7bMa8vJjQJqgKxlLlPji8PgrmCESYrqk9Sk7El4KMX+1vCDaz7lE VrHTFS/u6ROjH0MTmR7+ixIaJZmKhSaQiojBpTf1to9CQuKC0CfvPTnrhZf8QWcERtVuRl6UN 9kwg7mt3W50uiEcrdm+unUtcnsqXFdYgGTDawul7kaRrbr50BzDcWAUUw63rWBzBXL3MGZRp5 5CM5xdhggoMtRacCcOQOsxAnR6i/oE1dfiZD31yXbjTpSfvvoNGflaWME4N+EZQ+yjop78gZ7 FB/SFVFT6fsjddZyYNMmB84cU9N7JQCblbWjNPR1xp58pwegXdwCSsHXF3rtLGnowlis5dyzS wGvlOFrdLCvn/s6cTc9c/d9RV/VNCUt/f6Wn8NOiAGn9yg0uns8moHZj6bUto/8bSMPhzuAh4 le8UeDZEt1vKnrNYHvXNgmpeO2zS3VYOC+AOCnv9RA0hrnQHDkezVfJgfWfJqMIeaDnbBtXoO 58xxAOytoNK6WAyncz0wB/QQ/Ba0w4z1Nmk93/ma9DnzWCTMYvR/hoWbF9NGGCsvzoFN/sDwf 7T/c/vU3k1avy9tMBBfXZBv42QQZVQHOhoPQAqENHFr7T+TBdMqKpb+RzxeVMk0gU4D9LzqbH PdME4exr7IFscO78Ywit/QdbPo24BVfXsxJLyPuHGWKmGaG7uo9353h6UmRvagZrhqeJnHwte VNdzCODUyXRGfXFpgnEihUgdEyI9u7zBe+/wDMggHVkLmucYYjWVsyIcQoNZS+0+EyS2rZ6 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=212.227.126.133; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/10 09:10:17 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , qemu-trivial@nongnu.org, Richard Henderson , Michael Tokarev , Laurent Vivier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" From: Philippe Mathieu-Daud=C3=A9 memory_region_set_size() handle the 16 Exabytes limit by special-casing the UINT64_MAX value. This is not a problem for the 32-bit maximum, 4 GiB. By using the UINT32_MAX value, the aspeed-ram-container MemoryRegion ends up missing 1 byte: $ qemu-system-arm -M ast2600-evb -S -monitor stdio (qemu) info mtree address-space: aspeed.fmc-ast2600-dma-dram 0000000080000000-000000017ffffffe (prio 0, i/o): aspeed-ram-container 0000000080000000-00000000bfffffff (prio 0, ram): ram 00000000c0000000-ffffffffffffffff (prio 0, i/o): max_ram Fix by using the correct value. We now have: address-space: aspeed.fmc-ast2600-dma-dram 0000000080000000-000000017fffffff (prio 0, i/o): aspeed-ram-container 0000000080000000-00000000bfffffff (prio 0, ram): ram 00000000c0000000-ffffffffffffffff (prio 0, i/o): max_ram Reviewed-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: C=C3=A9dric Le Goater Reviewed-by: Richard Henderson Message-Id: <20200601142930.29408-2-f4bug@amsat.org> Signed-off-by: Laurent Vivier --- hw/arm/aspeed.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c index 2c23297edf07..62344ac6a3a2 100644 --- a/hw/arm/aspeed.c +++ b/hw/arm/aspeed.c @@ -262,7 +262,7 @@ static void aspeed_machine_init(MachineState *machine) bmc =3D g_new0(AspeedBoardState, 1); =20 memory_region_init(&bmc->ram_container, NULL, "aspeed-ram-container", - UINT32_MAX); + 4 * GiB); memory_region_add_subregion(&bmc->ram_container, 0, machine->ram); =20 object_initialize_child(OBJECT(machine), "soc", &bmc->soc, --=20 2.26.2 From nobody Mon May 13 04:47:46 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1591794859; cv=none; d=zohomail.com; s=zohoarc; b=mK1gCTpedHhLvJevm7efh10/+EUN8yE145lh/kXx9orjHrb5gYnf2LTfe8p1ssiDRwV0YLYQX3NrQCBYl1/5CsQH86JLgNztnkzfa00WRG0v034SYRmT2W7yM3XR9EwdiCuQknPV3boFGuOjXqQsX0p4DtGDjMB7/BxSkhEIDdU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1591794859; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=DgCKFdCepGX0Empabf9XT9qTS11Uje1I7PGJ/wQ73Bk=; b=eyi0AmMUAnkX0NLO49y+BAyggaCp7o34jAwL34HwgpamVp+T0PFiaG5njsGaaqVDSn97mBOQ6fvVuqx+06jkfLGyvkTZYJL6HEki/IiydFw2n1+Rp03yphnCBev6ZCvrrLo6VII82Q9RDXuSCeqc22jtuEG4E40Tl7LFSrERXKs= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1591794859018725.426985027969; Wed, 10 Jun 2020 06:14:19 -0700 (PDT) Received: from localhost ([::1]:44162 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jj0Yb-000531-K3 for importer@patchew.org; Wed, 10 Jun 2020 09:14:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45156) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jj0Ur-0007lP-9U; Wed, 10 Jun 2020 09:10:25 -0400 Received: from mout.kundenserver.de ([212.227.126.133]:43219) by eggs.gnu.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jj0Up-0003cU-68; Wed, 10 Jun 2020 09:10:24 -0400 Received: from localhost.localdomain ([82.252.135.106]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MZkxj-1jOsnc1wZT-00WoKz; Wed, 10 Jun 2020 15:10:19 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL v2 09/16] hw/hppa/dino: Use the IEC binary prefix definitions Date: Wed, 10 Jun 2020 15:10:04 +0200 Message-Id: <20200610131011.1941209-10-laurent@vivier.eu> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200610131011.1941209-1-laurent@vivier.eu> References: <20200610131011.1941209-1-laurent@vivier.eu> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:ZJcuuVvZMn4vd9WaxvKpzIGlpcH+8rkPeaVxzY+wL56wQ5SnrCV 8nsiZ9XpxJWmulsBA6wbojcB0wLerOd2JYBRjvBsolUqcExn5b+u+rGKTG2ut+84W4vqARR wvrMVnIj8D4x+VvmdgCqkklPQ0GlVC5dKAQzkgFWJjAjG1vM4HXRY+o4+Ns9ikDrzttMjTa RVpKQ1+vcYat/GTfClYeA== X-UI-Out-Filterresults: notjunk:1;V03:K0:JS5sxbSkzn4=:hw/NgN8XCkcbu9zBQ39147 Of+PRjGZZRJju14sMc59M8qd91EtnE8n9o+asBzRl+/VoM849ivnQk79V3OQ4Uvn0928rOYqc S8pi15XRpu30aZEQMLePw2niARh8zUoe3jZH+dSIJm/W/eurwXP0gwQIyiBYubl6w01ngRr8B Eq2jYHTHaaXaKumC4t9qO1kfH5nRFTZ4nWw92rxBfk96uKE3UmfaQsGS2iPLCaRbJSELV5o8M 5kAJ//Xwv6vnK8Ip242X4jxJgBBw4dLhU+a4hLfUyvYPNRwrUehcKijKERXkmk5x/X4/qeAvf O/gdCIOOJsrlF2sqImje+lfbP/Hjl31J7QgXqmfX3JEKKrPlL+L/9LUebKdvynTwK7WalKQ5l Em1QQNzvSZOFNptCjpU6h0btgnnShTQlxjMKpfmYrG+dwD4K3s2JdZL+huCLCF9fWoGiEl+gq v8GQiM/UY5kxp/uMtzlsfarFM+ijvJ1/vYhM3kgjJ5x9NZjvYlgG95pUW9XXDGyjOhh7XQU8p oyjZiQZeFQ8CKjINl/P/JD4syFlr8qFhxpmEJVKJ9EXkkFNVH22t5bfuUxmAcL6gso9gr5dDb 4zC0a68Mh+u+sFx9UNt2GIiFLqObRjeeXoHaltqW4hDfspb+EuZ+6xjqlpbbg7nSd3+QGrMCI AE1BMKtVQ8TiUAL8Fj+xhhb1Vvfuya9gS4JSRRSO8Cb/ZCXNi84QAMwZzq9RL1zxQUnBjltIm Ud8QtgLJxcDs3SRaqOj8+hzcQ2llifdQiQzQkdk1WriYHvziLR1dvifPKIJBFyrrcRlwU7OMH E7SYUM+Mf6CZJ6rJezubFhaSWHXU2maZSw4IugAGKlRjeVtjkUFEh3qY7ZDEyhIoq5VeMkQ Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=212.227.126.133; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/10 09:10:17 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , qemu-trivial@nongnu.org, Michael Tokarev , Richard Henderson , Laurent Vivier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" From: Philippe Mathieu-Daud=C3=A9 IEC binary prefixes ease code review: the unit is explicit. Reviewed-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Message-Id: <20200601142930.29408-7-f4bug@amsat.org> Signed-off-by: Laurent Vivier --- hw/hppa/dino.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/hppa/dino.c b/hw/hppa/dino.c index 2b1b38c58abc..7290f23962ce 100644 --- a/hw/hppa/dino.c +++ b/hw/hppa/dino.c @@ -542,7 +542,7 @@ PCIBus *dino_init(MemoryRegion *addr_space, &s->parent_obj.data_mem); =20 /* Dino PCI bus memory. */ - memory_region_init(&s->pci_mem, OBJECT(s), "pci-memory", 1ull << 32); + memory_region_init(&s->pci_mem, OBJECT(s), "pci-memory", 4 * GiB); =20 b =3D pci_register_root_bus(dev, "pci", dino_set_irq, dino_pci_map_irq= , s, &s->pci_mem, get_system_io(), @@ -561,7 +561,7 @@ PCIBus *dino_init(MemoryRegion *addr_space, } =20 /* Set up PCI view of memory: Bus master address space. */ - memory_region_init(&s->bm, OBJECT(s), "bm-dino", 1ull << 32); + memory_region_init(&s->bm, OBJECT(s), "bm-dino", 4 * GiB); memory_region_init_alias(&s->bm_ram_alias, OBJECT(s), "bm-system", addr_space, 0, 0xf0000000 + DINO_MEM_CHUNK_SIZE); --=20 2.26.2 From nobody Mon May 13 04:47:46 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1591795290; cv=none; d=zohomail.com; s=zohoarc; b=GgLw/zJAYbJ1wDcKGIBI41niduK21ej7xcaVEhncuBc283a5GtY3BiWF1CMkKYrerXMjv5xO9mdXYPKlNUlokqKMfvfnfFjD9ADRPt+zgaUBPTjQ1u02YlrOSV3NQVKkpLbyx4AYPEh0cW3kGW54nyjnLK+Vw29mmcCprECF8I0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1591795290; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=a5pRbfOCswFYuAVngtDJS1jC4kv2I4MrbYzgfJiY7mY=; b=MFBLJ1+7ubA4bY04buzFyP2fhuex2hJYE99CUlq2BLry2vbn11PhDO4lI55GbubKuWR7KF/jNVssuCEK9zWWmb/SeS6pzSHBjPaGHCGVaY9HTRaAVBJ9Z0XpFlstgyPRJjEbw1yo1WywreGErRtKCdmho9IwAki1grbezSYDCko= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1591795290007696.1854257876582; Wed, 10 Jun 2020 06:21:30 -0700 (PDT) Received: from localhost ([::1]:37154 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jj0fY-00068t-NE for importer@patchew.org; Wed, 10 Jun 2020 09:21:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45218) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jj0Uw-0007vx-Oj; Wed, 10 Jun 2020 09:10:30 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:42261) by eggs.gnu.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jj0Ur-0003gU-W3; Wed, 10 Jun 2020 09:10:30 -0400 Received: from localhost.localdomain ([82.252.135.106]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1M7JvQ-1jqgWe1TJM-007lDC; Wed, 10 Jun 2020 15:10:20 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL v2 10/16] hw/i386/xen/xen-hvm: Use the IEC binary prefix definitions Date: Wed, 10 Jun 2020 15:10:05 +0200 Message-Id: <20200610131011.1941209-11-laurent@vivier.eu> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200610131011.1941209-1-laurent@vivier.eu> References: <20200610131011.1941209-1-laurent@vivier.eu> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:IEDhWYW0eQduXnGN0tnW7BZO0Q+G0Yju7m2j6zdh416rKnGbwdZ ukI6dP2lbLLC8C2M/C8QSJvFq7tWCGMgZyIjPXy1kj7qQ7gfaO1MzjmttTeU9kEv7jvWL4C XC26sCiRAGHTdviQMkyxcMliHP1rfLcjH35q2L6EahyBFSyt5wk65t2Zb1ut1t5ZlUyM2M/ z3YJzhlcnHBfpT8MWWbxw== X-UI-Out-Filterresults: notjunk:1;V03:K0:pKpmjdCHzV4=:EJ8YnXEuVca/8RsOmqNtG1 UY/3dZwXsZZA7QBiBcbGAkbhsIYpJrl8U0MtZv5c1+Llnp8zFH40ZLSxIr+IfRKBgNgdhGYau 1RUudGneSMkiLchGB4mOPHOJX8O0agjS1T8X2OqfXKctqGM9BgNFHY6E+nT/uqDuxKwLdVoUx nwJ1WYqGrfLvjRl3BYADsIg9y8YWR5YjPjQ7Fa8V1AzbZHAm1EqL77VZZ1Fg9vs1qL7F9TwYb fiVVZBG90V/qm8TukXrvrNDnZ60TeJMcteOIUW35wV/6lUdkteDHbhgf3H03W/Ie7yES26oGV 7HCmjaFwyWSZ189c3A0HnXFzmDOmAzyVRJb5zCeeMiwtsQVhJgphpisZFkb3MoDHLndvDeEw4 S68HrKzOtPRYUg2QrH9/VVa+T3VfPCKRilsez+OWWtOOuetH6Aq5zNUWGFcFl8G+TiGP3iIp6 K+QkrRKTTYcNIL5KN20Jx3REdne1wrjaWdhUhY8ihT35g1NxRZoDrLLfKacGofp2ReUctSv97 733SQe3a0SY2V/OFYi3gDnlEjkYz1mfsXjZenFplwbIAm1iNyyJgt/1y0LxRO3ne7HQAb1oYD W6w8ry7xeQdwaP62WPilt1TN088yTVwWorukIhaqI3mgUHCOZ+ciS1NhxS/dVL9vZXwOZ8qi2 1XmAlTOsLgJXIP77l2ZpezjNt+eKMyn8m2Q+BB37pCtZ5TItq6pd5dcVnOeSCz18ym8V6TYi0 +aBrQveygEV13avz1/olHgoS3cTl0+z4cFpz9D9K8fWegRj3IH3wcAgAT/bKohpx7doaG9HzP J9o1AIHO/3dI6OzJL1m1B9+GyGVOUrgh+PcGh3JPoLEgqOKtyhQ2XSJvQiKF/4hCfXOwUew Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=212.227.126.187; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/10 09:10:15 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Paul Durrant , qemu-trivial@nongnu.org, Richard Henderson , Michael Tokarev , Laurent Vivier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" From: Philippe Mathieu-Daud=C3=A9 IEC binary prefixes ease code review: the unit is explicit. Reviewed-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Paul Durrant Reviewed-by: Richard Henderson Message-Id: <20200601142930.29408-8-f4bug@amsat.org> Signed-off-by: Laurent Vivier --- hw/i386/xen/xen-hvm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/i386/xen/xen-hvm.c b/hw/i386/xen/xen-hvm.c index 82ece6b9e739..94fe5d65e9fd 100644 --- a/hw/i386/xen/xen-hvm.c +++ b/hw/i386/xen/xen-hvm.c @@ -9,6 +9,7 @@ */ =20 #include "qemu/osdep.h" +#include "qemu/units.h" =20 #include "cpu.h" #include "hw/pci/pci.h" @@ -230,7 +231,7 @@ static void xen_ram_init(PCMachineState *pcms, * Xen does not allocate the memory continuously, it keeps a * hole of the size computed above or passed in. */ - block_len =3D (1ULL << 32) + x86ms->above_4g_mem_size; + block_len =3D (4 * GiB) + x86ms->above_4g_mem_size; } memory_region_init_ram(&ram_memory, NULL, "xen.ram", block_len, &error_fatal); --=20 2.26.2 From nobody Mon May 13 04:47:46 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1591795442; cv=none; d=zohomail.com; s=zohoarc; b=kh5hMMLcbq4KRUnLG7lZA9SsoBmqmCjxljYTr0t6d5SRZa78K7inPqI1MEAX4t1ulfIPjtCjFndKwgftpiKlxT9e7W0Fq4jg/pRcHaM65AnK6E7c5omlPi3ckck0hf5O9Ydn+8JxzPHucVNKpdvcqg8rRfcHReyXHyKd07yxj8k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1591795442; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=NNIRwOIZ2aAfHII3ghtwmm4jXyEIC2FaQXsVP7TJgWI=; b=AMmsvvE4J9YFKvQcRFOfki/7dxy/Oj35sjuntBPLUhROWCYxzltxZItWvJbxkLzSqrYT1NzTcI83V8caYfYGJ7ijSE/mjEFGppQxYH1zsDyG3m9lj8dduvXUvEi3gh3gET+MTCw/k0c7ms4GHWuNUgbbAot5fdMP7NhvcQRBK2g= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1591795442399644.6676952750003; Wed, 10 Jun 2020 06:24:02 -0700 (PDT) Received: from localhost ([::1]:46670 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jj0i1-0001nH-5F for importer@patchew.org; Wed, 10 Jun 2020 09:24:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45204) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jj0Uv-0007tu-2H; Wed, 10 Jun 2020 09:10:29 -0400 Received: from mout.kundenserver.de ([212.227.126.134]:43593) by eggs.gnu.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jj0Uq-0003fA-SH; Wed, 10 Jun 2020 09:10:28 -0400 Received: from localhost.localdomain ([82.252.135.106]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MNbtD-1jYjdW08gF-00P9u5; Wed, 10 Jun 2020 15:10:21 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL v2 11/16] target/i386/cpu: Use the IEC binary prefix definitions Date: Wed, 10 Jun 2020 15:10:06 +0200 Message-Id: <20200610131011.1941209-12-laurent@vivier.eu> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200610131011.1941209-1-laurent@vivier.eu> References: <20200610131011.1941209-1-laurent@vivier.eu> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:e6pNGKrZWZ3XWvCcug3ufm/XcEAN3JxTE4YulSlBdjBGInHKD7P 8RG2mFa7x7rkNi32v3TUmQwZQAh8kuBq0LTxlOSZU+D7BqYUg72Q2/Q15glmrQgkRvsu20B 8SNFU/QjZALKw32gkVISRkLI+fUEkRPTF5EEiKxG3F8YfMKaIROARMYRYYT8MuBZDfKNv7r W/SihU0Jfqb9WtAx4jVDw== X-UI-Out-Filterresults: notjunk:1;V03:K0:S5j0pdZnetU=:efiwghLxEfLhyUpTEtenyG os4RZcDi+sKn04oiYBBEY5IfBp4fOGxiN5hOLXl5nIoibKkhZq+BV2BZQTC+iZgknuNH8gkLq wbRfwv16MF7bTFOJ932oj9kwp3prj+q6qG2DDYkoTK7+kzq4U6NmFTcDM0s60tB/huYOlFtGG XD6Ah9ekk8jFvJHeinDyWfCLbmAQsGbbmyssim/yOiw9hj7WHC/zZ5Ow1LXJcZ0LmuVFBDCR3 3/vfLuC7OcgBF5IG1nummaboCPOMpj7t9yiMUADuqWkImS1hRmS9y9fbVTqf8tJ6oB7kyPfBF VqgG34Ew9iv1879ELILblaYMxUg3UDONcH8PK4PwEtF42YGum+d8C90HzbfPIZTXdoMs+n6TM CWJfX4Ecx4UESeY51DdbDmzkw2s0WXntE5X43wvvEfe680/YwoJ5i3J6JUod1DoHzUsQu8TcS wCwHVS4LdijbRfqoDs37EM6ZbGWCNq9Zx0iKMTA/1Z7zIb/LzpZw3ToY4UuauZ4Hw14dNP07V XTUWrm5huYSQV7mklcBB3jYv2EfXhdklbftF145H2sW421KCs8Bk2ors7VRFyZxyxrvTpSirX WGttVNXlXCh/WyfDctM/2LxggNPQxjYzwh0ggajZoLv1pa1R8fvbx4kU/rkTzm9oXzDfI5tlL E9QSptVL+bn/PafWmVgruA1Czo99TUYwhySrglo3089XKplU4dbOYoAS9ziw1hIAq5ARzFL2W ex+eaguJYsvO57OvNwkHrHNOLL8ZpafD8m+o+VZ9LBAkWkXCzFacGhywQmWSGVUOs9GDeOK9w 99+HEOpvOC6h6//Coq5KMwrUJ+cmyPWS6UjCyibIVlF83LcNy92EJGGcuFh2haZT8uJu7EO Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=212.227.126.134; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/10 09:10:23 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , qemu-trivial@nongnu.org, Michael Tokarev , Richard Henderson , Laurent Vivier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" From: Philippe Mathieu-Daud=C3=A9 IEC binary prefixes ease code review: the unit is explicit. Reviewed-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Message-Id: <20200601142930.29408-9-f4bug@amsat.org> Signed-off-by: Laurent Vivier --- target/i386/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index ba05da3f2e7f..02065e35d435 100644 --- a/target/i386/cpu.c +++ b/target/i386/cpu.c @@ -6159,7 +6159,7 @@ static void x86_cpu_machine_done(Notifier *n, void *u= nused) if (smram) { cpu->smram =3D g_new(MemoryRegion, 1); memory_region_init_alias(cpu->smram, OBJECT(cpu), "smram", - smram, 0, 1ull << 32); + smram, 0, 4 * GiB); memory_region_set_enabled(cpu->smram, true); memory_region_add_subregion_overlap(cpu->cpu_as_root, 0, cpu->smra= m, 1); } --=20 2.26.2 From nobody Mon May 13 04:47:46 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1591794756; cv=none; d=zohomail.com; s=zohoarc; b=gvDh+jOVeAatiEaEzK3MBO5BzufngGuCkxoFG7WhHqBndLSEuBdIWXs3QSeyk6Zpct1387VahM0/cKd4Z8EHEafHKq5DiLx+aPTaj6xOLdsdB12kYaqDQ1qFtw+LxESe2m0qzaRuNoTTizCJDFy/p5FBXMMDJMLoCZObr7jMPyI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1591794756; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=eHhQCv9yXfPFdygYZDcGl4Wf4XMY92FwCD7nCvpJQ10=; b=Xb/J/U+L8lc0X1T+V4LM3yw19AuP1dssi0SyPdK0HMgkXJW04zbRM6Yft1I6WVUKP5DbBBhnfIkmMYqoIEi3TdoknhcMNOeLYsvnvn/dvQD5fXW4/Z8mWJunYCHTwbSvgfl38wgMQRMRcRdn/WjcopZWaiai+/dUOHeCfVUgqJg= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1591794756431359.7633003297541; Wed, 10 Jun 2020 06:12:36 -0700 (PDT) Received: from localhost ([::1]:36716 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jj0Ww-0001lk-Eg for importer@patchew.org; Wed, 10 Jun 2020 09:12:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45168) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jj0Us-0007nS-ED; Wed, 10 Jun 2020 09:10:26 -0400 Received: from mout.kundenserver.de ([212.227.126.135]:41229) by eggs.gnu.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jj0Ur-0003fl-53; Wed, 10 Jun 2020 09:10:25 -0400 Received: from localhost.localdomain ([82.252.135.106]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MAORn-1jdFrC2iR1-00Bq4H; Wed, 10 Jun 2020 15:10:21 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL v2 12/16] target/unicore32: Remove unused headers Date: Wed, 10 Jun 2020 15:10:07 +0200 Message-Id: <20200610131011.1941209-13-laurent@vivier.eu> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200610131011.1941209-1-laurent@vivier.eu> References: <20200610131011.1941209-1-laurent@vivier.eu> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:KV/GpuEv2bzha1VAakez780Yu3jaoa0j//7HSGHhHonv2vRVczK sz1U3qYeCvrI0s1eRnk9X9UGWmlWfHZMhgo9e3Nk9UO3NDAMWL+ix2j2apjlrGHVpsnRb6F 9K70HzuymOvaNJyrz1sVOswnnOLzFU/WFoMs5j6DaSMCVhGT8DRtyIMoUBrzKGnem+hUPVF 75gzg2poGKe10xSXiCqwQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:7HBki9U8hgI=:CcuABUDAoiqp8IezzFCLT+ cy8HqOJ2NKfm1y0xebgmfbbFi3oybTtVKNMQqmzyg9+cuMmDqg9Ke2Ob2ouHPtseQBrQTCQ4O 2Yy1LRFU5krjEMGzQbQhC06PsIu67qv1bbWn+GwVwZFpQvXKrCqzwuKpxvjzpswGHDpqA3CfB 0lGrlIklD6rQueQmgHRQySiMkSXrlJn2sZzCE00meJ82HyCoZ7tYNzuOCIQpS4GfWYJATo87y f5W9HPXoSThOJIKZy02+tPXuzB+PZDmk1Kh5DpuOXppCfxtBASCbLe/UK2HvjCkFKY/tbmmtj RZii2BuaQp4KEmQ+/Q8H1YpWka1+9XaAzny26Y5Apjz6xu9GCOx466/C781Urfu8jQB+uLkkF GKQ0fJZcdybyO/Kaw3h649f8A6XikIHxqqcsHQm88d7QuTWN9u1tGP+HQcm2wdXDyEvSDxbOs YcYfsoumTUWK6CxSgemXcukZrFd3WKfBmEyPH4JQtFFBlNkaLJU32E95sjpeJ6ma0g9RTY3fD Bq8mbKJ+YNKovRzOBZkMDd9yluAuwTKqj/6KYdtAvpHS+JwpMdp1VGYevxfcpzpq+XngmrTk/ T5k2Vi+RMztikNl0FIC2hz4vYQLAGJU7jD4AXJlev3xo5vSVwbfmLXYlSl6vVy9S4OJvp9J1O +NG6DSnYEJ7vhmY6sbPJvpplNDJvDOdWoD8WcEykiq27VLh2LRKZX+ek5nL/Kr7MIMm1Jrg6q BvfAO999dmgRLak9sxIPu/HCoBMHOh+3pe7CDyI/AKJBeYNAr5pJQrem6gQRNR0rS3O68a9pw q4utcaYgisNw9T3v1TsGbAmHgQmF6PWr+AEy8gFDSNbn0hay4iWSMjajwWSFtT5z9bZCL2m Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=212.227.126.135; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/10 08:14:00 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Richard Henderson , Michael Tokarev , Laurent Vivier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" From: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Message-Id: <20200603123754.19059-2-f4bug@amsat.org> Signed-off-by: Laurent Vivier --- target/unicore32/helper.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/target/unicore32/helper.c b/target/unicore32/helper.c index 7d538e2144dd..53292ae311c1 100644 --- a/target/unicore32/helper.c +++ b/target/unicore32/helper.c @@ -12,9 +12,7 @@ #include "qemu/osdep.h" #include "cpu.h" #include "exec/exec-all.h" -#include "exec/gdbstub.h" #include "exec/helper-proto.h" -#include "qemu/host-utils.h" #ifndef CONFIG_USER_ONLY #include "ui/console.h" #endif --=20 2.26.2 From nobody Mon May 13 04:47:46 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1591795268; cv=none; d=zohomail.com; s=zohoarc; b=YPdetCS9QT/NFJyCC+oK7tC0m1Agn0u2ixIlK1T4i6gHfVXvsrd9UDbJ1B3isxf3g/tVMU8Z+/DlUyyRLlrq+brJMXqGtQu7eGYP0Glo+loZQBoEnYC/Nzd6j/WRB76tpp0uYQQi+ZGPO4dxqTAw7RwelsX1IqltAL3owu9zxh4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1591795268; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=7WKFcTwnmu5/XBptRiJHgsaoVrEazM8gXU8gF8WuWJc=; b=RGY+sYXR15I7XD0430vTJ+vETShbATTEGFV65mfZC2q9vf6ZtyepRMUXo2IPOEay6juNwFLSt3AHbAj2R/bJSDMIQ2RpkS1S/Vmj7uBfbmVIyj7zp8K4t7ndS7ePUPPrEouGiXQLajmrYCiUxlmra/tPmTtyNHriHNVdc13/n7o= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1591795268774283.4062416276704; Wed, 10 Jun 2020 06:21:08 -0700 (PDT) Received: from localhost ([::1]:35502 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jj0fD-0005Sc-FX for importer@patchew.org; Wed, 10 Jun 2020 09:21:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45180) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jj0Ut-0007ox-5u; Wed, 10 Jun 2020 09:10:27 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:60575) by eggs.gnu.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jj0Ur-0003gG-W3; Wed, 10 Jun 2020 09:10:26 -0400 Received: from localhost.localdomain ([82.252.135.106]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MZkxj-1jOsnZ13xf-00WoKz; Wed, 10 Jun 2020 15:10:22 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL v2 13/16] target/unicore32: Replace DPRINTF() by qemu_log_mask(GUEST_ERROR) Date: Wed, 10 Jun 2020 15:10:08 +0200 Message-Id: <20200610131011.1941209-14-laurent@vivier.eu> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200610131011.1941209-1-laurent@vivier.eu> References: <20200610131011.1941209-1-laurent@vivier.eu> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:9HfJrvfO+i3nrbxBCmnsBWWUGVvBPEiDsT6jc51M9j0dYoRioSV wbheNYm6h88m2fHXRE5tcAeFNXJglFSKVcqc47mJeuXM2x6p9G5ZIY03kTbOE+XbN3SsR0Q +8aTi7oc0qnVaX9TJ4bzJi5Tdo4eJXITW50UwiTkKp9kdQr6DXPbttl8mwZ8RsKVPgg1dSG gMltdRkAEkJm7WDn3ybiQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:R3QjNgjxlbI=:XPfO0DPGtJSmkOpd0xfsXf 1nmYZOqXdEzjXuIHf6X7AOl52UM3GEMgHLmqeuIsJ1aMghV7CgIuKCXR7UBDZ9rh/C8fYzkTn Kd1dRBV/OjUuQUXC6zSlHWMAjvKFnfn1aB/iDU8v8ivG5cI9ugubGn/k5iI8S7CJbspR+OuFM oGjg/fOTsHVqVzAJpNjo6F6k5NVYGsrMIIJI5bDHujU33ePLleYbkgqQDlHNn557qkPcxR5mS 3wTUHLhkFAC6UrfSotgBj5MeX/OJM7081ncRwkedj9dNbcpwctwQyBaeoMPDnYy6wpOzUVEN4 hvZPmLEmoC5GjNSPyxe28uVgfl+hbye6BupYJlEWe+4PGoGCY/d5KN+hWYqySSdewLklhdrVi IFYuP64gZTKxe2NRFLq3gLQRa/iTFoiO7qHMwgvgv9l5p7JV5dMx93vGm/szxqN+4P907KH9O vM5pCk6+AwgB2dE9AchuRhNWWFJZQqDa80DDugnZjGV+VGn7qiqDUJ+s8S4t2IrgOZ7L/Gz/2 0JXuMq6wlajWp89EhyFUcleGqYKS9WrEdsCmYlV08nJKD2E2RVt3bodpqni/so4NyFs8ZjRhx EQ7ZpuXxcPc13R2fhsTREQSCbAxdZO+S0ReXfq3pV1LmMXm1smXFFkDc2MlREpxQGVPXW6nnd kfS/ruErvXURnXg7yQ3E/Rb84I/EzkUqUjN+0+KwKoLp62DvIv/hxQJPwplq+wRRKp/bUpgfW OKtQqNcZTQz3J0RnAH8ovueeTRoYl8/JUCk6VokU47IzErkAUSOglgJ4UJ5ZRqDNwpb1Isa7g 9ZHSP7yTrGsxySz4LMgRfbZGYA18lkvEEPgcb/049Zpqet9wJpDa5RQ6x8C/o+pIVR0JyNy Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=212.227.126.131; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/10 09:10:24 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Richard Henderson , Michael Tokarev , Laurent Vivier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" From: Philippe Mathieu-Daud=C3=A9 Replace disabled DPRINTF() by qemu_log_mask(GUEST_ERROR). Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Message-Id: <20200603123754.19059-3-f4bug@amsat.org> Signed-off-by: Laurent Vivier --- target/unicore32/helper.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/target/unicore32/helper.c b/target/unicore32/helper.c index 53292ae311c1..00371a7da660 100644 --- a/target/unicore32/helper.c +++ b/target/unicore32/helper.c @@ -10,6 +10,7 @@ */ =20 #include "qemu/osdep.h" +#include "qemu/log.h" #include "cpu.h" #include "exec/exec-all.h" #include "exec/helper-proto.h" @@ -106,8 +107,9 @@ void helper_cp0_set(CPUUniCore32State *env, uint32_t va= l, uint32_t creg, } return; unrecognized: - DPRINTF("Wrong register (%d) or wrong operation (%d) in cp0_set!\n", - creg, cop); + qemu_log_mask(LOG_GUEST_ERROR, + "Wrong register (%d) or wrong operation (%d) in cp0_set!= \n", + creg, cop); } =20 uint32_t helper_cp0_get(CPUUniCore32State *env, uint32_t creg, uint32_t co= p) @@ -153,8 +155,9 @@ uint32_t helper_cp0_get(CPUUniCore32State *env, uint32_= t creg, uint32_t cop) } break; } - DPRINTF("Wrong register (%d) or wrong operation (%d) in cp0_set!\n", - creg, cop); + qemu_log_mask(LOG_GUEST_ERROR, + "Wrong register (%d) or wrong operation (%d) in cp0_set!= \n", + creg, cop); return 0; } =20 --=20 2.26.2 From nobody Mon May 13 04:47:46 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1591794890; cv=none; d=zohomail.com; s=zohoarc; b=MIkCFG0yFOGaOkeMAxrzV2GZsNyZYXaKIyvxoiG2mOe2O7pyuYYUDsc8M+Pivt7flFa7TXPNIzfV5CWTmIuMI2OBdIDnk7BpeWiDwoYVA9eVtnDuTlqU0WQnFGm1856Q/ukOeoqeRL91L8tEPkGOhCb/c4kbAlnCqF95zi14KtU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1591794890; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=NV9URI9bB+Peen4XgQPegUhwpSJYhJEFcBqSPgYFqno=; b=hvRvAAOHyE6F73WD4qSdpzUtjgyAYnQ39RvvZ5buFp6m/DM51HGa/v2zkCbLS6pSd1bENLH4W1Jo5RwLN7qnR7qsbuIk2HfpXv4xDJtQ9lh4ioUWwJRTu77p66mmk61SEAzcZJ77jyC9V7phU7qb2/BCjN7Sy8WGP0uivl08+B8= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1591794890570663.4819712262499; Wed, 10 Jun 2020 06:14:50 -0700 (PDT) Received: from localhost ([::1]:46294 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jj0Z7-00062s-4N for importer@patchew.org; Wed, 10 Jun 2020 09:14:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45188) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jj0Ut-0007qf-Qn; Wed, 10 Jun 2020 09:10:27 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:45539) by eggs.gnu.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jj0Us-0003gq-HS; Wed, 10 Jun 2020 09:10:27 -0400 Received: from localhost.localdomain ([82.252.135.106]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MIdW9-1jg0D53fAz-00EahL; Wed, 10 Jun 2020 15:10:23 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL v2 14/16] target/unicore32: Prefer qemu_semihosting_log_out() over curses Date: Wed, 10 Jun 2020 15:10:09 +0200 Message-Id: <20200610131011.1941209-15-laurent@vivier.eu> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200610131011.1941209-1-laurent@vivier.eu> References: <20200610131011.1941209-1-laurent@vivier.eu> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:nujbTLVeKt9LpZQbtZRxvpwXyfbarq8r5Bk1K42Ndq6YN0OacSQ RM56+kdZz5ysrbbSarasKGjY3EURD0bJo4Mz7hLzRHGQWNdyDGCLlx1Ocoa3hcs0OQ+B6n+ GXaSjO4a31/Yz+hUunQI2HM/axggTOjV3spR0vhJMZhCon2SHBQMfWw3oXq6W0tCSYf99WZ maom1MPm1jNzid/hHLUxQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:31TZV5x5tDg=:XrbprX7eZQeHeu4ew2uE2e NiKAqgGKP87b+jo8vIHXujuIXGkAEH6HZkkkdr/4VexALoV8uU9BA0T2eaIpTtQFg+6NbJeQQ ssE+kug7hMqlS/P85p+Y8SYoTKmCuWf7TDzS81qHp8AB2yUVRsLviXUhsQbI4ncGolyRM+iDx FESoMm7n9tw9ylLTCTNUi5cbZ7/HycYTENnVqgrwTdddoPIhaz79Y6jj0tiyNmpjMFUWtotAB Na8azqLuZLq15zd//b5471kN5k9PwXQSPAUI8oNnOE400tQZwKTc/nmp5HyyatrzwaUT/jCNd VwAYB4s2Jd3p/iE0goxtStM794sKKc0hj5APO0TH0ZnhqPObkaf9o5tCnJXXP8xkZo0gcr4k9 8VTGpjWMGJSgHk/YBi3MHfQhXlnpqR46TCcdcXE5GNY3rb2KcM0L9tzv+GLQou7gbd7zHlIDu l/TU6pOjaLqZoFd+hjZ5kjI42h8Ityz0mg4hTTMzzZ0C6Mi5XEe0ZTAiKPad/7q5DKTdIhdgN pePwzIntf3XoDgCbQr+VDhJD3C20e1HkylQ4SYTqD2RArHbG8IwhkbUrjLupmgLKG9LO31pP5 ocl4vMCoCSfNGpidenuZxRPwIiQc1e5R7GByKe8TfhFdHdjyIDPFt7D+D6OP+1G7yxmNHzSrP /0alf45SSeZbnNybSHQSkEsXQ5GN23f3O2+5L/4iEKHIOaIYSf43NQCUg+T6vMn343mTnLw8l fRG2ict5eA8JYdLNIsf4VpvS6CJNaeILE40A4nFyN6+Byv5lpkGQBmJfCXsdn3i6Bgnn/lG0z oB/fciBqwR38r9NsTCv58/6ulBoJKPqVRpHiRofMIg82ubJ06k= Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=212.227.126.130; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/10 09:10:20 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Richard Henderson , Michael Tokarev , Laurent Vivier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" From: Philippe Mathieu-Daud=C3=A9 Use the common API for semihosting logging. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Message-Id: <20200603123754.19059-4-f4bug@amsat.org> Signed-off-by: Laurent Vivier --- default-configs/unicore32-softmmu.mak | 1 + target/unicore32/helper.c | 57 +++------------------------ 2 files changed, 6 insertions(+), 52 deletions(-) diff --git a/default-configs/unicore32-softmmu.mak b/default-configs/unicor= e32-softmmu.mak index 0bfce48c6da7..899288e3d715 100644 --- a/default-configs/unicore32-softmmu.mak +++ b/default-configs/unicore32-softmmu.mak @@ -3,3 +3,4 @@ # Boards: # CONFIG_PUV3=3Dy +CONFIG_SEMIHOSTING=3Dy diff --git a/target/unicore32/helper.c b/target/unicore32/helper.c index 00371a7da660..54c26871feab 100644 --- a/target/unicore32/helper.c +++ b/target/unicore32/helper.c @@ -14,9 +14,7 @@ #include "cpu.h" #include "exec/exec-all.h" #include "exec/helper-proto.h" -#ifndef CONFIG_USER_ONLY -#include "ui/console.h" -#endif +#include "hw/semihosting/console.h" =20 #undef DEBUG_UC32 =20 @@ -161,58 +159,13 @@ uint32_t helper_cp0_get(CPUUniCore32State *env, uint3= 2_t creg, uint32_t cop) return 0; } =20 -#ifdef CONFIG_CURSES - -/* KEY_EVENT is defined in wincon.h and in curses.h. Avoid redefinition. */ -#undef KEY_EVENT -#include -#undef KEY_EVENT - -/* - * FIXME: - * 1. curses windows will be blank when switching back - * 2. backspace is not handled yet - */ -static void putc_on_screen(unsigned char ch) +void helper_cp1_putc(target_ulong regval) { - static WINDOW *localwin; - static int init; - - if (!init) { - /* Assume 80 * 30 screen to minimize the implementation */ - localwin =3D newwin(30, 80, 0, 0); - scrollok(localwin, TRUE); - init =3D TRUE; - } + const char c =3D regval; =20 - if (isprint(ch)) { - wprintw(localwin, "%c", ch); - } else { - switch (ch) { - case '\n': - wprintw(localwin, "%c", ch); - break; - case '\r': - /* If '\r' is put before '\n', the curses window will destroy = the - * last print line. And meanwhile, '\n' implifies '\r' inside.= */ - break; - default: /* Not handled, so just print it hex code */ - wprintw(localwin, "-- 0x%x --", ch); - } - } - - wrefresh(localwin); -} -#else -#define putc_on_screen(c) do { } while (0) -#endif - -void helper_cp1_putc(target_ulong x) -{ - putc_on_screen((unsigned char)x); /* Output to screen */ - DPRINTF("%c", x); /* Output to stdout */ + qemu_semihosting_log_out(&c, sizeof(c)); } -#endif +#endif /* !CONFIG_USER_ONLY */ =20 bool uc32_cpu_exec_interrupt(CPUState *cs, int interrupt_request) { --=20 2.26.2 From nobody Mon May 13 04:47:46 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1591795434; cv=none; d=zohomail.com; s=zohoarc; b=KHllfR/CzZzSqjXoHP1WGDKqgp1tDjaBi6MD7jS/1ePUh6B7BcMJjdVFh2plz6igJ/gkqDjOv8K6Vx2rURl7QrRPokZRc/bBkoHYFUo2EUfjP7HxZmsJJgoyKZx+ORGQB6R6Hn78whvRdLV8OvRMp2rwbV/kngunOQMptX8UC8I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1591795434; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=fTbKsNrJdd1VRs/45tgMkoTZ1o5n+wZ2qzSxL+C7I2Q=; b=J5nzIfgDmGUT0ZNWakshwjFeLARlBgfCVNnU+MxmhK6GgYWJd7jKxl/ys9LTrs0oKaXeQ2eDLnxziOpSNe1qVGRfgnc3FoGpilt/bzoTT4JK7XM7VoM0+LS5v5XawSW/9eGR4eB+xhRs/E4yebGOifr6TU/+7v8NwUknJLFofBU= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1591795434295309.0180198634216; Wed, 10 Jun 2020 06:23:54 -0700 (PDT) Received: from localhost ([::1]:46092 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jj0hs-0001Wz-PA for importer@patchew.org; Wed, 10 Jun 2020 09:23:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45254) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jj0Uy-00081B-QI; Wed, 10 Jun 2020 09:10:32 -0400 Received: from mout.kundenserver.de ([212.227.126.135]:56849) by eggs.gnu.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jj0Ux-0003iZ-GY; Wed, 10 Jun 2020 09:10:32 -0400 Received: from localhost.localdomain ([82.252.135.106]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1N5mOZ-1iqdNM3MqZ-017G53; Wed, 10 Jun 2020 15:10:24 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL v2 15/16] hw/openrisc/openrisc_sim: Add assertion to silence GCC warning Date: Wed, 10 Jun 2020 15:10:10 +0200 Message-Id: <20200610131011.1941209-16-laurent@vivier.eu> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200610131011.1941209-1-laurent@vivier.eu> References: <20200610131011.1941209-1-laurent@vivier.eu> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:8hggNOYDOPfXdValh0/LtwKsrJvnZ4EGWVtbAUwp4s8OL/Fywjr XM8ycjFTSCPGAN2lT70Si/9ZKlNzKz4q/t6UAuSq8IoixVgFpI9l3zb6Yv9nxbTdu7T4cw9 /QZ1kAQqEZfpoOKWn01BZtV70gNxTqFmEySF5H27YRkrwHpsP+mRxvZNVJrXZMiZtsk4SxM INW3G9NIAo32IrI1A2ngw== X-UI-Out-Filterresults: notjunk:1;V03:K0:ZQZSn2q+FiE=:utUpGYNOY2gkjdSNwg1Qdr SuHTxbDfUhNJeHTex7w5KiKoeXtrpaPqRVRZxxYoqK+CR8u0z6oBT5s8HuuwpL7Q8LUb6sVun yb3JTSV3ixfDOLK2slgywpc4e9A1tPCd5uZk4Ht/WE7FqZLlyqtfZWDVOeY8vpogUciuTk7v8 Wyl67YSXn2k3WxM2A8ejAHGyhsSR5kXnHWLADJ5IsifLok4RX8LHC8onEvFUqxaUxh777UmIj HcAshB5/pfmTKejbNJmuQPSwPEyaXW0VnfZnO7MvHubSvZAIbsaLTjzL77xx5Qpr/DDgu5e62 29O6pLA2RNzpm7ryrA/M1WeVFoVxXMZYffHXSznimV8LjI4kfg2d3M2X1P+3ehMtbWP6SiaW1 A38ePOtiKNCNPT5RMsczmXftCkYndT0oGoFlNLyLOsSDomjDvjXBLrswwwbfLSIwhkttN/I4W YSHFocH4FCyYnnJbSH1Ie9EYhW3qJ3emBbY/pibenvOadoiq5qLjxFbdV50ML/1VXuj4vjwG6 SSxBmNaH6I6QgXdx12+IsNlmqgk3xXK1Yl8ev9OJL2W/3W2LS6jYZPJ40njrQIPT9+fZwLKJm SRX/xLKfpdH+RiW0juQmdyLCg4AMDa8TG3JwopX/76KKZ+NYNY24DU47SbD8OoopC+zrx/lrC R+rhM4+Xso7/tS7w70Y24poBpfks/gCILThahOZdEk/50OCQJpqqA6sHUPTFy0hu2qgsoI5la fT1Ou/xEV521eoAxXP/3FvgXPd5JzCt7fa6FtcWpFei2fMR4iLOTb7PRVunH6IaFEqS5nn3SL EkCvG2eciz2EfVaNkyfzeM4eDpHMcFu0Qu4npbjWfiOb+BCJ84XOmQfy3D1jhzdSsjC1CgV Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=212.227.126.135; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/10 08:14:00 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Thomas Huth , qemu-trivial@nongnu.org, =?UTF-8?q?Martin=20Li=C5=A1ka?= , Michael Tokarev , Laurent Vivier , Stafford Horne , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" From: Philippe Mathieu-Daud=C3=A9 When compiling with GCC 10 (Fedora 32) using CFLAGS=3D-O2 we get: CC or1k-softmmu/hw/openrisc/openrisc_sim.o hw/openrisc/openrisc_sim.c: In function =E2=80=98openrisc_sim_init=E2=80= =99: hw/openrisc/openrisc_sim.c:87:42: error: =E2=80=98cpu_irqs[0]=E2=80=99 ma= y be used uninitialized in this function [-Werror=3Dmaybe-uninitialized] 87 | sysbus_connect_irq(s, i, cpu_irqs[i][irq_pin]); | ~~~~~~~~^~~ While humans can tell smp_cpus will always be in the [1, 2] range, (openrisc_sim_machine_init sets mc->max_cpus =3D 2), the compiler can't. Add an assertion to give the compiler a hint there's no use of uninitialized data. Buglink: https://bugs.launchpad.net/qemu/+bug/1874073 Reported-by: Martin Li=C5=A1ka Suggested-by: Peter Maydell Reviewed-by: Thomas Huth Tested-by: Eric Blake Reviewed-by: Eric Blake Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Acked-by: Stafford Horne Message-Id: <20200608160611.16966-1-philmd@redhat.com> Signed-off-by: Laurent Vivier --- hw/openrisc/openrisc_sim.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/openrisc/openrisc_sim.c b/hw/openrisc/openrisc_sim.c index d08ce6181199..02f5259e5e33 100644 --- a/hw/openrisc/openrisc_sim.c +++ b/hw/openrisc/openrisc_sim.c @@ -134,6 +134,7 @@ static void openrisc_sim_init(MachineState *machine) int n; unsigned int smp_cpus =3D machine->smp.cpus; =20 + assert(smp_cpus >=3D 1 && smp_cpus <=3D 2); for (n =3D 0; n < smp_cpus; n++) { cpu =3D OPENRISC_CPU(cpu_create(machine->cpu_type)); if (cpu =3D=3D NULL) { --=20 2.26.2 From nobody Mon May 13 04:47:46 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1591795436; cv=none; d=zohomail.com; s=zohoarc; b=jD3PL2+LxoXdtBnWY28cf6nA6PDzIgbELdAJ9Fh57TNAKkEYTgO34Ajv6KfYVmsYX2VsUzh3zmOKrkWGdCDFHUjMkfoDZfWMRrqu9KUGvGg1eVuJPKSoAmIbzYk8zLdtu6PNMOOKLcNnLpO5GesaQFviDAnMHDhD0PQ5epvVNmc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1591795436; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=gw/DGfJX5Gvqv8VU0cMS9FzzQ1a0LQBwSHI8ck4jy9k=; b=fWfeFmaXUq45a2dlM0rNB1cQQYT4mgiAtlyJSrQ+IdsVgsM6RShFEC1R/JxBJv6n2IYMs0TTVHCOllGCXOgIhEDjGEjn0TOsVJkIkZDQSn5FKWhTwmzangEMtPV+ZYftkM+8PoJUtcmC8FMwsF+rzMViBTAZMuCdrAl/6LKasXI= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 159179543676245.8129540547277; Wed, 10 Jun 2020 06:23:56 -0700 (PDT) Received: from localhost ([::1]:46168 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jj0hu-0001Yo-5j for importer@patchew.org; Wed, 10 Jun 2020 09:23:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45226) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jj0Ux-0007ya-Cr; Wed, 10 Jun 2020 09:10:31 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:40119) by eggs.gnu.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jj0Uw-0003iG-5v; Wed, 10 Jun 2020 09:10:30 -0400 Received: from localhost.localdomain ([82.252.135.106]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1Macaw-1jCPVK24pm-00c8PY; Wed, 10 Jun 2020 15:10:24 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL v2 16/16] semihosting: remove the pthread include which seems unused Date: Wed, 10 Jun 2020 15:10:11 +0200 Message-Id: <20200610131011.1941209-17-laurent@vivier.eu> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200610131011.1941209-1-laurent@vivier.eu> References: <20200610131011.1941209-1-laurent@vivier.eu> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:ldzgHkhI8KmsyOCiFaLmnS0K5iFXGYvIBP/UBPuWhTqg8wcqsIP wsnEKytnVV2F1Xl988TfyG7hNDxvvV8fex9KGMgtE3jS2B3NbI6ghu3admhgoWYmRFzJAkw XzfCqsNp24L7150ogMU20TZs8szOCUpvhqQw/N2SamZIFX4xZ9OpBSLcTnebS2TwD9xOVqT DPDZ3oUFlPcDVg7XX0QkA== X-UI-Out-Filterresults: notjunk:1;V03:K0:GYFIDvf0oXM=:Krk5biTk1H33Y5ee50ButZ KesGI7jR5CilUGKYf/qlesmRjJvaAWuS1X+djGX16sOcdpgFZ5wt4qbqJ7Cx4jiXL5NtFoZTH 59FLYlbBxTo1dsbz1IG6Q/tnB/lnNOObu/HFH3QdE1iI1/tfXhY4WjbZvxT17HiLLibiVjpHg lQkQXC78L6vvsUG34cGD6VtWtRkw1fMEGNasxf7ATMFU/iumlLuGMYmOiU6puTwOyaKLnSIFD nEiVTEBerofBPHyZyAGOP96sapnmXAHTSSak4fwLTQ0t19HmNTu8pV+k5lFSDkayz5CCOenFl 8pR6/mxIEywRCn0QwmtBlbbGN9/SYEMSMoMZylX7QBidYxH3KP07uVsBSRjTNvFOLr/pCkDeK y2J8K4i4ejAKS9DJKA5IN5KF5idXNgkDfB4YuAvnoQFl4BFtf0Xn1DyDTfhXXXvqMP+gpWZS6 sl38acmww4EsxKFKlrALfBk6PODbF7sSWZfAAN5bmxOouGDLy1vRExNjjSMRtngkMcL07YKgn O/RLm6WlvKP0Xb6Vx/7zbwSqAB1Oe0rvwESCMdp9rUFiFntgbs24V0XIwndaiIF8WsHyiCZBB 3Wgaeo5JcnEuINI/mrlYqIBDl4FlOBumiaG7xwh5hwD2PsZX/Oh14S6E73ull74ELXLyg6zLI jJMCIr89CcsD39paGP5bz16hSJcha1ku4Cep3rIT7SBwVSuxhwt7s+yjJkzEoOtJH75iDgLM7 uh4XLoS7dtw5UW2OTW6so2jeguMXwb0lakuBsduF5pOY9NtHjNltIRX4gmgURh0kTjL8faOFO qTT6nvUxmVfDgsrFcdbCgeNSlo4ZlAbDxZnbmofS78CrrZ0QSy1zlDsVTNVl1Nj5qIYECRi Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=212.227.126.131; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/10 09:10:24 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, =?UTF-8?q?Alex=20Benn=C3=A9e?= , Michael Tokarev , Laurent Vivier , KONRAD Frederic , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" From: KONRAD Frederic This have been introduced by: 8de702cb677c8381fb702cae252d6b69aa4c653b It doesn't seem to be used so remove it. Signed-off-by: KONRAD Frederic Reviewed-by: Philippe Mathieu-Daud=C3=A9 Acked-by: Alex Benn=C3=A9e Message-Id: <1589806958-23511-1-git-send-email-frederic.konrad@adacore.com> Signed-off-by: Laurent Vivier --- hw/semihosting/console.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/semihosting/console.c b/hw/semihosting/console.c index 6346bd7f506e..22e7827824af 100644 --- a/hw/semihosting/console.c +++ b/hw/semihosting/console.c @@ -23,7 +23,6 @@ #include "exec/exec-all.h" #include "qemu/log.h" #include "chardev/char.h" -#include #include "chardev/char-fe.h" #include "sysemu/sysemu.h" #include "qemu/main-loop.h" --=20 2.26.2