From nobody Mon Feb 9 17:24:47 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1591705934; cv=none; d=zohomail.com; s=zohoarc; b=QikyJd64YaIgm6LfGOYIdUVpoBN6C+y5Q8taHXjrf+krZIGzFJqB29kdAoP+cXSl48BUmvVwyuO2oJx2PublmCulEXw9rG1b3Lym5OCFY9QQ7huk+sg2a8JQMy1f0zzmNw66VtTBo9FzsLz8CP2n2hhswDO+OfcbJHy0ldTTpbA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1591705934; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=xLna1p07mKJM7i0zrrlNHyDNNPybX9I6BoX1ZKhLxe8=; b=JGjPkfZQAdyrOh/Rqj8I7/ZQCE7BU5RinquCppP0SoNDqVu58vvfP/ULqERXgF0qRRaN3nvOoxdMkaq6h9It0+JnTI7I6qxz2Lxqp1UPlOL/pjUxcTMeLEQkY9JjxaNNjGXM4Q+hYoHIPGksjey+TDqvplX5XMFzkXGZzA7FoUE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1591705934267873.1955386612079; Tue, 9 Jun 2020 05:32:14 -0700 (PDT) Received: from localhost ([::1]:50520 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jidQL-0004jD-0Q for importer@patchew.org; Tue, 09 Jun 2020 08:32:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41676) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jidIL-0003PS-G6 for qemu-devel@nongnu.org; Tue, 09 Jun 2020 08:23:57 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:50247 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jidIG-0005QK-PQ for qemu-devel@nongnu.org; Tue, 09 Jun 2020 08:23:57 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-218-Uw3oE5cMOcu36dgcawQSEQ-1; Tue, 09 Jun 2020 08:23:45 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D66E8A0BDA; Tue, 9 Jun 2020 12:23:44 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-112-121.ams2.redhat.com [10.36.112.121]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A6FFB82044; Tue, 9 Jun 2020 12:23:44 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 32966113846B; Tue, 9 Jun 2020 14:23:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591705427; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xLna1p07mKJM7i0zrrlNHyDNNPybX9I6BoX1ZKhLxe8=; b=TAp01WtU3y32KVIyDZ5FbtvUAeTy3W5y21mzr6jOzlQ4MRw1dXWtov863iLZpV7OAthKcw QnAfIR+6z7YoPjg/cIgdQV2ozaOLB1LeaUrjw91+QSF4iAHAYDLZNaQ2V/3sT8QRqWw3Kv 9RSfBKqxymjSxwBA5q5+155xqLDDANs= X-MC-Unique: Uw3oE5cMOcu36dgcawQSEQ-1 From: Markus Armbruster To: qemu-devel@nongnu.org Subject: [PATCH v3 22/24] qdev: Assert devices are plugged into a bus that can take them Date: Tue, 9 Jun 2020 14:23:37 +0200 Message-Id: <20200609122339.937862-23-armbru@redhat.com> In-Reply-To: <20200609122339.937862-1-armbru@redhat.com> References: <20200609122339.937862-1-armbru@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.139.110.120; envelope-from=armbru@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/09 02:44:16 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pbonzini@redhat.com, Mark Cave-Ayland , berrange@redhat.com, ehabkost@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" This would have caught some of the bugs I just fixed. Signed-off-by: Markus Armbruster Reviewed-by: Mark Cave-Ayland --- hw/core/qdev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/core/qdev.c b/hw/core/qdev.c index 9e5538aeae..b5b42b2616 100644 --- a/hw/core/qdev.c +++ b/hw/core/qdev.c @@ -97,6 +97,9 @@ static void bus_add_child(BusState *bus, DeviceState *chi= ld) void qdev_set_parent_bus(DeviceState *dev, BusState *bus) { BusState *old_parent_bus =3D dev->parent_bus; + DeviceClass *dc =3D DEVICE_GET_CLASS(dev); + + assert(dc->bus_type && object_dynamic_cast(OBJECT(bus), dc->bus_type)); =20 if (old_parent_bus) { trace_qdev_update_parent_bus(dev, object_get_typename(OBJECT(dev)), --=20 2.26.2