From nobody Fri Sep 20 22:16:09 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1591607874; cv=none; d=zohomail.com; s=zohoarc; b=GBSvbD+KFubHVcAanGhCg5WAhbaEJgUuK3NCPgmL7nAlx8EiMlVK+xjXOyNQlPRfds3TZOJhZeDt9KKywDoSqm3pw0WFDuiegz4sl4RiBKRfpsutpYy1ROaFM6Mj4bmxRwQCbn0dIVMPcMJ46jwU1qHYvdnM1AMnYbpNXy8DWyM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1591607874; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=GAilW8yie/Do5KptkIQuqkh+fcg/rpMOQw77I65dDB8=; b=SqPsud3x5Qkw1ilovF+PIrPbDcL/QDXZnkLqPqIY3rfBPds09KSEaXv2urwtYcMxzMXaXhF9cKL5kkce010Auua1wPzFzkdBqQV9kv+5P8iyRxL3J9YPVNvfTEMbBJMu0WClRax4EimxZEO+4xeYyW+zHgOXKKuX4MO0ycPlsB4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1591607874291940.9177076975283; Mon, 8 Jun 2020 02:17:54 -0700 (PDT) Received: from localhost ([::1]:41178 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jiDuj-0001lb-3K for importer@patchew.org; Mon, 08 Jun 2020 05:17:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47122) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jiDsA-00084f-Ev; Mon, 08 Jun 2020 05:15:14 -0400 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]:35368) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jiDs9-0006YU-K9; Mon, 08 Jun 2020 05:15:14 -0400 Received: by mail-wr1-x442.google.com with SMTP id x14so16551093wrp.2; Mon, 08 Jun 2020 02:15:12 -0700 (PDT) Received: from localhost.localdomain (181.red-88-10-103.dynamicip.rima-tde.net. [88.10.103.181]) by smtp.gmail.com with ESMTPSA id c5sm18258653wma.20.2020.06.08.02.15.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jun 2020 02:15:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=GAilW8yie/Do5KptkIQuqkh+fcg/rpMOQw77I65dDB8=; b=oEm4PStXndMdrJqKwb6eb7K8+NRMM1HCO1tnV4LI3kl/h7uo4y5SzLzZcjI4Vpbxma 0NvtC5ZQYjSs50pIODcz866DqBEJz2+BVrvVDm+rs5A+vveYvJO6E6EjpuZ5iZTO9AAp kPZRm+pL+QBDEHrqub4NW29VRvsq6R05YR8SaRRpfncL3TG/qlykfa4lFAD/+LS3C7to soazm+XNSUpdYmoHTiECSGQB1vG5+2rstGxqF9y+lddSl+6oaZhNwf5xRjLNUmQt13Eq yJvM3lWGqQ3Ja8yyK6tHqvPUMsTcGmElajHh+oDB5dusS94XKnDdOwHb0z2Oqup6UcFt FQuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=GAilW8yie/Do5KptkIQuqkh+fcg/rpMOQw77I65dDB8=; b=UqgkITBRpSrUSx7AWBKQFaPgdjNV1mqpHLT4ziDJKPQsg8NgGdLDj76KTwWFTjmK9W aCpNKy6bhSAqcWVrB12lojUeuEsliWNrRLujjWd1wDLkD9vGdDSo0TzcWwjJL6aAibBJ ttmlxmSEuaRV38dYvcerKuuDTlGOCHsD23RkPUCf327LRWgCoylYTzkLYi0oI6YoJDZ3 JfXgjxVxKMZCrqdVf6W75XmrXgTtjMZtFl/TERSToXkqC+r5pmOEf9HYl0NqnOkYSPYj UH9PhaaKtIdFMeUXDeKi21+sFKSS/F+P2PxD3EnQy8/00/2zbdaspHfQZf0R65pKwdKZ IsEw== X-Gm-Message-State: AOAM532e1C/dP6rkKJmY5rbl9Lga8eyIVfeSeMUlwCyUDxb1vgs3MT5Z 3oPqR/jMQZT3U4DFtIBSJAcGM94m X-Google-Smtp-Source: ABdhPJzKsjQBjZgx7bAQeXpii+MNkT9H3BOM1qbbHolNVqLu8p3j9rybbjIpKcEQH8xSti2BdBwJrQ== X-Received: by 2002:a5d:6601:: with SMTP id n1mr21605212wru.23.1591607711465; Mon, 08 Jun 2020 02:15:11 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH 1/2] hw/net/opencores_eth: Use definitions instead of magic values Date: Mon, 8 Jun 2020 11:15:07 +0200 Message-Id: <20200608091508.19838-2-f4bug@amsat.org> X-Mailer: git-send-email 2.21.3 In-Reply-To: <20200608091508.19838-1-f4bug@amsat.org> References: <20200608091508.19838-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::442; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-x442.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Jason Wang , Michael Tokarev , Laurent Vivier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Max Filippov Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Use definitions from "hw/net/mii.h". This also helps when using git-grep. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Acked-by: Max Filippov --- hw/net/opencores_eth.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/net/opencores_eth.c b/hw/net/opencores_eth.c index 2ba0dc8c2f..90d3846bb7 100644 --- a/hw/net/opencores_eth.c +++ b/hw/net/opencores_eth.c @@ -86,8 +86,8 @@ static void mii_reset(Mii *s) s->regs[MII_BMSR] =3D MII_BMSR_100TX_FD | MII_BMSR_100TX_HD | MII_BMSR_10T_FD | MII_BMSR_10T_HD | MII_BMSR_MFPS | MII_BMSR_AN_COMP | MII_BMSR_AUTONEG; - s->regs[MII_PHYID1] =3D 0x2000; - s->regs[MII_PHYID2] =3D 0x5c90; + s->regs[MII_PHYID1] =3D DP83848_PHYID1; + s->regs[MII_PHYID2] =3D DP83848_PHYID2; s->regs[MII_ANAR] =3D MII_ANAR_TXFD | MII_ANAR_TX | MII_ANAR_10FD | MII_ANAR_10 | MII_ANAR_CSMACD; mii_set_link(s, s->link_ok); --=20 2.21.3 From nobody Fri Sep 20 22:16:09 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1591607946; cv=none; d=zohomail.com; s=zohoarc; b=QcNWW2wdRHqjb8hfMGpYF6KDOUmi333NN4hIQC7G/tYM07r1QsClPQLz8XQ3RJyDMxGSJLnqvVFBICPVk3cd+zycv6RD89lRDT/E11Pe9X6jOqPFMggkJAyGAXWK9Dp+QzBXDeW6HCuUpVfkPoeBAASTfSk/9Ndjp/GIH6qyXJg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1591607946; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=JZJrkLA/SBPZqar+T/Pdm4HVA3BodVf1OjgW7SLCEjM=; b=ONMpishWHoXfMbGX6SZcUmrqgQyHb9vgDGRZw5hV/byWs4L3bJ5j56Xpbj/4N5G4iTda8YqXM4+QHQWy8PDijxMbhf4woZVGxAtDkoH/V+FUT4w6/UCITGs0H2tYxPq2Rr3Zy3S5vwRQZQlZcNm3FbA0FGR4dcKmTsrciVtoz70= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 159160794698016.804259683427404; Mon, 8 Jun 2020 02:19:06 -0700 (PDT) Received: from localhost ([::1]:43444 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jiDvt-0002gO-Kf for importer@patchew.org; Mon, 08 Jun 2020 05:19:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47126) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jiDsB-00085D-Eu; Mon, 08 Jun 2020 05:15:15 -0400 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]:33681) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jiDsA-0006ZP-Oj; Mon, 08 Jun 2020 05:15:15 -0400 Received: by mail-wr1-x443.google.com with SMTP id l11so16559650wru.0; Mon, 08 Jun 2020 02:15:14 -0700 (PDT) Received: from localhost.localdomain (181.red-88-10-103.dynamicip.rima-tde.net. [88.10.103.181]) by smtp.gmail.com with ESMTPSA id c5sm18258653wma.20.2020.06.08.02.15.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jun 2020 02:15:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=JZJrkLA/SBPZqar+T/Pdm4HVA3BodVf1OjgW7SLCEjM=; b=P2i8EjQP3BExQwIsGyjE1XhEg87m4I0jWUELA/2CvKga+Hyzy9h4fzLd5n3/Hi3F/t H0H+oIL/eMXbtVbTxKSsM9Ggd1QetxRYPC5W5keLZWGggSUhPbUyYbGZbDdKih+I+SOe 2jTwlYgH7ybjch84/G1B+4Rey040yiZ9gyuIRggkZXN+Q6bEvzuyztWMSlfgGc+6Igjh ZYiD+jswnq4kEFAA6QQfduK+a0w7O6IaBW90HlCrmMohU8oIGleDsG8powwvxfS0KxHi aEWBraiud2qJ4FBG41i85KrkX9+W9FnU5pJ8Eok5ZbHLhJDiHqh312dwtz7cBkbnCSym mCwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=JZJrkLA/SBPZqar+T/Pdm4HVA3BodVf1OjgW7SLCEjM=; b=GAjy+E7MhHEN1Z6drCJ/frLZx4NiUOeRXcBwkx/N652XZ5Dbzpu90V5DRJhV41rRu4 YXW1ZhCJyyuZBrsJGuMDNl+tQnv9dMwmDW/AKu0SdcDHgeIi5ryDMgEE6nIkzAidrS6H UGOh3+icZjOuM91oYSexXN+RXj1sw2im97cojXaMbi52KyKLZg/H0b3rkQSu6tQnkeJD j7R7jkYf6056Hp2l8+rxCeq+9h2c1srnkp1uVgutBRQuUD1ijCbtF419ICqSKUNqyQEX xrt7rP7Ci4vGmNa2WBE3Vd++z25xK1CHdcLOO/+eTDcFZXZXw6dwmsOD+xQ/aMYDTJyn bzSQ== X-Gm-Message-State: AOAM532Dh7McDr44zfNi/bOSPgqSav4rVchXJgLDw+MOLpotss5bwUqt vVJ5CDYqhv9tDf0weOaBzr0ZS447 X-Google-Smtp-Source: ABdhPJyD2A17b5V7wfNeYKHToJiZQs6oWzZzmEykFm1ifI+DuyB+DF3LsbtBFwwWbCj9bQQ/jUK0oA== X-Received: by 2002:a5d:558a:: with SMTP id i10mr24007262wrv.207.1591607712767; Mon, 08 Jun 2020 02:15:12 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH 2/2] hw/net/opencores_eth: Remove unnecessary address masking Date: Mon, 8 Jun 2020 11:15:08 +0200 Message-Id: <20200608091508.19838-3-f4bug@amsat.org> X-Mailer: git-send-email 2.21.3 In-Reply-To: <20200608091508.19838-1-f4bug@amsat.org> References: <20200608091508.19838-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::443; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-x443.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Jason Wang , Michael Tokarev , Laurent Vivier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Max Filippov Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) The memory region is limited to 1 KiB, so the address is garantied to be in that range. No need to mask. 711 static const MemoryRegionOps open_eth_desc_ops =3D { 712 .read =3D open_eth_desc_read, 713 .write =3D open_eth_desc_write, 714 }; ... 725 memory_region_init_io(&s->desc_io, OBJECT(dev), 725 &open_eth_desc_ops, s, 726 "open_eth.desc", 0x400); Signed-off-by: Philippe Mathieu-Daud=C3=A9 Acked-by: Max Filippov --- hw/net/opencores_eth.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/hw/net/opencores_eth.c b/hw/net/opencores_eth.c index 90d3846bb7..0c9879e8a7 100644 --- a/hw/net/opencores_eth.c +++ b/hw/net/opencores_eth.c @@ -687,7 +687,6 @@ static uint64_t open_eth_desc_read(void *opaque, OpenEthState *s =3D opaque; uint64_t v =3D 0; =20 - addr &=3D 0x3ff; memcpy(&v, (uint8_t *)s->desc + addr, size); trace_open_eth_desc_read((uint32_t)addr, (uint32_t)v); return v; @@ -698,7 +697,6 @@ static void open_eth_desc_write(void *opaque, { OpenEthState *s =3D opaque; =20 - addr &=3D 0x3ff; trace_open_eth_desc_write((uint32_t)addr, (uint32_t)val); memcpy((uint8_t *)s->desc + addr, &val, size); open_eth_check_start_xmit(s); --=20 2.21.3