From nobody Mon Feb 9 19:52:35 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1591371727; cv=none; d=zohomail.com; s=zohoarc; b=b+viZR5juaRBSDG5mVpAiZ2Ryg/E2QMVZwtBJsAOxia2c8l3O0s2Ml85y6skqE41jpvzSGrz3mCsqH25WLEulg/yBMv4LEpTY935tiSDispNGQcS0ErRzHcSzGBgpB+1fAIhHYG1mpbE2/HQzO8u1GpwpceI/rbBo2sWPFAJTKQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1591371727; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=MugtwhSa2UIARPD2RpJf6cOBr7a4c8tOBz0Sz8wV9m0=; b=iiJCvrsVrHMHXUvJcUr0J2WKFQMotOJGm2+OTjgE2g7cq/H0YSFYFq17qS1B/xC7MO8Z+gp4kaFqtcz53NwSbg/ouv6ZxTyeUK8m5wc75/NZshhkq7ajnfK/682IJqN05TSOVWaNO41TboilzHxBrnvFaIDpJAlkDg4A1osfTiQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1591371727700528.3347844421792; Fri, 5 Jun 2020 08:42:07 -0700 (PDT) Received: from localhost ([::1]:53952 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jhETu-0002Ws-By for importer@patchew.org; Fri, 05 Jun 2020 11:42:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56936) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jhEQG-0004n3-B7 for qemu-devel@nongnu.org; Fri, 05 Jun 2020 11:38:20 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:27372 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jhEQF-00022U-IX for qemu-devel@nongnu.org; Fri, 05 Jun 2020 11:38:20 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-325-CaiQivvuNfuzcVLdGb2MEw-1; Fri, 05 Jun 2020 11:38:16 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 64327A0C08; Fri, 5 Jun 2020 15:38:15 +0000 (UTC) Received: from localhost (ovpn-113-2.ams2.redhat.com [10.36.113.2]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0ACF65D9DA; Fri, 5 Jun 2020 15:38:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591371498; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MugtwhSa2UIARPD2RpJf6cOBr7a4c8tOBz0Sz8wV9m0=; b=QCa9T1b7IG/MGLRS1N9RUWuKxMT6cz1qL53JCt1X/1+jrLAClIyLH9sz/MqGy+pbtzeAfw XzAQRejkfCf/ba5CM3XXFIKlB3Zsygm1fl/6Gl7kGQ2RQLoFdXCBbqll2fey95kaA613vE YUsAf9xaAuv7fswJne6voAA37aNa/mU= X-MC-Unique: CaiQivvuNfuzcVLdGb2MEw-1 From: Cornelia Huck To: Peter Maydell Subject: [PULL 05/10] vfio-ccw: allow non-prefetch ORBs Date: Fri, 5 Jun 2020 17:37:51 +0200 Message-Id: <20200605153756.392825-6-cohuck@redhat.com> In-Reply-To: <20200605153756.392825-1-cohuck@redhat.com> References: <20200605153756.392825-1-cohuck@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=207.211.31.81; envelope-from=cohuck@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/05 03:40:54 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eric Farman , qemu-s390x@nongnu.org, Cornelia Huck , qemu-devel@nongnu.org, Jared Rossi Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" From: Jared Rossi Remove the explicit prefetch check when using vfio-ccw devices. This check does not trigger in practice as all Linux channel programs are intended to use prefetch. Newer Linux kernel versions do not require to force the PFCH flag with vfio-ccw devices anymore. Signed-off-by: Jared Rossi Reviewed-by: Eric Farman Message-Id: <20200512181535.18630-2-jrossi@linux.ibm.com> Signed-off-by: Cornelia Huck --- hw/vfio/ccw.c | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/hw/vfio/ccw.c b/hw/vfio/ccw.c index c8624943c177..63406184d226 100644 --- a/hw/vfio/ccw.c +++ b/hw/vfio/ccw.c @@ -74,16 +74,9 @@ static IOInstEnding vfio_ccw_handle_request(SubchDev *sc= h) struct ccw_io_region *region =3D vcdev->io_region; int ret; =20 - if (!(sch->orb.ctrl0 & ORB_CTRL0_MASK_PFCH)) { - if (!(vcdev->force_orb_pfch)) { - warn_once_pfch(vcdev, sch, "requires PFCH flag set"); - sch_gen_unit_exception(sch); - css_inject_io_interrupt(sch); - return IOINST_CC_EXPECTED; - } else { - sch->orb.ctrl0 |=3D ORB_CTRL0_MASK_PFCH; - warn_once_pfch(vcdev, sch, "PFCH flag forced"); - } + if (!(sch->orb.ctrl0 & ORB_CTRL0_MASK_PFCH) && vcdev->force_orb_pfch) { + sch->orb.ctrl0 |=3D ORB_CTRL0_MASK_PFCH; + warn_once_pfch(vcdev, sch, "PFCH flag forced"); } =20 QEMU_BUILD_BUG_ON(sizeof(region->orb_area) !=3D sizeof(ORB)); --=20 2.25.4