From nobody Mon Feb 9 05:44:17 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1591369716; cv=none; d=zohomail.com; s=zohoarc; b=cvEP2kHN/rGDeEpeE6cVDh/0RQyf+T/inI4YwbReiR1HqKJzDt+70wHaRXmOIvlWsesI09pvMlS6hxzMaEaiZf92KPUPtrW4MHTrrdMdrp3l6vlPGcMUZE1rjlN40ud3RUsWz8ylx/J0fNGVrY+z7mmntWwOcQbQJL3hbmNhWOw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1591369716; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=j9/UKvBvAmk9YTLtdqkbtVKGzKaZHy1sV41gr7ratc4=; b=Kwer3d8WWyZg/fW73Up/pUQOQAqrVRPDnw1T1GAvpOD98zclKNujoebOaT+SQEldc3wEvoTaMiupVh++XVCeeCaVq+qPTDbBWhgzUAB2CedSMLNVLRdAtQ84DMZvxZ2Y4X8FvKA8BqcE7IFInCruq7trN7p7wGObejFbW8PaipE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1591369716182629.523710225713; Fri, 5 Jun 2020 08:08:36 -0700 (PDT) Received: from localhost ([::1]:44112 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jhDxS-0004hu-PS for importer@patchew.org; Fri, 05 Jun 2020 11:08:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50940) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jhDlx-00046g-IQ for qemu-devel@nongnu.org; Fri, 05 Jun 2020 10:56:41 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:28898 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jhDlt-0007Vt-As for qemu-devel@nongnu.org; Fri, 05 Jun 2020 10:56:41 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-273-01llsDlWMdyZq3MpnQ3AQw-1; Fri, 05 Jun 2020 10:56:28 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 91990EC1B3; Fri, 5 Jun 2020 14:56:27 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-112-121.ams2.redhat.com [10.36.112.121]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3313410013C0; Fri, 5 Jun 2020 14:56:27 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id A44C31138527; Fri, 5 Jun 2020 16:56:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591368996; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=j9/UKvBvAmk9YTLtdqkbtVKGzKaZHy1sV41gr7ratc4=; b=QVl+hbIzHK4kAb0+LOi1krnu/XAbKRAscHhDzmQK+AgZwb8DBMfTJKVI4FS0hqMh6Mw481 +8k6a1KpWu/t3DluGq+edTDIsbF45QpukifL2xfZ/3TnKMIR21LFmtrrLKcXjWp5eI2S0R yXATfXWE8PL1t8ybxKz+hW1RUWq9FRM= X-MC-Unique: 01llsDlWMdyZq3MpnQ3AQw-1 From: Markus Armbruster To: qemu-devel@nongnu.org Subject: [PATCH 03/16] iotests/172: Cover -global floppy.drive=... Date: Fri, 5 Jun 2020 16:56:12 +0200 Message-Id: <20200605145625.2920920-4-armbru@redhat.com> In-Reply-To: <20200605145625.2920920-1-armbru@redhat.com> References: <20200605145625.2920920-1-armbru@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=207.211.31.120; envelope-from=armbru@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/05 03:07:04 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, berrange@redhat.com, ehabkost@redhat.com, qemu-block@nongnu.org, mreitz@redhat.com, pbonzini@redhat.com, jsnow@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Use of -global to set a default backend for non-singleton devices is a bad idea. But as long as we permit it, we better test it. Test output demonstrates we screw up when -global floppy clashes with -fda or with -device floppy: according to "info qtree", only the latter backend is attached, but according to "info block", both are. Here's the clash with -device: Testing: -drive if=3Dnone,file=3DTEST_DIR/t.qcow2 -drive if=3Dnone,file= =3DTEST_DIR/t.qcow2.2 -global floppy.drive=3Dnone0 -device floppy,drive=3Dn= one1,unit=3D0 dev: isa-fdc, id "" [...] driveA =3D "" driveB =3D "" [...] bus: floppy-bus.0 type floppy-bus dev: floppy, id "" unit =3D 0 (0x0) ---> drive =3D "none1" [...] none0 (NODE_NAME): TEST_DIR/t.qcow2 (qcow2) ---> Attached to: /machine/peripheral-anon/device[0] Cache mode: writeback none1 (NODE_NAME): TEST_DIR/t.qcow2.2 (qcow2) ---> Attached to: /machine/peripheral-anon/device[0] Removable device: not locked, tray closed Cache mode: writeback /machine/peripheral-anon/device[0] is the floppy created with -device. Test output further demonstrates the "Drive 'FOO' is already in use because it has been automatically connected to another device" error message can be misleading. With '-fda "" -global floppy.drive=3Dfloppy0', it's in use because -global reuses -fda's backend. There is no other device involved. Signed-off-by: Markus Armbruster --- tests/qemu-iotests/172 | 7 ++ tests/qemu-iotests/172.out | 134 +++++++++++++++++++++++++++++++++++++ 2 files changed, 141 insertions(+) diff --git a/tests/qemu-iotests/172 b/tests/qemu-iotests/172 index 714c7527b4..18056bcef7 100755 --- a/tests/qemu-iotests/172 +++ b/tests/qemu-iotests/172 @@ -151,6 +151,7 @@ check_floppy_qtree -fdb "$TEST_IMG" -drive if=3Dnone,fi= le=3D"$TEST_IMG.2" -global is # Conflicting (-fdX wins) check_floppy_qtree -fda "$TEST_IMG" -drive if=3Dnone,file=3D"$TEST_IMG.2" = -global isa-fdc.driveA=3Dnone0 check_floppy_qtree -fdb "$TEST_IMG" -drive if=3Dnone,file=3D"$TEST_IMG.2" = -global isa-fdc.driveB=3Dnone0 +check_floppy_qtree -fda "$TEST_IMG" -drive if=3Dnone,file=3D"$TEST_IMG.2" = -global floppy.drive=3Dnone0 =20 echo echo @@ -192,12 +193,16 @@ check_floppy_qtree -drive if=3Dnone,file=3D"$TEST_IMG= " -drive if=3Dnone,file=3D"$TEST_IM -global isa-fdc.driveB=3Dnone0 -device floppy,drive=3Dn= one1 check_floppy_qtree -drive if=3Dnone,file=3D"$TEST_IMG" -drive if=3Dnone,fi= le=3D"$TEST_IMG.2" \ -global isa-fdc.driveB=3Dnone0 -device floppy,drive=3Dn= one1,unit=3D0 +check_floppy_qtree -drive if=3Dnone,file=3D"$TEST_IMG" \ + -global floppy.drive=3Dnone0 -device floppy,unit=3D0 =20 # Conflicting check_floppy_qtree -drive if=3Dnone,file=3D"$TEST_IMG" -drive if=3Dnone,fi= le=3D"$TEST_IMG.2" \ -global isa-fdc.driveA=3Dnone0 -device floppy,drive=3Dn= one1,unit=3D0 check_floppy_qtree -drive if=3Dnone,file=3D"$TEST_IMG" -drive if=3Dnone,fi= le=3D"$TEST_IMG.2" \ -global isa-fdc.driveB=3Dnone0 -device floppy,drive=3Dn= one1,unit=3D1 +check_floppy_qtree -drive if=3Dnone,file=3D"$TEST_IMG" -drive if=3Dnone,fi= le=3D"$TEST_IMG.2" \ + -global floppy.drive=3Dnone0 -device floppy,drive=3Dnon= e1,unit=3D0 =20 echo echo @@ -205,8 +210,10 @@ echo =3D=3D=3D Attempt to use drive twice =3D=3D=3D =20 # if=3Dnone check_floppy_qtree -drive if=3Dnone -device floppy,drive=3Dnone0 -device f= loppy -device floppy,drive=3Dnone0 +check_floppy_qtree -drive if=3Dnone -global floppy.drive=3Dnone0 -device f= loppy -device floppy # if=3Dfloppy check_floppy_qtree -fda "" -device floppy,drive=3Dfloppy0 +check_floppy_qtree -fda "" -global floppy.drive=3Dfloppy0 # default if=3Dfloppy (not found, because it's created later) check_floppy_qtree -device floppy,drive=3Dfloppy0 =20 diff --git a/tests/qemu-iotests/172.out b/tests/qemu-iotests/172.out index 23c44210e8..345e27c294 100644 --- a/tests/qemu-iotests/172.out +++ b/tests/qemu-iotests/172.out @@ -860,6 +860,50 @@ sd0: [not inserted] (qemu) quit =20 =20 +Testing: -fda TEST_DIR/t.qcow2 -drive if=3Dnone,file=3DTEST_DIR/t.qcow2.2 = -global floppy.drive=3Dnone0 + + dev: isa-fdc, id "" + iobase =3D 1008 (0x3f0) + irq =3D 6 (0x6) + dma =3D 2 (0x2) + driveA =3D "" + driveB =3D "" + check_media_rate =3D true + fdtypeA =3D "auto" + fdtypeB =3D "auto" + fallback =3D "288" + isa irq 6 + bus: floppy-bus.0 + type floppy-bus + dev: floppy, id "" + unit =3D 0 (0x0) + drive =3D "floppy0" + logical_block_size =3D 512 (0x200) + physical_block_size =3D 512 (0x200) + min_io_size =3D 0 (0x0) + opt_io_size =3D 0 (0x0) + discard_granularity =3D 4294967295 (0xffffffff) + write-cache =3D "auto" + share-rw =3D false + drive-type =3D "144" +floppy0 (NODE_NAME): TEST_DIR/t.qcow2 (qcow2) + Attached to: /machine/unattached/device[15] + Removable device: not locked, tray closed + Cache mode: writeback + +none0 (NODE_NAME): TEST_DIR/t.qcow2.2 (qcow2) + Attached to: /machine/unattached/device[15] + Cache mode: writeback + +ide1-cd0: [not inserted] + Attached to: /machine/unattached/device[22] + Removable device: not locked, tray closed + +sd0: [not inserted] + Removable device: not locked, tray closed +(qemu) quit + + =20 =3D=3D=3D Mixing -fdX and -device =3D=3D=3D =20 @@ -1438,21 +1482,111 @@ sd0: [not inserted] (qemu) quit =20 =20 +Testing: -drive if=3Dnone,file=3DTEST_DIR/t.qcow2 -global floppy.drive=3Dn= one0 -device floppy,unit=3D0 + + dev: isa-fdc, id "" + iobase =3D 1008 (0x3f0) + irq =3D 6 (0x6) + dma =3D 2 (0x2) + driveA =3D "" + driveB =3D "" + check_media_rate =3D true + fdtypeA =3D "auto" + fdtypeB =3D "auto" + fallback =3D "288" + isa irq 6 + bus: floppy-bus.0 + type floppy-bus + dev: floppy, id "" + unit =3D 0 (0x0) + drive =3D "none0" + logical_block_size =3D 512 (0x200) + physical_block_size =3D 512 (0x200) + min_io_size =3D 0 (0x0) + opt_io_size =3D 0 (0x0) + discard_granularity =3D 4294967295 (0xffffffff) + write-cache =3D "auto" + share-rw =3D false + drive-type =3D "144" +none0 (NODE_NAME): TEST_DIR/t.qcow2 (qcow2) + Attached to: /machine/peripheral-anon/device[0] + Removable device: not locked, tray closed + Cache mode: writeback + +ide1-cd0: [not inserted] + Attached to: /machine/unattached/device[21] + Removable device: not locked, tray closed + +sd0: [not inserted] + Removable device: not locked, tray closed +(qemu) quit + + Testing: -drive if=3Dnone,file=3DTEST_DIR/t.qcow2 -drive if=3Dnone,file=3D= TEST_DIR/t.qcow2.2 -global isa-fdc.driveA=3Dnone0 -device floppy,drive=3Dno= ne1,unit=3D0 QEMU_PROG: -device floppy,drive=3Dnone1,unit=3D0: Floppy unit 0 is in use =20 Testing: -drive if=3Dnone,file=3DTEST_DIR/t.qcow2 -drive if=3Dnone,file=3D= TEST_DIR/t.qcow2.2 -global isa-fdc.driveB=3Dnone0 -device floppy,drive=3Dno= ne1,unit=3D1 QEMU_PROG: -device floppy,drive=3Dnone1,unit=3D1: Floppy unit 1 is in use =20 +Testing: -drive if=3Dnone,file=3DTEST_DIR/t.qcow2 -drive if=3Dnone,file=3D= TEST_DIR/t.qcow2.2 -global floppy.drive=3Dnone0 -device floppy,drive=3Dnone= 1,unit=3D0 + + dev: isa-fdc, id "" + iobase =3D 1008 (0x3f0) + irq =3D 6 (0x6) + dma =3D 2 (0x2) + driveA =3D "" + driveB =3D "" + check_media_rate =3D true + fdtypeA =3D "auto" + fdtypeB =3D "auto" + fallback =3D "288" + isa irq 6 + bus: floppy-bus.0 + type floppy-bus + dev: floppy, id "" + unit =3D 0 (0x0) + drive =3D "none1" + logical_block_size =3D 512 (0x200) + physical_block_size =3D 512 (0x200) + min_io_size =3D 0 (0x0) + opt_io_size =3D 0 (0x0) + discard_granularity =3D 4294967295 (0xffffffff) + write-cache =3D "auto" + share-rw =3D false + drive-type =3D "144" +none0 (NODE_NAME): TEST_DIR/t.qcow2 (qcow2) + Attached to: /machine/peripheral-anon/device[0] + Cache mode: writeback + +none1 (NODE_NAME): TEST_DIR/t.qcow2.2 (qcow2) + Attached to: /machine/peripheral-anon/device[0] + Removable device: not locked, tray closed + Cache mode: writeback + +ide1-cd0: [not inserted] + Attached to: /machine/unattached/device[21] + Removable device: not locked, tray closed + +sd0: [not inserted] + Removable device: not locked, tray closed +(qemu) quit + + =20 =3D=3D=3D Attempt to use drive twice =3D=3D=3D =20 Testing: -drive if=3Dnone -device floppy,drive=3Dnone0 -device floppy -dev= ice floppy,drive=3Dnone0 QEMU_PROG: -device floppy,drive=3Dnone0: Drive 'none0' is already in use b= y another device =20 +Testing: -drive if=3Dnone -global floppy.drive=3Dnone0 -device floppy -dev= ice floppy +QEMU_PROG: -device floppy: can't apply global floppy.drive=3Dnone0: Drive = 'none0' is already in use by another device + Testing: -fda -device floppy,drive=3Dfloppy0 QEMU_PROG: -device floppy,drive=3Dfloppy0: Drive 'floppy0' is already in u= se because it has been automatically connected to another device (did you n= eed 'if=3Dnone' in the drive options?) =20 +Testing: -fda -global floppy.drive=3Dfloppy0 +QEMU_PROG: can't apply global floppy.drive=3Dfloppy0: Drive 'floppy0' is a= lready in use because it has been automatically connected to another device= (did you need 'if=3Dnone' in the drive options?) + Testing: -device floppy,drive=3Dfloppy0 QEMU_PROG: -device floppy,drive=3Dfloppy0: Property 'floppy.drive' can't f= ind value 'floppy0' =20 --=20 2.26.2