From nobody Tue Feb 10 19:17:33 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1591171859; cv=none; d=zohomail.com; s=zohoarc; b=RaZ5Hqo7ucjSqWrVh6ncgpT4Jwe8q/sTyiQCeSvvyh2u2/tqG8c/BposCXHWAU2g5t/WoovlgXLo38p5khRHOI6sRf0dXyZVDVOnGn+qbciaK8reuTkfY38bs6CJwtwMzVnsG4GTTM3OdwYVEF7l7Iw4xk2ie1xjS4GA9BrBZBg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1591171859; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=lUWgMiRGbhGx0Yw80HHkEExMzM2CQBYD/MwfcXzfRFI=; b=GhGnjXzH1UVfPEL/cxlR4wa6j4/kokUkNjoLOunsbF69/Thu1O93BWYt3pNYqrNDED4wbZ5FCme9koBwmm6U/RWMb+5qKMHvwf2old84nIl+3uZOWJtkZ+xEgzNWyvmuXUBD/DRBeadAKHHky4AF86bzR1Z2TCWf+eTD0tMGfBQ= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1591171859738460.77026917689057; Wed, 3 Jun 2020 01:10:59 -0700 (PDT) Received: from localhost ([::1]:45624 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jgOUE-0002H7-B5 for importer@patchew.org; Wed, 03 Jun 2020 04:10:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39544) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jgOTC-0000YT-Mx for qemu-devel@nongnu.org; Wed, 03 Jun 2020 04:09:54 -0400 Received: from cmccmta1.chinamobile.com ([221.176.66.79]:3996) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jgOT9-0000Di-Lf for qemu-devel@nongnu.org; Wed, 03 Jun 2020 04:09:54 -0400 Received: from spf.mail.chinamobile.com (unknown[172.16.121.15]) by rmmx-syy-dmz-app01-12001 (RichMail) with SMTP id 2ee15ed75ab46aa-8ad9d; Wed, 03 Jun 2020 16:09:25 +0800 (CST) Received: from localhost.localdomain (unknown[112.25.154.146]) by rmsmtp-syy-appsvr08-12008 (RichMail) with SMTP id 2ee85ed75aae43e-61021; Wed, 03 Jun 2020 16:09:25 +0800 (CST) X-RM-TRANSID: 2ee15ed75ab46aa-8ad9d X-RM-TagInfo: emlType=0 X-RM-SPAM-FLAG: 00000000 X-RM-TRANSID: 2ee85ed75aae43e-61021 From: Mao Zhongyi To: qemu-devel@nongnu.org Subject: [PATCH 5/9] monitor/hmp-cmds: delete redundant Error check before invoke hmp_handle_error() Date: Wed, 3 Jun 2020 16:09:00 +0800 Message-Id: <20200603080904.997083-6-maozhongyi@cmss.chinamobile.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200603080904.997083-1-maozhongyi@cmss.chinamobile.com> References: <20200603080904.997083-1-maozhongyi@cmss.chinamobile.com> Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=221.176.66.79; envelope-from=maozhongyi@cmss.chinamobile.com; helo=cmccmta1.chinamobile.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/03 04:09:40 X-ACL-Warn: Detected OS = Linux 3.1-3.10 [fuzzy] X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mao Zhongyi Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" hmp_handle_error() does Error check internally. Signed-off-by: Mao Zhongyi Reviewed-by: Dr. David Alan Gilbert --- monitor/hmp-cmds.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c index 6938f1060e..acdd6baff3 100644 --- a/monitor/hmp-cmds.c +++ b/monitor/hmp-cmds.c @@ -1636,9 +1636,8 @@ void hmp_object_add(Monitor *mon, const QDict *qdict) obj =3D user_creatable_add_opts(opts, &err); qemu_opts_del(opts); =20 - if (err) { - hmp_handle_error(mon, err); - } + hmp_handle_error(mon, err); + if (obj) { object_unref(obj); } --=20 2.17.1