From nobody Tue Feb 10 18:55:55 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1591171860; cv=none; d=zohomail.com; s=zohoarc; b=KlJ93Kr6Lx0NChZuEQlvdLgBErETP+ixVa6k735rfokLXCdWai3zzrV3OxVAiVTM9uEkrBSr1cHWoCnV6J3gc94XevExxaYuBOpy4ThS6KSgfu6DaCG5mtMbqDBE58e+fWgMhEt6wncWKcGuqe/2NILz8C1KMe9MZKuZh/oKhMM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1591171860; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=V/XUB3ocffzui7sLak63H6I3JsY6B55oPHpnoN9QnRA=; b=FATseKGbfPx4vi7wpw284Ktz8/NKYRdAqWWnh2cCwn2KvkGT0+IGl34aSA6ZceAHKmjROedLBUQuK5wkvPB2vFXwAFv93HXS4UObMu8ET64BJMDyVRM+RNMitY/XvY+2/T8P0j1b9p8zJ33M6rDAlyrX0p6eT9oONjHVvlGDWBk= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1591171859904338.3980928229274; Wed, 3 Jun 2020 01:10:59 -0700 (PDT) Received: from localhost ([::1]:45608 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jgOUE-0002Gk-H8 for importer@patchew.org; Wed, 03 Jun 2020 04:10:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39538) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jgOTC-0000YD-2k for qemu-devel@nongnu.org; Wed, 03 Jun 2020 04:09:54 -0400 Received: from cmccmta2.chinamobile.com ([221.176.66.80]:13034) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jgOT8-0000Db-Mq for qemu-devel@nongnu.org; Wed, 03 Jun 2020 04:09:53 -0400 Received: from spf.mail.chinamobile.com (unknown[172.16.121.15]) by rmmx-syy-dmz-app08-12008 (RichMail) with SMTP id 2ee85ed75ab4862-8b2aa; Wed, 03 Jun 2020 16:09:25 +0800 (CST) Received: from localhost.localdomain (unknown[112.25.154.146]) by rmsmtp-syy-appsvr08-12008 (RichMail) with SMTP id 2ee85ed75aae43e-6101d; Wed, 03 Jun 2020 16:09:24 +0800 (CST) X-RM-TRANSID: 2ee85ed75ab4862-8b2aa X-RM-TagInfo: emlType=0 X-RM-SPAM-FLAG: 00000000 X-RM-TRANSID: 2ee85ed75aae43e-6101d From: Mao Zhongyi To: qemu-devel@nongnu.org Subject: [PATCH 4/9] monitor/hmp-cmds: don't silently output when running 'migrate_set_downtime' fails Date: Wed, 3 Jun 2020 16:08:59 +0800 Message-Id: <20200603080904.997083-5-maozhongyi@cmss.chinamobile.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200603080904.997083-1-maozhongyi@cmss.chinamobile.com> References: <20200603080904.997083-1-maozhongyi@cmss.chinamobile.com> Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=221.176.66.80; envelope-from=maozhongyi@cmss.chinamobile.com; helo=cmccmta2.chinamobile.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/03 04:09:39 X-ACL-Warn: Detected OS = Linux 3.1-3.10 [fuzzy] X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mao Zhongyi Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Although 'migrate_set_downtime' has been deprecated and replaced with 'migrate_set_parameter downtime_limit', it has not been completely eliminated, possibly due to compatibility with older versions. I think as long as this old parameter is running, we should report appropriate message when something goes wrong, not be silent. before: (qemu) migrate_set_downtime -1 (qemu) after: (qemu) migrate_set_downtime -1 Error: Parameter 'downtime_limit' expects an integer in the range of 0 to 2= 000 seconds Signed-off-by: Mao Zhongyi Reviewed-by: Dr. David Alan Gilbert --- monitor/hmp-cmds.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c index 8c3e436b39..6938f1060e 100644 --- a/monitor/hmp-cmds.c +++ b/monitor/hmp-cmds.c @@ -1188,8 +1188,11 @@ void hmp_migrate_pause(Monitor *mon, const QDict *qd= ict) /* Kept for backwards compatibility */ void hmp_migrate_set_downtime(Monitor *mon, const QDict *qdict) { + Error *err =3D NULL; + double value =3D qdict_get_double(qdict, "value"); - qmp_migrate_set_downtime(value, NULL); + qmp_migrate_set_downtime(value, &err); + hmp_handle_error(mon, err); } =20 void hmp_migrate_set_cache_size(Monitor *mon, const QDict *qdict) --=20 2.17.1