From nobody Sun Feb 8 18:31:09 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1591004334; cv=none; d=zohomail.com; s=zohoarc; b=VwDJR2HHPQ8nAWvjQHburhYSVPjMfanxSi6d2APadXgpMQFaNj1KE43ZB6jYUSQFfJgij0Q0aPDgyGuoLwdB5m7Z2ub/ckEMUrNjclhH/rRgiXHJLNum3lK5rOl5bDIgFUML28qKDd7fvNc8Tq6KVRdmYCTSFdPrS3ZIX2tEUjY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1591004334; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=A6IuMVBo3w0VRUGSdpAL1rExyTTAdFr6jjDb7IBj4CA=; b=AeJCyp+69aeStjzX6UZTCDzpZR8emFZItMTqM1pnr11/rOiqloHrPHflcEW4NI8tkQ00znUUxE8jKML6lZOoEpNZbetI1AMRLosDxN+5rPN8gEr53sBaQxfy/558VzNNwoxC3lwFK3jk8vhdM1zpChrC5ysyqnblSr8LixY8KT0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1591004334708473.6703465346311; Mon, 1 Jun 2020 02:38:54 -0700 (PDT) Received: from localhost ([::1]:43028 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jfguD-0005P4-HP for importer@patchew.org; Mon, 01 Jun 2020 05:38:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59998) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jfgtc-0004xc-K5 for qemu-devel@nongnu.org; Mon, 01 Jun 2020 05:38:16 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:24275 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jfgtb-0007S0-Lq for qemu-devel@nongnu.org; Mon, 01 Jun 2020 05:38:16 -0400 Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-288-KVeX3DGHMCuURFhkW2EXjA-1; Mon, 01 Jun 2020 05:38:11 -0400 Received: by mail-wr1-f69.google.com with SMTP id n6so4675055wrv.6 for ; Mon, 01 Jun 2020 02:38:11 -0700 (PDT) Received: from localhost.localdomain (43.red-83-51-162.dynamicip.rima-tde.net. [83.51.162.43]) by smtp.gmail.com with ESMTPSA id z132sm13020375wmc.29.2020.06.01.02.38.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jun 2020 02:38:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591004295; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=A6IuMVBo3w0VRUGSdpAL1rExyTTAdFr6jjDb7IBj4CA=; b=Wt+JgJ0cROSHJ89sMxqiRXgGmKx4t+WRWL6MO0yLz7zEGbT0Vsq5Wn7OiCcVpnIEczwOM2 HEbkrB7GC4xwjQche863/MRSp0XWzMC9zCJ8zRMtFUE3RI7tF5YzcY6pVGHRpJu/cMNyjN K1cQ2eZY9ZSVlDUnZkYVCQ8kiXiMn40= X-MC-Unique: KVeX3DGHMCuURFhkW2EXjA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=A6IuMVBo3w0VRUGSdpAL1rExyTTAdFr6jjDb7IBj4CA=; b=Gryl0EPAqG0BhBtUyFtc/IaDzBuhZGWI07PMBMMAyGOzYhLrN/22W0EmvVaiAVjy9W 6Sm8p5ngU6TzMktB1YEkZckxU+QEmI0JN5K107/p/5uvmwEdSTLioH0F5nhf00oIXVj6 FDNctiXxefQ36d4PKg99Jtkev01Xmgt3sN6d912WDLAMKjjL0mhVIq206PnytjCOWWA0 ELvN1ajL1fskmyqQIOxSrK/YXgQRFQnL0kP8/+9HDg0FZIgVBo7q67qEErJUFIokxdH2 tHvQ913Q6dBzS8ZDVELcljuLH4cEOX9qy9MfWAXEceODi/xNIhNdiw8LuG0RgeqCPCB8 3IIg== X-Gm-Message-State: AOAM533mQuGhQfJa7KkenpLg0SIxF55MG4Np979cIem2jpV6zNKXiZCh Gtv3LE4UhhPhInvJBdDWJGf8Z0JkqHH5rlvk5n8E1AxQol78V96jUlU/YG7cL8G9qleHC/WMJqy PTjJwXW8BGgzeCdg= X-Received: by 2002:adf:ec03:: with SMTP id x3mr21025452wrn.297.1591004290231; Mon, 01 Jun 2020 02:38:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwm5iK+NWZaCD7/vg4ESVQf5wukLhK2K6zrbITsXuHe0e2Tbz5zoIcXjdBgWMTHQEpFTkT41w== X-Received: by 2002:adf:ec03:: with SMTP id x3mr21025442wrn.297.1591004290036; Mon, 01 Jun 2020 02:38:10 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [RFC PATCH] qemu/thread: Mark qemu_thread_exit() with 'noreturn' attribute Date: Mon, 1 Jun 2020 11:38:08 +0200 Message-Id: <20200601093808.13102-1-philmd@redhat.com> X-Mailer: git-send-email 2.21.3 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8"; text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.139.110.120; envelope-from=philmd@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/01 05:35:47 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) After upgrading to Ubuntu 20.04 LTS, GCC 9.3 complains: util/qemu-thread-posix.c: In function =E2=80=98qemu_thread_exit=E2=80=99: util/qemu-thread-posix.c:577:6: error: function might be candidate for at= tribute =E2=80=98noreturn=E2=80=99 [-Werror=3Dsuggest-attribute=3Dnoreturn] 577 | void qemu_thread_exit(void *retval) | ^~~~~~~~~~~~~~~~ Fix by marking the qemu_thread_exit function with QEMU_NORETURN to set the 'noreturn' attribute. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- RFC because I'm not sure the error is correct, or we should simply ignore it by default with -Wno-suggest-attribute=3Dnoreturn. --- include/qemu/thread.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/qemu/thread.h b/include/qemu/thread.h index d22848138e..06c058fb58 100644 --- a/include/qemu/thread.h +++ b/include/qemu/thread.h @@ -177,7 +177,7 @@ void qemu_thread_create(QemuThread *thread, const char = *name, void *qemu_thread_join(QemuThread *thread); void qemu_thread_get_self(QemuThread *thread); bool qemu_thread_is_self(QemuThread *thread); -void qemu_thread_exit(void *retval); +void qemu_thread_exit(void *retval) QEMU_NORETURN; void qemu_thread_naming(bool enable); =20 struct Notifier; --=20 2.21.3