From nobody Mon Feb 9 07:05:35 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1590673448; cv=none; d=zohomail.com; s=zohoarc; b=lHRrC1mBdfjNaX/jdLuO2yxm+rTrP6KC1+3TgsDTqEsq99hEmQBgqosKH/goZrr0Fo6gjOhaCKvx4QoAv/UjSzr1A8lBwKPibO+koE6mACqHWJ1xTbHlUmC2s3WRU72CQF2KOByrHDlEQuh/g30vz7SKmVbeKbiqEAn4mRvnpu4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1590673448; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=e05g/is/lgsNSL/Pq60mo/ih+dnu1o1RQCp9fSYeJCw=; b=Ti+dJkOXs+EsApctdzpZhjQMC9fwO1F2El8HYN1D7G5Akp/gnBzD8X0P6JQC67ejrUqrjOs8RNCj2ApWJTZAQ26hb9Y75RhqWoYD0flf5rFsi81aNVtZaeQAFHk+dgURU0yoz+F66yqeH7BgJQxkT0DBFB5+8ymMCMoWeY5lagk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1590673448165301.3706762312215; Thu, 28 May 2020 06:44:08 -0700 (PDT) Received: from localhost ([::1]:56838 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jeIpK-0007VU-Ve for importer@patchew.org; Thu, 28 May 2020 09:44:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44060) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jeImG-00037i-0J for qemu-devel@nongnu.org; Thu, 28 May 2020 09:40:56 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:49094 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jeImF-0007vG-7x for qemu-devel@nongnu.org; Thu, 28 May 2020 09:40:55 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-149-wQedq-9dOJikGgPN3La3fA-1; Thu, 28 May 2020 09:40:46 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 16386107ACCA; Thu, 28 May 2020 13:40:45 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-113-50.ams2.redhat.com [10.36.113.50]) by smtp.corp.redhat.com (Postfix) with ESMTP id CB9A15D9EF; Thu, 28 May 2020 13:40:36 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 8FA189DAE; Thu, 28 May 2020 15:40:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1590673250; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:content-type:content-type:in-reply-to:in-reply-to: references:references; bh=e05g/is/lgsNSL/Pq60mo/ih+dnu1o1RQCp9fSYeJCw=; b=TtVO0tirPAiCstH30qJcyfPN4jRePoWfFuV3z841xOR95lakrvNWQeHcEaKkKUcnvAWFNY EmwVEbqDpdaLnoxzec53ttsOXl1P+tW6vggiLVB9/bJa2eM2+lvVl1dMd64C4jwoXCtCOo wFE68eSzdOACiVjrCVt9WojiXedLfzk= X-MC-Unique: wQedq-9dOJikGgPN3La3fA-1 From: Gerd Hoffmann To: qemu-devel@nongnu.org Subject: [PATCH v2 2/4] microvm: drop max-ram-below-4g support Date: Thu, 28 May 2020 15:40:33 +0200 Message-Id: <20200528134035.32025-3-kraxel@redhat.com> In-Reply-To: <20200528134035.32025-1-kraxel@redhat.com> References: <20200528134035.32025-1-kraxel@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=207.211.31.81; envelope-from=kraxel@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/28 02:50:32 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eduardo Habkost , Sergio Lopez , "Michael S. Tsirkin" , Gerd Hoffmann , Paolo Bonzini , imammedo@redhat.com, philmd@redhat.com, Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Not useful for microvm and allows users to shoot themself into the foot (make ram + mmio overlap). Signed-off-by: Gerd Hoffmann Reviewed-by: Igor Mammedov Acked-by: Paolo Bonzini Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/i386/microvm.c | 19 ------------------- 1 file changed, 19 deletions(-) diff --git a/hw/i386/microvm.c b/hw/i386/microvm.c index 44f940813b07..5e931975a06d 100644 --- a/hw/i386/microvm.c +++ b/hw/i386/microvm.c @@ -173,25 +173,6 @@ static void microvm_memory_init(MicrovmMachineState *m= ms) ram_addr_t lowmem =3D 0xc0000000; /* 3G */ int i; =20 - /* - * Handle the machine opt max-ram-below-4g. It is basically doing - * min(qemu limit, user limit). - */ - if (!x86ms->max_ram_below_4g) { - x86ms->max_ram_below_4g =3D 4 * GiB; - } - if (lowmem > x86ms->max_ram_below_4g) { - lowmem =3D x86ms->max_ram_below_4g; - if (machine->ram_size - lowmem > lowmem && - lowmem & (1 * GiB - 1)) { - warn_report("There is possibly poor performance as the ram siz= e " - " (0x%" PRIx64 ") is more then twice the size of" - " max-ram-below-4g (%"PRIu64") and" - " max-ram-below-4g is not a multiple of 1G.", - (uint64_t)machine->ram_size, x86ms->max_ram_below_= 4g); - } - } - if (machine->ram_size > lowmem) { x86ms->above_4g_mem_size =3D machine->ram_size - lowmem; x86ms->below_4g_mem_size =3D lowmem; --=20 2.18.4