From nobody Mon Feb 9 10:48:09 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1590669926; cv=none; d=zohomail.com; s=zohoarc; b=WKwV0fyoVrSODZj2wLif+21aKnlf1BgGo7vvwJzQoz4uWlAVUgtUVA/NpCma2X/O0I3sUlhVsZXBJPC0sWArRlb/yXr+4HsMXAk0JTCLJdV/t8iUpCgvOZleFkkNbOKyLa5JyJ4VcUzYzmtx/eRgScfD3dX5jLT0RJWPmL1bFGk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1590669926; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=O28inHDVpVZDhPHiuyyYR/itAk5vSTfRey6DnLy0yh4=; b=TCstDHwskA9yX123wIK7lAt0sNc3wKKRvOy3UJYkkuPPqUbS++JRBH8A+2PbHs15Rmz9KerqWDt4igNrq2kmX/jq9eLyLLcqN36H61ZG0y7tSHQT3jo71rUPd2woyaB58oH14F4xzjAKL4xJzJuFSkUNEzNm2cUPCMkwg97MFX0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1590669926491359.6695502107485; Thu, 28 May 2020 05:45:26 -0700 (PDT) Received: from localhost ([::1]:46350 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jeHuX-0003ka-8M for importer@patchew.org; Thu, 28 May 2020 08:45:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33782) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jeHmC-0002WW-Vr for qemu-devel@nongnu.org; Thu, 28 May 2020 08:36:49 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:29057 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jeHmC-0005P4-4g for qemu-devel@nongnu.org; Thu, 28 May 2020 08:36:48 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-405-agnOQl7SOzCNxWJBmamIUQ-1; Thu, 28 May 2020 08:36:18 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C8B6E8005AA; Thu, 28 May 2020 12:36:16 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-113-50.ams2.redhat.com [10.36.113.50]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2BFBF5C1C8; Thu, 28 May 2020 12:36:13 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 606A19DAD; Thu, 28 May 2020 14:36:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1590669407; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=O28inHDVpVZDhPHiuyyYR/itAk5vSTfRey6DnLy0yh4=; b=E8NaT+hUItrs1yZqDLNS4YXuxG22wibDOJh6B1sHM56TuFdbbreuai1zQABJT9CQFc5x29 qIti6sBPr1TTVgiOi7hcnrklKUgpyjIBPxniRwJsDHil2zUvKccoYo4DMqzUwHKYE4QpdU p9LAV45ji/02RjjDnIC+7q0Jp/ITUv4= X-MC-Unique: agnOQl7SOzCNxWJBmamIUQ-1 From: Gerd Hoffmann To: qemu-devel@nongnu.org Subject: [PULL 01/21] hw/display/edid: Add missing 'qdev-properties.h' header Date: Thu, 28 May 2020 14:35:49 +0200 Message-Id: <20200528123609.27362-2-kraxel@redhat.com> In-Reply-To: <20200528123609.27362-1-kraxel@redhat.com> References: <20200528123609.27362-1-kraxel@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=207.211.31.81; envelope-from=kraxel@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/28 02:50:32 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Igor Mitsyanko , Alistair Francis , Mark Cave-Ayland , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-arm@nongnu.org, qemu-ppc@nongnu.org, Gerd Hoffmann , "Edgar E. Iglesias" Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) From: Philippe Mathieu-Daud=C3=A9 When trying to consume the DEFINE_EDID_PROPERTIES() macro by including "hw/display/edid.h", we get this build failure: include/hw/display/edid.h:24:5: error: implicit declaration of function =E2=80=98DEFINE_PROP_UINT32=E2=80=99 [-Werror=3Dimplicit-functio= n-declaration] 24 | DEFINE_PROP_UINT32("xres", _state, _edid_info.prefx, 0), \ | ^~~~~~~~~~~~~~~~~~ Headers should be self-contained, and one shouldn't have to dig to find the missing headers. In this case "hw/qdev-properties.h" is missing. Add it. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alistair Francis Message-id: 20200526062252.19852-2-f4bug@amsat.org Signed-off-by: Gerd Hoffmann --- include/hw/display/edid.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/hw/display/edid.h b/include/hw/display/edid.h index ff99dc0a052b..23371ee82c63 100644 --- a/include/hw/display/edid.h +++ b/include/hw/display/edid.h @@ -2,6 +2,7 @@ #define EDID_H =20 #include "qom/object.h" +#include "hw/qdev-properties.h" =20 typedef struct qemu_edid_info { const char *vendor; /* http://www.uefi.org/pnp_id_list */ --=20 2.18.4