From nobody Fri Nov 14 21:41:12 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1590664184; cv=none; d=zohomail.com; s=zohoarc; b=libh7XUqx0buVa+zc7X1uYWxLTCKBisOvOUuoFepcNNOyT5EGNfpWzIiMlO7UHLLW3QE7jFfZKPlmylGPLtBNomfJsiXJcZvJKFP8QQW6J1m/Z36O6Bbko88bsbrB3dIpKYmuP6EOPQcKfIbUVbG18HMUvLatx06Nrv3FPyVDKI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1590664184; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Bfy+Oh8nlUt028pTCxJbbHy0rLw3m3T63uQUxAuRSvM=; b=H/D5feo9/wex7qEah4CujG2iQECqu3rWF98qKFF7cZ6M3Cv6KqdfpbpqwxHblbAcJI0fluLsx1kz7eia2N5me/QWkGHcs9dIuS8D0k0PT2nYMrgmbwi9NbDEO3pc3xlS5gOAb1qXxVHCdAT+Z3Yvp1HDkJB3sd8FjWjGY01I4C4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 159066418475848.11447523247671; Thu, 28 May 2020 04:09:44 -0700 (PDT) Received: from localhost ([::1]:49624 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jeGPv-0007FI-I6 for importer@patchew.org; Thu, 28 May 2020 07:09:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49836) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jeGLJ-0005nx-S2 for qemu-devel@nongnu.org; Thu, 28 May 2020 07:04:59 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:21756 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jeGLE-0006hC-Og for qemu-devel@nongnu.org; Thu, 28 May 2020 07:04:57 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-113-ra6mxHWPO3qs9n-Rjisggg-1; Thu, 28 May 2020 07:04:50 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 571051005512; Thu, 28 May 2020 11:04:49 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-112-32.ams2.redhat.com [10.36.112.32]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 259C35D9EF; Thu, 28 May 2020 11:04:49 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 0B85B11358CB; Thu, 28 May 2020 13:04:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1590663892; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Bfy+Oh8nlUt028pTCxJbbHy0rLw3m3T63uQUxAuRSvM=; b=hMSlqtQvpM3h6knP+FYDmFBpQ55GlVr2l5O1wyajgh8pJ4NSNI3Aq6yjoBaA94LYqtvQgM 2ex8j7EIIBNwfjW5EJ/Xzoo0tZAudmLxjJR3YTua4nRgEA0Ew4/MwYA9g35dlUJW357Kjy Byo1129h/t+hbicWEVWtwqVLQVvmNno= X-MC-Unique: ra6mxHWPO3qs9n-Rjisggg-1 From: Markus Armbruster To: qemu-devel@nongnu.org Subject: [PATCH v2 16/24] ppc/pnv: Put "*-pnv-chip" and "pnv-xive" on the main system bus Date: Thu, 28 May 2020 13:04:36 +0200 Message-Id: <20200528110444.20456-17-armbru@redhat.com> In-Reply-To: <20200528110444.20456-1-armbru@redhat.com> References: <20200528110444.20456-1-armbru@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=207.211.31.120; envelope-from=armbru@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/28 03:11:04 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: berrange@redhat.com, ehabkost@redhat.com, qemu-ppc@nongnu.org, =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , pbonzini@redhat.com, David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) pnv_init() creates "power10_v1.0-pnv-chip", "power8_v2.0-pnv-chip", "power8e_v2.1-pnv-chip", "power8nvl_v1.0-pnv-chip", or "power9_v2.0-pnv-chip" sysbus devices in a way that leaves them unplugged. pnv_chip_power9_instance_init() creates a "pnv-xive" sysbus device in a way that leaves it unplugged. Create them the common way that puts them into the main system bus. Affects machines powernv8, powernv9, and powernv10. Visible in "info qtree". Here's the change for powernv9: bus: main-system-bus type System + dev: power9_v2.0-pnv-chip, id "" + chip-id =3D 0 (0x0) + ram-start =3D 0 (0x0) + ram-size =3D 1879048192 (0x70000000) + nr-cores =3D 1 (0x1) + cores-mask =3D 72057594037927935 (0xffffffffffffff) + nr-threads =3D 1 (0x1) + num-phbs =3D 6 (0x6) + mmio 000603fc00000000/0000000400000000 [...] + dev: pnv-xive, id "" + ic-bar =3D 1692157036462080 (0x6030203100000) + vc-bar =3D 1689949371891712 (0x6010000000000) + pc-bar =3D 1690499127705600 (0x6018000000000) + tm-bar =3D 1692157036986368 (0x6030203180000) Cc: "C=C3=A9dric Le Goater" Cc: David Gibson Cc: qemu-ppc@nongnu.org Signed-off-by: Markus Armbruster Reviewed-by: C=C3=A9dric Le Goater --- hw/ppc/pnv.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c index da637822f9..8d4fc8109a 100644 --- a/hw/ppc/pnv.c +++ b/hw/ppc/pnv.c @@ -818,7 +818,7 @@ static void pnv_init(MachineState *machine) pnv->chips =3D g_new0(PnvChip *, pnv->num_chips); for (i =3D 0; i < pnv->num_chips; i++) { char chip_name[32]; - Object *chip =3D object_new(chip_typename); + Object *chip =3D OBJECT(qdev_create(NULL, chip_typename)); =20 pnv->chips[i] =3D PNV_CHIP(chip); =20 @@ -1317,8 +1317,8 @@ static void pnv_chip_power9_instance_init(Object *obj) PnvChipClass *pcc =3D PNV_CHIP_GET_CLASS(obj); int i; =20 - object_initialize_child(obj, "xive", &chip9->xive, sizeof(chip9->xive), - TYPE_PNV_XIVE, &error_abort, NULL); + sysbus_init_child_obj(obj, "xive", &chip9->xive, sizeof(chip9->xive), + TYPE_PNV_XIVE); object_property_add_alias(obj, "xive-fabric", OBJECT(&chip9->xive), "xive-fabric"); =20 --=20 2.21.3