From nobody Mon Feb 9 05:46:02 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) client-ip=205.139.110.61; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=amsat.org ARC-Seal: i=1; a=rsa-sha256; t=1590500012; cv=none; d=zohomail.com; s=zohoarc; b=fvycl/2JL00llDa/R5YNG5ZtLX0VHqBwCXHV/YfyPkYlq7k/wwpOI1RNiytQ/ZnOfFIyl+PjjW49ykBnma2ZnO98f5Hs8WBj0E7ElpQIaVudxcIW4vDReh5Iv95pDTt7WHuH9HJ23R3eK9Tz6KSTVFggWgUlIgTc9BdnV8Xs6Xk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1590500012; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=45UgqB7xiuv75to9D1xtOkBXTGrFM8LHRPwW44N+AXY=; b=TmaZreFlFIlLVbdcDFNeLUjXK0eq15pmMXbtzeGzd1bGYFb3kre4NnLFX5Tn+gfSiMW+XkCMkauIJeM2RlJGnH72DRJgDpejTpTiTzb23l3LAVlP6V05FRhwdOOd1qyJu3APYYBqFUfHvzLH/9c+7A+Z6U99OSCEeVeDJLqVqYk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by mx.zohomail.com with SMTPS id 1590500012617132.6483514129194; Tue, 26 May 2020 06:33:32 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-100-AT8NL_g3OdmkOIn20PJbJw-1; Tue, 26 May 2020 09:33:28 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CF02E18A072E; Tue, 26 May 2020 13:33:17 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AD8FA5C1BB; Tue, 26 May 2020 13:33:17 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 818C36B499; Tue, 26 May 2020 13:33:17 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 04QDXG8G012496 for ; Tue, 26 May 2020 09:33:16 -0400 Received: by smtp.corp.redhat.com (Postfix) id 699472026972; Tue, 26 May 2020 13:33:16 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast03.extmail.prod.ext.rdu2.redhat.com [10.11.55.19]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 501F82026971 for ; Tue, 26 May 2020 13:33:16 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id BB5CE80D683 for ; Tue, 26 May 2020 13:33:15 +0000 (UTC) Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-50-klAVjUjZMR69yQfG1IDQlw-1; Tue, 26 May 2020 09:33:09 -0400 Received: by mail-ed1-f52.google.com with SMTP id e10so17664426edq.0; Tue, 26 May 2020 06:33:08 -0700 (PDT) Received: from x1w.redhat.com (71.red-88-21-204.staticip.rima-tde.net. [88.21.204.71]) by smtp.gmail.com with ESMTPSA id n25sm1623084edo.56.2020.05.26.06.33.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 May 2020 06:33:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1590500011; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=45UgqB7xiuv75to9D1xtOkBXTGrFM8LHRPwW44N+AXY=; b=bOTPw3SHfcIbGwQfKTsrF5lAAFuW1rMoCXUGACg4CUaOuxfnvdXX0dS0Yk9Ns1WHtbNY9J LpnsFjIjJzQzWalTumIt2FTEO12zf8Pe1Hb03+SrVSFcZ9Gctfe0BA+dFip/K2+r5S6+6B ZFiLT+MexrUPNRdnrnke1eqSIrz4bus= X-MC-Unique: AT8NL_g3OdmkOIn20PJbJw-1 X-MC-Unique: klAVjUjZMR69yQfG1IDQlw-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=45UgqB7xiuv75to9D1xtOkBXTGrFM8LHRPwW44N+AXY=; b=EwSijc0G4/utzeZntcyb7Y/tHFX6KJSrUw13yl2JfopwDucnUOwkGkmyTj07ZjOxjP y1B+cufFzpPO88R+iJDgjSP5qWpxzyEQ1dR6+ZS8uADaNSgK3eBq1zOQIHjPmrDkDzQs 89pUA6VZrQhtwb4nXs4GPJp0Y3Fi3cSkCKrPwkLXjRItovKppnDJ6ee3aVFVc9zLa1Pe qZBZQuCIX95UoZCjcfmt9TzH0Q6knsXa9b+Kiv+5TRidryQctwfvOTSWPS9vyjcZrRXR Ps9v0zK567ogokazkE5FOI4mwapeG6ss/5tuxELruspH+yShIAEyNuKLpITbSwa6apNM 8U9w== X-Gm-Message-State: AOAM530HZOqWSbi3p78Ljv4YbRpsMkzaHUlbLPIFHfohDe+zNe4H/qxW dXbaT04d4W2l8ufsr+1YKlE= X-Google-Smtp-Source: ABdhPJxb7icFxfWH/GZOXulDFhi/cWtfATQReFSLmTJ3bbfzdxGr0+61zoopkwjRIIneAiOE44TjFg== X-Received: by 2002:a05:6402:1447:: with SMTP id d7mr20695849edx.367.1590499987728; Tue, 26 May 2020 06:33:07 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 12/14] hw/mips/malta: Add some logging for bad register offset cases Date: Tue, 26 May 2020 15:32:45 +0200 Message-Id: <20200526133247.13066-13-f4bug@amsat.org> In-Reply-To: <20200526133247.13066-1-f4bug@amsat.org> References: <20200526133247.13066-1-f4bug@amsat.org> MIME-Version: 1.0 X-Mimecast-Spam-Signature: yes X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: libvir-list@redhat.com Cc: Laurent Vivier , Aleksandar Rikalo , libvir-list@redhat.com, Thomas Huth , Jiaxun Yang , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aleksandar Markovic , Huacai Chen , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aurelien Jarno X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8"; text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) From: Aleksandar Markovic Log the cases where a guest attempts read or write using bad register offset. Reviewed-by: Philippe Mathieu-Daud=C3=A9 Tested-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Aleksandar Markovic Message-id: <20200518200920.17344-21-aleksandar.qemu.devel@gmail.com> [PMD: Replaced TARGET_FMT_lx by HWADDR_PRIX] Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/mips/malta.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/hw/mips/malta.c b/hw/mips/malta.c index e4c4de1b4e..b673a3a248 100644 --- a/hw/mips/malta.c +++ b/hw/mips/malta.c @@ -427,10 +427,9 @@ static uint64_t malta_fpga_read(void *opaque, hwaddr a= ddr, break; =20 default: -#if 0 - printf("malta_fpga_read: Bad register offset 0x" TARGET_FMT_lx "\n= ", - addr); -#endif + qemu_log_mask(LOG_GUEST_ERROR, + "malta_fpga_read: Bad register addr 0x%"HWADDR_PRIX"= \n", + addr); break; } return val; @@ -515,10 +514,9 @@ static void malta_fpga_write(void *opaque, hwaddr addr, break; =20 default: -#if 0 - printf("malta_fpga_write: Bad register offset 0x" TARGET_FMT_lx "\= n", - addr); -#endif + qemu_log_mask(LOG_GUEST_ERROR, + "malta_fpga_write: Bad register addr 0x%"HWADDR_PRIX= "\n", + addr); break; } } --=20 2.21.3