From nobody Fri Nov 14 21:46:05 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) client-ip=207.211.31.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=amsat.org ARC-Seal: i=1; a=rsa-sha256; t=1590500009; cv=none; d=zohomail.com; s=zohoarc; b=Pb/bK2FmBpmeqeUbF+ltgz/0dJFyrdmCxkB/nAvceNQnjou6HCP8U+s1avSr9n24T5545wammv6DroETUm3QqY38rsgch7Si1UeeghLnRBHCTB6SKtWuiadR2VtsKvpJumfEp9TqDpXZEHZ3mYEaigmLcjWpl8mPbMxUHL10Wg0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1590500009; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=O0RMe/KIBJnQN5FAGIPVddGSupuK4ETk0arXsanrJz8=; b=OontZyi+hGolaZkWOIerjRInO5f95+N2Ay1JlLbZ0v5SvRoahHhvj5mp8CeSmSuLvhAKMELMAtFX4Rj1hTeYuP4bg3eY3rAZ64pCD+h8wVH3HnmLM6/+D08fk/80wGuLBagHnxoLBeRFY03zzKFFJwLheEFSWBX3p7NKdnF9duM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by mx.zohomail.com with SMTPS id 1590500009674676.4971014999768; Tue, 26 May 2020 06:33:29 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-473-G0_ZL43dOh6k6H9hINcaQA-1; Tue, 26 May 2020 09:33:22 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C96D01855A21; Tue, 26 May 2020 13:33:12 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A722E1001268; Tue, 26 May 2020 13:33:12 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 751FA1800429; Tue, 26 May 2020 13:33:12 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 04QDXAjp012450 for ; Tue, 26 May 2020 09:33:10 -0400 Received: by smtp.corp.redhat.com (Postfix) id 8C8D02026971; Tue, 26 May 2020 13:33:10 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast01.extmail.prod.ext.rdu2.redhat.com [10.11.55.17]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4DC0E2029F62 for ; Tue, 26 May 2020 13:33:10 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1C52E8A5E4C for ; Tue, 26 May 2020 13:33:10 +0000 (UTC) Received: from mail-ej1-f67.google.com (mail-ej1-f67.google.com [209.85.218.67]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-150-BCAd3TX5MmiI3WU8y_mGKQ-1; Tue, 26 May 2020 09:33:05 -0400 Received: by mail-ej1-f67.google.com with SMTP id se13so23793819ejb.9; Tue, 26 May 2020 06:33:04 -0700 (PDT) Received: from x1w.redhat.com (71.red-88-21-204.staticip.rima-tde.net. [88.21.204.71]) by smtp.gmail.com with ESMTPSA id n25sm1623084edo.56.2020.05.26.06.33.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 May 2020 06:33:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1590500008; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=O0RMe/KIBJnQN5FAGIPVddGSupuK4ETk0arXsanrJz8=; b=EKvZEsNmN3YN1Z2V23/ZK96xlsuoEntT5qBXttlPsnZm7/PRrGdwQpWqYwbdPOzJ0j9XLN goRXIjlxUk9afeavZCQ4Pa1ECgiwdC0D97aGWIpH/eB0niS+HhL2Zy9nlLG5dLrWWSSioT Z7TGIKVhUDaMZTsa+TkYHdIFwYRHmSY= X-MC-Unique: G0_ZL43dOh6k6H9hINcaQA-1 X-MC-Unique: BCAd3TX5MmiI3WU8y_mGKQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=O0RMe/KIBJnQN5FAGIPVddGSupuK4ETk0arXsanrJz8=; b=qkP/DKv00ZdQWr02Gj1iSpTlQ4WEV7bx6bZoZ33y0b+IcEGyogzpU32XlCmhX1+nrV 3nk+mS82zQBK65Z26rXtpXUj2tepkHeqKcw/ZBQufm9ipyJ0y36ND0Ye8Rq9+9DdIv2N +nI1pAyox1yBfN25G+LY3LikJia0eOa1mqCDEHYNxo5jFqPVCNEHT12zBelTMTx6wrAG KMQ1T3HMavhVAbH2spmjFlrVXTunEW3jRfzxZM3l2A7IZOhRlq7ApFUKuwn1psv/8XAK txFMmyv0WRzTxEmxEP8WK63ldYhHRTZJw4KwBpXWqJSb2WPvfmwvIAlKiOnmbnBGJ1cP 642Q== X-Gm-Message-State: AOAM533kswFF0L7tP6uDDojXIqdnm4ZDKVnmeWBQoUQfSslwRglDvEWX qxCU6gnIwaszdZUqxBYiMD0= X-Google-Smtp-Source: ABdhPJxj4QYezkhS7+Sy+MlLzKtbDDpFMGDXmjmG0CfPbQKHZgOgtGgOjALCwDSmxrI6+t6Nf1iFDw== X-Received: by 2002:a17:906:f84b:: with SMTP id ks11mr1190807ejb.114.1590499983197; Tue, 26 May 2020 06:33:03 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 09/14] hw/mips/fuloong2e: Move code and update a comment Date: Tue, 26 May 2020 15:32:42 +0200 Message-Id: <20200526133247.13066-10-f4bug@amsat.org> In-Reply-To: <20200526133247.13066-1-f4bug@amsat.org> References: <20200526133247.13066-1-f4bug@amsat.org> MIME-Version: 1.0 X-Mimecast-Spam-Signature: yes X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: libvir-list@redhat.com Cc: Laurent Vivier , Aleksandar Rikalo , libvir-list@redhat.com, Thomas Huth , Jiaxun Yang , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aleksandar Markovic , Huacai Chen , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aurelien Jarno X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8"; text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Move the RAM-related call closer to the RAM creation block, rename the ROM comment. Reviewed-by: Huacai Chen Message-id: <20200510210128.18343-4-f4bug@amsat.org> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/mips/mips_fulong2e.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/mips/mips_fulong2e.c b/hw/mips/mips_fulong2e.c index 05b9efa516..6996f5e3d1 100644 --- a/hw/mips/mips_fulong2e.c +++ b/hw/mips/mips_fulong2e.c @@ -315,12 +315,11 @@ static void mips_fulong2e_init(MachineState *machine) error_report("Invalid RAM size, should be 256MB"); exit(EXIT_FAILURE); } + memory_region_add_subregion(address_space_mem, 0, machine->ram); =20 - /* allocate RAM */ + /* Boot ROM */ memory_region_init_rom(bios, NULL, "fulong2e.bios", BIOS_SIZE, &error_fatal); - - memory_region_add_subregion(address_space_mem, 0, machine->ram); memory_region_add_subregion(address_space_mem, 0x1fc00000LL, bios); =20 /* --=20 2.21.3