From nobody Fri Nov 14 21:41:11 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) client-ip=205.139.110.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1590490081; cv=none; d=zohomail.com; s=zohoarc; b=S2mgZH2imjME26HXczNXANCUgLaO6d5tDo/jaFCEZfnytxt/iZaL363Lm44h0nOTP6I0z3EeOboFCT8eW5r6L0zf70nZlvwDjsqKWYJ+b17xtX946Rzmnxo7GKshzg2wDmEKjhe+1Oco+QcRBJBObI2D2g/er9wz3SB81L3PMP8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1590490081; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=O0RMe/KIBJnQN5FAGIPVddGSupuK4ETk0arXsanrJz8=; b=Haiw3b6wNB/nXfgkWJV8CZiGlnUFrccf79FvdCqjcGdeXgSz4fTusytfsvH3yYk2jELX6RRsi0AYpj+xaud5Xbi+0pH5hSi2jJfSjHPTnc6PxQLh8SF1ZGm30Hsh2ofp9rll1Mq56qtYkwUlipRyAEujVYnAQ3O08srrizhBdys= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by mx.zohomail.com with SMTPS id 1590490081951587.0452955587452; Tue, 26 May 2020 03:48:01 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-392-OLndHGmUOWKoHwd3333icw-1; Tue, 26 May 2020 06:47:58 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D6673108BD0B; Tue, 26 May 2020 10:47:52 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B58826FB76; Tue, 26 May 2020 10:47:52 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 72E511809557; Tue, 26 May 2020 10:47:52 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 04QAlode029911 for ; Tue, 26 May 2020 06:47:50 -0400 Received: by smtp.corp.redhat.com (Postfix) id 38F2C202696B; Tue, 26 May 2020 10:47:50 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast03.extmail.prod.ext.rdu2.redhat.com [10.11.55.19]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 352252026E1C for ; Tue, 26 May 2020 10:47:50 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1A7E980066A for ; Tue, 26 May 2020 10:47:50 +0000 (UTC) Received: from mail-ed1-f66.google.com (mail-ed1-f66.google.com [209.85.208.66]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-356-KEcHtW8-Pp6ckA5rQvsVyw-1; Tue, 26 May 2020 06:47:43 -0400 Received: by mail-ed1-f66.google.com with SMTP id g9so17229214edw.10; Tue, 26 May 2020 03:47:42 -0700 (PDT) Received: from x1w.redhat.com (71.red-88-21-204.staticip.rima-tde.net. [88.21.204.71]) by smtp.gmail.com with ESMTPSA id c27sm3342597ejd.19.2020.05.26.03.47.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 May 2020 03:47:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1590490080; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=O0RMe/KIBJnQN5FAGIPVddGSupuK4ETk0arXsanrJz8=; b=FaG49fn+A/Tr8BikdwaVSacOg+c9LYpvAgHnv3RKxTDoN+TCmXqrmwADpL+XijMgVtqt2b Dz524fbYteP4NHr2TJ9ycMWJLKUAq+bCQhUSqLh2Kpxa6CRoJzx8qrrmUV4uAp5M1N9+6z 6Nl3B0ZEtYFRaq1grqLZUF7J+q7yu1E= X-MC-Unique: OLndHGmUOWKoHwd3333icw-1 X-MC-Unique: KEcHtW8-Pp6ckA5rQvsVyw-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=O0RMe/KIBJnQN5FAGIPVddGSupuK4ETk0arXsanrJz8=; b=YV2mzVLvFqHwnN6QDcCvhIspM90OQv4tImORISOqn4BaTenSLUd10Tr3DsZ0HpXCf/ pzKwMiYLq7VxeH3fRcakqKJnoTK4IrRdFn91gkY8XD7/353XFMaXbOn4W0+EdaWAmM/R vcse7NOSZuTeETQf7hGkrfHHAAudXEMoi8ZK0UpZb2Pw2/X/q+pZqlFCbxjq8NxDbqMB tPJGoHL6Zl2UhcPvXAi334iYojZb31F0LJgJkOm7rlxGjL1Bjevu3Wz1b5xYyIjfZlGq srKC2LqySKbvlN4FmstzleEpo+KtUBhFK0Y8w+dBauOuW0VvcTb/qDQ3WtAYwRGOVlbX VrcA== X-Gm-Message-State: AOAM531iHXJWmZtJZavDuVbFCm4zbHcgsBxNAunK//Rrc0V5O4URtvxk QxQtungYI9WfV11VbEvpwJo= X-Google-Smtp-Source: ABdhPJyyAHRwvz1QFqRke0gd34JWn3GXI8WomKQHJsrtEZW5IitbO859IkEZ7qbYfUjNEdXttrAzog== X-Received: by 2002:a50:955a:: with SMTP id v26mr19533154eda.5.1590490061184; Tue, 26 May 2020 03:47:41 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH 09/14] hw/mips/fuloong2e: Move code and update a comment Date: Tue, 26 May 2020 12:47:21 +0200 Message-Id: <20200526104726.11273-10-f4bug@amsat.org> In-Reply-To: <20200526104726.11273-1-f4bug@amsat.org> References: <20200526104726.11273-1-f4bug@amsat.org> MIME-Version: 1.0 X-Mimecast-Spam-Signature: yes X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: libvir-list@redhat.com Cc: Laurent Vivier , Aleksandar Rikalo , libvir-list@redhat.com, Thomas Huth , Jiaxun Yang , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aleksandar Markovic , Huacai Chen , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aurelien Jarno X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8"; text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Move the RAM-related call closer to the RAM creation block, rename the ROM comment. Reviewed-by: Huacai Chen Message-id: <20200510210128.18343-4-f4bug@amsat.org> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/mips/mips_fulong2e.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/mips/mips_fulong2e.c b/hw/mips/mips_fulong2e.c index 05b9efa516..6996f5e3d1 100644 --- a/hw/mips/mips_fulong2e.c +++ b/hw/mips/mips_fulong2e.c @@ -315,12 +315,11 @@ static void mips_fulong2e_init(MachineState *machine) error_report("Invalid RAM size, should be 256MB"); exit(EXIT_FAILURE); } + memory_region_add_subregion(address_space_mem, 0, machine->ram); =20 - /* allocate RAM */ + /* Boot ROM */ memory_region_init_rom(bios, NULL, "fulong2e.bios", BIOS_SIZE, &error_fatal); - - memory_region_add_subregion(address_space_mem, 0, machine->ram); memory_region_add_subregion(address_space_mem, 0x1fc00000LL, bios); =20 /* --=20 2.21.3