[PATCH 0/3] microvm: memory config tweaks

Gerd Hoffmann posted 3 patches 3 years, 10 months ago
Test docker-mingw@fedora passed
Test checkpatch passed
Test asan failed
Test docker-quick@centos7 failed
Test FreeBSD passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200525134101.24740-1-kraxel@redhat.com
Maintainers: Paolo Bonzini <pbonzini@redhat.com>, Sergio Lopez <slp@redhat.com>, Eduardo Habkost <ehabkost@redhat.com>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, Richard Henderson <rth@twiddle.net>, "Michael S. Tsirkin" <mst@redhat.com>
There is a newer version of this series
include/hw/i386/pc.h  |  2 ++
include/hw/i386/x86.h |  4 ----
hw/i386/microvm.c     | 35 +-------------------------------
hw/i386/pc.c          | 46 +++++++++++++++++++++++++++++++++++++++++++
hw/i386/pc_piix.c     | 10 +++++-----
hw/i386/pc_q35.c      | 10 +++++-----
hw/i386/x86.c         | 46 -------------------------------------------
7 files changed, 59 insertions(+), 94 deletions(-)
[PATCH 0/3] microvm: memory config tweaks
Posted by Gerd Hoffmann 3 years, 10 months ago
With more microvm memory config tweaks split this into its owns series,
the microvm acpi patch series is already big enough ...

take care,
  Gerd

Gerd Hoffmann (3):
  microvm: use 2G split unconditionally
  microvm: drop max-ram-below-4g support
  x86: move max-ram-below-4g to pc

 include/hw/i386/pc.h  |  2 ++
 include/hw/i386/x86.h |  4 ----
 hw/i386/microvm.c     | 35 +-------------------------------
 hw/i386/pc.c          | 46 +++++++++++++++++++++++++++++++++++++++++++
 hw/i386/pc_piix.c     | 10 +++++-----
 hw/i386/pc_q35.c      | 10 +++++-----
 hw/i386/x86.c         | 46 -------------------------------------------
 7 files changed, 59 insertions(+), 94 deletions(-)

-- 
2.18.4


Re: [PATCH 0/3] microvm: memory config tweaks
Posted by Paolo Bonzini 3 years, 10 months ago
On 25/05/20 15:40, Gerd Hoffmann wrote:
> With more microvm memory config tweaks split this into its owns series,
> the microvm acpi patch series is already big enough ...
> 
> take care,
>   Gerd
> 
> Gerd Hoffmann (3):
>   microvm: use 2G split unconditionally
>   microvm: drop max-ram-below-4g support
>   x86: move max-ram-below-4g to pc
> 
>  include/hw/i386/pc.h  |  2 ++
>  include/hw/i386/x86.h |  4 ----
>  hw/i386/microvm.c     | 35 +-------------------------------
>  hw/i386/pc.c          | 46 +++++++++++++++++++++++++++++++++++++++++++
>  hw/i386/pc_piix.c     | 10 +++++-----
>  hw/i386/pc_q35.c      | 10 +++++-----
>  hw/i386/x86.c         | 46 -------------------------------------------
>  7 files changed, 59 insertions(+), 94 deletions(-)
> 

Acked-by: Paolo Bonzini <pbonzini@redhat.com>


Re: [PATCH 0/3] microvm: memory config tweaks
Posted by no-reply@patchew.org 3 years, 10 months ago
Patchew URL: https://patchew.org/QEMU/20200525134101.24740-1-kraxel@redhat.com/



Hi,

This series failed the asan build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
export ARCH=x86_64
make docker-image-fedora V=1 NETWORK=1
time make docker-test-debug@fedora TARGET_LIST=x86_64-softmmu J=14 NETWORK=1
=== TEST SCRIPT END ===

  CC      x86_64-softmmu/target/i386/excp_helper.o
  CC      x86_64-softmmu/target/i386/fpu_helper.o
  CC      x86_64-softmmu/target/i386/int_helper.o
/tmp/qemu-test/src/hw/i386/xen/xen-hvm.c:206:34: error: use of undeclared identifier 'X86_MACHINE_MAX_RAM_BELOW_4G'
                                 X86_MACHINE_MAX_RAM_BELOW_4G,
                                 ^
1 error generated.
make[1]: *** [/tmp/qemu-test/src/rules.mak:69: hw/i386/xen/xen-hvm.o] Error 1
make[1]: *** Waiting for unfinished jobs....
  CC      x86_64-softmmu/target/i386/mem_helper.o
make: *** [Makefile:527: x86_64-softmmu/all] Error 2
Traceback (most recent call last):
  File "./tests/docker/docker.py", line 664, in <module>
    sys.exit(main())
---
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['sudo', '-n', 'docker', 'run', '--label', 'com.qemu.instance.uuid=a2fe8fb6681b4eafbb6da25a6234866a', '-u', '1003', '--security-opt', 'seccomp=unconfined', '--rm', '-e', 'TARGET_LIST=x86_64-softmmu', '-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=14', '-e', 'DEBUG=', '-e', 'SHOW_ENV=', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', '/home/patchew2/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', '/var/tmp/patchew-tester-tmp-u67ad0wm/src/docker-src.2020-05-25-21.48.27.23221:/var/tmp/qemu:z,ro', 'qemu:fedora', '/var/tmp/qemu/run', 'test-debug']' returned non-zero exit status 2.
filter=--filter=label=com.qemu.instance.uuid=a2fe8fb6681b4eafbb6da25a6234866a
make[1]: *** [docker-run] Error 1
make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-u67ad0wm/src'
make: *** [docker-run-test-debug@fedora] Error 2

real    4m14.520s
user    0m8.700s


The full log is available at
http://patchew.org/logs/20200525134101.24740-1-kraxel@redhat.com/testing.asan/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Re: [PATCH 0/3] microvm: memory config tweaks
Posted by no-reply@patchew.org 3 years, 10 months ago
Patchew URL: https://patchew.org/QEMU/20200525134101.24740-1-kraxel@redhat.com/



Hi,

This series failed the docker-quick@centos7 build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
make docker-image-centos7 V=1 NETWORK=1
time make docker-test-quick@centos7 SHOW_ENV=1 J=14 NETWORK=1
=== TEST SCRIPT END ===

  CC      aarch64-softmmu/qapi/qapi-types-machine-target.o
  CC      aarch64-softmmu/qapi/qapi-types-misc-target.o
/tmp/qemu-test/src/hw/i386/xen/xen-hvm.c: In function 'xen_ram_init':
/tmp/qemu-test/src/hw/i386/xen/xen-hvm.c:206:34: error: 'X86_MACHINE_MAX_RAM_BELOW_4G' undeclared (first use in this function)
                                  X86_MACHINE_MAX_RAM_BELOW_4G,
                                  ^
/tmp/qemu-test/src/hw/i386/xen/xen-hvm.c:206:34: note: each undeclared identifier is reported only once for each function it appears in
make[1]: *** [hw/i386/xen/xen-hvm.o] Error 1
make[1]: *** Waiting for unfinished jobs....
  CC      aarch64-softmmu/qapi/qapi-types.o
  CC      aarch64-softmmu/qapi/qapi-visit-machine-target.o
---
  CC      aarch64-softmmu/qapi/qapi-events-machine-target.o
  CC      aarch64-softmmu/qapi/qapi-events-misc-target.o
  CC      aarch64-softmmu/qapi/qapi-events.o
make: *** [x86_64-softmmu/all] Error 2
make: *** Waiting for unfinished jobs....
  CC      aarch64-softmmu/qapi/qapi-commands-machine-target.o
  CC      aarch64-softmmu/qapi/qapi-commands-misc-target.o
---
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['sudo', '-n', 'docker', 'run', '--label', 'com.qemu.instance.uuid=6355d775870e40b7b24b057ce98613cb', '-u', '1003', '--security-opt', 'seccomp=unconfined', '--rm', '-e', 'TARGET_LIST=', '-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=14', '-e', 'DEBUG=', '-e', 'SHOW_ENV=1', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', '/home/patchew2/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', '/var/tmp/patchew-tester-tmp-nzkk4v5m/src/docker-src.2020-05-25-21.44.46.13774:/var/tmp/qemu:z,ro', 'qemu:centos7', '/var/tmp/qemu/run', 'test-quick']' returned non-zero exit status 2.
filter=--filter=label=com.qemu.instance.uuid=6355d775870e40b7b24b057ce98613cb
make[1]: *** [docker-run] Error 1
make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-nzkk4v5m/src'
make: *** [docker-run-test-quick@centos7] Error 2

real    3m1.633s
user    0m8.168s


The full log is available at
http://patchew.org/logs/20200525134101.24740-1-kraxel@redhat.com/testing.docker-quick@centos7/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com