From nobody Tue Feb 10 13:34:14 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1590115303; cv=none; d=zohomail.com; s=zohoarc; b=jW2YTUR9TSPIvf1MrzRKNR4i5zRwvCbpXJ+iTdcvBPvMoDnkgV29USB40rxleQY9oT2Ek1OG96m4TLyM8ezYzrIR2O8/5f9NOoBBZIl8kabj4NhYixBUmXs3PkvpsxklQ97Xv0iMpAApZqcXpABAkXZOmNTi4Rv6a6JT9cXul1U= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1590115303; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=hXiDJogXpOZ8s/dlpDZsG+PYSCUe+WH+1ZPNXE4fyIc=; b=kX8S0L4EUczk8k7jIqK3JRyH+uVxy3hX9ArWe/v0Xgg+/MpLTHTeNEhHrUsqEztjHBIv1KH5LwxNUCHGfPgSJiiemolqjQ+1t80d7uarza+REBvvB/D+wXk9USsmkiRQFH2/k2G0LYRl2zjy9jwwdetxiRXvdlV+oMrSTur86Ys= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1590115303536372.8744598160598; Thu, 21 May 2020 19:41:43 -0700 (PDT) Received: from localhost ([::1]:47948 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jbxd0-0001C1-A7 for importer@patchew.org; Thu, 21 May 2020 22:41:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48208) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jbxWS-0002Pp-Gb for qemu-devel@nongnu.org; Thu, 21 May 2020 22:34:56 -0400 Received: from mail-pl1-x636.google.com ([2607:f8b0:4864:20::636]:41330) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jbxWR-00056m-6y for qemu-devel@nongnu.org; Thu, 21 May 2020 22:34:56 -0400 Received: by mail-pl1-x636.google.com with SMTP id a13so3818050pls.8 for ; Thu, 21 May 2020 19:34:54 -0700 (PDT) Received: from localhost.localdomain (174-21-143-238.tukw.qwest.net. [174.21.143.238]) by smtp.gmail.com with ESMTPSA id gt10sm5443755pjb.30.2020.05.21.19.34.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 May 2020 19:34:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hXiDJogXpOZ8s/dlpDZsG+PYSCUe+WH+1ZPNXE4fyIc=; b=y8oq2nftNUkDv7Z2gNTLbZATHAmWJH/x/kF1QBHHzAzZBMEUmX1crqzdmdBk3Qcr/K 5K4TA5o/UnBMxhowtYzwILfpvLB/Mz2RtepAvwNW9tw4NnaoU87rE10GI5pWfWfgPOYl xg01RVrJ4hrNZX1EZy9aJAY47yh/hEAOGF+SPZrFuXZYP9ueQNcMpj8QvUhzmWMagZFg iTboUdcVpRdEye8u7XvbTEp9dUmD9Hbu1KPLzfaDThCMFuqeTyhWCB0ADkra1gBFPgdY 2I9UITnAf7/w2y0WqEvlIOKhpY5DinzbwBsRfBnpoSB1NzFd807iJBaArymPxtBGgITV F0sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hXiDJogXpOZ8s/dlpDZsG+PYSCUe+WH+1ZPNXE4fyIc=; b=C/KnhE0XqQkmsXRUjpJ/Pi8R47+TEvb08pzeoHjHjpz9/sYssGKWbDHZz8Emc/D8a0 VeuI5DpxV9NkQXG/AvQkTnJaHBYq22rf6pjTHw1GET+WDU7sznhQLqWKvEmE5M6lJ+fE 7t5Akt9hBde4wK2a6QXU8RUv/GXSuC5MjC7waO7wxpiNfYVGPQxOG7Nywj+TS+3FraAi LT3ogihlho968PrInY0TJ1NIzBrdB+RSun+CxCpY/XXLjP2F6vN+z2MbOA8ZmyqD6ndX D7CgVHgMgIZgHRHgT1lDEOk4RCzepF7iUoq2EjduPHInfzp3RKL48iDBhuJuaKDGP5PZ OikQ== X-Gm-Message-State: AOAM5312/7g0nREDKvidFMXxHbd/xrnXs/sRTJqMTThA5E5W2U/fAf8B BZbeMiiu7pBsT2sOGGLUJJT3441Evfc= X-Google-Smtp-Source: ABdhPJwhB0kmesTA1qj6vV/wvb4hszrS/bxHTVUFvRKehEJuZPlbqEl4Qp3RO4lLJRX8tl2V86EWLQ== X-Received: by 2002:a17:90b:344d:: with SMTP id lj13mr1869879pjb.160.1590114893353; Thu, 21 May 2020 19:34:53 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH v3 09/25] Unify i/o functions and use RisuResult Date: Thu, 21 May 2020 19:34:24 -0700 Message-Id: <20200522023440.26261-10-richard.henderson@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200522023440.26261-1-richard.henderson@linaro.org> References: <20200522023440.26261-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::636; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x636.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.bennee@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) Push the trace check down from the function calling the reginfo function down into the i/o function. This means we don't have to pass a function pointer. Return a RisuResult from the i/o functions. This fixes a minor bug in send_register_info (even before the conversion to RisuResult), which returned the write_fn result directly. Reviewed-by: Alex Benn=C3=A9e Signed-off-by: Richard Henderson --- risu.h | 32 +++++++++------------- comms.c | 8 +++--- reginfo.c | 60 ++++++++++++++++++++-------------------- risu.c | 82 ++++++++++++++++++++++--------------------------------- 4 files changed, 81 insertions(+), 101 deletions(-) diff --git a/risu.h b/risu.h index e6d07eb..c83b803 100644 --- a/risu.h +++ b/risu.h @@ -34,13 +34,6 @@ void process_arch_opt(int opt, const char *arg); =20 #include REGINFO_HEADER(ARCH) =20 -/* Socket related routines */ -int master_connect(int port); -int apprentice_connect(const char *hostname, int port); -int send_data_pkt(int sock, void *pkt, int pktlen); -int recv_data_pkt(int sock, void *pkt, int pktlen); -void send_response_byte(int sock, int resp); - extern uintptr_t image_start_address; extern void *memblock; =20 @@ -80,31 +73,32 @@ typedef struct { uint32_t risu_op; } trace_header_t; =20 +/* Socket related routines */ +int master_connect(int port); +int apprentice_connect(const char *hostname, int port); +RisuResult send_data_pkt(int sock, void *pkt, int pktlen); +RisuResult recv_data_pkt(int sock, void *pkt, int pktlen); +void send_response_byte(int sock, int resp); + /* Functions operating on reginfo */ =20 -/* Function prototypes for read/write helper functions. - * - * We pass the helper function to send_register_info and - * recv_and_compare_register_info which can either be backed by the - * traditional network socket or a trace file. - */ -typedef int (*write_fn) (void *ptr, size_t bytes); -typedef int (*read_fn) (void *ptr, size_t bytes); -typedef void (*respond_fn) (RisuResult response); +/* Function prototypes for read/write helper functions. */ +RisuResult write_buffer(void *ptr, size_t bytes); +RisuResult read_buffer(void *ptr, size_t bytes); +void respond(RisuResult response); =20 /* * Send the register information from the struct ucontext down the socket. * NB: called from a signal handler. */ -RisuResult send_register_info(write_fn write_fn, void *uc); +RisuResult send_register_info(void *uc); =20 /* * Read register info from the socket and compare it with that from the * ucontext. * NB: called from a signal handler. */ -RisuResult recv_and_compare_register_info(read_fn read_fn, - respond_fn respond, void *uc); +RisuResult recv_and_compare_register_info(void *uc); =20 /* Print a useful report on the status of the last comparison * done in recv_and_compare_register_info(). This is called on diff --git a/comms.c b/comms.c index 861e845..21968da 100644 --- a/comms.c +++ b/comms.c @@ -168,7 +168,7 @@ ssize_t safe_writev(int fd, struct iovec *iov_in, int i= ovcnt) * Note that both ends must agree on the length of the * block of data. */ -int send_data_pkt(int sock, void *pkt, int pktlen) +RisuResult send_data_pkt(int sock, void *pkt, int pktlen) { unsigned char resp; /* First we send the packet length as a network-order 32 bit value. @@ -196,7 +196,7 @@ int send_data_pkt(int sock, void *pkt, int pktlen) return resp; } =20 -int recv_data_pkt(int sock, void *pkt, int pktlen) +RisuResult recv_data_pkt(int sock, void *pkt, int pktlen) { uint32_t net_pktlen; recv_bytes(sock, &net_pktlen, sizeof(net_pktlen)); @@ -206,10 +206,10 @@ int recv_data_pkt(int sock, void *pkt, int pktlen) * a response back. */ recv_and_discard_bytes(sock, net_pktlen); - return 1; + return RES_BAD_IO; } recv_bytes(sock, pkt, pktlen); - return 0; + return RES_OK; } =20 void send_response_byte(int sock, int resp) diff --git a/reginfo.c b/reginfo.c index b909a1f..fee025e 100644 --- a/reginfo.c +++ b/reginfo.c @@ -21,10 +21,11 @@ uint8_t apprentice_memblock[MEMBLOCKLEN]; static int mem_used; static int packet_mismatch; =20 -RisuResult send_register_info(write_fn write_fn, void *uc) +RisuResult send_register_info(void *uc) { struct reginfo ri; trace_header_t header; + RisuResult res; RisuOp op; =20 reginfo_init(&ri, uc); @@ -33,8 +34,9 @@ RisuResult send_register_info(write_fn write_fn, void *uc) /* Write a header with PC/op to keep in sync */ header.pc =3D get_pc(&ri); header.risu_op =3D op; - if (write_fn(&header, sizeof(header)) !=3D 0) { - return RES_BAD_IO; + res =3D write_buffer(&header, sizeof(header)); + if (res !=3D RES_OK) { + return res; } =20 switch (op) { @@ -45,11 +47,12 @@ RisuResult send_register_info(write_fn write_fn, void *= uc) * Do a simple register compare on (a) explicit request * (b) end of test (c) a non-risuop UNDEF */ - if (write_fn(&ri, reginfo_size()) !=3D 0) { - return RES_BAD_IO; + res =3D write_buffer(&ri, reginfo_size()); + /* For OP_TEST_END, force exit. */ + if (res =3D=3D RES_OK && op =3D=3D OP_TESTEND) { + res =3D RES_END; } - /* For OP_TEST_END, force return 1 to exit. */ - return op =3D=3D OP_TESTEND ? RES_END : RES_OK; + break; case OP_SETMEMBLOCK: memblock =3D (void *)(uintptr_t)get_reginfo_paramreg(&ri); break; @@ -58,12 +61,11 @@ RisuResult send_register_info(write_fn write_fn, void *= uc) get_reginfo_paramreg(&ri) + (uintptr_t)membl= ock); break; case OP_COMPAREMEM: - return write_fn(memblock, MEMBLOCKLEN); - break; + return write_buffer(memblock, MEMBLOCKLEN); default: abort(); } - return RES_OK; + return res; } =20 /* Read register info from the socket and compare it with that from the @@ -74,29 +76,29 @@ RisuResult send_register_info(write_fn write_fn, void *= uc) * that says whether it is register or memory data, so if the two * sides get out of sync then we will fail obscurely. */ -RisuResult recv_and_compare_register_info(read_fn read_fn, - respond_fn resp_fn, void *uc) +RisuResult recv_and_compare_register_info(void *uc) { - RisuResult resp =3D RES_OK; + RisuResult res; trace_header_t header; RisuOp op; =20 reginfo_init(&master_ri, uc); op =3D get_risuop(&master_ri); =20 - if (read_fn(&header, sizeof(header)) !=3D 0) { - return RES_BAD_IO; + res =3D read_buffer(&header, sizeof(header)); + if (res !=3D RES_OK) { + return res; } =20 if (header.risu_op !=3D op) { /* We are out of sync */ - resp =3D RES_BAD_IO; - resp_fn(resp); - return resp; + res =3D RES_BAD_IO; + respond(res); + return res; } =20 /* send OK for the header */ - resp_fn(RES_OK); + respond(RES_OK); =20 switch (op) { case OP_COMPARE: @@ -105,16 +107,16 @@ RisuResult recv_and_compare_register_info(read_fn rea= d_fn, /* Do a simple register compare on (a) explicit request * (b) end of test (c) a non-risuop UNDEF */ - if (read_fn(&apprentice_ri, reginfo_size())) { + res =3D read_buffer(&apprentice_ri, reginfo_size()); + if (res !=3D RES_OK) { packet_mismatch =3D 1; - resp =3D RES_BAD_IO; } else if (!reginfo_is_eq(&master_ri, &apprentice_ri)) { /* register mismatch */ - resp =3D RES_MISMATCH; + res =3D RES_MISMATCH; } else if (op =3D=3D OP_TESTEND) { - resp =3D RES_END; + res =3D RES_END; } - resp_fn(resp); + respond(res); break; case OP_SETMEMBLOCK: memblock =3D (void *)(uintptr_t)get_reginfo_paramreg(&master_ri); @@ -125,20 +127,20 @@ RisuResult recv_and_compare_register_info(read_fn rea= d_fn, break; case OP_COMPAREMEM: mem_used =3D 1; - if (read_fn(apprentice_memblock, MEMBLOCKLEN)) { + res =3D read_buffer(apprentice_memblock, MEMBLOCKLEN); + if (res !=3D RES_OK) { packet_mismatch =3D 1; - resp =3D RES_BAD_IO; } else if (memcmp(memblock, apprentice_memblock, MEMBLOCKLEN) !=3D= 0) { /* memory mismatch */ - resp =3D RES_MISMATCH; + res =3D RES_MISMATCH; } - resp_fn(resp); + respond(res); break; default: abort(); } =20 - return resp; + return res; } =20 /* Print a useful report on the status of the last comparison diff --git a/risu.c b/risu.c index 7b14f72..1917311 100644 --- a/risu.c +++ b/risu.c @@ -46,44 +46,15 @@ static sigjmp_buf jmpbuf; =20 #define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0])) =20 -/* Master functions */ +/* I/O functions */ =20 -int read_sock(void *ptr, size_t bytes) -{ - return recv_data_pkt(comm_fd, ptr, bytes); -} - -int write_trace(void *ptr, size_t bytes) +RisuResult read_buffer(void *ptr, size_t bytes) { size_t res; =20 -#ifdef HAVE_ZLIB - if (comm_fd =3D=3D STDOUT_FILENO) { -#endif - res =3D write(comm_fd, ptr, bytes); -#ifdef HAVE_ZLIB - } else { - res =3D gzwrite(gz_trace_file, ptr, bytes); + if (!trace) { + return recv_data_pkt(comm_fd, ptr, bytes); } -#endif - return (res =3D=3D bytes) ? 0 : 1; -} - -void respond_sock(RisuResult r) -{ - send_response_byte(comm_fd, r); -} - -/* Apprentice function */ - -int write_sock(void *ptr, size_t bytes) -{ - return send_data_pkt(comm_fd, ptr, bytes); -} - -int read_trace(void *ptr, size_t bytes) -{ - size_t res; =20 #ifdef HAVE_ZLIB if (comm_fd =3D=3D STDIN_FILENO) { @@ -95,21 +66,34 @@ int read_trace(void *ptr, size_t bytes) } #endif =20 - return (res =3D=3D bytes) ? 0 : 1; + return res =3D=3D bytes ? RES_OK : RES_BAD_IO; } =20 -void respond_trace(RisuResult r) +RisuResult write_buffer(void *ptr, size_t bytes) { - switch (r) { - case RES_OK: - case RES_END: - break; - default: - /* mismatch - if tracing we need to report, otherwise barf */ - if (!trace) { - abort(); - } - break; + size_t res; + + if (!trace) { + return send_data_pkt(comm_fd, ptr, bytes); + } + +#ifdef HAVE_ZLIB + if (comm_fd =3D=3D STDOUT_FILENO) { +#endif + res =3D write(comm_fd, ptr, bytes); +#ifdef HAVE_ZLIB + } else { + res =3D gzwrite(gz_trace_file, ptr, bytes); + } +#endif + + return res =3D=3D bytes ? RES_OK : RES_BAD_IO; +} + +void respond(RisuResult r) +{ + if (!trace) { + send_response_byte(comm_fd, r); } } =20 @@ -119,9 +103,9 @@ static void master_sigill(int sig, siginfo_t *si, void = *uc) signal_count++; =20 if (trace) { - r =3D send_register_info(write_trace, uc); + r =3D send_register_info(uc); } else { - r =3D recv_and_compare_register_info(read_sock, respond_sock, uc); + r =3D recv_and_compare_register_info(uc); } =20 switch (r) { @@ -141,9 +125,9 @@ static void apprentice_sigill(int sig, siginfo_t *si, v= oid *uc) signal_count++; =20 if (trace) { - r =3D recv_and_compare_register_info(read_trace, respond_trace, uc= ); + r =3D recv_and_compare_register_info(uc); } else { - r =3D send_register_info(write_sock, uc); + r =3D send_register_info(uc); } =20 switch (r) { --=20 2.20.1