From nobody Fri Nov 14 20:43:48 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1589908399; cv=none; d=zohomail.com; s=zohoarc; b=KKHg32gWR5bnQasAm4/b5n9R87ua61bf013ID4MDi8hzxaeIuB6oKPRbmjI7H0N5zPfizMAM3e7FOxC55sh5KUJ9Aj8o5Q93N4gTeAYo9VmSwsAKx3TMzplGn+GGFwgeov6nN8eeNCppIlSDPQl45KONizc+ameIQA8oNqFQNFo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1589908399; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=i+nfQ/k3btjKGYc/RWEmhyNXfBEeP3NikdCpuMvaz5k=; b=SMp7hx4MspHKJYs6AH+JRuh04byFJXLQKi0hFymjaBgUHpGC0sXz3oe2HJPZFnmwhPQlUAWNbOdUPfMu9rZepZlV8TgSM+tNQp8qPs/qhI45qGZ6fGjIfeE2/lWveDUy8L6hhPAh9lC+dkAE+AHM/9orKZW9d5oBC6RmfJnKa3w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 158990839908040.639695686151185; Tue, 19 May 2020 10:13:19 -0700 (PDT) Received: from localhost ([::1]:43934 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jb5nq-0004fL-65 for importer@patchew.org; Tue, 19 May 2020 13:13:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34236) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jb5mX-0002rG-9n for qemu-devel@nongnu.org; Tue, 19 May 2020 13:11:57 -0400 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:52073 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jb5mW-0002Ve-DR for qemu-devel@nongnu.org; Tue, 19 May 2020 13:11:56 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-145-uftcanREPDS83XSYpMjmVQ-1; Tue, 19 May 2020 13:11:52 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E90508D8760; Tue, 19 May 2020 17:11:50 +0000 (UTC) Received: from localhost (ovpn-114-215.ams2.redhat.com [10.36.114.215]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6D3FE6246F; Tue, 19 May 2020 17:11:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1589908315; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=i+nfQ/k3btjKGYc/RWEmhyNXfBEeP3NikdCpuMvaz5k=; b=UOgUajjES/IhyQRzWBv7ksqjtuur78LJlf5gKTtyrJ6K4g9lfIHrI7FbE8f5NibTevn5l2 t8xc21FNHMFSgOSaRD9ZlRTxGh8EXOBmsZ/S0jeLCjA4if/B389yJvFUv5FuCRQ/NviKLH rhP99BtsDoldwNUmoc8lZ6sbmQo8Ro4= X-MC-Unique: uftcanREPDS83XSYpMjmVQ-1 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Subject: [PATCH 2/7] block/nvme: drop tautologous assertion Date: Tue, 19 May 2020 18:11:33 +0100 Message-Id: <20200519171138.201667-3-stefanha@redhat.com> In-Reply-To: <20200519171138.201667-1-stefanha@redhat.com> References: <20200519171138.201667-1-stefanha@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=207.211.31.81; envelope-from=stefanha@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/19 00:34:39 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -3 X-Spam_score: -0.4 X-Spam_bar: / X-Spam_report: (-0.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MIME_BASE64_TEXT=1.741, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Fam Zheng , qemu-block@nongnu.org, Max Reitz , Stefan Hajnoczi , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" nvme_process_completion() explicitly checks cid so the assertion that follows is always true: if (cid =3D=3D 0 || cid > NVME_QUEUE_SIZE) { ... continue; } assert(cid <=3D NVME_QUEUE_SIZE); Signed-off-by: Stefan Hajnoczi Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Sergio Lopez --- block/nvme.c | 1 - 1 file changed, 1 deletion(-) diff --git a/block/nvme.c b/block/nvme.c index 7eb4512666..5286227074 100644 --- a/block/nvme.c +++ b/block/nvme.c @@ -336,7 +336,6 @@ static bool nvme_process_completion(BDRVNVMeState *s, N= VMeQueuePair *q) cid); continue; } - assert(cid <=3D NVME_QUEUE_SIZE); trace_nvme_complete_command(s, q->index, cid); preq =3D &q->reqs[cid - 1]; req =3D *preq; --=20 2.25.3