From nobody Fri Nov 14 18:17:46 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1589787899; cv=none; d=zohomail.com; s=zohoarc; b=dc4X+7Ao7yioBCCIlFQsK07RnVHw0LLr8mJ03qka0yyasoKydv0BnLbQ2M6/ZaSLA3SR6nSnDp42cX57ZFVnPqrNQ8XUiWGZtY+VyyMZD9buBjeQWA1aMqUCcF+FTAfWen1ZTR8oFFPXQTUP+uy0e2/dbTDfHgcYMVK6szPiguw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1589787899; h=Content-Type:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:Sender:Subject:To; bh=UElHim+FDsfadnKXsfBdfHKm+vRH2ogsYCXWhw1L3H4=; b=j+CNEE+pkBLKam1P/wTk8/1Oyj5grr3dZs/rBfzZ5xjjdgt+jPHHyFO2TNtxYZl42GUZBKwNdHehaD+WLiMvtNBXhnWWqkW6E9toPcUeVygPYdGNH4mLjKULOf7QGHvjj55a4Lmdk9pJ4Zng/8502fl+wamaVKXL/ZGI0yIKk5I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1589787899622773.1546543062809; Mon, 18 May 2020 00:44:59 -0700 (PDT) Received: from localhost ([::1]:53496 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jaaSI-0007SP-FY for importer@patchew.org; Mon, 18 May 2020 03:44:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41628) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jaaRM-0006r6-9b for qemu-devel@nongnu.org; Mon, 18 May 2020 03:44:00 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:48998 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jaaRL-0001nw-Hy for qemu-devel@nongnu.org; Mon, 18 May 2020 03:44:00 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-499-b6W_CpdSMfuHAT1HMKgL1w-1; Mon, 18 May 2020 03:43:56 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8D007107ACCA; Mon, 18 May 2020 07:43:55 +0000 (UTC) Received: from thuth.com (ovpn-112-182.ams2.redhat.com [10.36.112.182]) by smtp.corp.redhat.com (Postfix) with ESMTP id 51BC65C1B2; Mon, 18 May 2020 07:43:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1589787838; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:content-type:content-type; bh=UElHim+FDsfadnKXsfBdfHKm+vRH2ogsYCXWhw1L3H4=; b=Nh+UPrA3/tHnjTFS4vyj3NFS4UWz3IEM+DVL86EKXnlbFXwvTq5mnULJqHp/pL9oUl8BxW DpbhAVeQBkhzhHvgcvvLfBTUgBBU8Hsu7C5Z9j5kKNTdFnQVh9GUTg9UoAKJ0QrreMkgtW J6fqm0G/PVijzPAEGnQ2ReTmxsrSdfA= X-MC-Unique: b6W_CpdSMfuHAT1HMKgL1w-1 From: Thomas Huth To: Jason Wang , qemu-devel@nongnu.org Subject: [PATCH] net: Do not include a newline in the id of -nic devices Date: Mon, 18 May 2020 09:43:52 +0200 Message-Id: <20200518074352.23125-1-thuth@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=207.211.31.120; envelope-from=thuth@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/18 00:53:04 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, qemu-stable@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The '\n' sneaked in by accident here, an "id" string should really not contain a newline character at the end. Fixes: 78cd6f7bf6b ('net: Add a new convenience option "--nic" ...') Signed-off-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- net/net.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/net.c b/net/net.c index 38778e831d..cbeeeadff8 100644 --- a/net/net.c +++ b/net/net.c @@ -1506,7 +1506,7 @@ static int net_param_nic(void *dummy, QemuOpts *opts,= Error **errp) /* Create an ID if the user did not specify one */ nd_id =3D g_strdup(qemu_opts_id(opts)); if (!nd_id) { - nd_id =3D g_strdup_printf("__org.qemu.nic%i\n", idx); + nd_id =3D g_strdup_printf("__org.qemu.nic%i", idx); qemu_opts_set_id(opts, nd_id); } =20 --=20 2.18.1