From nobody Fri Nov 14 19:25:40 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1589715599; cv=none; d=zohomail.com; s=zohoarc; b=ABbs4NTETXxIKiCBUUSczVpMgKyaaG3NKJX4MysVYS92BXVfu4l6/bY4BYa4ouKnCsDopx8yGrT54S1mZvCZI5NxYW05PuEpc2rNKWxEJ3vx/YXvde+Mca5K46Loc+owB8EMwR6/YwihZUjD97XekMoz9FViJB0omMoXhKJ5aVI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1589715599; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=jdDbc6yPkbc/CrlTCOnabVx1wZ4fVwIoxaLDJHM44JU=; b=M7+pYod7IVcBrTLH9QByUy+s2QOCUn0N4Dxe1+wSgiv+OekNw6wq9xrVXDw9cmIwgQUmzPLS/u8gV8Nje0OZB34+9PMJPionULo5At7ckjLVbpPtfc1EcuOggH5Awaw+RVqNySraNqeoENqz8ikacU0PoWfd1YL/9HSUF5YAaEg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1589715599239431.3238330871393; Sun, 17 May 2020 04:39:59 -0700 (PDT) Received: from localhost ([::1]:41242 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jaHe9-0005mz-T6 for importer@patchew.org; Sun, 17 May 2020 07:39:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48882) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jaHcS-0004XN-Nq for qemu-devel@nongnu.org; Sun, 17 May 2020 07:38:14 -0400 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]:34344) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jaHcS-0001HE-5h for qemu-devel@nongnu.org; Sun, 17 May 2020 07:38:12 -0400 Received: by mail-wr1-x444.google.com with SMTP id y3so8519700wrt.1 for ; Sun, 17 May 2020 04:38:11 -0700 (PDT) Received: from localhost.localdomain (17.red-88-21-202.staticip.rima-tde.net. [88.21.202.17]) by smtp.gmail.com with ESMTPSA id u10sm11660451wmc.31.2020.05.17.04.38.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 May 2020 04:38:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=jdDbc6yPkbc/CrlTCOnabVx1wZ4fVwIoxaLDJHM44JU=; b=hwjo/7Dg32uRxQMnzoxAAVSlmOUbw0bT/PqAd9AfajmIASvEn8i4TmAP6c/I10ZS4D lIjUFjnb/G3VcHg2O6gONSJrSq1Y/pC5HsT0gNuHI6Hcc8y8D7DSgNd5CPRUqKhtqiQK htLq8ZkuD9gYNPIhAWZGe6zDQRvKKSahZXTFiCpDNS0D5w7U8s4l633V7BsIhhh9TknL BGjXUOrrFgc4AwiGy8FNp4+VeY5WwTlXTnO5ASTkfoaej+xllCPNk3tSb1sQXskg7vtH 93SYGnXgtwNNiwBh/O6f9sFl9FoPy02FYwBClTcNHhixhkQhCUDn5tzRV+CLZtHFq88O 9RFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=jdDbc6yPkbc/CrlTCOnabVx1wZ4fVwIoxaLDJHM44JU=; b=TlbGhQhC4yW2erfeKGInUEeiyBzBB9xPeSXH1lyfMxpmqn3J9LIh/VXD9qbV1hBbBk 0FBqWbGvpZ1xdyvoP3JaeFrT0I334hpjdZ1aYjMRhEqsHWbggPA8QvbWr6RuXOQUcEC3 98bw0G2Q/8RUe+cfNd2vOYnXMFdwKylFlyncxC9yRyauVppja+HK6taCwqEwvmgx+FnX AHMr3l4rSP8Jan4qybb6nU4XT2sARonlrVAIeZb0FX9OSY36RbMGU5R695O9GA1WYPdJ XcLkgdovJXepb4tO0H1tBe5qpnGIBsrDWhCFyTghF5j7ewJHjRD5bJq4zj7TZnQ+L2c8 0rnQ== X-Gm-Message-State: AOAM533hiAu2k7Xcrr+2jIZjBr+wOZLhDB4qzFIwV/UBqHGdOT4bTLNI 22Mx0tyzmqCUWtPClmsJur4GySdR2w8= X-Google-Smtp-Source: ABdhPJzwxMIAf6A/FNrwZ1+ntIC2QvC/quX6UNipYWLrBscJsflhDvvmWCC8a+Oqun3EfDTmCZKtvg== X-Received: by 2002:adf:a3c5:: with SMTP id m5mr14944249wrb.390.1589715490429; Sun, 17 May 2020 04:38:10 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [RFC PATCH 1/2] exec: Let memory_access_size() consider minimum valid access size Date: Sun, 17 May 2020 13:38:03 +0200 Message-Id: <20200517113804.9063-2-f4bug@amsat.org> X-Mailer: git-send-email 2.21.3 In-Reply-To: <20200517113804.9063-1-f4bug@amsat.org> References: <20200517113804.9063-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::444; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-x444.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Li Zhijian , Tony Nguyen , Alexey Kardashevskiy , Julia Suvorova , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Peter Xu , Alexander Bulekov , Paolo Bonzini , Richard Henderson , Stefano Garzarella Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) As it is illegal to access a device with less that its minimum valid size, also check for access_size_min. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- exec.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/exec.c b/exec.c index 5162f0d12f..d3ec30f995 100644 --- a/exec.c +++ b/exec.c @@ -3066,10 +3066,14 @@ void memory_region_flush_rom_device(MemoryRegion *m= r, hwaddr addr, hwaddr size) =20 static int memory_access_size(MemoryRegion *mr, unsigned l, hwaddr addr) { + unsigned access_size_min =3D mr->ops->valid.min_access_size; unsigned access_size_max =3D mr->ops->valid.max_access_size; =20 /* Regions are assumed to support 1-4 byte accesses unless otherwise specified. */ + if (access_size_min =3D=3D 0) { + access_size_min =3D 1; + } if (access_size_max =3D=3D 0) { access_size_max =3D 4; } @@ -3082,11 +3086,14 @@ static int memory_access_size(MemoryRegion *mr, uns= igned l, hwaddr addr) } } =20 - /* Don't attempt accesses larger than the maximum. */ - if (l > access_size_max) { + /* Don't attempt accesses not in the minimum/maximum range. */ + if (l < access_size_min) { + l =3D access_size_min; + } else if (l > access_size_max) { l =3D access_size_max; + } else { + l =3D pow2floor(l); } - l =3D pow2floor(l); =20 return l; } --=20 2.21.3