From nobody Fri Nov 14 19:39:05 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1589651835; cv=none; d=zohomail.com; s=zohoarc; b=dDgdA5qfKgZMjZsm5GgJH6Kf5wqlw2hTWwOeFhKXteaLO7udXhOECzhnkBSqrBMUj4KCludfEX3+aTRfv3JbLDjs6gHgC//2ESaAorZiRyqHQOMw9b+L7qXuZ0E7t1CXdUjUIZDZ9bskWiqhg7BV/PNKnQRq/dpeIaR1ujfmV8o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1589651835; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=bFeqPWm2QsPGoTt7fEQgUrf7uzCq2N6hwh31edqpp1E=; b=jwqtTXOjY+ZTdWTFkastlBk0LDgr35USG3Lvdm0GZAMpOypFhDxwMEiZHF42vELGkFBODLU8DfnZvMKX0Jk2cmHll0g8W9La8rIbEJ5Kvgm1IUpML8OFSUGM5ZqXN9I/+CnZk0D8xrZKCUhhUi6gzZO/npIk1zbtDv5AjMYNpV8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1589651835277744.0947312469766; Sat, 16 May 2020 10:57:15 -0700 (PDT) Received: from localhost ([::1]:58978 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ja13i-0004Oa-4e for importer@patchew.org; Sat, 16 May 2020 13:57:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52218) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ja0te-0003b4-Ok for qemu-devel@nongnu.org; Sat, 16 May 2020 13:46:50 -0400 Received: from mail-lj1-x243.google.com ([2a00:1450:4864:20::243]:37901) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ja0td-0008SF-S4 for qemu-devel@nongnu.org; Sat, 16 May 2020 13:46:50 -0400 Received: by mail-lj1-x243.google.com with SMTP id e25so5570851ljg.5 for ; Sat, 16 May 2020 10:46:49 -0700 (PDT) Received: from localhost.localdomain ([109.245.227.98]) by smtp.gmail.com with ESMTPSA id i1sm3024759lja.3.2020.05.16.10.46.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 16 May 2020 10:46:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=bFeqPWm2QsPGoTt7fEQgUrf7uzCq2N6hwh31edqpp1E=; b=X1LxGlMjyO6sEyhdw6SIS8Zm+yQlYqxpOXPwlQWh5Q4oiELu00S8cKbjTkLI0n7ZdB K3v8XSqBBRsdT/gVGKpJcurqJEDBOWpEqipmR9jXEdg7lh17TiipiEU/ftLcuz18b7x6 iDXscfk4BzYhkx1ghOl2R+sxnLjYcAQBvbGDzGUlcYKvT7mwyHl50Y2jYG3Qb49zj4cC f+88CxsEn8Uyh4ZNIlpj+bYXBlPA09ha0hp2XgetjhOmnHKjwPW8dz99vndfiOKoScBw PABKY7Nha2x0L0eF4xTjm9XyoKAXNx4Nwo0M7T5pBgI7HwqCi0ou7PH8yrXnpINw+3BS 05YA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=bFeqPWm2QsPGoTt7fEQgUrf7uzCq2N6hwh31edqpp1E=; b=H6kv+M8TgR4pNPRQGWWKQVZcaisoVN3h3fYyUIQ51gaAUut+RRZY6gIMBNAUsfInya 2ONZlXU34wDGFXbzi77b7q02PVm6olcz6qf2hOVzg5bOqA/YbxrvKOM1M4cjvIKJoM7/ JsOQEPajtBqswviLGzPx0gpf/Bby7WGM7WeRl/QWlm9iUXoa2WcQYbXwfQTYdnxVw18R dY2K7jYgUR/q6kXLrWEhEoXbiEZByJ4aDFC0o6T6S2Chadh62tVC0wUZ0owalmZs6IpI kBCHm3JdoTJGV4owvlgy/idFKOGyx/WOk02vWfezHNLY5RgClzcsViYezm+BzVo1D1fF /tsQ== X-Gm-Message-State: AOAM531tfl6WT+eRXfiDdDzhDAuWHEMtlzAKRnjkGYMDS4zmKVIBN+4W 2u2nSJB9vT7pUlIkSfGJsYgsw5BCVhc= X-Google-Smtp-Source: ABdhPJxslnjkthASH1+w0PhYVQGnKVrNUy9pDhb1S39TGxdiE04emVBs73mWzuddP9rbS40LnUr3KQ== X-Received: by 2002:a2e:8807:: with SMTP id x7mr5711113ljh.173.1589651208280; Sat, 16 May 2020 10:46:48 -0700 (PDT) From: Aleksandar Markovic To: qemu-devel@nongnu.org Subject: [PATCH v3 15/18] target/mips: fpu: Name better paired-single variables Date: Sat, 16 May 2020 19:45:45 +0200 Message-Id: <20200516174548.7631-16-aleksandar.qemu.devel@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200516174548.7631-1-aleksandar.qemu.devel@gmail.com> References: <20200516174548.7631-1-aleksandar.qemu.devel@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::243; envelope-from=aleksandar.qemu.devel@gmail.com; helo=mail-lj1-x243.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: aleksandar.rikalo@rt-rk.com, Aleksandar Markovic Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @gmail.com) Content-Type: text/plain; charset="utf-8" Use consistently 'l' and 'h' for low and high halves. Signed-off-by: Aleksandar Markovic --- target/mips/fpu_helper.c | 62 ++++++++++++++++++++-------------------- 1 file changed, 31 insertions(+), 31 deletions(-) diff --git a/target/mips/fpu_helper.c b/target/mips/fpu_helper.c index 56ba49104e..dbb8ca5692 100644 --- a/target/mips/fpu_helper.c +++ b/target/mips/fpu_helper.c @@ -1059,14 +1059,14 @@ uint32_t helper_float_recip1_s(CPUMIPSState *env, u= int32_t fst0) =20 uint64_t helper_float_recip1_ps(CPUMIPSState *env, uint64_t fdt0) { - uint32_t fst2; + uint32_t fstl2; uint32_t fsth2; =20 - fst2 =3D float32_div(float32_one, fdt0 & 0XFFFFFFFF, - &env->active_fpu.fp_status); + fstl2 =3D float32_div(float32_one, fdt0 & 0XFFFFFFFF, + &env->active_fpu.fp_status); fsth2 =3D float32_div(float32_one, fdt0 >> 32, &env->active_fpu.fp_sta= tus); update_fcr31(env, GETPC()); - return ((uint64_t)fsth2 << 32) | fst2; + return ((uint64_t)fsth2 << 32) | fstl2; } =20 uint64_t helper_float_rsqrt1_d(CPUMIPSState *env, uint64_t fdt0) @@ -1091,15 +1091,15 @@ uint32_t helper_float_rsqrt1_s(CPUMIPSState *env, u= int32_t fst0) =20 uint64_t helper_float_rsqrt1_ps(CPUMIPSState *env, uint64_t fdt0) { - uint32_t fst2; + uint32_t fstl2; uint32_t fsth2; =20 - fst2 =3D float32_sqrt(fdt0 & 0XFFFFFFFF, &env->active_fpu.fp_status); + fstl2 =3D float32_sqrt(fdt0 & 0XFFFFFFFF, &env->active_fpu.fp_status); fsth2 =3D float32_sqrt(fdt0 >> 32, &env->active_fpu.fp_status); - fst2 =3D float32_div(float32_one, fst2, &env->active_fpu.fp_status); + fstl2 =3D float32_div(float32_one, fstl2, &env->active_fpu.fp_status); fsth2 =3D float32_div(float32_one, fsth2, &env->active_fpu.fp_status); update_fcr31(env, GETPC()); - return ((uint64_t)fsth2 << 32) | fst2; + return ((uint64_t)fsth2 << 32) | fstl2; } =20 uint64_t helper_float_rint_d(CPUMIPSState *env, uint64_t fs) @@ -1367,19 +1367,19 @@ uint32_t helper_float_recip2_s(CPUMIPSState *env, u= int32_t fst0, uint32_t fst2) =20 uint64_t helper_float_recip2_ps(CPUMIPSState *env, uint64_t fdt0, uint64_t= fdt2) { - uint32_t fst0 =3D fdt0 & 0XFFFFFFFF; + uint32_t fstl0 =3D fdt0 & 0XFFFFFFFF; uint32_t fsth0 =3D fdt0 >> 32; - uint32_t fst2 =3D fdt2 & 0XFFFFFFFF; + uint32_t fstl2 =3D fdt2 & 0XFFFFFFFF; uint32_t fsth2 =3D fdt2 >> 32; =20 - fst2 =3D float32_mul(fst0, fst2, &env->active_fpu.fp_status); + fstl2 =3D float32_mul(fstl0, fstl2, &env->active_fpu.fp_status); fsth2 =3D float32_mul(fsth0, fsth2, &env->active_fpu.fp_status); - fst2 =3D float32_chs(float32_sub(fst2, float32_one, + fstl2 =3D float32_chs(float32_sub(fstl2, float32_one, &env->active_fpu.fp_status)); fsth2 =3D float32_chs(float32_sub(fsth2, float32_one, &env->active_fpu.fp_status)); update_fcr31(env, GETPC()); - return ((uint64_t)fsth2 << 32) | fst2; + return ((uint64_t)fsth2 << 32) | fstl2; } =20 uint64_t helper_float_rsqrt2_d(CPUMIPSState *env, uint64_t fdt0, uint64_t = fdt2) @@ -1404,51 +1404,51 @@ uint32_t helper_float_rsqrt2_s(CPUMIPSState *env, u= int32_t fst0, uint32_t fst2) =20 uint64_t helper_float_rsqrt2_ps(CPUMIPSState *env, uint64_t fdt0, uint64_t= fdt2) { - uint32_t fst0 =3D fdt0 & 0XFFFFFFFF; + uint32_t fstl0 =3D fdt0 & 0XFFFFFFFF; uint32_t fsth0 =3D fdt0 >> 32; - uint32_t fst2 =3D fdt2 & 0XFFFFFFFF; + uint32_t fstl2 =3D fdt2 & 0XFFFFFFFF; uint32_t fsth2 =3D fdt2 >> 32; =20 - fst2 =3D float32_mul(fst0, fst2, &env->active_fpu.fp_status); + fstl2 =3D float32_mul(fstl0, fstl2, &env->active_fpu.fp_status); fsth2 =3D float32_mul(fsth0, fsth2, &env->active_fpu.fp_status); - fst2 =3D float32_sub(fst2, float32_one, &env->active_fpu.fp_status); + fstl2 =3D float32_sub(fstl2, float32_one, &env->active_fpu.fp_status); fsth2 =3D float32_sub(fsth2, float32_one, &env->active_fpu.fp_status); - fst2 =3D float32_chs(float32_div(fst2, FLOAT_TWO32, + fstl2 =3D float32_chs(float32_div(fstl2, FLOAT_TWO32, &env->active_fpu.fp_status)); fsth2 =3D float32_chs(float32_div(fsth2, FLOAT_TWO32, &env->active_fpu.fp_status)); update_fcr31(env, GETPC()); - return ((uint64_t)fsth2 << 32) | fst2; + return ((uint64_t)fsth2 << 32) | fstl2; } =20 uint64_t helper_float_addr_ps(CPUMIPSState *env, uint64_t fdt0, uint64_t f= dt1) { - uint32_t fst0 =3D fdt0 & 0XFFFFFFFF; + uint32_t fstl0 =3D fdt0 & 0XFFFFFFFF; uint32_t fsth0 =3D fdt0 >> 32; - uint32_t fst1 =3D fdt1 & 0XFFFFFFFF; + uint32_t fstl1 =3D fdt1 & 0XFFFFFFFF; uint32_t fsth1 =3D fdt1 >> 32; - uint32_t fst2; + uint32_t fstl2; uint32_t fsth2; =20 - fst2 =3D float32_add(fst0, fsth0, &env->active_fpu.fp_status); - fsth2 =3D float32_add(fst1, fsth1, &env->active_fpu.fp_status); + fstl2 =3D float32_add(fstl0, fsth0, &env->active_fpu.fp_status); + fsth2 =3D float32_add(fstl1, fsth1, &env->active_fpu.fp_status); update_fcr31(env, GETPC()); - return ((uint64_t)fsth2 << 32) | fst2; + return ((uint64_t)fsth2 << 32) | fstl2; } =20 uint64_t helper_float_mulr_ps(CPUMIPSState *env, uint64_t fdt0, uint64_t f= dt1) { - uint32_t fst0 =3D fdt0 & 0XFFFFFFFF; + uint32_t fstl0 =3D fdt0 & 0XFFFFFFFF; uint32_t fsth0 =3D fdt0 >> 32; - uint32_t fst1 =3D fdt1 & 0XFFFFFFFF; + uint32_t fstl1 =3D fdt1 & 0XFFFFFFFF; uint32_t fsth1 =3D fdt1 >> 32; - uint32_t fst2; + uint32_t fstl2; uint32_t fsth2; =20 - fst2 =3D float32_mul(fst0, fsth0, &env->active_fpu.fp_status); - fsth2 =3D float32_mul(fst1, fsth1, &env->active_fpu.fp_status); + fstl2 =3D float32_mul(fstl0, fsth0, &env->active_fpu.fp_status); + fsth2 =3D float32_mul(fstl1, fsth1, &env->active_fpu.fp_status); update_fcr31(env, GETPC()); - return ((uint64_t)fsth2 << 32) | fst2; + return ((uint64_t)fsth2 << 32) | fstl2; } =20 #define FLOAT_MINMAX(name, bits, minmaxfunc) \ --=20 2.20.1