From nobody Sat Feb 7 08:07:02 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1589635537; cv=none; d=zohomail.com; s=zohoarc; b=LTfMA1ZlsWV5YK8A07vq3OkWlr+gJka+jjSF4kU5O3bOX/Ruu74pQf/63/yKt5Yg/ZbvduoaaWpvnLfUtN0DIiv+5A6KL8sBgPVUVvrBhsgHC+1oRJ56Liu66gUNXzT/Am+qlPXHZ0xMOhv3h3xY1t3N3FWiXyfFJ2WLG/JcBAQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1589635537; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=U9cfnPg+MLBiCOh/kTFgkSM3KClsLG/Ou/q7NLbmsAM=; b=LhiKCflPrb8YS78FjvXWg7fLdG3F6FU4cb72BFRW1NR0tBm3u4BTb9ReZXgqWyZmcnG6NIBMevD0x5SwGeJNIhUJzYWRZzgYZqZ+4AMmwQcvwEHh0yVm+Yw58boZp/oxza38ImcYP+51huyJwPW0v2bwo7P9MfwZpd9r1Ve27aw= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1589635536920317.80163615977995; Sat, 16 May 2020 06:25:36 -0700 (PDT) Received: from localhost ([::1]:46874 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jZwop-0000YD-4r for importer@patchew.org; Sat, 16 May 2020 09:25:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53036) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jZwnz-0007uo-Me for qemu-devel@nongnu.org; Sat, 16 May 2020 09:24:43 -0400 Received: from zero.eik.bme.hu ([2001:738:2001:2001::2001]:16434) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jZwnv-0004Po-T3 for qemu-devel@nongnu.org; Sat, 16 May 2020 09:24:40 -0400 Received: from zero.eik.bme.hu (blah.eik.bme.hu [152.66.115.182]) by localhost (Postfix) with SMTP id 53578746333; Sat, 16 May 2020 15:23:52 +0200 (CEST) Received: by zero.eik.bme.hu (Postfix, from userid 432) id 39E9374594E; Sat, 16 May 2020 15:23:52 +0200 (CEST) From: BALATON Zoltan Subject: [PATCH] ati-vga: Do not allow unaligned access via index register Date: Sat, 16 May 2020 15:13:03 +0200 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable To: qemu-devel@nongnu.org Message-Id: <20200516132352.39E9374594E@zero.eik.bme.hu> X-Spam-Probability: 8% Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2001:738:2001:2001::2001; envelope-from=balaton@eik.bme.hu; helo=zero.eik.bme.hu X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Gerd Hoffmann Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" According to docs bits 1 and 0 of MM_INDEX are hard coded to 0 so unaligned access via this register should not be possible. This also fixes problems reported in bug #1878134. Signed-off-by: BALATON Zoltan Acked-by: Alexander Bulekov Tested-by: Alexander Bulekov --- hw/display/ati.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/display/ati.c b/hw/display/ati.c index f4c4542751..2ee23173b2 100644 --- a/hw/display/ati.c +++ b/hw/display/ati.c @@ -531,7 +531,7 @@ static void ati_mm_write(void *opaque, hwaddr addr, } switch (addr) { case MM_INDEX: - s->regs.mm_index =3D data; + s->regs.mm_index =3D data & ~3; break; case MM_DATA ... MM_DATA + 3: /* indexed access to regs or memory */ --=20 2.21.3