From nobody Tue Apr 15 03:57:25 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1589547748; cv=none; d=zohomail.com; s=zohoarc; b=jTcZ0p8JJriZGyaS6sF/mydTEuf0HQ613sVxWtkzaUgxr+4IwrllOHZyeufjeZB7tPozRm5R0KhriS5E8CD5ueAbNtlmY6DfdS9beYhkzKvepNsk/ch84jbS+eNaSCymn1601BQ4rp2kZ8VvYY+jDCRCvMD/o0PtMfF4mvrxHVs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1589547748; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=KtpNI9TIpqyeC8eNPxlzs8E9Rtgz2FJ7kWU3lqald08=; b=ZLxLk2HsXzgjZ82k4ZTMAErtWBUpxcc4NhdoXfAofmQ8coTBT9iAyHibUTS3Fbe1J1lek/pnUpybcSzluCJ7T8zCIxdltMPjWtGxsNTyM2yhBjQbo65sNr+6h+JFXqhyIaW1k/AJNBo/K9G3Izrh7Ja5jPycZEnDYZyYvvkPxwg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1589547748176394.0062325704206; Fri, 15 May 2020 06:02:28 -0700 (PDT) Received: from localhost ([::1]:50764 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jZZyt-00008y-8g for importer@patchew.org; Fri, 15 May 2020 09:02:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45968) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jZZjd-0003pB-DB for qemu-devel@nongnu.org; Fri, 15 May 2020 08:46:41 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:25300 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jZZjb-0002Ty-LP for qemu-devel@nongnu.org; Fri, 15 May 2020 08:46:40 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-400-nMnhWcBuNjuiX8PLe-Zz-A-1; Fri, 15 May 2020 08:46:36 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D6F138005AD; Fri, 15 May 2020 12:46:35 +0000 (UTC) Received: from linux.fritz.box.com (ovpn-113-110.ams2.redhat.com [10.36.113.110]) by smtp.corp.redhat.com (Postfix) with ESMTP id DCD662E166; Fri, 15 May 2020 12:46:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1589546798; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KtpNI9TIpqyeC8eNPxlzs8E9Rtgz2FJ7kWU3lqald08=; b=JZWEhborc3l6ModitRrTf5TZXd2VdB3krYHjwzbxE1jFvabxBOxc1w5+CBk4jLLzxPph5y wLu0XuQGVbwem2MSL/bNgfjmHHkOxZMMaj8Ttet8FpBwz4Op3wur+WpqKCVQVU9UFLA439 QPa16FLXNGkz8kp7QMn6sugY4DIwY9Y= X-MC-Unique: nMnhWcBuNjuiX8PLe-Zz-A-1 From: Kevin Wolf To: qemu-block@nongnu.org Subject: [PULL 47/51] block/block-copy: Fix uninitialized variable in block_copy_task_entry Date: Fri, 15 May 2020 14:45:17 +0200 Message-Id: <20200515124521.335403-48-kwolf@redhat.com> In-Reply-To: <20200515124521.335403-1-kwolf@redhat.com> References: <20200515124521.335403-1-kwolf@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.139.110.120; envelope-from=kwolf@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/14 23:27:07 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, peter.maydell@linaro.org, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) From: Philippe Mathieu-Daud=C3=A9 Fix when building with -Os: CC block/block-copy.o block/block-copy.c: In function =E2=80=98block_copy_task_entry=E2=80=99: block/block-copy.c:428:38: error: =E2=80=98error_is_read=E2=80=99 may be = used uninitialized in this function [-Werror=3Dmaybe-uninitialized] 428 | t->call_state->error_is_read =3D error_is_read; | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~ Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20200507121129.29760-2-philmd@redhat.com> Reviewed-by: Eric Blake Signed-off-by: Kevin Wolf --- block/block-copy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/block-copy.c b/block/block-copy.c index 4713c8f2a3..7c7f7acbae 100644 --- a/block/block-copy.c +++ b/block/block-copy.c @@ -418,7 +418,7 @@ out: static coroutine_fn int block_copy_task_entry(AioTask *task) { BlockCopyTask *t =3D container_of(task, BlockCopyTask, task); - bool error_is_read; + bool error_is_read =3D false; int ret; =20 ret =3D block_copy_do_copy(t->s, t->offset, t->bytes, t->zeroes, --=20 2.25.4