From nobody Fri Nov 14 19:22:30 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1589530979; cv=none; d=zohomail.com; s=zohoarc; b=l79ImFptm5sTK8DOFmZSoJpQEAENnzp8dkiFMgYwcFsHucpK08yOkiBg4A1C7G3Hk8CEmqm/yI2srJ+OysWffVIoxu1AAWOdPsoHXZMZuagm9SMh0WVeZJiWjVtuuoTvmZ8OnJbx7/ZwEtRrKfseuoyp6G6RcUXGSfNJVxpQSHA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1589530979; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=jRMZC5OSX7ykSRfi5pqfB6bzNGtkWLXupu/WFBt08dk=; b=UNy2Jl54Ztl/fGhgwhWwSpFc8k4IK4fmcwMq+QhBLMVd1I218M1QfLpUFls8Y/A9tK3A3ToGPOLQXapea88Eo2O6qsFcATPIenI8hk9HdUylQRqgGFuEdT36smd1HibFHz/OzQcrGoH0LQG0bklBBg3u24rYHZDn8gXhIUVgCkU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1589530979023818.2322843383535; Fri, 15 May 2020 01:22:59 -0700 (PDT) Received: from localhost ([::1]:52008 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jZVcP-00058A-CL for importer@patchew.org; Fri, 15 May 2020 04:22:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51506) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jZVbP-0002h7-OL for qemu-devel@nongnu.org; Fri, 15 May 2020 04:21:55 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:43680 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jZVbO-000735-6i for qemu-devel@nongnu.org; Fri, 15 May 2020 04:21:54 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-488-ob76ASCDNiyf0K_JKDQPCQ-1; Fri, 15 May 2020 04:21:50 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id EC674EC1B0; Fri, 15 May 2020 08:21:49 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-115-145.ams2.redhat.com [10.36.115.145]) by smtp.corp.redhat.com (Postfix) with ESMTP id BB1F25D9F3; Fri, 15 May 2020 08:21:46 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id C14201750A; Fri, 15 May 2020 10:21:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1589530912; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:content-type:content-type:in-reply-to:in-reply-to: references:references; bh=jRMZC5OSX7ykSRfi5pqfB6bzNGtkWLXupu/WFBt08dk=; b=H8sV7nwRC41PeZ1d0nHy3XifVnih081DTtGQNZJuKmt4z/GyWgnWRVa2D9dehOSGiAQTir IMSgTgsPXBhUX+Ur2A79KdUd9k4jhS57TgUBKrf1+mFwN3XVisVnMzGzPvWN6MOYKEli2q PEyjPx+Jl6tp+ot1UJvPrEA4F/Rte68= X-MC-Unique: ob76ASCDNiyf0K_JKDQPCQ-1 From: Gerd Hoffmann To: qemu-devel@nongnu.org Subject: [PULL 2/2] ui/sdl2: fix segment fault caused by null pointer dereference Date: Fri, 15 May 2020 10:21:45 +0200 Message-Id: <20200515082145.4732-3-kraxel@redhat.com> In-Reply-To: <20200515082145.4732-1-kraxel@redhat.com> References: <20200515082145.4732-1-kraxel@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.139.110.120; envelope-from=kraxel@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/14 23:27:07 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , Gerd Hoffmann , Changbin Du Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Changbin Du I found SDL_GetWindowFromID() sometimes return NULL when I start qemu via ssh forwarding even the window has been crated already. I am not sure whether this is a bug of SDL, but we'd better check it carefully. Signed-off-by: Changbin Du Message-id: 20200427132412.17909-1-changbin.du@gmail.com Signed-off-by: Gerd Hoffmann --- ui/sdl2.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/ui/sdl2.c b/ui/sdl2.c index 3c9424eb42c3..61c7956da334 100644 --- a/ui/sdl2.c +++ b/ui/sdl2.c @@ -332,6 +332,10 @@ static void handle_keydown(SDL_Event *ev) int gui_key_modifier_pressed =3D get_mod_state(); int gui_keysym =3D 0; =20 + if (!scon) { + return; + } + if (!scon->ignore_hotkeys && gui_key_modifier_pressed && !ev->key.repe= at) { switch (ev->key.keysym.scancode) { case SDL_SCANCODE_2: @@ -412,6 +416,10 @@ static void handle_keyup(SDL_Event *ev) { struct sdl2_console *scon =3D get_scon_from_window(ev->key.windowID); =20 + if (!scon) { + return; + } + scon->ignore_hotkeys =3D false; sdl2_process_key(scon, &ev->key); } @@ -421,6 +429,10 @@ static void handle_textinput(SDL_Event *ev) struct sdl2_console *scon =3D get_scon_from_window(ev->text.windowID); QemuConsole *con =3D scon ? scon->dcl.con : NULL; =20 + if (!con) { + return; + } + if (qemu_console_is_graphic(con)) { return; } --=20 2.18.4