From nobody Fri Nov 14 18:16:55 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1589469495; cv=none; d=zohomail.com; s=zohoarc; b=Dt7sZL/80SlX+F/56WEl+PsBsCw+6t4KvkItM2ErMdPhiK2n3jyqx27atza1JSUmZ2Wf/9c+0OnYTJgA0Y/fDS5uGi1nRuTrJjc7eDSwJkJgCcs3PvPSrcmt67l/oEjFXde1SgkvCYJEozs5ZG/Ctp8aarrVt9lwrlOINSuQb+0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1589469495; h=Content-Type:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=ZdoSemO+CEcJZ8IM7vaGir0gUiR19EhUeUGylY0GoVU=; b=oKIZi5+QlcnwprSmqxLDY5lmnpD+x4OviqwC/FRz+0tyfm1dmDAodY0Habiu7h06TPAvmlVtEfFBlXOWiVOYocwmld47f58aVE44qD5ShrFnFHWTpjs05M7ufDcVgmN4Jpz2jou14kQVlio+s7hFnRZOjfVHSwx4s42GRO3fKY0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1589469495711550.4435073008731; Thu, 14 May 2020 08:18:15 -0700 (PDT) Received: from localhost ([::1]:37022 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jZFck-0005zP-Ea for importer@patchew.org; Thu, 14 May 2020 11:18:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47772) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jZFbf-0003wn-NA for qemu-devel@nongnu.org; Thu, 14 May 2020 11:17:07 -0400 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:42745 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jZFbe-0002ca-Po for qemu-devel@nongnu.org; Thu, 14 May 2020 11:17:07 -0400 Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-360-xMoGqGjNNQOsn3Gf3h3-jQ-1; Thu, 14 May 2020 11:17:02 -0400 Received: by mail-wr1-f72.google.com with SMTP id x8so1721801wrl.16 for ; Thu, 14 May 2020 08:17:02 -0700 (PDT) Received: from redhat.com (bzq-79-179-68-225.red.bezeqint.net. [79.179.68.225]) by smtp.gmail.com with ESMTPSA id 60sm4583208wrp.92.2020.05.14.08.16.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 May 2020 08:17:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1589469425; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type; bh=ZdoSemO+CEcJZ8IM7vaGir0gUiR19EhUeUGylY0GoVU=; b=JwnMZoqtmP5wx82knoCbk46ZkGjzyhBSFgajj7ql7DcnqEeOyN5vY0sOtvEbqPwBbfm5SU wBBzq6CjNgy3owfT+R+gwYamQHEBhwYL3THj/4vWwPYlQ9ELxdIfLj65Ka5RF6CVYnIo+/ IqXi1FLXMJwU8HW6/1INWwYrfuQJIJ8= X-MC-Unique: xMoGqGjNNQOsn3Gf3h3-jQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition; bh=ZdoSemO+CEcJZ8IM7vaGir0gUiR19EhUeUGylY0GoVU=; b=rPxpsfCjQ6ul6NFQtLxbi28zCc8NOycmIBtS/3aaONZUZL53iOjQNYqw7Yec0Q8w90 vAdutMspzJoFL5P+qgFNx+jaPNDRkHloIlOW7s0G673oSKNo1AUKlWsQEStIKAq4zupn SPFe+ncysIv7brbHFr5ypFnxsB6rYCIUEuMM+AFJK2WcNVVKRnrPdnP/TluxsZjXLJ9z KKZriLExG1ZRbVSEY7NY0ZKLTnbmflI6pKZy3MXP6oWmjGJlr1b4PCJSeUeqXMjJUto3 RbXP/OpiPDOgsxad1Gzr7Ir7yxuFitk9vgENn5rMzSA9LgEx2sF3EMgOIJKOaGYPetfv 0+2Q== X-Gm-Message-State: AOAM531x+DsQD4TMbRCmqktFtYAEA9HLmG0pj1t0peHWI/D74oecQbyY dynX2DC1TZHSAIj7FqN8iXOWXOJkgdsceASItQYQuqDsaRoQEaHSJ2Z6asBWhHBS/ymHZo0pZXO YSBMb0Y4rLB02QzE= X-Received: by 2002:a5d:414f:: with SMTP id c15mr6025606wrq.61.1589469421045; Thu, 14 May 2020 08:17:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzAvCmOEMRJsZ/HRx1Sqe/Y/3PWekTh0cQ6tg2SJCCXH9lYM3H82/uayxMROdVro1k14nkJ7A== X-Received: by 2002:a5d:414f:: with SMTP id c15mr6025589wrq.61.1589469420831; Thu, 14 May 2020 08:17:00 -0700 (PDT) Date: Thu, 14 May 2020 11:16:58 -0400 From: "Michael S. Tsirkin" To: qemu-devel@nongnu.org Subject: [PATCH] msix: allow qword MSI-X table accesses Message-ID: <20200514151648.877882-1-mst@redhat.com> MIME-Version: 1.0 X-Mailer: git-send-email 2.24.1.751.gd10ce2899c X-Mutt-Fcc: =sent X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.139.110.61; envelope-from=mst@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/13 22:25:42 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jusual@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" PCI spec says: For all accesses to MSI-X Table and MSI-X PBA fields, software must use aligned full DWORD or aligned full QWORD transactions; otherwise, the result is undefined. However, since MSI-X was converted to use memory API, QEMU started blocking qword transactions, only allowing DWORD ones. Guests do not seem to use QWORD accesses, but let's be spec compliant. Fixes: 95524ae8dc8f ("msix: convert to memory API") Signed-off-by: Michael S. Tsirkin Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/pci/msix.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/hw/pci/msix.c b/hw/pci/msix.c index 29187898f2..e6a5559038 100644 --- a/hw/pci/msix.c +++ b/hw/pci/msix.c @@ -199,6 +199,9 @@ static const MemoryRegionOps msix_table_mmio_ops =3D { .endianness =3D DEVICE_LITTLE_ENDIAN, .valid =3D { .min_access_size =3D 4, + .max_access_size =3D 8, + }, + .impl =3D { .max_access_size =3D 4, }, }; @@ -227,6 +230,9 @@ static const MemoryRegionOps msix_pba_mmio_ops =3D { .endianness =3D DEVICE_LITTLE_ENDIAN, .valid =3D { .min_access_size =3D 4, + .max_access_size =3D 8, + }, + .impl =3D { .max_access_size =3D 4, }, }; --=20 MST