From nobody Fri Dec 19 04:29:31 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1589467549; cv=none; d=zohomail.com; s=zohoarc; b=k6+XWWPZHfxUyCDzTkrwTJ6NuLmLIWXf2VVBLBH37Tk8z5lqeR/6RP/x2OmyqokwTu2ahXVYCV+w7I7VqF4XjxZ7yXT3k+BOnAq0GBSAeIs/UptpbRe/+OUg34L/a06MaoSsf8JSu8/m0PQOxdBcTsY81RZH2ody1LRCV8SM8iY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1589467549; h=Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=9E2a6m7F5ZssSmao8aF1y6xe2lQzquAMmYI0Hdbp6MU=; b=hQ+XW2WBzJ2v/pGznYht2Bya/83ARXPp3VF+2dmfPX2tGWuev02utkBwPNBbBSuU2EiWZx0FIESAhcFneUOof47ZubJcF3sVzKbG7i/5I6g8m2wPLwrObpr0EkaEkKDMSAA8FVZSeze78gYs0SyyCx0RFy+jUZbF/GEb6dPiJTk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 15894675492001013.5651454816056; Thu, 14 May 2020 07:45:49 -0700 (PDT) Received: from localhost ([::1]:50348 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jZF7L-0003ns-S1 for importer@patchew.org; Thu, 14 May 2020 10:45:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39710) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jZEkp-0003vr-VE for qemu-devel@nongnu.org; Thu, 14 May 2020 10:22:31 -0400 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]:35401) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jZEko-00060o-V9 for qemu-devel@nongnu.org; Thu, 14 May 2020 10:22:31 -0400 Received: by mail-wm1-x336.google.com with SMTP id n5so18018053wmd.0 for ; Thu, 14 May 2020 07:22:30 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [81.2.115.148]) by smtp.gmail.com with ESMTPSA id 88sm4077443wrq.77.2020.05.14.07.22.28 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 May 2020 07:22:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=9E2a6m7F5ZssSmao8aF1y6xe2lQzquAMmYI0Hdbp6MU=; b=Xz5tRWcnGP9v9GvkpGCE9h9LOQ4ztMHcfR6irBAcG2bZpmMepRgnFLFqrDcu9rQsKl RaFrkm/geOcJyosxK/0PWwbiGcXZrrZuws0uUy7KmKW3aQ2Y8YvYcq147woXxsZ14TIE W2ZTHyj/vVuCpevM8u9X02XAoQaCfbDJrBIiKPc4HCJT+LRlndrKcSLSp97cKKHiHwuc lHR0WPu67RKQcYJF+R5SATJtV4v6CMMYuEr390laWhGD0lZLjU7hWt/b173v/HnHxk26 UpC/l2OoVAGKUbPpk5namRtUy06TMfET3bwBv3oDbMsk0EMCevP9EmTdKjABJSbZ3CsE l6iQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9E2a6m7F5ZssSmao8aF1y6xe2lQzquAMmYI0Hdbp6MU=; b=qwzw1+xezVc6TqnI40k+Cvm6Pn9ns+DQHgFCGatuobm9wm4w0a23skU3BIi0Y4Jnw3 qo5IrRhr4SS4ySkXPUFSuQcwqTL3bM3/ORNuZVG6H0LUSVbwggpMh9Dy8CtlozJwIn1d OJiiodvu9xiRvfPdSJHmUncrkstYuYnXUjFufRlN55IyaRHvhkOf1hNY/bO0iYOOXKsR d/6ruB25ZQkm9FeQKqfBQwgRPY+BChli27w0hJB6ypQTwg0YzX4+x1sLGj2B9FYyunYx L7ohBJSyYUmjNvazXchUoTHA13sz9kN4NPbz7rELY7A+6IU0v4gpNksaKpmEwuB/1WEZ K78Q== X-Gm-Message-State: AGi0PuYcJAa7HHNdp+ll8kyhMl1AjD/l0NGc9uN7Bwi0o1/Q0tkT7Txd SXaBZp5YGA6qefNbF/EgPpqsV1rX3Sb/qA== X-Google-Smtp-Source: APiQypIvEJWWykeMB8jzf1d7gbcrf2McrS0t0oB+bZAbdLERcCR0Y0ZpD07PMRAh1O1mu8fWiKT3Aw== X-Received: by 2002:a1c:f615:: with SMTP id w21mr46753481wmc.183.1589466149199; Thu, 14 May 2020 07:22:29 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PULL 38/45] target/arm: Convert Neon VQDMULH/VQRDMULH 3-reg-same to decodetree Date: Thu, 14 May 2020 15:21:31 +0100 Message-Id: <20200514142138.20875-39-peter.maydell@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200514142138.20875-1-peter.maydell@linaro.org> References: <20200514142138.20875-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::336; envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x336.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) Content-Type: text/plain; charset="utf-8" Convert the Neon VQDMULH and VQRDMULH 3-reg-same insns to decodetree. These are the last integer operations in the 3-reg-same group. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson Message-id: 20200512163904.10918-11-peter.maydell@linaro.org --- target/arm/neon-dp.decode | 3 +++ target/arm/translate-neon.inc.c | 24 ++++++++++++++++++++++++ target/arm/translate.c | 24 +----------------------- 3 files changed, 28 insertions(+), 23 deletions(-) diff --git a/target/arm/neon-dp.decode b/target/arm/neon-dp.decode index 3659fb036c7..fd32837fb17 100644 --- a/target/arm/neon-dp.decode +++ b/target/arm/neon-dp.decode @@ -152,6 +152,9 @@ VPMAX_U_3s 1111 001 1 0 . .. .... .... 1010 . . .= 0 .... @3same_q0 VPMIN_S_3s 1111 001 0 0 . .. .... .... 1010 . . . 1 .... @3same_q0 VPMIN_U_3s 1111 001 1 0 . .. .... .... 1010 . . . 1 .... @3same_q0 =20 +VQDMULH_3s 1111 001 0 0 . .. .... .... 1011 . . . 0 .... @3same +VQRDMULH_3s 1111 001 1 0 . .. .... .... 1011 . . . 0 .... @3same + VPADD_3s 1111 001 0 0 . .. .... .... 1011 . . . 1 .... @3same_q0 =20 VQRDMLAH_3s 1111 001 1 0 . .. .... .... 1011 ... 1 .... @3same diff --git a/target/arm/translate-neon.inc.c b/target/arm/translate-neon.in= c.c index e0137364075..f52302f42b1 100644 --- a/target/arm/translate-neon.inc.c +++ b/target/arm/translate-neon.inc.c @@ -997,3 +997,27 @@ DO_3SAME_PAIR(VPMIN_S, pmin_s) DO_3SAME_PAIR(VPMAX_U, pmax_u) DO_3SAME_PAIR(VPMIN_U, pmin_u) DO_3SAME_PAIR(VPADD, padd_u) + +#define DO_3SAME_VQDMULH(INSN, FUNC) \ + WRAP_ENV_FN(gen_##INSN##_tramp16, gen_helper_neon_##FUNC##_s16); \ + WRAP_ENV_FN(gen_##INSN##_tramp32, gen_helper_neon_##FUNC##_s32); \ + static void gen_##INSN##_3s(unsigned vece, uint32_t rd_ofs, \ + uint32_t rn_ofs, uint32_t rm_ofs, \ + uint32_t oprsz, uint32_t maxsz) \ + { \ + static const GVecGen3 ops[2] =3D { \ + { .fni4 =3D gen_##INSN##_tramp16 }, \ + { .fni4 =3D gen_##INSN##_tramp32 }, \ + }; \ + tcg_gen_gvec_3(rd_ofs, rn_ofs, rm_ofs, oprsz, maxsz, &ops[vece - 1= ]); \ + } \ + static bool trans_##INSN##_3s(DisasContext *s, arg_3same *a) \ + { \ + if (a->size !=3D 1 && a->size !=3D 2) { = \ + return false; \ + } \ + return do_3same(s, a, gen_##INSN##_3s); \ + } + +DO_3SAME_VQDMULH(VQDMULH, qdmulh) +DO_3SAME_VQDMULH(VQRDMULH, qrdmulh) diff --git a/target/arm/translate.c b/target/arm/translate.c index ce30417014d..561cb67286d 100644 --- a/target/arm/translate.c +++ b/target/arm/translate.c @@ -5432,6 +5432,7 @@ static int disas_neon_data_insn(DisasContext *s, uint= 32_t insn) case NEON_3R_VPMAX: case NEON_3R_VPMIN: case NEON_3R_VPADD_VQRDMLAH: + case NEON_3R_VQDMULH_VQRDMULH: /* Already handled by decodetree */ return 1; } @@ -5496,29 +5497,6 @@ static int disas_neon_data_insn(DisasContext *s, uin= t32_t insn) tmp2 =3D neon_load_reg(rm, pass); } switch (op) { - case NEON_3R_VQDMULH_VQRDMULH: /* Multiply high. */ - if (!u) { /* VQDMULH */ - switch (size) { - case 1: - gen_helper_neon_qdmulh_s16(tmp, cpu_env, tmp, tmp2); - break; - case 2: - gen_helper_neon_qdmulh_s32(tmp, cpu_env, tmp, tmp2); - break; - default: abort(); - } - } else { /* VQRDMULH */ - switch (size) { - case 1: - gen_helper_neon_qrdmulh_s16(tmp, cpu_env, tmp, tmp2); - break; - case 2: - gen_helper_neon_qrdmulh_s32(tmp, cpu_env, tmp, tmp2); - break; - default: abort(); - } - } - break; case NEON_3R_FLOAT_ARITH: /* Floating point arithmetic. */ { TCGv_ptr fpstatus =3D get_fpstatus_ptr(1); --=20 2.20.1