From nobody Fri Nov 14 18:02:31 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1589436281; cv=none; d=zohomail.com; s=zohoarc; b=mYUvT/GEdknmzY1r1nyzEYfeb1btwYhZpDyO16krmGiq4egEA1/8xETJVXQahe7MzR3vWfkTAW9PwsaG3D8E7NloG6fdaVbzShFqYHYkKCF3bpMboO3y8Uf65dqz6zuI71wzC8MTVIEx2NIiwZe3WPwSyZWJGpUNQke6ortYtUE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1589436281; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=/tVN0afalNgUBbGXwQsgXCGn6NurJEflGZeF3kN7Gek=; b=Vf1tibTVYpXeB/VXySpyEJ57z28O/5xUbjDKqoB9DQVNnpjt28bVmsoRXUjSz48PoN9MjTc4rmbjpp+bxqJ8nRvgY2jB3r0TgI4188ifxax5+ugZf9T8zoLMDubBWGjF6k57utYJtayvgz9TAczXXrKj/41Gk9WAAuwOldyAPr4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1589436281705750.526312051442; Wed, 13 May 2020 23:04:41 -0700 (PDT) Received: from localhost ([::1]:42570 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jZ6z2-0001JO-Ao for importer@patchew.org; Thu, 14 May 2020 02:04:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36568) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jZ6pY-0005dG-4i for qemu-devel@nongnu.org; Thu, 14 May 2020 01:54:52 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:59871 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jZ6pX-0001gk-5P for qemu-devel@nongnu.org; Thu, 14 May 2020 01:54:51 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-328-fsTI_4BEMVSSEUIoa571Pw-1; Thu, 14 May 2020 01:54:48 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5ECFF107ACF3; Thu, 14 May 2020 05:54:47 +0000 (UTC) Received: from probe.redhat.com (ovpn-113-9.rdu2.redhat.com [10.10.113.9]) by smtp.corp.redhat.com (Postfix) with ESMTP id F16F36A977; Thu, 14 May 2020 05:54:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1589435690; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/tVN0afalNgUBbGXwQsgXCGn6NurJEflGZeF3kN7Gek=; b=XKXdom4ULknmZQzfTfoLzGp/ssk4STotexo502oqJ8xbRBUef+6+TfH3JGrPbS0XRTo43W IHWZoF1va8HdNmgbnALCPWx/So8xRhU25Ne3egc4z/2APV4UHGuTYVCr3bYIH5/eiJvQmT UUqVLwtSk9Bq06wt0BObE0UEpaSUUxA= X-MC-Unique: fsTI_4BEMVSSEUIoa571Pw-1 From: John Snow To: qemu-devel@nongnu.org Subject: [PATCH RFC 21/32] python//machine.py: remove logging configuration Date: Thu, 14 May 2020 01:53:52 -0400 Message-Id: <20200514055403.18902-22-jsnow@redhat.com> In-Reply-To: <20200514055403.18902-1-jsnow@redhat.com> References: <20200514055403.18902-1-jsnow@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.139.110.61; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/13 22:25:42 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Kevin Wolf , Vladimir Sementsov-Ogievskiy , Eduardo Habkost , qemu-block@nongnu.org, =?UTF-8?q?Alex=20Benn=C3=A9e?= , Markus Armbruster , Max Reitz , John Snow , Cleber Rosa , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Python 3.5 and above do not print a warning when logging is not configured. As a library, it's best practice to leave logging configuration to the client executable. Signed-off-by: John Snow Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- python/qemu/lib/machine.py | 3 --- 1 file changed, 3 deletions(-) diff --git a/python/qemu/lib/machine.py b/python/qemu/lib/machine.py index c31bf7cabb..e92afe8649 100644 --- a/python/qemu/lib/machine.py +++ b/python/qemu/lib/machine.py @@ -110,9 +110,6 @@ def __init__(self, binary, args=3DNone, wrapper=3DNone,= name=3DNone, self._console_socket =3D None self._remove_files =3D [] =20 - # just in case logging wasn't configured by the main script: - logging.basicConfig() - def __enter__(self): return self =20 --=20 2.21.1