From nobody Fri Nov 14 18:02:26 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1589436185; cv=none; d=zohomail.com; s=zohoarc; b=eT8/JEJoaHx0vULWJF/CKi44VPgWicOsZKsve5XO9Q5tXrYjdUAa46TCYIgs8FzOM1P6+TrFzlITKOL3dag4Rt2SR9v8I/j/d4XkXODBA0NN5GG2spTQ9GJk3RShX81LtiS+NEpkU/xN8UXLkdNth00Nh2UXcZBQTpiUrZfZq3M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1589436185; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=bL6cC0ljly/wbLmslRqO+su0FKs1lFJp2Wid4hDE+q8=; b=WuKus/5yMxAdW5/XDu9VwJDUgzBAKX6X5T7gT/ZwqRvr+vAAvCWE7qhNDGsr3zsPFUO2hw3uLVz6JU1wEuslKTwwn1zAiw/ODGWcoN8IkDE0A20d/v33SRO4aj6IaMY/xis9B1Ls++ktGQmAhB6yVLxZMmZtRNtByEV3V5HpixE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1589436185874184.25222873279313; Wed, 13 May 2020 23:03:05 -0700 (PDT) Received: from localhost ([::1]:35210 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jZ6xU-0006lr-FC for importer@patchew.org; Thu, 14 May 2020 02:03:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36564) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jZ6pX-0005cl-BY for qemu-devel@nongnu.org; Thu, 14 May 2020 01:54:51 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:51799 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jZ6pV-0001gg-Mc for qemu-devel@nongnu.org; Thu, 14 May 2020 01:54:51 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-185-7I3zEvAlMtCmSzMHJo36Iw-1; Thu, 14 May 2020 01:54:47 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C5DA4800053; Thu, 14 May 2020 05:54:45 +0000 (UTC) Received: from probe.redhat.com (ovpn-113-9.rdu2.redhat.com [10.10.113.9]) by smtp.corp.redhat.com (Postfix) with ESMTP id 656367D952; Thu, 14 May 2020 05:54:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1589435689; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bL6cC0ljly/wbLmslRqO+su0FKs1lFJp2Wid4hDE+q8=; b=HB3A6NxL6QtqboThhC+qUU57Nz2uGoyZBfL0Oh6NlR94Y2cO7yJEobO9trt44tNTFi0zB/ qefwC+yBQkfGE0al/1BgbYHCvh013nJBQHNAo559wHrLHMq3GWepefEg1l7VDhfBHoZFv4 AuFLTIdneOZ6zxnmp8hG6trR0UbDxC0= X-MC-Unique: 7I3zEvAlMtCmSzMHJo36Iw-1 From: John Snow To: qemu-devel@nongnu.org Subject: [PATCH RFC 20/32] python//qmp.py: assert sockfile is not None Date: Thu, 14 May 2020 01:53:51 -0400 Message-Id: <20200514055403.18902-21-jsnow@redhat.com> In-Reply-To: <20200514055403.18902-1-jsnow@redhat.com> References: <20200514055403.18902-1-jsnow@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=207.211.31.81; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/13 22:25:46 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Kevin Wolf , Vladimir Sementsov-Ogievskiy , Eduardo Habkost , qemu-block@nongnu.org, =?UTF-8?q?Alex=20Benn=C3=A9e?= , Markus Armbruster , Max Reitz , John Snow , Cleber Rosa , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" In truth, if you don't do this, you'll just get a TypeError exception. Now, you'll get an AssertionError. Is this tangibly better? No. Does mypy complain less? Yes. Signed-off-by: John Snow Acked-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- python/qemu/lib/qmp.py | 1 + 1 file changed, 1 insertion(+) diff --git a/python/qemu/lib/qmp.py b/python/qemu/lib/qmp.py index 5fb16f4b42..1aefc00c93 100644 --- a/python/qemu/lib/qmp.py +++ b/python/qemu/lib/qmp.py @@ -132,6 +132,7 @@ def __negotiate_capabilities(self): raise QMPCapabilitiesError =20 def __json_read(self, only_event=3DFalse): + assert self.__sockfile is not None while True: data =3D self.__sockfile.readline() if not data: --=20 2.21.1