From nobody Mon Feb 9 10:28:39 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1589398176; cv=none; d=zohomail.com; s=zohoarc; b=c786AMk9lXh7InvNCWpqPZwQBjSeuKA0lZOQEJHtOMeoDUjSeFUfhT+yMjqTjctSSXRIbyhIGnWTlm1LrmmuF5yL1DLSQkjMm1L/9Axv251QbuA2GiKaD9kq0FoslGujUwB2Ta0JKKI6LlBi9KgQGSVcssU+1BFDwSqaswncuXM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1589398176; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=g7Wwtk9ifLt2PW9urZRkD/faqZdWOc0LKdJZFY+87xA=; b=aN3tqnAjVhMaB9Ju904h6LiCnM+GEJpF9H88k7fFPGkg/IGdGmtqGREbmMPtm6DXpmRQ1oJcNhCyARl3Httt3wNIl4aFOPUPTrRW7RhCXYxPhx+H4ZDePz+AaH2VPOhqyLwL4emhmL/d92pZBpNnLf3myVjTFCepTMHWt1W309s= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 158939817630848.76024584891479; Wed, 13 May 2020 12:29:36 -0700 (PDT) Received: from localhost ([::1]:33592 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jYx4Q-0001p0-Vg for importer@patchew.org; Wed, 13 May 2020 15:29:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45778) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jYx3G-0000Pz-7Q for qemu-devel@nongnu.org; Wed, 13 May 2020 15:28:27 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:38579 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jYx3F-0000gL-Bg for qemu-devel@nongnu.org; Wed, 13 May 2020 15:28:21 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-104-yQ0E7Sn-OsivOsMxnUBH8Q-1; Wed, 13 May 2020 15:28:18 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1C4E6102CE3C; Wed, 13 May 2020 19:28:17 +0000 (UTC) Received: from localhost.localdomain (unknown [10.74.9.109]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 86B0B6A977; Wed, 13 May 2020 19:28:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1589398100; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=g7Wwtk9ifLt2PW9urZRkD/faqZdWOc0LKdJZFY+87xA=; b=CRtFKZpGZ9MeqZcISkzv91NXDmPbzz2PHB0LqUSboXM9EYIkWSosankGSwp710hgIU8dJb PDUc/ORwdftA4tQ5OwW9rXWgvRU36apz+f+HSpoP+WfXe8oQNUmSff/p+D0zSdXO4K5AYh dUhbMIGDz4loFXFg+TJNiF/iU+RxYho= X-MC-Unique: yQ0E7Sn-OsivOsMxnUBH8Q-1 From: P J P To: QEMU Developers Subject: [PATCH v2 2/3] megasas: avoid NULL pointer dereference Date: Thu, 14 May 2020 00:55:39 +0530 Message-Id: <20200513192540.1583887-3-ppandit@redhat.com> In-Reply-To: <20200513192540.1583887-1-ppandit@redhat.com> References: <20200513192540.1583887-1-ppandit@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.139.110.61; envelope-from=ppandit@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/13 01:56:38 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Prasad J Pandit , Alexander Bulekov , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Ding Ren , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" From: Prasad J Pandit While in megasas_handle_frame(), megasas_enqueue_frame() may set a NULL frame into MegasasCmd object for a given 'frame_addr' address. Add check to avoid a NULL pointer dereference issue. Reported-by: Alexander Bulekov Fixes: https://bugs.launchpad.net/qemu/+bug/1878259 Signed-off-by: Prasad J Pandit Acked-by: Alexander Bulekov Reviewed-by: Darren Kenny --- hw/scsi/megasas.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/scsi/megasas.c b/hw/scsi/megasas.c index 6ce598cd69..b531d88a9b 100644 --- a/hw/scsi/megasas.c +++ b/hw/scsi/megasas.c @@ -504,7 +504,7 @@ static MegasasCmd *megasas_enqueue_frame(MegasasState *= s, cmd->pa =3D frame; /* Map all possible frames */ cmd->frame =3D pci_dma_map(pcid, frame, &frame_size_p, 0); - if (frame_size_p !=3D frame_size) { + if (!cmd->frame || frame_size_p !=3D frame_size) { trace_megasas_qf_map_failed(cmd->index, (unsigned long)frame); if (cmd->frame) { megasas_unmap_frame(s, cmd); --=20 2.25.4