From nobody Thu Dec 18 17:52:00 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1589379630; cv=none; d=zohomail.com; s=zohoarc; b=KrmHH3cHuq4gMJHZhk8JrcZYLtzk7QVvxGwLqDaoRr1TNV0/IgcQxefKGBmvFklhK8TN+duw9Pi/V1mXnaBAXZcUFvaGC0/psPncCA+viq0taV1QpDHxe/RQpAR1QdzAx90+UgWWmTzZmtdf4B+e+UM530+7mWPKRQBM4c7W1MY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1589379630; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=h1k8HUcYyL4hDAnK3l2APn0LlvRmFkrYOBkWYcZxP8Y=; b=BZy4IzsmOaGOMQgz3A+kmnV74djtECa7nFVr1yO1ozypVdcYVLxu6RfLrPA9n5hyy7U7WwfImdrDheoB+QEfycnUnnmSBIFTaURGEOgo0ZhM/j1XoZswLf7SvBMobyyIyamRvB/vSKZaPzNVUZCkxw3XMAZlNSurt8P9s3NAwuY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1589379630252846.3118603611895; Wed, 13 May 2020 07:20:30 -0700 (PDT) Received: from localhost ([::1]:58816 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jYsFI-0004Jz-Rd for importer@patchew.org; Wed, 13 May 2020 10:20:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53578) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jYsBC-0005F5-9s for qemu-devel@nongnu.org; Wed, 13 May 2020 10:16:14 -0400 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:20010 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jYsBB-0006MN-JA for qemu-devel@nongnu.org; Wed, 13 May 2020 10:16:13 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-78-TuSNJ814NqSWrG_zfJhJMw-1; Wed, 13 May 2020 10:16:04 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C0D9018FF667; Wed, 13 May 2020 14:16:02 +0000 (UTC) Received: from localhost (unknown [10.40.193.218]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 57B4B600DB; Wed, 13 May 2020 14:16:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1589379372; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=h1k8HUcYyL4hDAnK3l2APn0LlvRmFkrYOBkWYcZxP8Y=; b=gTtPHZA7y0Mg9JiiQ/5G4JpC7LVzNT9L5VVczhK1v5nsEKhe1kiY8a7aQmUBZ/LPJyZ6Vd tMmLF/UGxmwVMu+3XwsIjYqJU4LVID1S+kG7Pw5mFrXz9+mH1tv60UUtPOgeM94G0kEYi+ edxQiHAGbIN4oOOWvngmUVgsBs43ecI= X-MC-Unique: TuSNJ814NqSWrG_zfJhJMw-1 From: Max Reitz To: qemu-block@nongnu.org Subject: [PULL 5/5] block/block-copy: fix use-after-free of task pointer Date: Wed, 13 May 2020 16:15:44 +0200 Message-Id: <20200513141544.1459069-6-mreitz@redhat.com> In-Reply-To: <20200513141544.1459069-1-mreitz@redhat.com> References: <20200513141544.1459069-1-mreitz@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.139.110.61; envelope-from=mreitz@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/13 01:56:38 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Peter Maydell , qemu-devel@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" From: Vladimir Sementsov-Ogievskiy Obviously, we should g_free the task after trace point and offset update. Reported-by: Coverity (CID 1428756) Fixes: 4ce5dd3e9b5ee0fac18625860eb3727399ee965e Signed-off-by: Vladimir Sementsov-Ogievskiy Message-Id: <20200507183800.22626-1-vsementsov@virtuozzo.com> Reviewed-by: Eric Blake Signed-off-by: Max Reitz --- block/block-copy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/block-copy.c b/block/block-copy.c index 03500680f7..4713c8f2a3 100644 --- a/block/block-copy.c +++ b/block/block-copy.c @@ -591,13 +591,13 @@ static int coroutine_fn block_copy_dirty_clusters(Blo= ckCopyState *s, } if (s->skip_unallocated && !(ret & BDRV_BLOCK_ALLOCATED)) { block_copy_task_end(task, 0); - g_free(task); progress_set_remaining(s->progress, bdrv_get_dirty_count(s->copy_bitmap) + s->in_flight_bytes); trace_block_copy_skip_range(s, task->offset, task->bytes); offset =3D task_end(task); bytes =3D end - offset; + g_free(task); continue; } task->zeroes =3D ret & BDRV_BLOCK_ZERO; --=20 2.26.2