From nobody Sun Feb 8 20:34:54 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1589378559; cv=none; d=zohomail.com; s=zohoarc; b=cz9TMx3MhYbCQXoPzNhqBWAx2/N3WS0/YbdeMVF/VHagzWX4+PFDQn8k6rXOkFSvwy0qu9SLW37STA+nGCKU471fTBBG6+jrWyQUF5VJhenoE+dbhwYzCmJCH9E83flK+ES0mcVtQWfOw29qs9N5oENoy08V/tjYIG0Qu+K1rrU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1589378559; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=elJpFRjL7L8vS4tJJiDj0rgRnL8BOZyY/mJqzTqXtQ0=; b=V+A9SjQMwAZLVPt8WP3jXXRqqO07Xhplk1BIe+Yuw+0tHgrDgDKy0b3vPeZilhHcZFI1gFFoft4Qttl0ywAP+OApX98YxbY2r9u58kNR9vwXkEPyHmWMBhRGYtxqJZaY2sGbwxY5OesKqvfRyygm4UOuDkHPl5vZNffwyZ1n2sM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1589378559034777.0039636969459; Wed, 13 May 2020 07:02:39 -0700 (PDT) Received: from localhost ([::1]:50050 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jYry1-0001Ot-DP for importer@patchew.org; Wed, 13 May 2020 10:02:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51564) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jYrwX-0000NI-Gk for qemu-devel@nongnu.org; Wed, 13 May 2020 10:01:05 -0400 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:37738 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jYrwW-0002zh-Km for qemu-devel@nongnu.org; Wed, 13 May 2020 10:01:05 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-242-VPbIUzHZP4yvam144kgtAQ-1; Wed, 13 May 2020 10:01:01 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E790F53; Wed, 13 May 2020 14:00:59 +0000 (UTC) Received: from localhost (ovpn-112-208.phx2.redhat.com [10.3.112.208]) by smtp.corp.redhat.com (Postfix) with ESMTP id 612966B8C1; Wed, 13 May 2020 14:00:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1589378463; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=elJpFRjL7L8vS4tJJiDj0rgRnL8BOZyY/mJqzTqXtQ0=; b=duJoZTmSISnomQu790NoMPhGZ8tyHRLwyIvh1jJredpoREtcFsm90vngCQyN8Rw/URuzAd Vl3T8KjS9syRNzDXJJjMLR9VAnPn1AF570M0xQryOFnXM5R9xgn5nH5fI210ERd4ZpZEtQ 8wuicl+TawAa7TCU+Yc2L+8387rxhHk= X-MC-Unique: VPbIUzHZP4yvam144kgtAQ-1 From: Eduardo Habkost To: qemu-devel@nongnu.org, Peter Maydell Subject: [PULL 1/1] hostmem: don't use mbind() if host-nodes is empty Date: Wed, 13 May 2020 10:00:57 -0400 Message-Id: <20200513140057.576234-2-ehabkost@redhat.com> In-Reply-To: <20200513140057.576234-1-ehabkost@redhat.com> References: <20200513140057.576234-1-ehabkost@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.139.110.61; envelope-from=ehabkost@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/13 01:56:38 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eduardo Habkost , qemu-stable@nongnu.org, Manuel Hohmann , Igor Mammedov , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) From: Igor Mammedov Since 5.0 QEMU uses hostmem backend for allocating main guest RAM. The backend however calls mbind() which is typically NOP in case of default policy/absent host-nodes bitmap. However when runing in container with black-listed mbind() syscall, QEMU fails to start with error "cannot bind memory to host NUMA nodes: Operation not permitted" even when user hasn't provided host-nodes to pin to explictly (which is the case with -m option) To fix issue, call mbind() only in case when user has provided host-nodes explicitly (i.e. host_nodes bitmap is not empty). That should allow to run QEMU in containers with black-listed mbind() without memory pinning. If QEMU provided memory-pinning is required user still has to white-list mbind() in container configuration. Reported-by: Manuel Hohmann Signed-off-by: Igor Mammedov Message-Id: <20200430154606.6421-1-imammedo@redhat.com> Tested-by: Philippe Mathieu-Daud=C3=A9 Cc: qemu-stable@nongnu.org Signed-off-by: Eduardo Habkost --- backends/hostmem.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/backends/hostmem.c b/backends/hostmem.c index 327f9eebc3..0efd7b7bd6 100644 --- a/backends/hostmem.c +++ b/backends/hostmem.c @@ -383,8 +383,10 @@ host_memory_backend_memory_complete(UserCreatable *uc,= Error **errp) assert(sizeof(backend->host_nodes) >=3D BITS_TO_LONGS(MAX_NODES + 1) * sizeof(unsigned long)); assert(maxnode <=3D MAX_NODES); - if (mbind(ptr, sz, backend->policy, - maxnode ? backend->host_nodes : NULL, maxnode + 1, flags= )) { + + if (maxnode && + mbind(ptr, sz, backend->policy, backend->host_nodes, maxnode += 1, + flags)) { if (backend->policy !=3D MPOL_DEFAULT || errno !=3D ENOSYS) { error_setg_errno(errp, errno, "cannot bind memory to host NUMA nodes"); --=20 2.26.2