From nobody Mon Feb 9 04:03:37 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1589294768; cv=none; d=zohomail.com; s=zohoarc; b=UmWhhZhrdJO4rW6dAhnUp+FhxjoSIWljqxCKbslFLHzlCiQkKsVQFNw87cw7T7dSrlqngs5s0QxZlEHkP0DaLkeuaJ8wPo4lKx59tQ5uQDkfORnsIThj/gknEh9RSuKFYO5VFpvUuQf4B+3OjOsRZ1CIEkHgNz5BLwhkjJOinrs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1589294768; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=eVhphe42YboNI73ipReJhHsUFh2j7kanYA6+hAjilN0=; b=BcVGmguXrgcwGFPCMN4toZ71HRnCXYaLUsAhbrYSoomcOKuxFVMDQ0PqES2CnSmWLazupNcF7F5SGjCnOAchL+mdpsIivvTPvhQp7awXo/l6/rSTT1KCK/9tqiqPXMH3tlCdY0cnirhU5xg/7dBaSTYPFrm/qNkJpFc/UJOKVpo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1589294768714137.9717583846915; Tue, 12 May 2020 07:46:08 -0700 (PDT) Received: from localhost ([::1]:59670 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jYWAZ-00057f-BJ for importer@patchew.org; Tue, 12 May 2020 10:46:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58180) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jYW8r-0003OJ-Oe for qemu-devel@nongnu.org; Tue, 12 May 2020 10:44:21 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:39493 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jYW8r-00043O-2z for qemu-devel@nongnu.org; Tue, 12 May 2020 10:44:21 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-297-Q_5XCfcnOte1G7TsRcnwwg-1; Tue, 12 May 2020 10:44:17 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7F77F88CE47; Tue, 12 May 2020 14:44:10 +0000 (UTC) Received: from linux.fritz.box.com (ovpn-114-74.ams2.redhat.com [10.36.114.74]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8D3995D9DD; Tue, 12 May 2020 14:44:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1589294659; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eVhphe42YboNI73ipReJhHsUFh2j7kanYA6+hAjilN0=; b=iVLR58fRc5tcuhafTZb0yUrFFqIlHQntvZ0PQkOj1oNvluDle5zKqZ8NdnIvLvX3fLLwuQ iZVOhvSm0t0qXB7Z6avFQFKqR3lTzE4Im8AG2ytirNG2DzcR+vCvKot5rgb/QqsTEHYaxm G8utmX6EeN6TFwHsR4k5f/2fy5vqfI8= X-MC-Unique: Q_5XCfcnOte1G7TsRcnwwg-1 From: Kevin Wolf To: qemu-block@nongnu.org Subject: [RFC PATCH 3/3] block: Assert we're running in the right thread Date: Tue, 12 May 2020 16:43:18 +0200 Message-Id: <20200512144318.181049-4-kwolf@redhat.com> In-Reply-To: <20200512144318.181049-1-kwolf@redhat.com> References: <20200512144318.181049-1-kwolf@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=207.211.31.120; envelope-from=kwolf@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/12 02:20:15 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, qemu-devel@nongnu.org, s.reiter@proxmox.com, armbru@redhat.com, mreitz@redhat.com, stefanha@redhat.com, t.lamprecht@proxmox.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" tracked_request_begin() is called for most I/O operations, so it's a good place to assert that we're indeed running in the home thread of the node's AioContext. Signed-off-by: Kevin Wolf Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- block/io.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/block/io.c b/block/io.c index 7808e8bdc0..924bf5ba46 100644 --- a/block/io.c +++ b/block/io.c @@ -695,14 +695,17 @@ static void tracked_request_begin(BdrvTrackedRequest = *req, uint64_t bytes, enum BdrvTrackedRequestType type) { + Coroutine *self =3D qemu_coroutine_self(); + assert(bytes <=3D INT64_MAX && offset <=3D INT64_MAX - bytes); + assert(bs->aio_context =3D=3D qemu_coroutine_get_aio_context(self)); =20 *req =3D (BdrvTrackedRequest){ .bs =3D bs, .offset =3D offset, .bytes =3D bytes, .type =3D type, - .co =3D qemu_coroutine_self(), + .co =3D self, .serialising =3D false, .overlap_offset =3D offset, .overlap_bytes =3D bytes, --=20 2.25.3