From nobody Tue Feb 10 03:40:30 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1589145186; cv=none; d=zohomail.com; s=zohoarc; b=CKJ+QJG8A7ESgMViVH0ZXyD97Elktlrb8GGC6Bhx+yGydI0ipID7emvtu+tUkQCeBVMzkm7pmFE2A88W/yHtv1aMxjcADJUnB8whYW+hKsFET3TB4X/i8VwV5KQr5TTIKxzke9NoSmW2Ho7fv07X/fg/GTdqzc4WXmkNX4BPqhw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1589145186; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=1cJ5MBtfm5U9bUfRE1+Uv1c5Y0Ygwr9qTN/mJlJtXvc=; b=O2nwAPSUiLlLR+jS+dP3LwMDNVA2HT1VcviNYqPNa1TAzpvBF1c6D/TUNTL0nlopLWeJ9nYrEEriOh7NMIW5FlKf1zhWaOAYfr4OyvzYNmjQj4QeaZoGqgOBKWEB96u8PQktne42wTfdZ2/aE6kB2omyXfDF7IgueNO0jpS9+0g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1589145186533652.7292330261475; Sun, 10 May 2020 14:13:06 -0700 (PDT) Received: from localhost ([::1]:44886 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jXtFx-0005Rv-Cl for importer@patchew.org; Sun, 10 May 2020 17:13:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60490) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jXt5C-0007kB-II for qemu-devel@nongnu.org; Sun, 10 May 2020 17:01:58 -0400 Received: from mail-ej1-x643.google.com ([2a00:1450:4864:20::643]:36225) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jXt5B-00017b-Qy for qemu-devel@nongnu.org; Sun, 10 May 2020 17:01:58 -0400 Received: by mail-ej1-x643.google.com with SMTP id z5so5393187ejb.3 for ; Sun, 10 May 2020 14:01:57 -0700 (PDT) Received: from localhost.localdomain (17.red-88-21-202.staticip.rima-tde.net. [88.21.202.17]) by smtp.gmail.com with ESMTPSA id d15sm921152ejr.50.2020.05.10.14.01.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 May 2020 14:01:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1cJ5MBtfm5U9bUfRE1+Uv1c5Y0Ygwr9qTN/mJlJtXvc=; b=WqoXu9wZb/bqTgN4dO+eKuvahc49X6gJY9xAGr/unrFae8yxJ/yDRx/O093EC0LoV5 te9oLVY7qA8QcfsYB9b/vXtlbniJPFz/oDbtglZwkdqeOvW07gNPckykztCRY6nxe5BQ zEOH3d+sJaEDb+gVQiFzzTu6GgoL9LetaWj6+3ZN8V319zYQbmkV8iGAsoXljN0bC2lL dIy9/2xCd9EkCfSTcLIfHz7W4XbrYpm8Xad9z3uk8hWlapnBzmIuDfKf5E9+jO3ZALPd q8BwCNS8wqpeo1vhOzh6zrq1ZDdljyvT1ohfsu8iIBjTyjF0+wU/0zi1Axg3JU96PHUE rakA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=1cJ5MBtfm5U9bUfRE1+Uv1c5Y0Ygwr9qTN/mJlJtXvc=; b=aBYxZMUuq4Ks6IaPD0dme6vt+/7I+ufcnTx+C6YXlDFGvMbiYe94f/baYkmG3Jh/zU 9HOtKNNQrDemzSlsXC4rgS//Q9YZmnAV8g3mgeEcn/c7As7pa/0OzGnxiRvmnuVn4Idn SMntJ8owKOpxQ43yzK7t9h2PEfqI8AOR96cERon4T1JgKoKZ/ApYRsssxjWyHAjnd3GR m7trWb4Vvfpb+zXeHL5RdLTfK3d+slEreHEnYG1Eejwkx3DTlTbZyMy7FmQ035WYftlZ T9dnEuPf95KJLnVhhRfit5eUtVbVopJ8zA6jjmZRViMWOfZ3qY8iJ0UNpYWjA0KXsif9 xODw== X-Gm-Message-State: AOAM5313/3+CizE1lIGQXKTc+wHFwmfXNHUWFVB8ECROR/f9MCmDbcmK jLJfYl+3nCk5A9voyM2uwr+fm0Nja8Y= X-Google-Smtp-Source: ABdhPJyElAPPG067++3HlLFky7vz1MCCrjzsGj7ynYZU6lV2wqqXVY148M3Q8RfnO5hEwMeACnBEig== X-Received: by 2002:a17:907:1189:: with SMTP id uz9mr42717ejb.53.1589144516285; Sun, 10 May 2020 14:01:56 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [NOTFORMERGE PATCH 12/12] POC hw/pci-host/bonito: Fix BONGENCFG value after a warm-reset Date: Sun, 10 May 2020 23:01:28 +0200 Message-Id: <20200510210128.18343-13-f4bug@amsat.org> X-Mailer: git-send-email 2.21.3 In-Reply-To: <20200510210128.18343-1-f4bug@amsat.org> References: <20200510210128.18343-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::643; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-ej1-x643.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Damien Hedde , Thomas Huth , Huacai Chen , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Jiaxun Yang , Aleksandar Markovic , Paolo Bonzini , Huacai Chen , Aleksandar Rikalo , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aurelien Jarno Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) The CPUSELFRESET bit should only be set on COLD reset. To have the PMON firmware behave correctly after WARM reset, we need to clear this bit. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- Cc: Damien Hedde --- hw/pci-host/bonito.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/hw/pci-host/bonito.c b/hw/pci-host/bonito.c index 86aceb333a..60eab867f0 100644 --- a/hw/pci-host/bonito.c +++ b/hw/pci-host/bonito.c @@ -586,6 +586,12 @@ static int pci_bonito_map_irq(PCIDevice *pci_dev, int = irq_num) } } =20 +static ResetType bonito_reset_type(PCIBonitoState *s) +{ + /* TODO: Use resettable_get_type(s) to also return RESET_TYPE_WARM */ + return RESET_TYPE_COLD; +} + static void bonito_reset(void *opaque) { PCIBonitoState *s =3D opaque; @@ -598,7 +604,8 @@ static void bonito_reset(void *opaque) val =3D FIELD_DP32(val, BONGENCFG, WRITEBEHIND, 1); val =3D FIELD_DP32(val, BONGENCFG, PREFETCH, 1); val =3D FIELD_DP32(val, BONGENCFG, UNCACHED, 1); - val =3D FIELD_DP32(val, BONGENCFG, CPUSELFRESET, 1); + val =3D FIELD_DP32(val, BONGENCFG, CPUSELFRESET, + bonito_reset_type(s) =3D=3D RESET_TYPE_COLD); s->regs[BONITO_BONGENCFG] =3D val; =20 s->regs[BONITO_IODEVCFG] =3D 0x2bff8010; --=20 2.21.3