From nobody Sun May 19 15:58:48 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1589130846; cv=none; d=zohomail.com; s=zohoarc; b=Ej/V4h5fxIOUmXtzGckOC5cnHXxWaCwVpfDi4YORqTVTaidrF/SuSDkXGUZCmt0Vn69jq/H8/NUQubGmX09ZxhuFS4Vqt6W2Zazys807aRY7pZbRCNRhN4ut4Moz3LFbgp22+gr82V3lsKoNNSdolhVwuj+jL4STD+c5Eifu700= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1589130846; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=+R9EYTOiCvQbq05OuVhtB2qHgFEnZLCI6qjL27hF2YM=; b=HzBAuD10dzrqyJC3EEP8vNOZ4bWvl5+B+5QBGlH71LhqGGqlzjkJWU2Wy/CcDrlmceBALkz118q7Rk29D5zWY050Uv0n9L4AJpCWNmaJeC+t8Fk9BT/8DXTRW1c61GSX3YLrVjK6n2X2qszVeoZRQpXcantzVNOVtGQoMtQ4mN8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 158913084680563.69695278025881; Sun, 10 May 2020 10:14:06 -0700 (PDT) Received: from localhost ([::1]:53616 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jXpWf-0002Q6-IL for importer@patchew.org; Sun, 10 May 2020 13:14:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36880) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jXpU7-0005mN-LA; Sun, 10 May 2020 13:11:27 -0400 Received: from mail-ed1-x542.google.com ([2a00:1450:4864:20::542]:42479) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jXpU7-0000Bt-0J; Sun, 10 May 2020 13:11:27 -0400 Received: by mail-ed1-x542.google.com with SMTP id s10so5858008edy.9; Sun, 10 May 2020 10:11:26 -0700 (PDT) Received: from localhost.localdomain (17.red-88-21-202.staticip.rima-tde.net. [88.21.202.17]) by smtp.gmail.com with ESMTPSA id w7sm960776edr.20.2020.05.10.10.11.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 May 2020 10:11:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+R9EYTOiCvQbq05OuVhtB2qHgFEnZLCI6qjL27hF2YM=; b=MDddxZcLQ+i1nMJ1VDYjSlrbsSI/8AnySHKjg6Sj2RIURwJQUlfl2olECr+RGeqSCh BE61NzR6pOJjkuzO1g/S3AdvyJAisthr6z8Jvw5xJ/98Xlr+19EN/6PEFBPjMtICqZ5z 9+kdkjjB7EWxdDgIo8NgPvzJ7v5wPUJUZBdoCooIC1YHcW+J/KhjsFy/29/DN1l0TY/3 qCI6OB+rljyLQoQ3DPKh516rte10nlooxyj4i92tmwda2U5ZxlcLJfnqANYbJjPOsJ3w 6l9nlJSKIYFkVJE7IH73W37fFCz/NjU8nxwl6RcSmTthN5B7ALCSQRPfcgedkZi4o2sO iFww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=+R9EYTOiCvQbq05OuVhtB2qHgFEnZLCI6qjL27hF2YM=; b=t6REItwDC8SRcocxU6pJGMwSV6S0J4MWdATjDwgzd8P1mAfdGDzWmZABrG7bkxXND/ lVKZ786WVwrVuf1i2lZc9aZQcfeC4sQkTtgWwsNpqOuif+ctH0YuzQ5ebFeqC0nTQ42H Ab4oKETLXfAHPmMz9xz8yIrabjlhQps7pqw6HyvNpsJMxyoV4qR2jewh3BRvrsMp4VT+ DKLGhZ8Iz180ktui1i6DoUBghrK4z89AVgbF0retyHG5UkJADQW5JF64BpHPJ5GkORq2 Fu+xtyoPbSVLqxltY544ElEck7U9TycRnENXHu35RXKSRxUi3r/S7qe+GHx6HBCCx3/7 YXZA== X-Gm-Message-State: AGi0PuZMc8w1z/Q1EM7DOg2uLkok9f5r7ExWLaR/zv50nxvodLuZ7UNj XYH0QgD7HnmhjxiAv8MZuKu+B8ZM8/M= X-Google-Smtp-Source: APiQypJaVTuou/HjJPd6Fon9772mjdoCV7ap9k7rX38nALdYYvUXxMeJYJ+nhfK9F42kM7sSFWo7gg== X-Received: by 2002:a05:6402:1d89:: with SMTP id dk9mr10153093edb.382.1589130685005; Sun, 10 May 2020 10:11:25 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH 1/3] qemu/plugin: Trivial code movement Date: Sun, 10 May 2020 19:11:17 +0200 Message-Id: <20200510171119.20827-2-f4bug@amsat.org> X-Mailer: git-send-email 2.21.3 In-Reply-To: <20200510171119.20827-1-f4bug@amsat.org> References: <20200510171119.20827-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::542; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-ed1-x542.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Michael Tokarev , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Laurent Vivier , "Emilio G . Cota" , =?UTF-8?q?Alex=20Benn=C3=A9e?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Move the qemu_plugin_event enum declaration earlier. This will make the next commit easier to review. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Emilio G. Cota --- include/qemu/plugin.h | 32 ++++++++++++++++---------------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/include/qemu/plugin.h b/include/qemu/plugin.h index 11687e8cdc..e45f950fe3 100644 --- a/include/qemu/plugin.h +++ b/include/qemu/plugin.h @@ -13,6 +13,22 @@ #include "qemu/queue.h" #include "qemu/option.h" =20 +/* + * Events that plugins can subscribe to. + */ +enum qemu_plugin_event { + QEMU_PLUGIN_EV_VCPU_INIT, + QEMU_PLUGIN_EV_VCPU_EXIT, + QEMU_PLUGIN_EV_VCPU_TB_TRANS, + QEMU_PLUGIN_EV_VCPU_IDLE, + QEMU_PLUGIN_EV_VCPU_RESUME, + QEMU_PLUGIN_EV_VCPU_SYSCALL, + QEMU_PLUGIN_EV_VCPU_SYSCALL_RET, + QEMU_PLUGIN_EV_FLUSH, + QEMU_PLUGIN_EV_ATEXIT, + QEMU_PLUGIN_EV_MAX, /* total number of plugin events we support */ +}; + /* * Option parsing/processing. * Note that we can load an arbitrary number of plugins. @@ -47,22 +63,6 @@ static inline int qemu_plugin_load_list(QemuPluginList *= head) } #endif /* !CONFIG_PLUGIN */ =20 -/* - * Events that plugins can subscribe to. - */ -enum qemu_plugin_event { - QEMU_PLUGIN_EV_VCPU_INIT, - QEMU_PLUGIN_EV_VCPU_EXIT, - QEMU_PLUGIN_EV_VCPU_TB_TRANS, - QEMU_PLUGIN_EV_VCPU_IDLE, - QEMU_PLUGIN_EV_VCPU_RESUME, - QEMU_PLUGIN_EV_VCPU_SYSCALL, - QEMU_PLUGIN_EV_VCPU_SYSCALL_RET, - QEMU_PLUGIN_EV_FLUSH, - QEMU_PLUGIN_EV_ATEXIT, - QEMU_PLUGIN_EV_MAX, /* total number of plugin events we support */ -}; - union qemu_plugin_cb_sig { qemu_plugin_simple_cb_t simple; qemu_plugin_udata_cb_t udata; --=20 2.21.3 From nobody Sun May 19 15:58:48 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1589130757; cv=none; d=zohomail.com; s=zohoarc; b=NuNdKNGVVmIBrDD97kMcqS1gnQaSwcO16vnnPWM12GmqQgxqTzPeS3fyesN+bNFy3EfOVXl3XD23TBN/yC61e80O6hFctBPE5MwTl992V7+SzY+yGsGwIMJB2v62OrJScJVBtixh+SwKHEX04Jc87eq9vSCrju3NZCnG9mAzxH4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1589130757; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=2wY0Jnl7mJEYElH4v6fPrm4v3qIHs5F0/By9SpX3QVg=; b=fb3xw8Se1Ua97g6ZEUM9okMUOHvUhCcbmYeTbujEuf8A3/kGsYHfgTfXnz9o3ShyGZdS3ZtO738jDoknCgUxx+cPc2AJqBlStYm4IPrGOMUXgTY82p0XKlRE+zJKvpuTsfX2Jwh+dNSHGsIBvbz837WJnCzdlwDXMiSyrlulNtM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1589130757584873.5731346730136; Sun, 10 May 2020 10:12:37 -0700 (PDT) Received: from localhost ([::1]:47136 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jXpVE-0007Sn-B0 for importer@patchew.org; Sun, 10 May 2020 13:12:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36884) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jXpU9-0005nu-1r; Sun, 10 May 2020 13:11:29 -0400 Received: from mail-ej1-x644.google.com ([2a00:1450:4864:20::644]:43806) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jXpU8-0000C2-AJ; Sun, 10 May 2020 13:11:28 -0400 Received: by mail-ej1-x644.google.com with SMTP id o10so5850371ejn.10; Sun, 10 May 2020 10:11:27 -0700 (PDT) Received: from localhost.localdomain (17.red-88-21-202.staticip.rima-tde.net. [88.21.202.17]) by smtp.gmail.com with ESMTPSA id w7sm960776edr.20.2020.05.10.10.11.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 May 2020 10:11:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=2wY0Jnl7mJEYElH4v6fPrm4v3qIHs5F0/By9SpX3QVg=; b=TDiXw/QoPa5H9McmoJA25SzFHUBNYwZ2Hb4cv994QyKZJXIrvW+5B6KU11lXuvliQd I9Cxtf25FcVDHNy7xThaXFD2PBx7ldOHWPrttFZFv84pRuwLBaWQyVlxBiY92gVALxN+ nY5/pehTsq6DPz9gsd7j8bN0SLZOY+FecI/7MCjh2+MFJIvrQC/arUqwfoidEqIKwq8C leC9bYUuPOpziYTCqVGikc7nGXahXSniNy+gg2eRyA6DlpRr/8qfTw4ZhU++mHnE5tkj MpDHYZcKpklUjCHW89q9LuHXUbmhpVwbn7aXa+P73rljvjlF4yJ6PEu6lxBYVF6oJZho Mlvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=2wY0Jnl7mJEYElH4v6fPrm4v3qIHs5F0/By9SpX3QVg=; b=qrWJvC+2726sb9itMN7RFyVFDp7hviyR+wJmSZiYlTE1XELPGzJl8MJorPDp+GHeZn dvIqcRIAI0hTMq08ZfmNhRXuywRYemAZiYxrG1gvtZEiWCzO7ZJsW5Jpz0Mh/HB7hWNh wGlBtcJ8/+qy0cuVrRiZm2PXBaPjy48FdosgKGkVNtL+knd6CzAzBf/qjvNUcPMygw9v AzHyG/3p1QdGdnxvPWJe83vRan8qDsM0RRK8dsRdo3+ybhnYKYazxgtKpukL2u14lvDT 001AGOKB75YvMJTPyC+DLzCoIQQDgomYraiCXNv34cDJ8r/iCOEKofoMbtaRg8ZfBGO5 CdYw== X-Gm-Message-State: AOAM530E9FEp7jzF1E5vNdtO6O8IJ/WaX6O/pSVyK3nwAmD0HyTzf3Sn Flx2FjIdU4s3qdGhBw3QzRLjvuW1ROM= X-Google-Smtp-Source: ABdhPJxPmol4XpTeOUfNwUHB7wG9A2LzUzAXgxWQkVMQSU2Piu/qwGT/bFIJTOAWNz1HRCTXMaDqlw== X-Received: by 2002:a17:906:404a:: with SMTP id y10mr1173255ejj.130.1589130686406; Sun, 10 May 2020 10:11:26 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH 2/3] qemu/plugin: Move !CONFIG_PLUGIN stubs altogether Date: Sun, 10 May 2020 19:11:18 +0200 Message-Id: <20200510171119.20827-3-f4bug@amsat.org> X-Mailer: git-send-email 2.21.3 In-Reply-To: <20200510171119.20827-1-f4bug@amsat.org> References: <20200510171119.20827-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::644; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-ej1-x644.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, "Emilio G . Cota" , =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Simplify the ifdef'ry by moving all stubs together. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Emilio G. Cota --- include/qemu/plugin.h | 33 +++++++++++++++------------------ 1 file changed, 15 insertions(+), 18 deletions(-) diff --git a/include/qemu/plugin.h b/include/qemu/plugin.h index e45f950fe3..ab790ad105 100644 --- a/include/qemu/plugin.h +++ b/include/qemu/plugin.h @@ -46,22 +46,6 @@ static inline void qemu_plugin_add_opts(void) =20 void qemu_plugin_opt_parse(const char *optarg, QemuPluginList *head); int qemu_plugin_load_list(QemuPluginList *head); -#else /* !CONFIG_PLUGIN */ -static inline void qemu_plugin_add_opts(void) -{ } - -static inline void qemu_plugin_opt_parse(const char *optarg, - QemuPluginList *head) -{ - error_report("plugin interface not enabled in this build"); - exit(1); -} - -static inline int qemu_plugin_load_list(QemuPluginList *head) -{ - return 0; -} -#endif /* !CONFIG_PLUGIN */ =20 union qemu_plugin_cb_sig { qemu_plugin_simple_cb_t simple; @@ -182,8 +166,6 @@ struct qemu_plugin_insn *qemu_plugin_tb_insn_get(struct= qemu_plugin_tb *tb) return insn; } =20 -#ifdef CONFIG_PLUGIN - void qemu_plugin_vcpu_init_hook(CPUState *cpu); void qemu_plugin_vcpu_exit_hook(CPUState *cpu); void qemu_plugin_tb_trans_cb(CPUState *cpu, struct qemu_plugin_tb *tb); @@ -207,6 +189,21 @@ void qemu_plugin_disable_mem_helpers(CPUState *cpu); =20 #else /* !CONFIG_PLUGIN */ =20 +static inline void qemu_plugin_add_opts(void) +{ } + +static inline void qemu_plugin_opt_parse(const char *optarg, + QemuPluginList *head) +{ + error_report("plugin interface not enabled in this build"); + exit(1); +} + +static inline int qemu_plugin_load_list(QemuPluginList *head) +{ + return 0; +} + static inline void qemu_plugin_vcpu_init_hook(CPUState *cpu) { } =20 --=20 2.21.3 From nobody Sun May 19 15:58:48 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1589130768; cv=none; d=zohomail.com; s=zohoarc; b=KOuxF8BMCDzoz1fR1b1/sS65O++A5jjyr0Zkcw82IcbX8KbKhivOYlraVaJb9jV4W+JLPWczporLrNKugxD7hZacvcmFV6Bj7xIAxH/VRnTKm1UTiSN70T+YT2Jx2ze6BABbhbbjuqy03+c+iUIMtjKaBmZBqFGet56yIzfUwb8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1589130768; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=opJWKypD+HXG5axwxyBOWTbtCOfa9yREZFCiYnwvuD0=; b=f0wv8VDon6M9mwSM8wrYIcFsC+Ys0roj/nYdmtG/fx72vOhlVtmn0s8qLnK3UF27QbFmu5mDIMVvDnGe7lp4uWKMqWUHSgnA4AKzOf9QBZQ4jbmvMCie9N5JkyJFbGYQkAyIMgVCbU3JZZ8m+KDyxmJBTb+LO1/QDFNWTB8qScU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 158913076865988.89435245076982; Sun, 10 May 2020 10:12:48 -0700 (PDT) Received: from localhost ([::1]:47834 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jXpVP-0007mT-DU for importer@patchew.org; Sun, 10 May 2020 13:12:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36888) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jXpUA-0005q6-7N; Sun, 10 May 2020 13:11:30 -0400 Received: from mail-ed1-x544.google.com ([2a00:1450:4864:20::544]:37071) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jXpU9-0000CE-I8; Sun, 10 May 2020 13:11:29 -0400 Received: by mail-ed1-x544.google.com with SMTP id w2so5875810edx.4; Sun, 10 May 2020 10:11:28 -0700 (PDT) Received: from localhost.localdomain (17.red-88-21-202.staticip.rima-tde.net. [88.21.202.17]) by smtp.gmail.com with ESMTPSA id w7sm960776edr.20.2020.05.10.10.11.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 May 2020 10:11:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=opJWKypD+HXG5axwxyBOWTbtCOfa9yREZFCiYnwvuD0=; b=CPVHAz98Cmyf66upvDkvwXPvXF2FlyrWNlWEPK9BTzDafFEvCTWTKyJOZS0FY9y2ep FPTd1Ne7PW2YXr1TbXIsAagS5afadsDh/MByCOZzKD1bqwEaTf4Yx5TPXHYvOOiREelY fDtUUajWOgEEslD8HRZuRXW4J1GnqT1vvs8YolXnG9sa7m8ydj9MOMHuc44LQ2NsyUoq kkDyWNXygnn1uIVd9M0f591pKGA7dEngCSRyKsiOMdjd3oGhmaaTLWetKO0H2f6RY6J+ m1QU7uaeuiipcM+GURd76Bse9WyOd3sz9V5aRHvbduCYMjLhYnm1JPH4gICKLlApJumZ 0Ekg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=opJWKypD+HXG5axwxyBOWTbtCOfa9yREZFCiYnwvuD0=; b=fDuYmkcZ8HlguyRutVGMkn2sxVvi+4Tp1y0nQEPOPvLEreBYwL6bDccLVlS8DrDg9Q cFJD3WNI2RFxfzoqzlRIU4JqavzsqWWkqqgTTqbE+faipntuliySHuv3d8f2NgbSaWon hz1UmR5a008AelodGJBAZ4x+dEEnPKD3pjRdxZsCTbOpO73HAwb5TezlR7WVzrWa6sbZ bd0rccPuW25oZ32o1XwYEIasgDNlPM3IYfoigp3nc2RY0lKkev7Ar+j0njWD2VNoGIWm aflWpZsGmclYT7rJBQZqNY9ZFuyat7HYpfCeXR/UfMgC2zzw/DuEYGK5tWZPthTKJyPD 8XwQ== X-Gm-Message-State: AOAM531sYjA8RAuF20gL7oeeyoJo9gMzLJNU/0tp/xmHKXvsy94SdMFn DymVUFI7LQlQhLLY3vhAoQbANTsjMH4= X-Google-Smtp-Source: ABdhPJx6fDzA1yjGn8O/Y7E0YHHrCbPFvmdyGZmtFczPoLoYv7bGshd4zW04ykGRZpFKfm3Pi8fZlg== X-Received: by 2002:aa7:d496:: with SMTP id b22mr918491edr.301.1589130687702; Sun, 10 May 2020 10:11:27 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH 3/3] qemu/qemu-plugin: Make qemu_plugin_hwaddr_is_io() hwaddr argument const Date: Sun, 10 May 2020 19:11:19 +0200 Message-Id: <20200510171119.20827-4-f4bug@amsat.org> X-Mailer: git-send-email 2.21.3 In-Reply-To: <20200510171119.20827-1-f4bug@amsat.org> References: <20200510171119.20827-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::544; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-ed1-x544.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, "Emilio G . Cota" , =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Rename qemu_plugin_hwaddr_is_io() address argument 'haddr' similarly to qemu_plugin_hwaddr_device_offset(), and make it const. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Emilio G. Cota --- Having the variable named similarly to the 'hwaddr' typedef is slighly confusing. Also if we declare 'hwaddr' typedef poisoned, GCC complains qemu_plugin_hwaddr_is_io() use a poisoned variable... Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- include/qemu/qemu-plugin.h | 2 +- plugins/api.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/include/qemu/qemu-plugin.h b/include/qemu/qemu-plugin.h index 5502e112c8..89ed579f55 100644 --- a/include/qemu/qemu-plugin.h +++ b/include/qemu/qemu-plugin.h @@ -331,7 +331,7 @@ struct qemu_plugin_hwaddr *qemu_plugin_get_hwaddr(qemu_= plugin_meminfo_t info, * to return information about it. For non-IO accesses the device * offset will be into the appropriate block of RAM. */ -bool qemu_plugin_hwaddr_is_io(struct qemu_plugin_hwaddr *hwaddr); +bool qemu_plugin_hwaddr_is_io(const struct qemu_plugin_hwaddr *haddr); uint64_t qemu_plugin_hwaddr_device_offset(const struct qemu_plugin_hwaddr = *haddr); =20 typedef void diff --git a/plugins/api.c b/plugins/api.c index 53c8a73582..bbdc5a4eb4 100644 --- a/plugins/api.c +++ b/plugins/api.c @@ -275,10 +275,10 @@ struct qemu_plugin_hwaddr *qemu_plugin_get_hwaddr(qem= u_plugin_meminfo_t info, } #endif =20 -bool qemu_plugin_hwaddr_is_io(struct qemu_plugin_hwaddr *hwaddr) +bool qemu_plugin_hwaddr_is_io(const struct qemu_plugin_hwaddr *haddr) { #ifdef CONFIG_SOFTMMU - return hwaddr->is_io; + return haddr->is_io; #else return false; #endif --=20 2.21.3