From nobody Tue Feb 10 07:57:45 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1588962723; cv=none; d=zohomail.com; s=zohoarc; b=Z0FMnCVGOvT5rxiTJQWBiHjQyC8wIx2zpMfYR/wKEGMUp+LveZDEScNA5qcZhxm409h14MI4Mg4ffBQpdvSNRaU0Dr8iA2vAbcpiVNkmze3M3c55Q3wYQDJy3vUb3OVIriX210XqsQK2hj+Rur+vY9qEen7N8tK88cG3wobyD60= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1588962723; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=s991altgojrzqPsjuJ8OpBmqeSv4utq4bADW+fVvS7E=; b=DV5kE7ojeb4s4KkAMTog+gng5Zqrb4KYSOKYjhEdsi+s9eTJreoFF5HBcqOfp/wfwqWhI/peb6ncimRgmMhGbyNS0qt7sq2J2tegouA3yQDSPpp2YMhQq1QELwh2DfgXlXbpDuDS3LvHiFkuNC55C1pQlKal9NQs9Ucee4zIdns= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1588962723224238.5745056142439; Fri, 8 May 2020 11:32:03 -0700 (PDT) Received: from localhost ([::1]:60476 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jX7mz-0007WU-OP for importer@patchew.org; Fri, 08 May 2020 14:32:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33720) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jX7hf-0006qW-Lo for qemu-devel@nongnu.org; Fri, 08 May 2020 14:26:31 -0400 Received: from mail-pl1-x641.google.com ([2607:f8b0:4864:20::641]:45256) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jX7he-0006PW-Et for qemu-devel@nongnu.org; Fri, 08 May 2020 14:26:31 -0400 Received: by mail-pl1-x641.google.com with SMTP id u22so1088220plq.12 for ; Fri, 08 May 2020 11:26:30 -0700 (PDT) Received: from localhost.localdomain (174-21-149-226.tukw.qwest.net. [174.21.149.226]) by smtp.gmail.com with ESMTPSA id u9sm2421775pfn.197.2020.05.08.11.26.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 May 2020 11:26:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=s991altgojrzqPsjuJ8OpBmqeSv4utq4bADW+fVvS7E=; b=YGgzIb4NUxmGXZzDbwNHxj7TW+F0gbGH3gh7zDMUdwGxZGiSmt7pl6L8srLIZUFkaT 5MLWT69Hn3s4iCaIUB+C3wnzeU+ZHKgK8UpLOpMowAuMH/JwsbHpKFniJQm5b/kS/7Oq 33FDOOJcj4webqfMh+v7TKsXDTA5bB2jSz7k9EVR8bWOMXbH7hTkcA5wI3cJKVf6gdej s6mzSTr9f2IN82t5s3xBVQPVKR3NqXDAlVl9VOEuxZJUpjifdMhtDitaEi9Dyq/bHlhZ i/FOlfQcIANSCDa4Zuc9uTdnkmFbDdPrIST3uArMLV5cjNeaJ+O8RNf4UCH5Aur5iwOH pZJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=s991altgojrzqPsjuJ8OpBmqeSv4utq4bADW+fVvS7E=; b=VFniOhdsJx0zZvIjg3j/Qp+8JCdImvAJN5qJdIwxa5xu3WWFiEaNv0BfyRImtdju8i jzZdF8i0InfgMtn2BcaA8cb44wPG4x5W153LVhlZHdSaC/LTr0z7zinEYfnqk/hkw2Fr C2SpEAa95ik5WZeAXTJ2kBSO/QnuCghgTx36dKGn4KKKozRtUzs1j8nzJ+/Z257C0EK2 rL2h/sGtaMGM2NpdaO5yhm3Flza/ghEfDbE/3oviIe4PrKeR7G4N6kQ/5p/esp4+ujqJ P+c9l72Y34lHHvq46Ey/2Hi2dBxNwJRFOXUAMe85m0dzoXCwMgdNRHZNZVE5/+E92nCo gPFg== X-Gm-Message-State: AGi0PuZul9jO+Wzlx04CrUUQrPexqys7CcMCiBVVtWFynTS2XmCKgXzi gGFrYp9Nz0xzREmB4WA5juxthn2tyYQ= X-Google-Smtp-Source: APiQypLCHJVgvuQOaWOw15k8mqpLDs6bLnDkI3ZQBA5F9SfXM7jJAGmGx+P0VDywFdxYEJHdLO/kEw== X-Received: by 2002:a17:902:a604:: with SMTP id u4mr3656342plq.196.1588962388702; Fri, 08 May 2020 11:26:28 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH v4 08/19] tcg: Use tcg_constant_{i32,i64} with tcg plugins Date: Fri, 8 May 2020 11:26:05 -0700 Message-Id: <20200508182616.18318-9-richard.henderson@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200508182616.18318-1-richard.henderson@linaro.org> References: <20200508182616.18318-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::641; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x641.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.bennee@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) Reviewed-by: Alex Benn=C3=A9e Signed-off-by: Richard Henderson --- accel/tcg/plugin-gen.c | 49 +++++++++++++++++++----------------------- 1 file changed, 22 insertions(+), 27 deletions(-) diff --git a/accel/tcg/plugin-gen.c b/accel/tcg/plugin-gen.c index 51580d51a0..e5dc9d0ca9 100644 --- a/accel/tcg/plugin-gen.c +++ b/accel/tcg/plugin-gen.c @@ -284,8 +284,8 @@ static TCGOp *copy_extu_i32_i64(TCGOp **begin_op, TCGOp= *op) if (TCG_TARGET_REG_BITS =3D=3D 32) { /* mov_i32 */ op =3D copy_op(begin_op, op, INDEX_op_mov_i32); - /* movi_i32 */ - op =3D copy_op(begin_op, op, INDEX_op_movi_i32); + /* mov_i32 w/ $0 */ + op =3D copy_op(begin_op, op, INDEX_op_mov_i32); } else { /* extu_i32_i64 */ op =3D copy_op(begin_op, op, INDEX_op_extu_i32_i64); @@ -306,39 +306,34 @@ static TCGOp *copy_mov_i64(TCGOp **begin_op, TCGOp *o= p) return op; } =20 -static TCGOp *copy_movi_i64(TCGOp **begin_op, TCGOp *op, uint64_t v) -{ - if (TCG_TARGET_REG_BITS =3D=3D 32) { - /* 2x movi_i32 */ - op =3D copy_op(begin_op, op, INDEX_op_movi_i32); - op->args[1] =3D v; - - op =3D copy_op(begin_op, op, INDEX_op_movi_i32); - op->args[1] =3D v >> 32; - } else { - /* movi_i64 */ - op =3D copy_op(begin_op, op, INDEX_op_movi_i64); - op->args[1] =3D v; - } - return op; -} - static TCGOp *copy_const_ptr(TCGOp **begin_op, TCGOp *op, void *ptr) { if (UINTPTR_MAX =3D=3D UINT32_MAX) { - /* movi_i32 */ - op =3D copy_op(begin_op, op, INDEX_op_movi_i32); - op->args[1] =3D (uintptr_t)ptr; + /* mov_i32 */ + op =3D copy_op(begin_op, op, INDEX_op_mov_i32); + op->args[1] =3D tcgv_i32_arg(tcg_constant_i32((uintptr_t)ptr)); } else { - /* movi_i64 */ - op =3D copy_movi_i64(begin_op, op, (uint64_t)(uintptr_t)ptr); + /* mov_i64 */ + op =3D copy_op(begin_op, op, INDEX_op_mov_i64); + op->args[1] =3D tcgv_i64_arg(tcg_constant_i64((uintptr_t)ptr)); } return op; } =20 static TCGOp *copy_const_i64(TCGOp **begin_op, TCGOp *op, uint64_t v) { - return copy_movi_i64(begin_op, op, v); + if (TCG_TARGET_REG_BITS =3D=3D 32) { + /* 2x mov_i32 */ + op =3D copy_op(begin_op, op, INDEX_op_mov_i32); + op->args[1] =3D tcgv_i32_arg(tcg_constant_i32(v)); + op =3D copy_op(begin_op, op, INDEX_op_mov_i32); + op->args[1] =3D tcgv_i32_arg(tcg_constant_i32(v >> 32)); + } else { + /* mov_i64 */ + op =3D copy_op(begin_op, op, INDEX_op_mov_i64); + op->args[1] =3D tcgv_i64_arg(tcg_constant_i64(v)); + } + return op; } =20 static TCGOp *copy_extu_tl_i64(TCGOp **begin_op, TCGOp *op) @@ -486,8 +481,8 @@ static TCGOp *append_mem_cb(const struct qemu_plugin_dy= n_cb *cb, =20 tcg_debug_assert(type =3D=3D PLUGIN_GEN_CB_MEM); =20 - /* const_i32 =3D=3D movi_i32 ("info", so it remains as is) */ - op =3D copy_op(&begin_op, op, INDEX_op_movi_i32); + /* const_i32 =3D=3D mov_i32 ("info", so it remains as is) */ + op =3D copy_op(&begin_op, op, INDEX_op_mov_i32); =20 /* const_ptr */ op =3D copy_const_ptr(&begin_op, op, cb->userp); --=20 2.20.1