From nobody Wed Feb 11 00:59:44 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1588950971; cv=none; d=zohomail.com; s=zohoarc; b=Y+sgHPj3vuQ0oC2O/K3tHIrFWWxKbaGTIG/PxC19kfFlT8CyU7YRoOwj7KH+NX3VsjR56ZqoRD+3N2F2fQWysMMU3MzUVObWh4/k7vaphnE5aGySDbdw9uahEpGDG2cmvxVYoB4nt0RzzLwaLR256mQWcpCCk+11WBl3GXxeh30= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1588950971; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=/K1ycY1z79VZy1TG8t7nnh9EG9pxzEbf4Elb16Ela3g=; b=nJCBBLHAg/hdZS3QM/3XKVuGGLiRhCHoS8W+6G3v9bkTBv9F+jOCjaZGXskRwClTq3GNqD0bQxzkOQ2Tb8ZVnKVZ6yFddgws2jj+Pmj3D/OHUqH+SnDWCtHwMiEdCbyRTJ6o7R1lDjUnZ+/THxEaB/RNiCuMcypig6e92ebqYTA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 158895097101464.59784263969368; Fri, 8 May 2020 08:16:11 -0700 (PDT) Received: from localhost ([::1]:55414 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jX4jR-0002BS-Kk for importer@patchew.org; Fri, 08 May 2020 11:16:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59974) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jX4eV-0002S0-Hd for qemu-devel@nongnu.org; Fri, 08 May 2020 11:11:03 -0400 Received: from mail-pj1-x1041.google.com ([2607:f8b0:4864:20::1041]:51388) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jX4eU-00040i-FN for qemu-devel@nongnu.org; Fri, 08 May 2020 11:11:03 -0400 Received: by mail-pj1-x1041.google.com with SMTP id mq3so4390403pjb.1 for ; Fri, 08 May 2020 08:11:02 -0700 (PDT) Received: from localhost.localdomain (174-21-149-226.tukw.qwest.net. [174.21.149.226]) by smtp.gmail.com with ESMTPSA id d13sm1557562pga.64.2020.05.08.08.10.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 May 2020 08:11:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/K1ycY1z79VZy1TG8t7nnh9EG9pxzEbf4Elb16Ela3g=; b=AE8E3+zNPcgfJoWKOALOSXXGsU2ya883IeASEzmfjiB7d7y9oT53m5aGyFk20VipUh DagXrJreD6sRv0uqtkfxsVNa/j4kHPWdsMGeij7VraSHl+ZHTYc2xjiRY1+Hb402LTeN jv+CrEITpe8s3E9O2iid5klqLQGtEnfAfOqusBMZsqQU9XgWpW8zDaurns3iQJTiMIs8 5pLoFmXYMlybI59/HgRJDXEMepM5SaV8P7PMlPNs7dGoGr2ripkgHEiXXwVCmFVR0EI7 5E4oa3cXSBxA/9hvDol6Z7dXjMS+uaH6iiaz5bEN3OPjlvjivR1suhK6Q/O4iH2/IdCX /fBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/K1ycY1z79VZy1TG8t7nnh9EG9pxzEbf4Elb16Ela3g=; b=UuRJh9/r/P4nl6ECGBbE+dges5EPlJw9v3KxRCcWK27ViBp+KEl2a8jfJzwCLEoiYg j6YrTr1PghIyyJZM4sjDE2tTxfrmBDFR5agyRonhBgobZGOCiEWxujORC/zRQwzFkifh FasFybhXCNF+yiTpZsF2Czyfq4seMawhYFbYDZa+KMEcaT5eYwyUqD6+3GohcjfKCWHR vzJrR9AApSAijUJ22g7pps6CgaxHaeRFgoyFcy1sZSrtcwrfOaLE9L3+oCkDNuFxKZFH h6KMw63PtDltL4BYkrlxKH4tpw0a70C8dBtR9RRCDq00ouykJb9DybGG8rCuG1DOrolV Q6iw== X-Gm-Message-State: AGi0PuZ6HjDsgEVFQZ0E+PtB7F7kvsuBxRseKZhB2IyIPa8i5I3leZ+N WWU66gIyxofKuENYHLT8mqHO2M46bII= X-Google-Smtp-Source: APiQypIFon/p3UT2dVOmmVq/8gtNhAXVxrrnBxe/ERQbY1X+u0wAd2MnBvobseg7EJCkj2/pvjj+tA== X-Received: by 2002:a17:90a:12c3:: with SMTP id b3mr6714772pjg.57.1588950660718; Fri, 08 May 2020 08:11:00 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH v3 03/10] tcg: Remove expansion to shift by vector from do_shifts Date: Fri, 8 May 2020 08:10:48 -0700 Message-Id: <20200508151055.5832-4-richard.henderson@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200508151055.5832-1-richard.henderson@linaro.org> References: <20200508151055.5832-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::1041; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1041.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.bennee@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) Content-Type: text/plain; charset="utf-8" We do not reflect this expansion in tcg_can_emit_vecop_list, so it is unused and unusable. However, we actually perform the same expansion in do_gvec_shifts, so it is also unneeded. Signed-off-by: Richard Henderson --- tcg/tcg-op-vec.c | 35 +++++++++++------------------------ 1 file changed, 11 insertions(+), 24 deletions(-) diff --git a/tcg/tcg-op-vec.c b/tcg/tcg-op-vec.c index 488f9bd27b..fb1250fee6 100644 --- a/tcg/tcg-op-vec.c +++ b/tcg/tcg-op-vec.c @@ -707,7 +707,7 @@ void tcg_gen_rotrv_vec(unsigned vece, TCGv_vec r, TCGv_= vec a, TCGv_vec b) } =20 static void do_shifts(unsigned vece, TCGv_vec r, TCGv_vec a, - TCGv_i32 s, TCGOpcode opc_s, TCGOpcode opc_v) + TCGv_i32 s, TCGOpcode opc) { TCGTemp *rt =3D tcgv_vec_temp(r); TCGTemp *at =3D tcgv_vec_temp(a); @@ -716,48 +716,35 @@ static void do_shifts(unsigned vece, TCGv_vec r, TCGv= _vec a, TCGArg ai =3D temp_arg(at); TCGArg si =3D temp_arg(st); TCGType type =3D rt->base_type; - const TCGOpcode *hold_list; int can; =20 tcg_debug_assert(at->base_type >=3D type); - tcg_assert_listed_vecop(opc_s); - hold_list =3D tcg_swap_vecop_list(NULL); - - can =3D tcg_can_emit_vec_op(opc_s, type, vece); + tcg_assert_listed_vecop(opc); + can =3D tcg_can_emit_vec_op(opc, type, vece); if (can > 0) { - vec_gen_3(opc_s, type, vece, ri, ai, si); + vec_gen_3(opc, type, vece, ri, ai, si); } else if (can < 0) { - tcg_expand_vec_op(opc_s, type, vece, ri, ai, si); + const TCGOpcode *hold_list =3D tcg_swap_vecop_list(NULL); + tcg_expand_vec_op(opc, type, vece, ri, ai, si); + tcg_swap_vecop_list(hold_list); } else { - TCGv_vec vec_s =3D tcg_temp_new_vec(type); - - if (vece =3D=3D MO_64) { - TCGv_i64 s64 =3D tcg_temp_new_i64(); - tcg_gen_extu_i32_i64(s64, s); - tcg_gen_dup_i64_vec(MO_64, vec_s, s64); - tcg_temp_free_i64(s64); - } else { - tcg_gen_dup_i32_vec(vece, vec_s, s); - } - do_op3_nofail(vece, r, a, vec_s, opc_v); - tcg_temp_free_vec(vec_s); + g_assert_not_reached(); } - tcg_swap_vecop_list(hold_list); } =20 void tcg_gen_shls_vec(unsigned vece, TCGv_vec r, TCGv_vec a, TCGv_i32 b) { - do_shifts(vece, r, a, b, INDEX_op_shls_vec, INDEX_op_shlv_vec); + do_shifts(vece, r, a, b, INDEX_op_shls_vec); } =20 void tcg_gen_shrs_vec(unsigned vece, TCGv_vec r, TCGv_vec a, TCGv_i32 b) { - do_shifts(vece, r, a, b, INDEX_op_shrs_vec, INDEX_op_shrv_vec); + do_shifts(vece, r, a, b, INDEX_op_shrs_vec); } =20 void tcg_gen_sars_vec(unsigned vece, TCGv_vec r, TCGv_vec a, TCGv_i32 b) { - do_shifts(vece, r, a, b, INDEX_op_sars_vec, INDEX_op_sarv_vec); + do_shifts(vece, r, a, b, INDEX_op_sars_vec); } =20 void tcg_gen_bitsel_vec(unsigned vece, TCGv_vec r, TCGv_vec a, --=20 2.20.1