From nobody Fri Nov 14 16:55:24 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1588849443; cv=none; d=zohomail.com; s=zohoarc; b=UZIIwS15GP7vmzUbx4Un4pI1JEvg5z3BYqDBOsWINqxuvCChf0khdDRWAYiY6MvSZzO8jHLPpCmp/JzpTjVZ0u3mCToLGHr0S8Hm9YvdOck/w9X+dCXawjTvlo3A53gMH9kPV4uKcMadG3jZ5UtTysNzYJvkcYfjOmcNR5ZHhtg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1588849443; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=+AWi9cyt9dqBojN7P+ajbpq6VS5006E49zi4PdAgGBs=; b=bSQcebk8za7J6OKFd6LX5FntRGmKsMFAk58UeoJWFVC0R0ueX+UA3uQYWbqqeolO+9wttuR5vnm6HEUgxhz9PVB7YBEZV6swx5YwuvUC6Ej0hdXr2hn0QeE7hQ0E71PLjAT/NDS3iyPXz+PDZojM6kd0ToWRqv/5ij1aJhP7Wr8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 158884944392639.045031233421696; Thu, 7 May 2020 04:04:03 -0700 (PDT) Received: from localhost ([::1]:45558 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jWeJu-0008Go-IC for importer@patchew.org; Thu, 07 May 2020 07:04:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51594) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jWeH6-0004vb-Ju for qemu-devel@nongnu.org; Thu, 07 May 2020 07:01:08 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:27751 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jWeH3-0000IZ-35 for qemu-devel@nongnu.org; Thu, 07 May 2020 07:01:07 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-146-Glf3N8rROYujyy3_SQ-0Rw-1; Thu, 07 May 2020 06:59:27 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7EF891895A2B; Thu, 7 May 2020 10:59:26 +0000 (UTC) Received: from localhost.localdomain (unknown [10.74.8.13]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4BFA6649A9; Thu, 7 May 2020 10:59:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588849262; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+AWi9cyt9dqBojN7P+ajbpq6VS5006E49zi4PdAgGBs=; b=ED86DRmg5xGPDSy3Z08m5dRBvwhXtlnUxhcaDEfD1QjAljNCoRlYet2VZVnRsg0SlTAz+L bWgkYo0HFkdGz/tQJRc/j/x3e/JFQi7wK4d+o61p5zpsGufU68/2wnDtNMPqO5lpg26CwP qQhtRRhpz5znC19AzUJ1ExEAe0SFQS4= X-MC-Unique: Glf3N8rROYujyy3_SQ-0Rw-1 From: P J P To: QEMU Developers Subject: [PATCH 1/2] megasas: use unsigned type for reply_queue_head Date: Thu, 7 May 2020 16:27:17 +0530 Message-Id: <20200507105718.1319187-2-ppandit@redhat.com> In-Reply-To: <20200507105718.1319187-1-ppandit@redhat.com> References: <20200507105718.1319187-1-ppandit@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=205.139.110.61; envelope-from=ppandit@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/07 02:00:54 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Paolo Bonzini , Prasad J Pandit , Ren Ding Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" From: Prasad J Pandit A guest user may set 's->reply_queue_head' MegasasState field to a negative value. Later in 'megasas_lookup_frame' it is used to index into s->frames[] array. Use unsigned type to avoid OOB access issue. Reported-by: Ren Ding Signed-off-by: Prasad J Pandit --- hw/scsi/megasas.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/scsi/megasas.c b/hw/scsi/megasas.c index af18c88b65..433353bad0 100644 --- a/hw/scsi/megasas.c +++ b/hw/scsi/megasas.c @@ -112,7 +112,7 @@ typedef struct MegasasState { uint64_t reply_queue_pa; void *reply_queue; int reply_queue_len; - int reply_queue_head; + uint16_t reply_queue_head; int reply_queue_tail; uint64_t consumer_pa; uint64_t producer_pa; --=20 2.25.4