From nobody Tue Oct 14 10:38:05 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1588828179; cv=none; d=zohomail.com; s=zohoarc; b=B8VyA2ZmnjCCDGg8usXRu4VLe8mXEmUykdMemGixMeJ/+0jPFQSawqzbJ57tPyNyOLaGx82FELaj3UHFAoFxnesSvSY4IKj99U2VPQFjW7AAhOTfSiPu+EJrinj50mJJJUatEU6qnITB+nQZEiUzvupNtdGboTKaNrr0YtDd97U= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1588828179; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ue5a/FDbKYefhRgJW9mnJ8JLO2GjmebPB0yTmeR+AIg=; b=TQAQOWPUjkfmYEGRhkKtAu+OjZCy8BPE/5O9wX+PhfQCGLmbxUu3/dAt05iUR/hkHrm8luXk+VZbaMUujZaclT+n2PeHje6k8d1aoT3wGgXerTC2SvYFLJWyEC7woL696magTSfYhaU/d8d9DC+k3Qq3xrGGhjUX5heeoqlowwU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1588828179663638.9608282505989; Wed, 6 May 2020 22:09:39 -0700 (PDT) Received: from localhost ([::1]:60596 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jWYmw-0000kC-CA for importer@patchew.org; Thu, 07 May 2020 01:09:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33606) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jWYi1-0007nl-9r; Thu, 07 May 2020 01:04:33 -0400 Received: from bilbo.ozlabs.org ([203.11.71.1]:50971 helo=ozlabs.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jWYi0-0007vZ-B0; Thu, 07 May 2020 01:04:32 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 49HhFq2BXHz9sTP; Thu, 7 May 2020 15:04:15 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1588827855; bh=Ac2LtnCm9+Y0a7siK0TCtnW7xvh2oSg1c3KoRJWx+N8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=G9ommfMx7trhkQ+k6/OxseAhFdU7FvrCa3kXEhYJM4MQtLY+5VEQShKFEwUT1J7RS ZdquzWteoEe7+V1TFpPThPN2NtiTyW30nHOuQ8UglyQqqofAFVJmN2+bfwPDCLUV5e igl9AEN+chTpVRl8Nia3GK5hhTwEWo/wmkDL9BpI= From: David Gibson To: peter.maydell@linaro.org Subject: [PULL 16/18] spapr_nvdimm.c: make 'label-size' mandatory Date: Thu, 7 May 2020 15:02:26 +1000 Message-Id: <20200507050228.802395-17-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200507050228.802395-1-david@gibson.dropbear.id.au> References: <20200507050228.802395-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=203.11.71.1; envelope-from=dgibson@ozlabs.org; helo=ozlabs.org X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/07 01:04:14 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.249, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: aik@ozlabs.ru, Daniel Henrique Barboza , qemu-devel@nongnu.org, npiggin@gmail.com, groug@kaod.org, qemu-ppc@nongnu.org, clg@kaod.org, David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" From: Daniel Henrique Barboza The pseries machine does not support NVDIMM modules without label. Attempting to do so, even if the overall block size is aligned with 256MB, will seg fault the guest kernel during NVDIMM probe. This can be avoided by forcing 'label-size' to always be present for sPAPR NVDIMMs. The verification was put before the alignment check because the presence of label-size affects the alignment calculation, so it's not optimal to warn the user about an alignment error, then about the lack of label-size, then about a new alignment error when the user sets a label-size. Signed-off-by: Daniel Henrique Barboza Message-Id: <20200413203628.31636-1-danielhb413@gmail.com> Signed-off-by: David Gibson --- hw/ppc/spapr_nvdimm.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/hw/ppc/spapr_nvdimm.c b/hw/ppc/spapr_nvdimm.c index 25be8082d7..9abcdcc26b 100644 --- a/hw/ppc/spapr_nvdimm.c +++ b/hw/ppc/spapr_nvdimm.c @@ -37,6 +37,12 @@ void spapr_nvdimm_validate_opts(NVDIMMDevice *nvdimm, ui= nt64_t size, QemuUUID uuid; int ret; =20 + if (object_property_get_int(OBJECT(nvdimm), NVDIMM_LABEL_SIZE_PROP, + &error_abort) =3D=3D 0) { + error_setg(errp, "NVDIMM device requires label-size to be set"); + return; + } + if (size % SPAPR_MINIMUM_SCM_BLOCK_SIZE) { error_setg(errp, "NVDIMM memory size excluding the label area" " must be a multiple of %" PRIu64 "MB", --=20 2.26.2