From nobody Fri Nov 14 16:37:26 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1588758712; cv=none; d=zohomail.com; s=zohoarc; b=I1lOgchNttgUJGLoGFoMTYfxTlEgFCvyxylqhmfcFakoLVRbVTtCQfkmy0fPJz/EqmNZ6X8PLNqGhm4OkMdxE0ko8mSsrFYz6PecaTaGFXE0ZjCCKt9j95pMOwabYV2AoOoa366G6KoUllzn7ySQF+zvE+ATZc2/+IOf/TBuUmY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1588758712; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ePQAGUxkbDh1KstjsNvoLvmQ61QNRVAAmm68r4w7K/A=; b=fxoCt7e0jRxoKMT8kvNAeBJUSF2hlcD+3fQQiHjXByesAV5ZNYAMsh/6rj/SJbkm4GN2zQYenOAX8R3FKPAV1CHiTNI4aovzGRbENsI9ZGjS1+kaTcc+goCxe+3cU6bct0MGqFDuOjJlx7/5lAPI8DLSn0JeMD0sNrruGjaKANM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1588758712597303.05813051602365; Wed, 6 May 2020 02:51:52 -0700 (PDT) Received: from localhost ([::1]:51392 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jWGiV-0006iD-7T for importer@patchew.org; Wed, 06 May 2020 05:51:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54158) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jWGh7-0004uB-7q for qemu-devel@nongnu.org; Wed, 06 May 2020 05:50:25 -0400 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:27973 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jWGh6-00045S-Dt for qemu-devel@nongnu.org; Wed, 06 May 2020 05:50:24 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-445-WBZ3s7CHPq61jgOylngiQw-1; Wed, 06 May 2020 05:50:22 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BDF488018AB; Wed, 6 May 2020 09:50:20 +0000 (UTC) Received: from t480s.redhat.com (ovpn-113-17.ams2.redhat.com [10.36.113.17]) by smtp.corp.redhat.com (Postfix) with ESMTP id E0A415C1BD; Wed, 6 May 2020 09:50:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588758623; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ePQAGUxkbDh1KstjsNvoLvmQ61QNRVAAmm68r4w7K/A=; b=XcgkJg4Hi3SM90RjgDl1whalxwQ945p6WBJBEY6vfm3JLN5SAVhZBIYHaR/67xrnkUIQDu wWPUoU/5mooeUHxi+c77nDGtrZLp0NujVWWlp0YOJ/KaqRpglP7ZTw7ZK9yuCbxytolpmt 4noph6jcvCHfkzt5SDbbtHDGHthUsUM= X-MC-Unique: WBZ3s7CHPq61jgOylngiQw-1 From: David Hildenbrand To: qemu-devel@nongnu.org Subject: [PATCH v1 03/17] accel/kvm: Convert to ram_block_discard_set_broken() Date: Wed, 6 May 2020 11:49:34 +0200 Message-Id: <20200506094948.76388-4-david@redhat.com> In-Reply-To: <20200506094948.76388-1-david@redhat.com> References: <20200506094948.76388-1-david@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=207.211.31.81; envelope-from=david@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/06 02:39:40 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eduardo Habkost , kvm@vger.kernel.org, "Michael S . Tsirkin" , David Hildenbrand , "Dr . David Alan Gilbert" , qemu-s390x@nongnu.org, Paolo Bonzini , Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Discarding memory does not work as expected. At the time this is called, we cannot have anyone active that relies on discards to work properly. Cc: Paolo Bonzini Signed-off-by: David Hildenbrand Reviewed-by: Dr. David Alan Gilbert --- accel/kvm/kvm-all.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index 439a4efe52..33421184ac 100644 --- a/accel/kvm/kvm-all.c +++ b/accel/kvm/kvm-all.c @@ -40,7 +40,6 @@ #include "trace.h" #include "hw/irq.h" #include "sysemu/sev.h" -#include "sysemu/balloon.h" #include "qapi/visitor.h" #include "qapi/qapi-types-common.h" #include "qapi/qapi-visit-common.h" @@ -2107,7 +2106,7 @@ static int kvm_init(MachineState *ms) =20 s->sync_mmu =3D !!kvm_vm_check_extension(kvm_state, KVM_CAP_SYNC_MMU); if (!s->sync_mmu) { - qemu_balloon_inhibit(true); + g_assert(ram_block_discard_set_broken(true)); } =20 return 0; --=20 2.25.3